7f31e16bc1
Remove glow, full-border tint, and reduced-motion overlay so the running composer paints only a short constant-speed arc. Expand focused arc tests and document verification limits.
48 lines
2.4 KiB
Markdown
48 lines
2.4 KiB
Markdown
# Composer running border: highlight only
|
|
|
|
The running state now paints one short highlight travelling round the composer
|
|
pill's edge at constant arc-length speed, and nothing else. It supersedes the
|
|
glow, full-border tint and reduced-motion overlay described in
|
|
`composer-running-border.md` and `composer-running-border-arc.md`.
|
|
|
|
## Changes
|
|
|
|
- `lib/features/chat/conversation/composer_running_arc.dart`
|
|
- The highlight covers `runningHighlightSpan` (12%) of the outline, not a
|
|
38% band. Its colour runs along its own length: transparent, `primary`,
|
|
`tertiary`, transparent (stops 0, .3, .6, 1).
|
|
- `runningHighlightStrokes` returns the visible pieces as plain stroke paths
|
|
with colours. These are the only things painted: no blur, glow, shadow, fill
|
|
or whole-border stroke.
|
|
- `lib/features/chat/conversation/composer_running_border.dart`
|
|
- The painter draws only those strokes, at the existing 2 px stroke width.
|
|
The glow (`MaskFilter.blur`) and the 70% static overlay are removed.
|
|
- Reduced motion (`MediaQuery.disableAnimations`) paints nothing. The normal
|
|
composer outline shows alone, and the controller never ticks.
|
|
- Period (2.75 s), colours and linear lap are unchanged.
|
|
- `test/features/chat/conversation/composer_running_arc_test.dart` covers the
|
|
origin speed and wrap, colour stops, the short segment, the arc split at the
|
|
outline start, painted coverage per lap, and stroke bounds.
|
|
|
|
## Focused results
|
|
|
|
- `tool/memwatch/full.sh 'test/features/chat/conversation/composer_running_arc_test.dart test/features/chat/conversation/chat_composer_running_test.dart'`
|
|
→ PASS 19 passed, 0 failed (peak ~954 MB, exit 0). The verdict names only these two paths.
|
|
- `tool/analyze.sh` → clean, exit 0.
|
|
- `dart format --set-exit-if-changed` on the three changed files → clean.
|
|
|
|
## Affected states
|
|
|
|
- Running, default: the highlight travels; no other paint is drawn (stroke-level tests).
|
|
- Running, reduced motion: no highlight; `chat-composer-running-border` is still
|
|
mounted and ticks zero times (widget test).
|
|
- Turn ended: border gone, no ticker (widget test).
|
|
|
|
## Not verified
|
|
|
|
- Light and dark captures were requested but not made. This stage does not build
|
|
or capture UI; ui-review owns that.
|
|
- Pixel output is not tested. The "paints nothing under reduced motion" rule is
|
|
enforced by the painter's early return and not by a canvas assertion.
|
|
- Not profiled on device; mobile and browser behaviour unverified.
|