767643d991
Phone and browser notifications that carry an artifact open it full screen in the artifact viewer, with an Open run action and the preview as expanded text; pipelines://artifact deep links route to the viewer.
54 lines
3.2 KiB
Markdown
54 lines
3.2 KiB
Markdown
# Notification artifact deep link
|
|
|
|
Implemented the client-side artifact notification contract. The app parses
|
|
`pipelines://artifact/<run>/<sequence>/<path>`, renders a synthetic artifact
|
|
record in the existing full-screen Markdown/text viewer, and returns to the run
|
|
route when the viewer is dismissed. Android notification parsing preserves the
|
|
artifact, preview and `run_click` fields; attached previews are used for
|
|
expanded text and an `Open run` action is added when supplied. Existing
|
|
per-run/per-chat grouping remains intact.
|
|
|
|
Focused checks:
|
|
|
|
- `tool/memwatch/full.sh 'test/application/app_route_test.dart test/features/attention/notify/notification_controller_test.dart test/features/attention/notify/notification_delivery_test.dart test/features/attention/notify/notification_models_test.dart'` — 42 passed.
|
|
- `tool/analyze.sh` — clean.
|
|
- `gradle :app:testDebugUnitTest --tests net.awan.pipelines_app.notify.NotificationProtocolTest` — passed, including intent-link and action-label regression checks. The repository has no Gradle wrapper; system Gradle was used.
|
|
- `tool/memwatch/full.sh 'test/features/attention/notify/notification_bridge_web_test.dart --platform chrome'` — 2 passed; covers the browser notification click callback.
|
|
- `tool/memwatch/full.sh 'test/features/attention/notify/notification_controller_test.dart test/application/app_route_test.dart --no-pub'` — 23 passed.
|
|
- Android intent construction coverage now asserts the action, deep-link data and notification IDs, plus the non-app-link fallback.
|
|
|
|
The notification controller now forwards attached artifact metadata to the web
|
|
bridge tap callback; routes preserve escaped deep-link path segments, and the
|
|
viewer uses the contract URL, name and media type when supplied. Missing
|
|
metadata still opens the run.
|
|
|
|
UI/device captures were not available in this stage; phone and desktop deep-link
|
|
captures remain for the next stage.
|
|
|
|
Review follow-up:
|
|
|
|
- Preserved raw URL-path encoding for artifact routes, so an escaped literal
|
|
slash such as `reports%2Ffinal.md` remains one path segment in route history
|
|
and in the fallback artifact URL.
|
|
- `tool/memwatch/full.sh 'test/application/app_route_test.dart test/application/app_router_test.dart'` — 28 passed.
|
|
- `tool/analyze.sh` — clean.
|
|
- The notification test pair could not load on the default VM because the web
|
|
bridge imports `dart:js_interop`; the web test must run with the Chrome
|
|
platform. No claim is made for that check here.
|
|
|
|
Review follow-up (grouped Android notifications):
|
|
|
|
- Grouped thread notifications now use `BigTextStyle` with the latest artifact
|
|
preview, falling back to the stored message, while retaining per-run/per-chat
|
|
grouping, run action, tap intent and dismissal behavior.
|
|
- `gradle :app:testDebugUnitTest --tests
|
|
net.awan.pipelines_app.notify.NotificationProtocolTest` — passed.
|
|
- `tool/memwatch/full.sh 'test/application/app_route_test.dart
|
|
test/features/attention/notify/notification_controller_test.dart'` — 23
|
|
passed.
|
|
- `tool/memwatch/full.sh
|
|
'test/features/attention/notify/notification_bridge_web_test.dart --platform
|
|
chrome'` — 2 passed.
|
|
- `tool/analyze.sh` — clean; `git diff --check` — clean.
|
|
- Phone and desktop deep-link captures remain outstanding.
|