f102ff94ea
Code merges the base branch first and meets the repository's UI guidance; Review rejects UI code that breaks it; UIReview judges as a demanding designer, captures every affected state and sends unreachable states back to Code; review loops allow five visits.
4.5 KiB
4.5 KiB
stage Code
{"max_visits":5,"on":["blocked_retryable","error"]}
Implement the task and any supplied plan. First merge the current base branch and resolve conflicts keeping both intents. Follow the repository's AGENTS.md and area guidance; reuse existing code and conventions and keep the change focused. Rendered work must meet the repository's UI guidance (a design or UI quality checklist, if it has one): aligned layout, consistent spacing, no bad wrapping, theme colours and standard controls. If the preview fixture cannot show a state the task changes, extend it so UIReview can capture it. On a re-entry, fix the must-fix findings in the handoff; after a failed delivery, merge the base branch again and fix the listed checks. Do not redo the task. Verify with focused checks appropriate to the repository, never the full suites. Report the commands and results and the changed files. Do not commit, push or deploy. Use blocked_retryable only for an evidenced transient prerequisite; otherwise blocked.
read
glob
grep
edit
shell
provider=default
model=default
retries=1
timeout=30m
budget_tokens=8000000
none: focused checks are reported by Code; the delivery stage runs repository checks
success -> Review
blocked_retryable -> Code
blocked -> #failure
error -> Code
stage Review
{"max_visits":5,"on":["rejected","error"]}
Review this run's change against the task by reading the diff, not the whole repository. Start from the changed files, git status and a diff against the base branch, then read only code around changed hunks. Run no test suites, builds or analyzers: judge the checks Code reported and name missing coverage. Check correctness, regressions, duplication, performance and UI code that breaks the repository's UI guidance (hard-coded colours or sizes, ad-hoc styles, layout that cannot align). Rendered acceptance belongs to UIReview. On a revisit, confirm only that previous must-fix findings are fixed and that new hunks introduced no defect. Return rejected only for a must-fix defect with file, line, evidence and fix; advisory when only non-blocking notes remain; otherwise success. Do not edit or commit.
read
glob
grep
shell
provider=default
model=default
retries=1
timeout=45m
none: read-only review; shell is used only for status and diff inspection
success -> UIReview
advisory -> UIReview
rejected -> Code
error -> Review
stage UIReview
{"max_visits":5,"on":["rejected","error"]}
Judge the rendered result against the task and the repository's UI guidance as a demanding product designer: approve only what you would ship. When the change has no rendered effect, return skipped with the reason. Otherwise use the repository's documented capture or preview workflow to capture every affected state at small and large sizes, light and dark, including popups, focus, empty and long content; inspect every image you cite and save evidence where the task requires it. Run no test suites. Do not edit or commit. Return rejected for any visual or interaction defect with evidence, location and a fix; a state the fixture cannot show is rejected too, naming the fixture data Code must add. Return advisory only for minor polish, blocked only when the application cannot be built or opened at all, otherwise approved.
read
glob
grep
shell
provider=default
model=default
retries=1
timeout=45m
none: read-only visual review; repository delivery checks run separately
skipped -> Land
approved -> Land
advisory -> Land
rejected -> Code
blocked -> #failure
error -> UIReview
stage Land
Commit this run's reviewed change locally and leave a clean candidate. Never push, tag, rebase or amend, and do not merge into the base branch yourself. Inspect status and the diff, stage the run's changes, check for unrelated work and secrets, and create no empty commit. Report the commit hash and any files left out. Do not run suites or analyzers here; the delivery checks run them. If there is nothing to stage, report success clearly.
read
glob
grep
edit
shell
provider=default
model=default
retries=1
timeout=1h
none: repository-specific delivery checks must be supplied by the operator; this starter does not guess a build or test command
success -> #success
blocked -> #failure
error -> #failure