9532ecddcf
The run-wide header, note, filter and matched-path counter still describe every visit; below them Previous/Next move through the recorded visits in run order without wrapping, and the shown visit keeps its own stage and Visit N heading. A single recorded visit renders no pager.
223 lines
7.7 KiB
Dart
223 lines
7.7 KiB
Dart
import 'package:flutter/cupertino.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:pipelines_app/core/api_gateway.dart';
|
|
import 'package:pipelines_app/features/changes/changes.dart';
|
|
import 'package:pipelines_app/features/changes/widgets/visit_pager.dart';
|
|
|
|
import 'fixtures.dart';
|
|
import 'widget_hosts.dart';
|
|
|
|
List<JsonMap> twoVisitRun() => [
|
|
stepFixture(
|
|
stage: 'implementer',
|
|
sequence: 1,
|
|
fileChanges: captureFixture(
|
|
files: [
|
|
fileChangeFixture(path: 'lib/a.dart'),
|
|
fileChangeFixture(path: 'lib/b.dart'),
|
|
],
|
|
),
|
|
),
|
|
stepFixture(
|
|
stage: 'reviewer',
|
|
sequence: 2,
|
|
fileChanges: captureFixture(
|
|
files: [
|
|
fileChangeFixture(path: 'lib/b.dart'),
|
|
fileChangeFixture(path: 'lib/c.dart'),
|
|
],
|
|
),
|
|
),
|
|
];
|
|
|
|
void main() {
|
|
testWidgets(
|
|
'Previous/Next page recorded visits while the aggregate stays run-wide',
|
|
(tester) async {
|
|
await tester.pumpWidget(
|
|
materialHost(ChangesViewer(steps: twoVisitRun())),
|
|
);
|
|
|
|
// The aggregate counts each path once across both visits, and does not
|
|
// change as the operator pages.
|
|
expect(find.text('3 files changed'), findsOneWidget);
|
|
expect(find.text('1 of 2 recorded visits'), findsOneWidget);
|
|
expect(find.text('implementer'), findsOneWidget);
|
|
expect(find.text('Visit 1 · completed'), findsOneWidget);
|
|
expect(find.text('lib/a.dart'), findsOneWidget);
|
|
expect(find.text('lib/c.dart'), findsNothing);
|
|
|
|
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
|
|
await tester.pump();
|
|
|
|
// The shown page keeps its own visit identity in the heading.
|
|
expect(find.text('reviewer'), findsOneWidget);
|
|
expect(find.text('Visit 1 · completed'), findsOneWidget);
|
|
expect(find.text('lib/c.dart'), findsOneWidget);
|
|
expect(find.text('lib/a.dart'), findsNothing);
|
|
expect(find.text('3 files changed'), findsOneWidget);
|
|
expect(find.text('2 of 2 recorded visits'), findsOneWidget);
|
|
|
|
await tester.tap(find.byKey(ChangesVisitPager.previousKey));
|
|
await tester.pump();
|
|
|
|
expect(find.text('implementer'), findsOneWidget);
|
|
expect(find.text('lib/a.dart'), findsOneWidget);
|
|
expect(find.text('lib/c.dart'), findsNothing);
|
|
expect(find.text('1 of 2 recorded visits'), findsOneWidget);
|
|
},
|
|
);
|
|
|
|
testWidgets('paging stops at both ends instead of wrapping', (tester) async {
|
|
await tester.pumpWidget(materialHost(ChangesViewer(steps: twoVisitRun())));
|
|
|
|
TextButton previous() =>
|
|
tester.widget<TextButton>(find.byKey(ChangesVisitPager.previousKey));
|
|
TextButton next() =>
|
|
tester.widget<TextButton>(find.byKey(ChangesVisitPager.nextKey));
|
|
|
|
expect(previous().onPressed, isNull);
|
|
expect(next().onPressed, isNotNull);
|
|
|
|
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
|
|
await tester.pump();
|
|
expect(previous().onPressed, isNotNull);
|
|
expect(next().onPressed, isNull);
|
|
|
|
// The disabled Next is inert; the page stays on the last visit.
|
|
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
|
|
await tester.pump();
|
|
expect(find.text('reviewer'), findsOneWidget);
|
|
|
|
await tester.tap(find.byKey(ChangesVisitPager.previousKey));
|
|
await tester.pump();
|
|
expect(find.text('implementer'), findsOneWidget);
|
|
expect(previous().onPressed, isNull);
|
|
});
|
|
|
|
testWidgets('a run with one recorded visit offers no pager', (tester) async {
|
|
await tester.pumpWidget(
|
|
materialHost(
|
|
ChangesViewer(
|
|
steps: [
|
|
stepFixture(
|
|
fileChanges: captureFixture(
|
|
files: [fileChangeFixture(path: 'lib/only.dart')],
|
|
),
|
|
),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
expect(find.text('Previous visit'), findsNothing);
|
|
expect(find.text('Next visit'), findsNothing);
|
|
expect(find.textContaining('recorded visits'), findsNothing);
|
|
// The single visit still keeps its identity heading.
|
|
expect(find.text('implementer'), findsOneWidget);
|
|
expect(find.text('Visit 1 · completed'), findsOneWidget);
|
|
expect(find.text('lib/only.dart'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('the filter and its aggregate counter survive paging', (
|
|
tester,
|
|
) async {
|
|
await tester.pumpWidget(materialHost(ChangesViewer(steps: twoVisitRun())));
|
|
|
|
await tester.enterText(find.byType(TextField), 'a.dart');
|
|
await tester.pump();
|
|
expect(find.text('1 of 3 changed paths match'), findsOneWidget);
|
|
expect(find.text('lib/a.dart'), findsOneWidget);
|
|
|
|
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
|
|
await tester.pump();
|
|
// The filter still applies to the shown visit, and the counter still
|
|
// describes the whole run's changed paths.
|
|
expect(find.text('1 of 3 changed paths match'), findsOneWidget);
|
|
expect(find.text('No changed filenames match "a.dart".'), findsOneWidget);
|
|
expect(find.text('lib/c.dart'), findsNothing);
|
|
expect(find.text('reviewer'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('a shorter reply clamps the shown visit instead of overflowing', (
|
|
tester,
|
|
) async {
|
|
final first = twoVisitRun();
|
|
final second = [
|
|
stepFixture(
|
|
stage: 'implementer',
|
|
sequence: 1,
|
|
fileChanges: captureFixture(
|
|
files: [fileChangeFixture(path: 'lib/a.dart')],
|
|
),
|
|
),
|
|
];
|
|
await tester.pumpWidget(materialHost(ChangesViewer(steps: first)));
|
|
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
|
|
await tester.pump();
|
|
expect(find.text('reviewer'), findsOneWidget);
|
|
|
|
await tester.pumpWidget(materialHost(ChangesViewer(steps: second)));
|
|
await tester.pump();
|
|
expect(tester.takeException(), isNull);
|
|
expect(find.text('implementer'), findsOneWidget);
|
|
expect(find.text('Visit 1 · completed'), findsOneWidget);
|
|
expect(find.text('Previous visit'), findsNothing);
|
|
});
|
|
|
|
testWidgets('the pager stays reachable at 320x720 with 2x text', (
|
|
tester,
|
|
) async {
|
|
tester.view.physicalSize = const Size(320, 720);
|
|
tester.view.devicePixelRatio = 1;
|
|
addTearDown(tester.view.reset);
|
|
await tester.pumpWidget(
|
|
materialHost(
|
|
ChangesViewer(steps: twoVisitRun()),
|
|
scaler: const TextScaler.linear(2),
|
|
),
|
|
);
|
|
expect(tester.takeException(), isNull);
|
|
expect(find.text('Previous visit'), findsOneWidget);
|
|
expect(find.text('Next visit'), findsOneWidget);
|
|
|
|
// At 2x text the fixed summary and filter leave a short scroll viewport;
|
|
// the pager is still reachable by scrolling the visit body.
|
|
await tester.ensureVisible(find.text('Next visit'));
|
|
await tester.pump();
|
|
await tester.tap(find.text('Next visit'));
|
|
await tester.pump();
|
|
expect(tester.takeException(), isNull);
|
|
expect(find.text('reviewer'), findsOneWidget);
|
|
expect(find.text('Visit 1 · completed'), findsOneWidget);
|
|
expect(find.text('lib/c.dart'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('Cupertino pages with native buttons at both ends', (
|
|
tester,
|
|
) async {
|
|
await tester.pumpWidget(cupertinoHost(ChangesViewer(steps: twoVisitRun())));
|
|
|
|
final previous = tester.widget<CupertinoButton>(
|
|
find.byKey(ChangesVisitPager.previousKey),
|
|
);
|
|
final next = tester.widget<CupertinoButton>(
|
|
find.byKey(ChangesVisitPager.nextKey),
|
|
);
|
|
expect(previous.onPressed, isNull);
|
|
expect(next.onPressed, isNotNull);
|
|
expect(find.text('Previous visit'), findsOneWidget);
|
|
expect(find.text('Next visit'), findsOneWidget);
|
|
|
|
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
|
|
await tester.pump();
|
|
expect(find.text('reviewer'), findsOneWidget);
|
|
expect(
|
|
tester
|
|
.widget<CupertinoButton>(find.byKey(ChangesVisitPager.nextKey))
|
|
.onPressed,
|
|
isNull,
|
|
);
|
|
});
|
|
}
|