68 lines
4.1 KiB
Markdown
68 lines
4.1 KiB
Markdown
# The destinations pill stands down in a run detail
|
|
|
|
## What this item changed
|
|
|
|
`android/` only, the app shell's floating destination pill and run-detail stack.
|
|
|
|
- `ui/PipelinesApp.kt` — the pill's one rule gains a run-detail hiding state.
|
|
`destinationPillVisible(currentRoute, conversationOpen, runDetailOpen)` is now
|
|
`!(currentRoute == CHAT_ROUTE && conversationOpen) && !runDetailOpen`: the chat conversation
|
|
hides it exactly as before (the chat clause is unchanged), and the full run-detail stack hides
|
|
it too. `runDetailOpen` derives from the Runs destination's saved selection depth, so it
|
|
covers summary, graph, stage, artifact and decision surfaces and Back to the list restores it.
|
|
Everything downstream is unchanged and still keys off that one
|
|
predicate — `contentPillPadding(pillVisible)` (the named zero) and
|
|
`pillScrollInset(pillVisible)` (the named `DESTINATION_PILL_RESERVE` +
|
|
`ATTENTION_CHIP_RESERVE`, or `0.dp` while hidden) — so hiding the pill in a run detail
|
|
leaves no empty band, exactly as hiding it in a conversation already does.
|
|
- Tests — `PipelinesNavTest`: the existing `destinationPillVisible` test is extended in place
|
|
(renamed `thePillStandsDownWhileAConversationOrRunDetailIsOpen`) to pin that the full
|
|
run-detail stack hides the pill on the runs route, that the run list restores it, and that
|
|
the chat clause is untouched; and the scroll-inset test's loop gains the detail
|
|
dimension, so `pillScrollInset` is proved zero while a run detail hides the pill
|
|
(no empty band) and the drawn reserve while it is drawn.
|
|
|
|
No new dimension, so no `ui/theme/Dimens.kt` token was needed (a raw literal would fail
|
|
`DimensTest`). No dependency added, no server/Go/installer/Docker file touched, and no run
|
|
started from the app.
|
|
|
|
## Shared documents this change makes stale
|
|
|
|
`android/README.md` documents the pill's hiding rule and is written here rather than edited in
|
|
place; the `docs-fold` writer should update it.
|
|
|
|
- `android/README.md:6219` — the section headline
|
|
"## Destination pill stands down in an open conversation (17 Oct 2026)" and its opening
|
|
paragraph ("It now stands down while the Chat destination is showing an open conversation
|
|
and stays everywhere else, unchanged") now describe only half the rule. The section should
|
|
also record the new item, e.g. append a dated section:
|
|
|
|
```markdown
|
|
## The destinations pill stands down in a run detail (18 Oct 2026)
|
|
|
|
The floating destinations pill also stood over run-detail surfaces. It now stands down for
|
|
the entire detail stack — summary, graph, stage, artifact and pending-decision surfaces —
|
|
exactly as it already does inside an open chat conversation, and returns on Back to the runs
|
|
list. `android/` only; no new dependency, no run started from the app, no
|
|
server/installer/Docker file touched.
|
|
|
|
- **The one rule gains a second hiding state.** `destinationPillVisible(currentRoute,
|
|
conversationOpen, runDetailOpen)` is `!(currentRoute == CHAT_ROUTE && conversationOpen) &&
|
|
!runDetailOpen`. The chat clause is unchanged; `runDetailOpen` derives from the Runs
|
|
destination's saved selection depth, so every run-detail surface follows the same rule.
|
|
- **Still one predicate, still no band.** `contentPillPadding` and `pillScrollInset` are
|
|
unchanged and still derive from `pillVisible` alone, so a hidden pill in a run detail
|
|
leaves no empty band; the scroll-inset test now loops the detail dimension and pins that.
|
|
- **Scoped to the run detail.** The run list keeps the pill; every run-detail surface hides it.
|
|
The chat behaviour and the narrow/wide placement rules are untouched.
|
|
```
|
|
|
|
## Not stale
|
|
|
|
- No packaged OpenCode skill reference (`internal/author/skill/references/`) documents the
|
|
app's destination pill or its hiding states; they describe the server, the CLI and the
|
|
pipeline authoring model. No packaged template (`examples/*.md`) and no `internal/author/`
|
|
managed file names them either, so `internal/author/install.go`'s inventory needs no change.
|
|
- `android/AGENTS.md` describes `ui/PipelinesApp.kt` generically ("the app shell:
|
|
destinations, the floating pill, the omni-search morph") and needs no change.
|