Files
pipelines/app/test/ui/adaptive/app_popups_test.dart
T
alan 6b82f51331 Open a choice menu over its anchor when the anchor is a whole pane
The add-pane picker is opened from a pane, not a button; with no room
above or below the anchor the panel was laid out with no height (found by
run 303's UI review).
2026-11-10 22:41:59 +00:00

236 lines
7.7 KiB
Dart

import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/ui/adaptive/app_popups.dart';
Widget _app({Alignment alignment = Alignment.topLeft, List<String>? picked}) =>
MaterialApp(
home: Scaffold(
body: Align(
alignment: alignment,
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
Builder(
builder: (anchor) => TextButton(
onPressed: () async {
final value = await showAppChoiceMenu<String>(
anchor,
builder: (menu) => Column(
mainAxisSize: MainAxisSize.min,
children: [
for (final choice in const ['One', 'Two', 'Three'])
ListTile(
title: Text(choice),
onTap: () => Navigator.of(menu).pop(choice),
),
],
),
);
picked?.add('$value');
},
child: const Text('Open menu'),
),
),
Builder(
builder: (context) => TextButton(
onPressed: () => showAppDetails<void>(
context,
builder: (_) => const Text('Details body'),
),
child: const Text('Open details'),
),
),
],
),
),
),
);
void _size(WidgetTester tester, Size size) {
tester.view.physicalSize = size;
tester.view.devicePixelRatio = 1;
addTearDown(tester.view.reset);
}
final _menu = find.byKey(const ValueKey('app-choice-menu'));
void main() {
testWidgets('wide: a menu anchored below its button, closed by a choice, '
'Escape or a press outside', (tester) async {
_size(tester, const Size(1280, 800));
final picked = <String>[];
await tester.pumpWidget(_app(picked: picked));
final button = tester.getRect(find.text('Open menu'));
await tester.tap(find.text('Open menu'));
await tester.pumpAndSettle();
expect(find.byType(BottomSheet), findsNothing);
final menu = tester.getRect(_menu);
expect(menu.width, 320);
expect(menu.top, greaterThanOrEqualTo(button.bottom));
expect(menu.top - button.bottom, lessThan(40));
expect(menu.left, greaterThanOrEqualTo(8));
await tester.tap(find.text('Two'));
await tester.pumpAndSettle();
expect(picked, ['Two']);
expect(_menu, findsNothing);
await tester.tap(find.text('Open menu'));
await tester.pumpAndSettle();
await tester.sendKeyEvent(LogicalKeyboardKey.escape);
await tester.pumpAndSettle();
expect(_menu, findsNothing);
await tester.tap(find.text('Open menu'));
await tester.pumpAndSettle();
await tester.tapAt(const Offset(1200, 700));
await tester.pumpAndSettle();
expect(_menu, findsNothing);
expect(picked, ['Two', 'null', 'null']);
});
testWidgets('wide: near the bottom right the menu opens above, inside the '
'app', (tester) async {
_size(tester, const Size(1280, 800));
await tester.pumpWidget(_app(alignment: Alignment.bottomRight));
final button = tester.getRect(find.text('Open menu'));
await tester.tap(find.text('Open menu'));
await tester.pumpAndSettle();
final menu = tester.getRect(_menu);
expect(menu.bottom, lessThanOrEqualTo(button.top));
expect(menu.right, lessThanOrEqualTo(1280 - 8));
expect(menu.top, greaterThanOrEqualTo(8));
});
testWidgets('wide: anchored to a whole pane, the menu opens over its top', (
tester,
) async {
_size(tester, const Size(1280, 800));
await tester.pumpWidget(
MaterialApp(
home: Padding(
padding: const EdgeInsets.only(left: 400),
child: Builder(
builder: (pane) => Center(
child: TextButton(
onPressed: () => showAppChoiceMenu<void>(
pane,
width: 420,
builder: (_) => const SizedBox(
height: 300,
child: Center(child: Text('Picker')),
),
),
child: const Text('Open'),
),
),
),
),
),
);
await tester.tap(find.text('Open'));
await tester.pumpAndSettle();
final menu = tester.getRect(_menu);
expect(menu.size.width, 420);
expect(menu.height, greaterThanOrEqualTo(300));
expect(menu.left, 400);
expect(menu.top, lessThan(40));
expect(find.text('Picker').hitTestable(), findsOneWidget);
});
testWidgets('wide: details are a dialog', (tester) async {
_size(tester, const Size(1280, 800));
await tester.pumpWidget(_app());
await tester.tap(find.text('Open details'));
await tester.pumpAndSettle();
expect(find.byType(Dialog), findsOneWidget);
expect(find.byType(BottomSheet), findsNothing);
expect(tester.getSize(find.byType(Dialog)).width, lessThanOrEqualTo(1280));
expect(find.text('Details body'), findsOneWidget);
});
testWidgets('wide: details taller than the app scroll inside the dialog', (
tester,
) async {
_size(tester, const Size(1280, 600));
await tester.pumpWidget(
MaterialApp(
home: Builder(
builder: (context) => TextButton(
onPressed: () => showAppDetails<void>(
context,
builder: (_) => Column(
mainAxisSize: MainAxisSize.min,
children: [
for (var i = 0; i < 30; i++)
SizedBox(height: 48, child: Text('Row $i')),
],
),
),
child: const Text('Open'),
),
),
),
);
await tester.tap(find.text('Open'));
await tester.pumpAndSettle();
expect(tester.takeException(), isNull);
final dialog = tester.getRect(
find
.descendant(of: find.byType(Dialog), matching: find.byType(Material))
.first,
);
expect(dialog.height, lessThanOrEqualTo(600 * 0.85));
await tester.scrollUntilVisible(
find.text('Row 29'),
200,
scrollable: find
.descendant(
of: find.byType(Dialog),
matching: find.byType(Scrollable),
)
.first,
);
expect(find.text('Row 29').hitTestable(), findsOneWidget);
});
testWidgets('phone: both are bottom sheets', (tester) async {
_size(tester, const Size(430, 900));
final picked = <String>[];
await tester.pumpWidget(_app(picked: picked));
await tester.tap(find.text('Open menu'));
await tester.pumpAndSettle();
expect(find.byType(BottomSheet), findsOneWidget);
expect(_menu, findsNothing);
await tester.tap(find.text('Three'));
await tester.pumpAndSettle();
expect(picked, ['Three']);
await tester.tap(find.text('Open details'));
await tester.pumpAndSettle();
expect(find.byType(BottomSheet), findsOneWidget);
expect(find.byType(Dialog), findsNothing);
});
testWidgets('the app decides, not a narrow surface inside it', (
tester,
) async {
_size(tester, const Size(1280, 800));
late BuildContext inner;
await tester.pumpWidget(
MaterialApp(
home: MediaQuery(
data: const MediaQueryData(size: Size(360, 400)),
child: Builder(
builder: (context) {
inner = context;
return const SizedBox();
},
),
),
),
);
expect(MediaQuery.sizeOf(inner).width, 360);
expect(usesDesktopPopups(inner), isTrue);
});
}