59 lines
3.3 KiB
Markdown
59 lines
3.3 KiB
Markdown
# App warning visibility
|
|
|
|
Run Summary now displays the server's `run_detail.warnings` as visible,
|
|
selectable messages above the facts. Empty/malformed warning entries are not
|
|
rendered. An unwarned run has no empty section. Material uses SelectableText;
|
|
Cupertino uses a read-only multiline CupertinoTextField like existing details.
|
|
|
|
Pipeline Summary independently validates the selected recorded source through
|
|
the existing read-only `validate` request. Its warning strings and validation
|
|
errors are displayed as Definition warnings without hiding historical detail.
|
|
Loading does not block source/facts; transport/malformed-reply failures remain
|
|
visible with Retry validation. No source means no request. Checks are cached per
|
|
gateway and exact source, bounded to sixteen entries, so switching tabs or
|
|
revisiting the same source does not repeatedly revalidate it. Source changes
|
|
start a new check. No authoring or server changes were made.
|
|
|
|
Checks:
|
|
- Pipelines and runs feature suites: 499 passed through memory watchdog
|
|
(`/tmp/memwatch/out.fKnKmB`, peak 2157 MB).
|
|
- After adding the no-source guard, focused regression suite: 10 passed
|
|
(`/tmp/memwatch/out.yY6KGu`, peak 999 MB).
|
|
- Focused analyze clean; fixture web release build and Wasm dry run succeeded.
|
|
|
|
Real browser evidence (all six PNGs inspected):
|
|
- `/tmp/app-warnings-material-final/`, Material 1100x900.
|
|
- `/tmp/app-warnings-cupertino-final/`, Cupertino 560x1000.
|
|
- In each: run Summary warning, Copy Input interaction retaining warning,
|
|
Pipeline Summary definition warning. Captures and reports pass; kit-owned
|
|
Chrome instances and loopback servers exited normally.
|
|
- The fixture's pre-existing schedules reply is absent, so its Summary shows
|
|
Loading schedules; this is not a scheduling verification.
|
|
|
|
The initial capture attempt used waitfor on a static heading; the kit does not
|
|
index that static label, although the saved PNG visibly showed the warning.
|
|
Final captures use screenshots and a real Copy Input interaction instead.
|
|
No physical device or Safari claim is made here. Nothing was deployed.
|
|
|
|
## Summary request ordering follow-up
|
|
|
|
The integrated application test exposed a real ordering dependency: the shared
|
|
PipelinesClient serializes each request until its reply. Definition validation
|
|
was enqueued immediately while its widget mounted, before the schedule section
|
|
had enqueued `list_schedules`, so a delayed or unanswered optional validation
|
|
held up primary Summary content.
|
|
|
|
Validation now starts in a microtask after synchronous Summary mounting. This
|
|
lets the schedule request enter the existing transport queue first, without
|
|
adding a timer or changing the client's serialization contract. The selected
|
|
source and gateway are captured before deferral, so a later selection cannot
|
|
change a queued request's source. The application fixture answers the new
|
|
validation request and asserts that schedules and launch controls are available
|
|
while validation is still unanswered. No selection, backend or transport code
|
|
was changed. Focused application/definition-warning tests and analysis are
|
|
recorded in the follow-up handoff; no full suite or deployment was run here.
|
|
|
|
Follow-up result: 149 application/definition-warning tests pass through the
|
|
memory watchdog (`/tmp/memwatch/out.35VDe8`, peak 2105 MB, 49 s). Focused analysis
|
|
is clean (`flutter-analyze.NVN15m`).
|