8.5 KiB
One shared list row (style review batch 3: F6, F8 results, F16)
Before this change Runs, Pipelines, Chat, Search results and Schedules each drew
rows differently (see /tmp/app-style-review/report.md). They now all use one
component, on both hosts.
Shared pieces (lib/ui/layout/)
app_list_row.dart,AppListRow: the leading slot, then a bold one-linetitlewithtimeon the same line (the time takes at most 40% of the line), then one mutedsubtitleline with an optionalsubtitleLeading(status dot) andsubtitleTrailing(unread dot), then an optionalmenu.- Styles come from the host's type scale. Material: title
titleMediumw600 (letter spacing 0), subtitlebodyMedium, timebodySmall, all inonSurfaceVariant. Cupertino: titletextStylew600, subtitle and time 15ptsecondaryLabel. selected: MaterialsecondaryContainer(title inonSecondaryContainer), CupertinotertiarySystemFill.AppListRow.selectedColorgives the fill. Semantics are a container withselectedandbutton.emphasized(unread or attention): w700 title, accent time in w600.- Tapping: Material uses
InkWellon aMaterialsurface. Cupertino uses aGestureDetectorthat highlightssystemGrey4while pressed, like a table cell, and fades nothing.tapKeygoes on the tap target. divider(default true): a hairline inset to the start of the text column. Cupertino usesseparatorat 1 physical pixel; Material usesoutlineVariantat 1. Lists turn it off for the last row of a group.- Compact mode: when the row is narrower than
kAppListRowCompactWidth(280), it keeps the avatar (a run's status) and the menu, moves the time to its own line under the subtitle and showscompactSubtitleif one is given. Only belowkAppListRowMinimalWidth(160, narrower than any list pane) does it drop the avatar and menu so the text never overflows. (keepMenuWhenCompactis gone: every row keeps its menu.) - No fixed heights. Padding is 16 horizontal and 13 vertical
(
kAppListRowVerticalPadding), with a 4px gap under the title and a 14px gap after the avatar (8 when compact). At 2x text in a 320px row everything ellipsises without overflowing. - Test keys:
appListRowSurfaceKeyandappListRowDividerKey.
- Styles come from the host's type scale. Material: title
app_list_avatar.dartAppListAvataris a 40px circle (theCircleAvatardefault) holding an icon (22) or text. The circle is filled with the foreground at 14%, or a neutral fill when there is no foreground. An optional cornerbadgeis supported. The glyph scales down to stay inside the circle at large text.AppListAvatar.initialshows the first letter in 18pt w700. It replaces the pipelines initial that used to read as an empty circle.AppListStatusDotis a small dot that follows text scaling and can carry a semantics label.
app_overflow_menu.dart:AppOverflowMenu<T>andAppMenuActiongive the app one overflow control. Material uses aPopupMenuButtonwithIcons.more_vert. Cupertino uses aCupertinoButtonwithCupertinoIcons.ellipsisthat opens aCupertinoActionSheetwith Cancel. Item keys sit on the popup items or sheet actions on both hosts. Used by the run menu (list rows and the run detail header), chat rows, search artifact hits and pipeline schedule rows.
Migrated
- Runs (
runs/ui/runs_list.dart):RunListRowis a thinAppListRow. Its leading slot is the status avatar. Rows are separated by inset dividers, with no divider before a day heading. The keyrun-row-<id>is now on the row.run-list-more-menu-<id>and the menu item keys are unchanged.run-row-surface-<id>is gone; useappListRowSurfaceKey. The run detail's menu uses the same control, so its Cupertino icon changed fromellipsis_circletoellipsis. - Pipelines (
pipelines/widgets/pipeline_list_panel.dart): one list for both hosts. The Cupertino inset-grouped section and the full-width Material dividers are gone, and so is the chevron. The legible initial avatar keeps the keypipeline-avatar-<id>. The latest-run dot is nowAppListStatusDot, keepingpipeline-status-<id>. Compact rows show the latest state word. The compact threshold moved from 220 to 280. - Chat (
chat/ui/sessions/session_row_content.dartChatSessionRow, used by bothsession_list_material.dartandsession_list_cupertino.dart): the separate MaterialListTileand CupertinoCupertinoListTilerows are gone. The Cupertino list no longer uses inset groups; a directory header is now a small grey label. All keys are kept:chat-row-<id>,chat-actions-<id>,chat-row-unread,chat-row-workingandchat-row-starred. Titles are now w600, or w700 when unread (they were w500/w700). The menu stays when compact. - Chat in the shell (
chat/screen.dart): theBelowTopBarwrapper is removed. The list pads itself by the bar height (Material through defaultListViewpadding, Cupertino explicitly), so it scrolls behind the bar like the other lists. - Search (
search/ui/search_result_row.dartSearchResultRow, used by both bodies): the leading slot is the kind icon in an avatar, or the image thumbnail, now 40px. The recency is the time. The line starts with the kind in bold ("Field · …"), then shows the snippet with the match in bold.SearchKindTag, the two-line title and the Cupertino inset group are gone. Artifact hits keepsearch.actions.<target>and the tooltip "Open…". - Schedules list (
schedules/ui/list/schedule_list_row.dart): the six-line block is now two lines. The clock avatar is green when enabled and grey when paused, and also carries the status as its semantics label. The time isscheduleNextDueShort("22 Oct 09:00" or "Paused"). The line shows the timer and the pipeline/version. The prompt, workspace, timezone and exact due time are left to the editor the row opens. The list stays read-only and has no menu: its tests require no Edit/Pause/Delete, and the list controller has no mutations. - Pipeline Summary schedules (
schedules/ui/pipeline/schedule_pipeline_row.dart): the same two lines, with the line "v2 · Every 24h · mon · Europe/London". The inline Edit, Pause/Enable and Delete text buttons moved into an overflow menu under a new key,scheduleRowMenuKey(id). The item keysscheduleRowEditKey,scheduleRowToggleKeyandscheduleRowDeleteKeyare kept, and Delete is destructive. A busy row disables its menu and tap. A tap on the row edits it. A refusal appears under the row withscheduleRowErrorKey.
Tests
- New:
test/ui/layout/app_list_row_test.dartcovers both hosts. It checks the layout order, inset divider, tap, menu icon and items, the selected and emphasised styles, compact mode,keepMenuWhenCompact, 320px at 2x in light and dark, and the initial avatar. - Updated for intentional changes:
list_detail_consistency_test,pipelines_destination_test,chat_list_detail_test,chat_active_selection_test,chat_session_row_layout_test,chat_session_row_material_test,pipeline_list_composition_test(inset divider and legible avatar),pipelines_adaptive_test,pipelines_screen_test,pipeline_summary_schedules_test,schedules_layout_test,schedule_pipeline_section_test(actions open through the menu) andsearch_bar_layout_test.
Evidence
The captures are in /tmp/wave2-d-evidence/. They were taken with headless
Chrome using the reviewer's driver (a copy pointed at this worktree's tool
directory). The sources were:
lib/main.dartover the runs and pipelines fixture servers;- the new
tool/app_host_probe_entry.dart, which is the same composition with?host=cupertino; tool/chat_sessions_probe_entry.dart,tool/schedules_list_probe_app.dart,tool/schedule_pipeline_probe_app.dartandtool/search_selection_probe_entry.dart.
The captures were taken at 560 and 1200, in light and dark, on Material and Cupertino. There was no device run, so Android and iOS are unverified.
Roomier rows (2026-11-03)
The user found the chat, run and pipeline lists cramped. In AppListRow only:
vertical padding 10 -> 13 per side, title-to-subtitle gap 2 -> 4, avatar-to-text
gap 12 -> 14 (compact stays 8). A two-line Material row goes from about 69 to
75 logical px; text sizes and the content-driven layout are unchanged, and the
divider still starts at the text column. Narrow (compact) list panes still fit.
Captures (Material light, 560x1000 and 1400x900, plus a narrowed pane and
Cupertino chat) are in /tmp/rowsize/{before,after}/.