List rows: a little more vertical room in the shared row
This commit is contained in:
@@ -17,9 +17,15 @@ const double kAppListRowMinimalWidth = 160;
|
||||
|
||||
/// The rows' horizontal inset and the gap after the avatar.
|
||||
const double kAppListRowInset = 16;
|
||||
const double _avatarGap = 12;
|
||||
const double _avatarGap = 14;
|
||||
const double _compactAvatarGap = 8;
|
||||
|
||||
/// The rows' vertical breathing room: the padding above and below the
|
||||
/// content and the gap between the title and the lines under it. Rows stay
|
||||
/// content-driven; these only space them out so they are easier to hit.
|
||||
const double kAppListRowVerticalPadding = 13;
|
||||
const double _lineGap = 4;
|
||||
|
||||
/// Keys on a row's highlight surface and inset divider, for tests.
|
||||
const appListRowSurfaceKey = ValueKey<String>('app-list-row-surface');
|
||||
const appListRowDividerKey = ValueKey<String>('app-list-row-divider');
|
||||
@@ -135,8 +141,8 @@ class AppListRow extends StatelessWidget {
|
||||
padding: EdgeInsetsDirectional.only(
|
||||
start: start,
|
||||
end: showMenu ? 4 : kAppListRowInset,
|
||||
top: 10,
|
||||
bottom: 10,
|
||||
top: kAppListRowVerticalPadding,
|
||||
bottom: kAppListRowVerticalPadding,
|
||||
),
|
||||
child: Row(
|
||||
children: [
|
||||
@@ -285,7 +291,7 @@ class AppListRow extends StatelessWidget {
|
||||
return Column(
|
||||
mainAxisSize: MainAxisSize.min,
|
||||
crossAxisAlignment: CrossAxisAlignment.stretch,
|
||||
children: [titleLine, const SizedBox(height: 2), timeLine],
|
||||
children: [titleLine, const SizedBox(height: _lineGap), timeLine],
|
||||
);
|
||||
}
|
||||
return Column(
|
||||
@@ -293,7 +299,7 @@ class AppListRow extends StatelessWidget {
|
||||
crossAxisAlignment: CrossAxisAlignment.stretch,
|
||||
children: [
|
||||
titleLine,
|
||||
const SizedBox(height: 2),
|
||||
const SizedBox(height: _lineGap),
|
||||
Row(
|
||||
children: [
|
||||
if (subtitleLeading != null)
|
||||
|
||||
@@ -31,8 +31,10 @@ component, on both hosts.
|
||||
given. Only below `kAppListRowMinimalWidth` (160, narrower than any list
|
||||
pane) does it drop the avatar and menu so the text never overflows.
|
||||
(`keepMenuWhenCompact` is gone: every row keeps its menu.)
|
||||
- No fixed heights. Padding is 16 horizontal and 10 vertical. At 2x text in
|
||||
a 320px row everything ellipsises without overflowing.
|
||||
- No fixed heights. Padding is 16 horizontal and 13 vertical
|
||||
(`kAppListRowVerticalPadding`), with a 4px gap under the title and a 14px
|
||||
gap after the avatar (8 when compact). At 2x text in a 320px row
|
||||
everything ellipsises without overflowing.
|
||||
- Test keys: `appListRowSurfaceKey` and `appListRowDividerKey`.
|
||||
- `app_list_avatar.dart`
|
||||
- `AppListAvatar` is a 40px circle (the `CircleAvatar` default) holding an
|
||||
@@ -130,3 +132,13 @@ directory). The sources were:
|
||||
|
||||
The captures were taken at 560 and 1200, in light and dark, on Material and
|
||||
Cupertino. There was no device run, so Android and iOS are unverified.
|
||||
|
||||
## Roomier rows (2026-11-03)
|
||||
|
||||
The user found the chat, run and pipeline lists cramped. In `AppListRow` only:
|
||||
vertical padding 10 -> 13 per side, title-to-subtitle gap 2 -> 4, avatar-to-text
|
||||
gap 12 -> 14 (compact stays 8). A two-line Material row goes from about 69 to
|
||||
75 logical px; text sizes and the content-driven layout are unchanged, and the
|
||||
divider still starts at the text column. Narrow (compact) list panes still fit.
|
||||
Captures (Material light, 560x1000 and 1400x900, plus a narrowed pane and
|
||||
Cupertino chat) are in `/tmp/rowsize/{before,after}/`.
|
||||
|
||||
Reference in New Issue
Block a user