Files
pipelines/app/notes/material-final-api-cleanup.md

88 lines
4.5 KiB
Markdown

# Material-only API cleanup
## Manager completion (supersedes the original handoff)
Integrated the complete tooling sweep and removed obsolete control-family
arguments, fields, icon metadata, forwarding and host helpers across application,
feature, shared UI, test and fixture callers. Removed the unused dynamic-color
and alternate-theme APIs. Native Material routing, predictive Back and Apple
interactive Back transitions remain intact.
Final case-insensitive inventory over `app/lib app/test app/tool` is exactly
three lines: the restricted import and two uses of Flutter's
`CupertinoPageTransitionsBuilder` in `ui/theme/app_theme.dart`. This framework
transition is explicitly retained; there are no alternate app widgets, host
choices, flags, tests, capture options or fixture loops left.
Checks so far:
- Root and explicit `tool/` analysis: clean.
- Full-app fixture web build and production web build: passed.
- Application regressions: 153 passed, zero failed. Navigation fixtures now
disable unrelated native update plugins; chat fixtures answer the auxiliary
shell-runs snapshot rather than blocking the correlated request queue.
- Dependency lock changed only by removing `cupertino_icons`; no SDK or other
dependency was upgraded. All changed Dart files were formatted.
- Complete test-suite rerun: 3,222 passed after cleanup; the later Runs-indicator
addition was also checked by the full suite: 3,230 passed, zero failed.
- Fresh independent desktop review remains pending; no deployment is claimed.
The web compiler emits an expected-font warning for framework-reachable Apple
icon data after removing the optional icon font. The application has no such
icon references; actual Material Back controls and rendered evidence must be
checked rather than silently restoring obsolete UI dependencies.
## Original failed-stage handoff (historical)
## Status
Blocked/incomplete. This visit removed the obsolete `cupertino_icons` dependency
from `app/pubspec.yaml` and regenerated `app/pubspec.lock` with the existing
dependency versions (`flutter pub get --no-example`; no upgrade was requested
or performed).
The coordinated source/API cleanup was not completed. The clean integrated
baseline still contains compatibility fields and callers throughout
`app/lib`, Material/Cupertino fixture variants in `app/test`, and active
dual-platform hosts/loops in `app/tool`. The parallel run381 host/driver lane
has not landed in this worktree; its callers and host builders must be updated
together rather than removed piecemeal. No source/test behavior was weakened or
probes deleted to hide the dependency.
## Inventory evidence
At `2026-11-11T21:24:28Z`, a case-insensitive grep over `app/lib app/test
app/tool` reported **1,040 matching lines** across the remaining source,
tests, fixtures, probes, and historical notes. This is not an acceptable final
inventory: it includes active code and tests and therefore requires the next
coordinated cleanup lane.
The active production hotspots include `lib/application/pipelines_app.dart`,
`lib/ui/adaptive/segmented_bar.dart`, `lib/ui/adaptive/floating_destination_bar.dart`,
`lib/ui/theme/app_theme.dart`, shared adaptive/layout primitives, and feature
callers retaining `cupertino`/`cupertinoIcon` compatibility arguments. The
remaining tool dependency includes host entries and JS loops such as
`tool/templates_wiring_probe_entry.dart`, `tool/attention_probe.dart`, and
the corresponding `*_probe.mjs` drivers.
`CupertinoPageTransitionsBuilder` in `lib/ui/theme/app_theme.dart` is the one
explicitly permitted Material transition API and must be retained to preserve
the native iOS back-swipe behavior. It is not evidence that the active
Cupertino widget hosts are complete or removable independently.
## Verification
- `flutter pub get --no-example`: passed; removed `cupertino_icons` 1.0.9 from
the lockfile while preserving the other resolved versions.
- Focused watchdog tests: not run; the requested API cleanup was not complete.
- `tool/analyze.sh`: not run after the final clean-baseline decision; no source
edits requiring analysis were retained.
- Browser/device/build verification: not run.
## Remaining work
Land or otherwise provide run381's host/driver cleanup, then remove all
remaining compatibility APIs and callers, convert the named startup/routing,
native-back, shared UI/theme/status, selector/window/search tests to the single
Material path, format all changed Dart, run the explicitly scoped watchdog
regressions and analysis, and replace this handoff with complete evidence.