Commit Graph

356 Commits

Author SHA1 Message Date
alan db522c8dc9 Merge commit '2da375ccce14528305d19416678bc2667520afa9' into pipelines/run-20261111-1951-material-cleanup-chat-workspace-and-sess-8fd9 2026-11-11 21:01:24 +00:00
alan d16c1b3db7 Merge current main and preserve Material chat cleanup 2026-11-11 20:53:58 +00:00
alan 1d790c2a66 Merge commit 'a823a6e8a398ab1327ff22f9c393d970e52a6f4b' into pipelines/run-20261111-1947-use-desktop-dialogs-for-remaining-sheets-4d07 2026-11-11 20:47:24 +00:00
alan 00d470a4aa Merge commit '61c34bb74ad275430fb8909f64fc18cd588fb943' into pipelines/run-20261111-1927-open-search-with-alt-slash-and-cmd-slash-f9f5 2026-11-11 20:38:11 +00:00
alan e1cc3cbf3d Merge commit 'fb8acda1975ed21dea3b03d9ecff2fc03a78f137' into pipelines/run-20261111-1951-material-cleanup-chat-conversation-and-t-b53d 2026-11-11 20:20:19 +00:00
alan 714f8aedab Merge commit '2e3275a46e8ab51fff4191204fe4bd0f2e39ab82' into pipelines/run-20261111-1947-use-desktop-dialogs-for-remaining-sheets-4d07 2026-11-11 20:10:57 +00:00
alan 04ba81e0ea Remove Cupertino chat cleanup leftovers
Keep chat and folder-picker UI on the Material path by removing obsolete Cupertino imports, icon metadata, flags, and alternate control handling while preserving existing behavior and focused test coverage.
2026-11-11 20:06:37 +00:00
alan ba198d144a Use desktop dialogs for remaining sheets
Keep the audited runs filter, chat colour picker, and Needs you flows as Material bottom sheets on narrow or touch layouts while presenting bounded desktop dialogs on wide layouts. Remove obsolete Cupertino flags and add focused route regressions and notes.
2026-11-11 20:06:27 +00:00
alan 87a568a7b4 Remove dead Cupertino chat paths
Keep the chat transcript and toolbar on their existing Material behavior while removing obsolete Cupertino-only helpers, arguments, and icon metadata. Preserve compatibility parameters where callers outside this lane still require them.
2026-11-11 20:05:45 +00:00
alan 70b3f05c5e Merge commit 'f45bca093f04e9d87bbdfdd58c88331a9737e3b3' into pipelines/run-20261111-1927-open-search-with-alt-slash-and-cmd-slash-f9f5 2026-11-11 20:05:06 +00:00
alan f45bca093f Merge commit '2e41717e83132e55d296853c0338bc2c7ed87b9d' into pipelines/run-20261111-1927-unify-chat-selectors-with-permission-men-e1a8 2026-11-11 19:53:26 +00:00
alan 1850528ced Cover Alt slash search focus
Update the keyboard focus regression coverage so Alt+/ is verified as the shell Search destination shortcut while preserving the existing Ctrl+/ behavior. Record the expanded focused-check result in the implementation note.
2026-11-11 19:51:15 +00:00
alan 2e41717e83 Merge commit '3f05421e8b61f063155eb61a166edcee910b750a' into pipelines/run-20261111-1928-focus-chat-composer-when-toggling-from-f-1ed3 2026-11-11 19:48:03 +00:00
alan 6cacd11c6b Use proper sort icon in file explorer
Give the FilesHeader sort control a recognizable Material sort glyph while preserving the default overflow icon for other menus. Add focused widget coverage for sort key and direction behavior.
2026-11-11 19:41:20 +00:00
alan 4668deeaf7 Focus floating chat from terminal shortcut
Raise the most recently used chat when Ctrl+Y is invoked from another window, then rely on the existing host lifecycle to focus its composer. Preserve toggle behavior while chat is active and retain the Apple shortcut aliases.
2026-11-11 19:40:30 +00:00
alan 2d0e33dd67 Unify chat selector menus
Use the permission selector's shared popup and choice-row primitives for model and thinking controls while preserving catalog, search, and next-turn behavior. Remove the obsolete Cupertino model chooser parameter and cover current-model dismissal.
2026-11-11 19:40:26 +00:00
alan 3da71c3053 Merge commit 'c8d9f661b5285a97ff9b2fb5f670549d09ac2ebf' into pipelines/run-20261111-1811-preserve-center-stage-reading-width-with-c833 2026-11-11 18:25:51 +00:00
alan d17d356814 Preserve center stage width with file explorer
Report each pane's active explorer width to the center-stage layout so the reading column stays at its preferred width while constrained workspaces still make room for side strips. Restore the allocation when switching panes or closing the explorer.
2026-11-11 18:25:44 +00:00
alan c8d9f661b5 Support Alt+E center stage shortcut
Recognize Option+E by physical key position so macOS dead-key delivery works, including from focused composers, while preserving existing platform aliases and shell behavior. Update labels, notes, and focused coverage.
2026-11-11 18:20:24 +00:00
alan ae208699d8 Remove Cupertino chat session branches
Keep the Material-only session UI and narrow its tests to the supported host. Preserve public Cupertino parameters for callers while removing unreachable Cupertino widgets and variants.
2026-11-11 14:18:04 +00:00
alan 96de9f5bea Remove Cupertino chat conversation branches
Keep the Material-only conversation implementation while preserving public Cupertino parameters for callers. Narrow affected tests to Material hosts so the dead platform paths are no longer exercised.
2026-11-11 13:11:05 +00:00
alan 8f52c7ec55 Narrow chat tests to Material hosts
Remove Cupertino-only fixtures, test variants, and the obsolete readable-text test now that the app is Material-only. Preserve the Material coverage while avoiding unreachable platform branches.
2026-11-11 12:35:38 +00:00
alan fc1e93760d Narrow chat tests to Material hosts
Remove Cupertino-only composer test variants and keep the remaining coverage focused on the app's Material-only runtime.
2026-11-11 12:10:39 +00:00
alan 4e083af695 Merge commit '3ba124f2500ed32c7169cf3b7963b60d6c1ee0b3' into pipelines/run-20261111-1117-cupertino-out-chat-transcript-part-1-bf8b 2026-11-11 11:57:10 +00:00
alan fbe1928f59 Remove Cupertino chat transcript branches
Keep the existing Material transcript path while preserving public Cupertino parameters for callers. Narrow transcript tests to the Material-only behavior and remove Cupertino-only fixtures.
2026-11-11 11:46:13 +00:00
alan 3ba124f250 Remove Cupertino branches from shown transcript
Keep the Material transcript path while preserving public Cupertino parameters for callers that will be removed in a later change.
2026-11-11 11:13:58 +00:00
alan 1c2bb8733a Remove Cupertino folder picker branches
Keep the Material-only folder picker implementation while preserving public cupertino parameters for callers. Narrow the matching tests to the supported Material host.
2026-11-11 10:56:54 +00:00
alan ac4627b8f2 Take the race out of the chat seen-sync test
The open chat acknowledged after 20 ms of real time, so on a loaded machine
it could fire before the assertion that the other device still shows New.
That failed the delivery gate of runs 304 and 318.
2026-11-11 10:46:05 +00:00
alan b6aa820378 Remove Cupertino chat conversation branches
Keep the Material-only chat conversation implementation while preserving public Cupertino parameters for downstream compatibility. Narrow the matching tests to the Material path.
2026-11-11 05:18:29 +00:00
alan 8e98651db6 Remove Cupertino chat shell branches
Keep the Material-only chat shell path while preserving public Cupertino parameters for callers. Narrow matching tests to the supported Material host.
2026-11-11 04:41:58 +00:00
alan 9bdabb32d9 Remove Cupertino shell branches
Keep the Material-only shell path while preserving public cupertino parameters for callers. Narrow matching tests to Material hosts and behavior because the app always runs under MaterialApp.
2026-11-11 03:48:41 +00:00
alan c75023eb40 Remove Cupertino chat workspace branches
Keep the app's Material-only chat workspace path while retaining public cupertino parameters for callers. Narrow the affected widget tests to the supported Material host.
2026-11-11 01:53:14 +00:00
alan f21365f609 Remove Cupertino chat file branches
Keep the Material-only file explorer path while preserving public APIs used by callers. Remove unreachable Cupertino widgets, hosts, routes, and tests so the app remains behaviorally unchanged on Material screens.
2026-11-11 01:23:59 +00:00
alan 2628f6c425 Copy a terminal selection with Ctrl+C outside Apple platforms
A browser keeps Ctrl+Shift+C for its developer tools, so on Linux and
Windows web nothing copied. With text selected Ctrl+C now copies it (and
clears the selection) instead of interrupting the process; Ctrl+Insert
copies too, and a finished run's read-only output answers the copy keys.
The terminal's options menu names the key.
2026-11-11 00:05:16 +00:00
alan aa6468dc06 Drop Cupertino variants of the mode control tests 2026-11-10 23:11:29 +00:00
alan 046460b4b6 Merge 2b.2: mode and add-pane pickers as menus on desktop 2026-11-10 23:02:20 +00:00
alan 6a071a5b02 Drop Cupertino variants of the row menu and run detail tests 2026-11-10 23:02:20 +00:00
alan 5fc3c9d3bd Show the mode picker and the add-pane picker as menus on desktop
Phase 2b.2 of docs/plans/floating-windows.md, implemented by pipeline run
303: both use showAppChoiceMenu (a menu anchored to its button on a wide
app, a bottom sheet on a phone).
2026-11-10 23:02:20 +00:00
alan 4acecd3d1c Merge 2b.3: turn changes and shell history as dialogs on desktop 2026-11-10 22:56:33 +00:00
alan 3a0577cba0 Keep phone pages and window pages for turn changes and shell history
A dialog only in the tiled app on a wide layout: a phone keeps its
full-screen page (run 304 had turned it into a sheet and rewritten the
tests), and a floating window opens it as a page of that window so a diff
or command output it opens stays in the window.
2026-11-10 22:56:32 +00:00
alan 8c95f0dd39 Fix the tests the chat details dialog broke on main
I landed 2b.4 without reading its gate result: six Cupertino variants of
the chat details tests and one floating chat test expected the old sheet.
2026-11-10 22:56:24 +00:00
alan f6046c5ab6 Drop the Cupertino files test the Material-only details invalidated 2026-11-10 22:54:32 +00:00
alan 286506310c Show chat details and file details as dialogs on desktop
Phase 2b.4 of docs/plans/floating-windows.md: both use showAppDetails (a
dialog on a wide app, a bottom sheet on a phone). Implemented by pipeline
run 305; landed by hand after its UI review found the dialog clipped, which
the helper now scrolls.
2026-11-10 22:21:15 +00:00
alan 8a308204fa Use adaptive popups for chat details
Present chat turn and shell-history detail surfaces through the shared adaptive popup helpers so desktop uses dialogs while phone layouts retain bottom sheets. Update focused tests and document the verified behavior.
2026-11-10 22:14:29 +00:00
alan fdc730422d Host floating chats on the shell window system
Phase 2.3 and 2.4 of docs/plans/floating-windows.md. A floating chat is a
window of the chat kind over the app's WindowManager, built from the
app-lifetime ChatRuntime, so it shows over every destination and at start
without the Chat destination being built. Float and Dock move the same
keyed view between the tiling and the window host. The pipelines app keeps
one runtime and one ChatWindows; saved chatFloat records (v1 and v2) are
brought over once.

ChatFloatHost, ChatFloatWindow, the float frames and binding, the
controller's float list and FloatingFocusRoot are gone; the workspace only
asks whether a chat is out in a window. Every MenuAnchor targets the root
overlay (guarded by a test), and menus and tooltips name the Alt chords.
2026-11-10 21:17:40 +00:00
alan 9695100faa Build chat panes through one content builder
Phase 2.2 of docs/plans/floating-windows.md: buildChatPaneContent wraps a
conversation in the scopes it needs and keys it by the runtime, so the
tiling and (next) a floating window build the same subtree. The tiling uses
it; behaviour is unchanged.
2026-11-10 21:05:41 +00:00
alan 558eedb410 Extract ChatRuntime from the Chat screen
Phase 2.1 of docs/plans/floating-windows.md. The session list controller,
opened rows, accepted models, transcript positions and caches, composer
focus requests and list folds move from ChatScreen's state to ChatRuntime.
ChatScreen builds its own unless one is passed; behaviour is unchanged.
2026-11-10 21:00:21 +00:00
alan 182fd9bb62 Pad chat bar text buttons 12 px and add Alt+Y for floating chats
Model, mode and thinking buttons carry 12 px horizontal padding, replacing
the pill inset from 440995e3. Alt+Y (Option+Y by key position) toggles the
floating chats, like Alt+T for the terminal.
2026-11-10 19:18:46 +00:00
alan 440995e31f Keep model and mode text off the action bar pill ends
Run 299 removed the model and mode buttons' horizontal padding on desktop
so the island's gap sets the spacing, which left their text touching the
pill's rounded ends. The island now insets its content by 12 px.
2026-11-10 17:00:42 +00:00
alan 123c864397 Evenly space chat action bar controls
Add a uniform desktop gap between header control groups and remove duplicated horizontal padding from model and mode controls. Preserve compact-layout touch targets and add Material/Cupertino regression coverage.
2026-11-10 16:38:55 +00:00