Fix the tests the chat details dialog broke on main
I landed 2b.4 without reading its gate result: six Cupertino variants of the chat details tests and one floating chat test expected the old sheet.
This commit is contained in:
@@ -273,16 +273,12 @@ void main() {
|
||||
);
|
||||
await tester.pumpAndSettle();
|
||||
expect(find.text('Chat details').hitTestable(), findsOneWidget);
|
||||
// Chat details, the sheet that used to open behind the window.
|
||||
// Chat details, which used to open behind the window: a dialog on the
|
||||
// root navigator, over the window.
|
||||
await tester.tap(find.text('Chat details'));
|
||||
await tester.pumpAndSettle();
|
||||
final sheet = find.byType(BottomSheet);
|
||||
expect(sheet.hitTestable(), findsOneWidget);
|
||||
// On the root navigator: wider than the window, and over it.
|
||||
expect(
|
||||
tester.getSize(sheet).width,
|
||||
greaterThan(tester.getSize(_window('Chat b')).width),
|
||||
);
|
||||
expect(find.byType(Dialog), findsOneWidget);
|
||||
expect(find.text('Chat information').hitTestable(), findsOneWidget);
|
||||
expect(_shown('Chat b'), findsNothing);
|
||||
expect(tester.takeException(), isNull);
|
||||
await app.stop(tester);
|
||||
|
||||
@@ -140,7 +140,8 @@ void main() {
|
||||
});
|
||||
});
|
||||
|
||||
for (final cupertino in [false, true]) {
|
||||
// Chat details is Material only (a dialog, or a sheet on a phone).
|
||||
for (final cupertino in [false]) {
|
||||
final host = cupertino ? 'Cupertino' : 'Material';
|
||||
|
||||
testWidgets('$host: account usage shows windows, plan and age', (
|
||||
|
||||
@@ -116,7 +116,8 @@ Future<void> _tap(WidgetTester tester, Key key) async {
|
||||
}
|
||||
|
||||
void main() {
|
||||
for (final cupertino in [false, true]) {
|
||||
// Chat details is Material only (a dialog, or a sheet on a phone).
|
||||
for (final cupertino in [false]) {
|
||||
final host = cupertino ? 'cupertino' : 'material';
|
||||
|
||||
testWidgets('$host: shows the native id, harness and directory', (
|
||||
|
||||
@@ -7,7 +7,8 @@ import 'package:pipelines_app/features/chat/ui/transcript/chat_message_view.dart
|
||||
import 'chat_thread_fixtures.dart';
|
||||
|
||||
void main() {
|
||||
for (final cupertino in [false, true]) {
|
||||
// Chat details is Material only (a dialog, or a sheet on a phone).
|
||||
for (final cupertino in [false]) {
|
||||
testWidgets(
|
||||
'usage updates leave transcript widgets alone but refresh Info ($cupertino)',
|
||||
(tester) async {
|
||||
|
||||
Reference in New Issue
Block a user