No conflicts: main's chat-surface work (the in-flight tool work in ChatFormat,
ChatStore and ChatTranscript, run notifications, the status palette) sits in
different hunks from this branch's fan-out edits, and main did not touch
docs/cli.md. Checks re-run on the merged tree: gofmt -l . (clean), go build ./...,
go vet ./..., go test -count=1 ./... (all packages pass; the focused multi-client
tests fan-out, per-session serialisation, first-answer-wins, pending replay and
resync pass), and the Android unit tests
(gradle --offline --no-daemon :app:testDebugUnitTest, BUILD SUCCESSFUL, 598 tests,
0 failures).
A session was owned by one connection: the claim map in chat_claims.go let the
first client hold it, every other client saw the session Busy and read-only, and
a second client's prompt was rejected. Replace the claim with a per-session
"room" so the operator's phone, tablet and terminal all watch and write the same
conversation, and a pending approval is a shared, exactly-once object.
Server (internal/server, internal/protocol):
- New chat_room.go: one room per session holding the session's single broker
stream, its one bounded prompt queue (8) and the fan-out to every attached
client. A chat_subscribe frame attaches a connection to a session's shared
stream and replays the still-unresolved approval requests the room holds.
- chat_stream.go: handleChatPrompt accepts a prompt from any client. It attaches
the sender, either starts a turn or queues the prompt behind the in-flight turn
and acknowledges it with chat_queued:true ("queued" is the chosen behaviour,
stated on the wire and in docs/cli.md), and echoes the user turn to every other
client attributed to the sender's label. The prompt handler no longer owns the
stream; one turn runner per room drains the queue, so two turns never
interleave. Per-connection write serialisation is unchanged (each chatSub has
its own writer goroutine and bounded buffer).
- chat_permissions.go / chat_commands.go: an approval is reserved by the first
answer and confirmed once delivered; the first answer wins, is recorded with
the answering client's label, and the resolution is pushed to every watching
client as chat_permission with resolved/decision/resolved_by so their cards
clear. A later answer is refused with an error naming the client that answered,
and never reaches the agent twice; a reservation whose reply failed is
released.
- chat_hub.go / chat_sessions.go / chat.go: the hub now owns rooms and the
user-turn id sequence; the resulting user turns are retained (role and client
carried) so a reconnect re-syncs who said what. chat_sessions no longer marks a
session Busy and its clientID parameter is gone; the protocol keeps the Busy
field for wire compatibility only. websocket.go detaches a connection's chat
subscriptions when the read loop ends.
- chat_claims.go is removed, not left vestigial: the only exclusive thing left is
a turn, and the room's queue is that.
App (android):
- PipelinesRepository carries a stable per-device client label (Build.MODEL, with
a fallback) on prompts and replies, and adds chatSubscribe; AppViewModel
subscribes on opening a chat (best-effort, an older server's error frame does
not stop history loading) and records the queued ack.
- ChatStore folds a user frame from another client into the transcript once,
attributed by the sender's label, and never receives its own prompt back, so
the sender's own message is never duplicated. ChatThread.readOnly is gone:
canSend no longer depends on another client, the composer says "Queued - it
will send when the current turn finishes." instead of disabling input, and the
status label is Running/Idle only. Scroll/follow behaviour is untouched.
- Tests: ChatProtocolTest round-trips the new wire fields, ChatFormatTest asserts
the stale Busy flag cannot produce a read-only label, MultiChatStateTest asserts
a session another client watches stays writable.
Reflected where it belongs: no packaged template changes (no bundled starter
embeds the chat protocol). Checked the packaged authoring skill references: none
of them describes the chat wire beyond operations.md, and
internal/author/skill/references/operations.md is now stale - its "Brokered
OpenCode chat" section still says chat_sessions marks "busy" when another client
holds the session and that a second client's chat_prompt is rejected, and it does
not mention chat_subscribe, the per-session prompt queue/chat_queued, the
per-client label or the shared exactly-once approval (it also still describes the
per-subscription permission poller, which the room's single poller replaced). The
supported semantics are the ones in docs/cli.md, updated in this commit; the
operations.md section needs a rewrite to match. No README or other shared
document was edited here.
Checks run on the committed tree: gofmt -l internal cmd examples (nothing), go
build ./..., go vet ./internal/... ./cmd/..., go test ./internal/server
./internal/protocol ./internal/stage ./internal/pipeline.
A session said "Running" with an empty tool chip while it worked, so a silent
wait was indistinguishable from a stuck one. Derive the in-flight work from the
stream the app already folds and show it on both surfaces.
- ChatFormat: runningToolCalls() reads the tool parts still running, in
transcript order, so the conversation and the session row share one set;
toolDetail() takes the command/description the part actually carries (the
first of description/command/filePath/file_path/path/pattern/query/url),
collapsed to one line and elided at 72 chars, and returns null rather than a
fabricated summary; runningToolElapsedMillis() uses the protocol's own
time.ran/created when present and the local per-part stamp otherwise;
runningToolStamps() keeps a stable start per part across frames;
TOOL_LONG_RUNNING_MILLIS (60s) and toolLongRunning() mark an unusually long
call; sessionWorkLabel() names what a working session is doing while a
text-streaming turn stays plain "Running" and a busy session never reads
"Idle".
- ChatStore: ChatThread gains toolStartedAt, stamped when a part turns running
and dropped when it settles, plus runningTools/toolElapsedMillis; history()
and the frame fold maintain it; setRunning/turn end clear it.
- ChatTranscript: RunningIndicator lists one line per running call (name,
detail where present, live elapsed) keyed by part id so concurrent calls
render together without flicker; no percentage, ETA or progress bar.
- ChatListPane: the session row renders sessionWorkLabel(busy, thread).
- ChatRunningWorkTest covers name/detail/elapsed, clear on completion, error
state, concurrent calls and the no-detail stream.
Only fields the harness reports are used: tool name, state.status and input;
the live brokered frame carries no timing envelope, so elapsed falls back to the
local stamp. Existing chips, INPUT/OUTPUT, reasoning blocks, stop control,
activity marks and scroll/follow behaviour are untouched.
Checked and unchanged: no packaged template or packaged authoring-skill
reference describes this app surface (the chat references in
internal/author/skill/references/ document the server's brokered chat_* protocol,
which this change does not touch), so none is stale. android/AGENTS.md already
names ui/chat/ and its files. The shared documents this change does make stale
are recorded, not edited, in docs/notes/chat-in-flight-tool-work.md: the
Running-indicator and session-status statements in android/README.md.
The recovered commit gave every status one colour, but it predates main's split of the run
view and main's own cyan 'waiting' colour. Resolution: keep main's Waiting, keep the run
view's own file (main already has RunSummaryTab), and carry the parts that were genuinely
missing - RunState.Blocked and RunState.Skipped with their words, glyphs and one colour
each - so the palette and the enum agree.
A successful stage read amber in the Timeline because a visit's chip was
coloured from the graph's outcome palette (`graphColors`/`outcomeColor`) while
every other surface used the run-status palette, so the same word meant two
colours. This makes `RunStatusPalette` the single source of truth:
- `RunState` gains the server's own `Waiting`/`Blocked`/`Skipped` words, each
with a deliberate palette entry, a distinct material glyph and a label, so a
status is never colour alone and success is green / failure red everywhere.
- `graphColors()` takes success/error from `runStateColor(Succeeded/Failed)`;
`outcomeColor()` returns the shared status colour for any word that resolves
to a `RunState` and leaves `GraphPalette` only the graph-only flow outcomes
(`rejected`/`exhausted`/`retry`/`approved`/`fast`/`missing`; `blocked`/
`skipped`/`done` removed). The Timeline's `TimelineRow` uses the same factory.
- A visit's *outcome* stays distinct from the run's *status* by the chip's own
label and the row's state glyph, never a second colour.
- The runs-list failure diagnostic uses `runStateColor(Failed)` instead of a
scheme role that could drift from the chip above it; the status filter gains
`waiting`.
Tests: new `StatusColorConsistencyTest` (timeline colour comes from the runs-list
source; every state maps to exactly one colour) and extended `GraphPaletteTest`/
`RunStatusTest`. `gradle --offline --no-daemon :app:testDebugUnitTest
--rerun-tasks` -> 516 tests, 0 failures, 0 errors, 0 skipped.
Docs check: the root README and docs/ do not describe the Android status
colours; the packaged templates and internal/author/skill/references cover the
authoring surface and are unrelated, so nothing there needed updating.
android/README.md did enumerate the run states and claimed the graph outcome
palette was unchanged, so its features bullets were updated and a new "One status
colour everywhere" section added, with the old bullet marked superseded.
APK published to the run's artifacts as pipelines-debug-wip-d13f359.apk.
(cherry picked from commit a3caa734cd4769f42883b518d877dd0132ef57ae)
Every item wrote the shared, append-only docs (android/README.md, docs/cli.md and
the packaged skill references), so every merge conflicted on prose. Keep the duty
to notice stale docs; move the writing to one deliberate place.
- Per-item note, not a shared edit. An item that makes a shared document stale
writes docs/notes/<slug>.md - unique per item, so two items never touch the same
file - and commits that note with its change. It never edits a README, topic doc
or packaged skill reference itself.
- One writer. The manual-only docs-fold pipeline, bundled as the fifth starter
examples/docs-fold.md, folds every note under docs/notes/ into the shared
document it names and deletes the consumed notes in its own commit; an empty
notes directory is a success no-op. Operator trigger:
pipelines new "Docs fold" --template docs-fold --no-open; pipelines submit
<draft.md>; pipelines run "Docs fold".
- Implemented where the convention lives: orchestration.md (brief item 5, the
hard-constraint bullet, a "Single documentation writer" section and the
"Pipeline choice" committer bullet), the canonical committer checklist in
format.md (new step 6), the committer prompts in examples/task.md and
examples/three-stage.md, the new examples/docs-fold.md with its catalog and
README entries, and the repository guideline AGENTS.md. Test-expectation counts
(examples/catalog_test.go, internal/server/templates_test.go,
scripts/smoke-first-install.py) follow the fifth starter.
Reflected where it belongs: the packaged templates (examples/task.md,
examples/three-stage.md, the new examples/docs-fold.md), the packaged skill
references (orchestration.md, format.md) and the repo guideline AGENTS.md all carry
the new convention. No new reference file was added, so install.go's managed
inventory is unchanged. The shared descriptive docs were deliberately not
rewritten: this change makes README.md:191, docs/cli.md:170 and
internal/author/skill/references/operations.md:13 name four starters where there are
now five. Those stay as they are - correcting them now is exactly the per-item
shared edit this change removes - and the stale-doc note
docs/notes/docs-fold-single-writer.md records each one for the docs-fold writer to
fold. Nothing else needed updating. No new dependency; no Android, Gradle, server,
installer, Docker or published-definition change; no definition published over the
running pipelines.
Evidence: go test -count=1 ./... passed; go build ./... and go vet on the touched
packages clean; ./internal/author/... covers embedding, reference links, the managed
inventory and install/upgrade/protection; ./examples/... validates the fifth starter
and its manual-only, committer-terminated graph; ./internal/server/... covers the
served catalog. Not run: the docs-fold writer against the shared docs (nothing to
fold yet); no install or deploy.
(cherry picked from commit f29656cf084d7eee2e033f2a37a9d231d7acaaf0)
Brings this branch up to main (73284ff) so it can be merged back without
conflict. Main's two chat commits (ChatFormat/ChatTranscript reasoning into
one collapsible block) do not touch any of the notification files, so the
merge was clean with no conflicts to resolve. The merged tree keeps both
intents unchanged.
The app already had an in-app attention surface but nothing in the system
tray. This adds the app's own Android notifications for the two events that
need a person: a run waiting for a decision (highest importance) and a run
that failed. A successful, running or cancelled run raises nothing.
- RunAlerts.kt: the pure model. Maps the attention list's kinds to run
alerts, coalesces several into one grouped summary, dedupes one
notification per run+kind via AlertLedger (never repeated while the run
stays failed or waiting), clears on resolution/dismissal/arrival, and
decides the one-time permission prompt and tap destination. Unit-tested.
- RunNotifier.kt: the Android edge. Creates the single "Runs that need you"
channel, posts/clears through NotificationManagerCompat, and reports
notificationsAllowed() from POST_NOTIFICATIONS (API 33+) / the system
notification switch. Posted from the app's own process.
- Manifest: POST_NOTIFICATIONS runtime permission; PipelinesApplication
creates the channel before anything can post.
- SettingsRepository/AppViewModel: remembers that the permission was asked
once (never nags), keeps notificationsAllowed fresh on resume, feeds the
tray from the same attention flow, and clears a run's notification when
the operator arrives at it.
- PipelinesApp/DecisionPrompt/RunDetailScreen: the one-time rationale before
the system dialog, asked at a sensible moment (first run that needs the
operator, or first open of the attention surface), degrading to the
existing in-app surface on refusal; a waiting run's tap opens its decision
sheet (pipelines://run/<id>?action=decide), a failed run's tap opens the
run; reaching a run clears its notification.
- Attention.kt: drops the Finished kind so a successful run is never
announced on any surface (the operator's rule), keeps the deep-link parser
(now carrying an optional action) and still decodes an older state's
looked-at-finished set.
- AttentionTest.kt / RunAlertsTest.kt: the mapping (waiting and failed
only), the permission paths (granted, refused, not-yet-asked), coalescing
and clearing, dedupe, and the tap destination.
Checks: `:app:assembleDebug` and `:app:testDebugUnitTest --rerun-tasks`
pass (578 tests, 0 failures). Reflected-where-it-belongs check: this is an
android/-only change and the packaged authoring skill references and the
packaged templates describe the server's ntfy notification authoring, not
the Android app's tray, so none of them needs updating. No README or other
shared documentation file was touched.
A chat turn that reasoned several times now shows a single collapsible thinking
block (with its step count and elapsed time) instead of one box per reasoning
part, and a streaming turn grows that block rather than adding another.
The chat rendered every reasoning part as its own ReasoningBlock, so a turn
that reasoned several times stacked several thinking boxes between messages.
This folds a turn's reasoning parts into a single collapsible entry, anchored
where the turn's first reasoning part sits, so a streaming turn grows the
block it has instead of gaining another.
- ChatFormat.kt: add ReasoningTurn / turnReasoning (the ordered fold of a
turn's reasoning parts), reasoningLabel (counted wording for >1 steps, plain
one-block wording otherwise) and turnElapsedMillis (elapsed from the turn's
own part timing envelopes, null when unknown). ReasoningExpansion is now
keyed by the turn's message id via reasoningTurnKey rather than a per-part
key.
- ChatTranscript.kt: AssistantParts renders exactly one ReasoningBlock per
turn (first reasoning part wins the anchor); the collapsed line reads
"Thinking · N steps"/"Reasoning · N steps" when the turn reasoned more than
once, else "Thinking…"/"Reasoning", with elapsed time appended when known.
Streaming elapsed is driven by thread.runningSince so it matches the running
indicator. The answer, tool chips, diff cards, attachments and approval
cards are untouched.
- Tests: ChatTranscriptTest exercises the turn-keyed expansion; new
ChatReasoningTurnTest covers the fold (several parts -> one entry in order),
the collapsed wording, elapsed derivation and a streaming turn appending
into the same entry.
Checked for stale packaged artefacts: none needs updating. The packaged
authoring skill references (internal/author/skill/references/) document the
protocol (reasoning deltas, cost/token budgets), not the Android transcript
rendering, so nothing there describes per-part thinking blocks. No packaged
template mentions reasoning rendering. Shared docs / the Android area map are
left to the single documentation writer; nothing here changes documented
behaviour beyond the transcript fold.
Verified with the Android toolchain (no daemon): :app:testDebugUnitTest passes
567 tests, 0 failures, 0 errors, including ChatReasoningTurnTest (5),
ChatTranscriptTest (7) and DimensTest (2). No new raw geometry literals.
Main adds only documentation (per-area agent maps for the Android app, the TUI
and the server); the sweep-ui side holds the UI/UX sweep fixes. No overlapping
files, so both intents are kept unchanged.
Addresses the survey/review findings on the sweep-ui branch, reusing the
app's existing patterns and named tokens (DetailTabBody, formatLocalTimestamp,
stageCountText, ATTENTION_CHIP_RESERVE) rather than hardcoding values.
Fixed findings:
- n:1 attention-chip reserve (OmniSearchResults, ATTENTION_CHIP_RESERVE in
Dimens, PipelinesApp bottom content reserve).
- n:2 formatted local timestamps via the shared Format.formatLocalTimestamp
(PipelinesApp lists, RunHistory, RunSummaryTab, PipelineDetail).
- n:3 decodeHtmlEntities for the session export's HTML entities (Markdown),
with regression cases for entities and a bold-only line.
- n:4 Raw/Rendered control now labels the current view and its state
(SourceView).
- n:5 filters as a Material modal bottom sheet capped at a window-derived
filterMenuMaxHeight with a scrolling body (FilterMenu), plus tests.
- n:7 stage-count wording via the shared stageCountText helper.
- n:8 labelled key row on the template detail screen.
- n:9 stage pane de-duplicates identity / folds the definition.
- n:10 wide-flag plumbing into the destination lists and ChatListPane, which
now wraps its session list in DetailTabBody(wide, ...) so wide rows keep
DETAIL_MAX_WIDTH_DP centred.
- n:13 Settings: Disconnect is the filled primary while connected and the
trust warning moved into a surfaceVariant card.
- n:15 CodeBlock bounded height plus a scroll affordance with an unbounded
option.
Deferred findings (with reason):
- n:3 (Chat transcript) residual is server-side data: chat_messages returns a
single assistant part whose text is already interleaved/doubled, so the
renderer cannot close it. The android half (entities/Markdown) is fixed.
- n:6 Runs list titles arrive truncated to 80 chars mid-word from the server.
- n:11 Two-pane top-band layering is a product/design decision.
- n:12 48dp graph-node hit targets and label dodging are product decisions.
- n:14 The session-list chip is OpenChatStrip (open chats), not a list filter;
relabelling it would misdescribe it.
Commands: :app:compileDebugKotlin + :app:testDebugUnitTest (562 tests, 0
failures) and :app:assembleDebug all succeed.
Pure move: split the three multi-feature server files into per-concern files,
with no behaviour change - same package, same exported and unexported
identifiers, same call graph, same tests.
- internal/server/chat.go -> chat.go (broker seam, client token, dispatcher),
chat_hub.go, chat_claims.go, chat_permissions.go, chat_sessions.go,
chat_stream.go, chat_commands.go
- internal/stage/model.go -> model.go, model_run.go, model_failure.go,
model_validation.go
- internal/pipeline/runs.go -> runs.go (read side), runs_schema.go,
runs_create.go, runs_mutate.go, runs_sessions.go
Checked before committing:
- Packaged templates and internal/author/skill/references: neither refers to
internal/server/chat.go, internal/stage/model.go or internal/pipeline/runs.go,
so nothing there needed updating (the change is a move with no behaviour
change).
- gofmt -l on the three packages: clean. go build ./..., go vet ./... and
go test ./... pass. go.mod/go.sum unchanged.
- No test, docs, android/, install or Docker files touched.
Known stale path pointers deliberately left to the single docs writer (shared
docs) and out of scope (android/): docs/chat-verification.md and
android/README.md name the old file paths.
Combine the chat end-to-end verification record update (revision, APK
artifact, test totals and the 3ffc126..ec27a2d chat-surface delta) into main.
Docs-only; no behaviour change.
Update docs/chat-verification.md from the earlier `3ffc126` record to the
current revision `ec27a2d`, which is both this lane's HEAD and main:
- revision, APK name/size/sha256 and LAN URL refreshed to the rebuilt
artifact `pipelines-debug-wip-ec27a2d.apk` (18,585,084 bytes,
sha256 5ee4b38c…da84);
- unit-test totals refreshed to 61 suites / 558 tests / 0 failures, and the
server-side `go build ./...` plus the chat/session/adopt Go tests recorded;
- a "Changes since the previous record" section describing the chat-relevant
delta `3ffc126..ec27a2d` (the `chat_adopt` request, the lazy
`MarkdownBlocks` renderer, the run-watch scope change) and correcting the
chat protocol file path to `data/protocol/Chat.kt`.
The change is documentation only: no app or server behaviour changes.
Checked where the change belongs: packaged templates (no template encodes
this record) and the packaged authoring skill references
(internal/author/skill/references/) — none is made stale by a
verification-record update, so none is touched. `go build ./...` passes.
The debug APK lives in the run's artifacts directory outside the repo and is
therefore not committed.
Refs: brief "Verify the chat end to end, on the phone, against the real server".
main brought pushed run events (emitRun/RunEventFrame across protocol, server
and the Android client) and this branch brought per-run usage recording. Both
touch internal/server/runner.go; git auto-merged cleanly and the result keeps
both intents — each model step is stamped with its effective provider/model and
budget-derived usage (stageUsage, overlayEffectiveModels) while run events are
emitted (emitRun) and applied to the same step loop. No conflict markers, no
side's work discarded.
Post-merge checks: gofmt -l clean, go build ./..., go vet ./... and
go test ./... all pass.
Carry the usage a model stage already measures for its budget
(stage.Budget.Snapshot()) onto the step as typed evidence and total it in
one pass, rather than a second harness read, a transcript parse or an
output-length estimate. A shared budget across stage revisits records only
the visit's increment, and a revisit that observes no new report records no
usage instead of a fabricated known zero.
- protocol: StageUsage/RunUsage/TotalUsage and UsageTotals.
- pipeline: step_usage table + migration, COALESCEd into the one step
projection, FinishStep persistence, one json_extract history aggregate,
retention removes the rows with their run.
- server: stageUsage maps the budget snapshot, stamping per-stage model and
usage for every model stage (including failures).
- cli: inspect/stats human and JSON output.
- budget/pi: retain the reported in/out split, mark a total-only (Pi) report
split-unknown, and keep an unreported cost unknown (never zero).
Evidence and docs updated in the packaged skill references and docs/cli.md;
the live database has no step_usage rows yet (all history predates this), so
per-run figures are reported as unavailable, not zero.
The Android client subscribes to run events for every workspace its runs list
displays (the blank "any workspace" scope the server already honours) instead
of only the configured workspace, so a run executing in a lane worktree - a
different workspace - now delivers frames. A pushed frame carries the run's
pipeline identity (pipeline_id, name, title, version), so the runs-list fold
inserts a never-seen run and the pipelines list, run detail, timeline and stage
cards all follow a run finishing and a new one starting without a refresh, with
no per-event fetch. Server-side workspace isolation and coalescing are unchanged.
Combines this lane's "make every view live from the pushed run events" change
(android + server run-event scope and frame identity) with main's operator
chat brokering work (opencode endpoint adoption, protocol/settings/CLI chat
support, operations reference). The two touch different files; git's ort
strategy merged them cleanly with no conflict markers and nothing to resolve.
Post-merge checks: go build/vet and go test ./... all pass; gradle
--no-daemon testDebugUnitTest assembleDebug passes (558 tests, 0 failures).
The pipelines list (and every other run-state view) kept the row it had when
the screen was last fetched. Two class-level root causes, fixed here:
- The app subscribed to run events scoped to the one workspace the operator
configured, so a run executing in another workspace (a lane worktree is its
own workspace) never delivered a frame: the rows only changed on a manual
refresh. The app now asks for the blank "any workspace" scope the server
already treats as any (ALL_WORKSPACES in AppViewModel.subscribeRuns, blank
default on PipelinesRepository.subscribeRuns). Workspace isolation on the
server is unchanged: an explicit workspace scope still matches only that
workspace (TestRunEventWorkspaceIsolation); the new
TestRunEventAllWorkspacesSubscription pins the blank "any" scope.
- foldRunEvent refused to insert a run the list had never held, returning
needsResync and leaving the list untouched, so a run started after the
screen loaded appeared only after a fetch. The pushed frame now carries the
pipeline identity a row needs (RunEventFrame.PipelineID/Name/Title/Version),
so the fold inserts the new run at the head from the frame's own identity
without a fetch and without reordering existing rows; a server that predates
those fields still falls back to the one resync. Added fields and why each
is needed: pipeline_id (row's pipeline join), name (row title), title (the
stored operator-facing title a row shows), version (the row's pinned
version) - everything a RunSummary row renders, so no per-event fetch and no
guess from stale cache. The server stamps them on every emitted frame from a
per-run identity remembered at create/decide/cancel/resume (runner.go
runIdentity/rememberRunIdentity/stampRunIdentity), first-write-wins through
the coalescer (mergeRunEventFrame) and on the subscribe snapshot, so every
transition - created/queued, running, each stage start/finish, terminal -
carries them. Reconnect still resyncs once then follows pushes; the
pull-to-refresh path is untouched.
Checks run: go build ./..., go vet ./..., go test ./... (all packages ok),
go test -race -run 'RunEvent|RunEvents|Subscribe' ./internal/protocol/
./internal/server/, and gradle --no-daemon testDebugUnitTest assembleDebug
(558 tests, 0 failures, 0 skipped; BUILD SUCCESSFUL).
Packaged templates and the packaged authoring skill references were checked:
nothing there describes the run_event field list or the client's subscription
scope, so neither needs updating (references/notifications.md only says the
attention surface is derived from the pushed run events, which is unchanged).
Docs are a shared file owned by a single writer and were not edited:
docs/cli.md's description of the pushed `run_event` frame still enumerates
only the older fields (status, outcome, current stage, completed-step count,
timestamps, optional step) and is now incomplete - it should mention the
pipeline identity fields; docs/ntfy.md remains accurate.
Broker chat from an operator-supplied OpenCode endpoint (opt-in flag/env,
validated once, no fallback) with the endpoint choice recorded across restarts,
and add chat_adopt with the pipelines chat-adopt CLI command to continue a
session that already exists on that endpoint.
Add an opt-in way to broker chat from an operator-supplied OpenCode service
instead of the instance the server spawns for itself, and a way to adopt a
session that already exists on that endpoint so it appears in chat_sessions and
can be continued from the app.
- Endpoint selection: the `-opencode-endpoint` server flag (defaulting to
`PIPELINES_OPENCODE_ENDPOINT`) opts in; precedence is explicit flag >
explicit environment > the endpoint recorded on a previous run, with the
spawned instance as the default. opencode.OpenEndpoint validates the
reference once (http(s), host, no userinfo/query/fragment/path), detects the
backend from its own /api/info (v2) or /global/health (v1) contract, and
requires a streamable text/event-stream event path. It owns no process
(Close is a no-op) and never calls startServe; every failure names the
endpoint and disables chat rather than silently falling back. An
authenticated endpoint takes an optional password only through the private
file PIPELINES_OPENCODE_ENDPOINT_PASSWORD_FILE, with
PIPELINES_OPENCODE_ENDPOINT_USERNAME overriding the detected default.
- Persistence: the validated choice is recorded in an additive single-row
server_settings table so a restart with no flag/environment reuses it; an
unreachable recorded endpoint disables chat with a clear message and no
fallback.
- chat_adopt: a new protocol request (ChatAdoptRequest) with handleChatAdopt in
internal/server/chat.go. It refuses a nil broker/registry/payload and a
blank or foreign-shaped id before any endpoint call, reads the endpoint via
the shared Chat.Session (which reuses Sessions/decodeChatSessions), records
through the existing RecordOperatorSession with the endpoint's directory and
title verbatim, and echoes the adopted session plus its registry row like
chat_create. A missing id is refused naming the id and records nothing; an
endpoint record with an empty directory is refused rather than substituting
the server's working directory or home.
- CLI: `pipelines chat-adopt <session-id> [--json]` (usage, notes, help
inventory, dispatch) with docs/cli.md updated under Chat sessions.
- Autostart preserves the endpoint variables (and the password-file reference,
never an inline secret) via serviceEnvironmentKeys.
Checks before committing:
- Package location: the change is user-facing chat behaviour, so the packaged
authoring skill reference internal/author/skill/references/operations.md is
updated in the same change (Brokered OpenCode chat section) with a dated
verification-evidence entry and the not-deployed state. No new reference file
is added, so internal/author/install.go's managed inventory is unchanged.
- Packaged templates: this repository packages no template set for this
behaviour and none references the chat endpoint, so no template needs
updating.
- Verification: `go build ./...`, `go vet` on the touched packages, `gofmt -l`
clean and `go test ./...` all pass. The unit tests cover the endpoint
validation/precedence, the adopt happy path and refusals, the recorded
endpoint round-trip, the protocol round-trip and the CLI dispatch. The live
scratch-server check against the operator's real endpoint was not run in this
change.
Nothing unrelated is staged; docs left stale (README and other shared documents)
are not edited here and are for a single folding writer.
Lands the Android reader for the per-stage session export: a Session section in
the stage detail that appears only when the visit's session_export actually wrote
a file, renders the markdown export with the app's existing markdown renderer
(lazy, off the main thread), offers the html export in a WebView via a toggle, and
reports a failed fetch as its own in-pane error without hiding other sections.
The server-side export already landed in 016c39c.
Add a Session section to the stage detail that appears only when the visit's
session export actually wrote a file, beside the artifacts it was written with,
and opens the transcript on a click like any artifact.
- Derive the section from the recorded `session_export` matched against the
step's artifact listing (`sessionExportFiles`), so a visit with no export - a
non-OpenCode harness, an export failure, or a pre-export server - lists no
empty section, mirroring internal/protocol/runs.go and the server's export.
- Default to the markdown export rendered with the app's existing markdown
renderer (new lazy `MarkdownBlocks` reusing `MarkdownBlock`), and when both
files exist offer the html export through an "HTML view" toggle in a WebView
for fidelity; html is the default only when markdown is absent.
- Behave like the artifacts around it: the same Scaffold/TopAppBar/back chrome,
the shared ArtifactBytesCache so the file is fetched once and never loaded
twice, decode/parse off the main thread so a several-hundred-kilobyte session
stays responsive in a lazy block list, and a failed fetch shown as its own
in-pane error without hiding the other sections.
- `SessionExport` protocol model and `RunStep.session_export`, with the
unit tests for section presence, fetch/render, fetch failure isolation and a
large session.
Checked the packaged templates and the packaged authoring skill references: the
session export's server-side behaviour is already documented in
references/delivery.md and references/operations.md (landed with the server
change), and no packaged reference or template describes the Android stage
pane's sections, so none of them needs updating for this client-only change.
Verified before commit (recorded by the independent code review on this tree):
compileDebugKotlin, testDebugUnitTest (forced rerun) and assembleDebug all
BUILD SUCCESSFUL, 554 tests / 0 failures across 61 classes, SessionExportTest
9/0/0.
Lands the session-export feature: a finished OpenCode-harness stage writes its
real session into its own step artifacts directory as session.md and
session.html, served by the existing artifact listing and URL path, with
bounded source and rendered output, a visible truncation banner, recorded
session_export evidence and failure isolation that never fails the stage.
Every OpenCode-harness model stage now writes its real session into its own
step artifacts directory as session.md and session.html, so the existing
bounded artifact listing, the /artifacts/<run>/<step>/<name> serving path and
the artifact scan find and serve them with no special casing, while the stage
keeps its bounded preview in the run record unchanged.
- internal/opencode/export.go adds the one shared native export invocation and
the exact session-ID/messages validation used by both Connection.Messages and
the new ExportSession, so the readback path does not diverge. The backend's
published subcommand is used (v1 `export <id>`, v2 `session export <id>`),
the source read is capped at 8 MiB, and a larger session is read as a prefix
and reported truncated instead of failing. boundedOutput.ReadFrom keeps the
cap effective so overflow and the truncation path are real.
- internal/stage/session_export.go renders markdown and html with a metadata
header, every role and every part (unknown part types as raw JSON, every
session text escaped in html), atomic temp+rename writes that never overwrite
an existing file, a visible truncation banner at both ends when the source or
the 2 MiB rendered cap cuts it, and an honest 0-message header for an empty
session rather than fabricated text.
- protocol.SessionExport and RunStep.SessionExport are stored in a new
step_session_exports table (CREATE TABLE IF NOT EXISTS, so an old database
gains an empty table with no migration) loaded through the existing main
SELECT alongside the other per-step evidence and deleted by run retention.
- internal/server/runner.go exports after the post-stage filediff capture and
before scanArtifacts, with context.WithTimeout(context.WithoutCancel(ctx),
10s); it never waits for session idleness and a failure or a Pi stage (no
native export path) records a sanitized diagnostic and continues, never
changing the stage status, outcome, target, timing or result validation.
Reflected where it belongs: the packaged skill references
(internal/author/skill/references/operations.md and delivery.md) carry the new
Session export rules and the run-artifacts bullet, and docs/stage-artifacts.md
documents the names, the <run>/<step> paths, the served URL, the caps, the
truncation labels, failure isolation and the Pi limitation. The packaged
templates (examples/*.md) only tell a stage to save its own artifacts and say
nothing about the server-written session export, so none needed updating; no
new reference file was added, so install.go's managed inventory is unchanged.
Shared documentation: README.md's per-step artifacts sentence is now stale - it
should name the exported session alongside images, screenshots, reports and
logs. It is deliberately not committed here; the shared documents are folded by
the single documentation writer.
Checks: gofmt -l on the touched packages produced no output; go vet ./...
passed; go test -race -count=1 ./... passed.
Add docs/chat-verification.md, the required record for the chat verification brief: per-flow table (flow, result, evidence path, notes), the known tree-level gaps, and the section on what could not be verified and why. Verification only; no app behaviour changed.
Checked: packaged templates (internal/author/skill/references/) do not mention this record - no template or skill reference needed updating. Shared README and topic docs are intentionally not touched (single-writer fold).
Pure move of RunDetailScreen.kt (847 -> 342) and PipelinesApp.kt (1003 -> 405)
into files by concern with no behaviour change: five run tabs plus the header,
and the destination pill and destinations separate from the shell that hosts
them. Same package, same composable names and signatures, same call graph and
rendering; only private -> internal visibility widenings. Verified with
:app:assembleDebug and the unit suite (545 tests, 0 failures).
Brings main's retention store/CLI, review-contract and notification work
(internal/pipeline, internal/cli, internal/server, internal/author/skill/
references) together with this branch's pure move of the Android run view and
app shell into files by concern. No overlapping paths, so no conflict; the
merge was clean and the run/shell split is unchanged.
Pure move of two oversized Android UI files into smaller files by concern,
with no behaviour change:
- RunDetailScreen.kt 847 -> 342: the run header and ConfirmDialog stay; the
five run tabs move out to RunSummaryTab.kt, RunGraphTab.kt,
RunFieldSectionsTab.kt, RunEvidenceTab.kt and RunTimelineTab.kt.
- PipelinesApp.kt 1003 -> 405: the shell/scaffold, NavHost and hoisted state
stay; the destination pill and the three destinations move out to
DestinationBar.kt, PipelineDestination.kt, RunsDestination.kt and
TemplatesDestination.kt.
Same package, same composable names and signatures, same call graph and
rendering. The only textual edits are eleven private -> internal visibility
widenings on declarations now called across the new file boundaries. No
strings, colours, spacing tokens, tests or entry points changed.
Verified with `gradle :app:assembleDebug --no-daemon` (BUILD SUCCESSFUL) and
`gradle :app:testDebugUnitTest --no-daemon` (545 tests, 0 failures, 0 errors,
0 skipped).
Checked packaging that could go stale with this change:
- internal/author/skill/references/ (the packaged authoring skill references):
none mention these files or any Android UI symbol, so nothing to update.
- packaged templates: not touched and none reference the split files.
- android/README.md: its historical prose still names some now-stale file
locations; left unedited because the shared documentation is folded by a
single writer and this commit's job is the move itself.
Brings the definition-level review-loop control change and its server tests into
main: the reviewer advisory -> next stage edge for non-blocking notes, the
blocked_retryable -> implementer self-edge bounded by {"max_visits":5}, and the
unchanged rejected -> implementer limit. No production Go code changed; the new
internal/server/review_contract_test.go and the shared test seams cover it.
Keeps this branch's advisory review edge, bounded blocked_retryable implementer
edge and their tests alongside main's run-attention/ntfy notification work, the
split of the Android chat conversation screen, and the retention/history changes.
No conflicts: the two sides touch disjoint files.
Cut the review loop's repeat cost and make a blocked stage actionable, at the
definition level only, with the runner's existing visit counting and caps.
The published maintenance, quick and focused pipelines gain a reviewer
`advisory -> next stage` edge for non-blocking notes, so an advisory-only review
continues the run instead of buying another implementer visit; `rejected ->
implementer` and its unchanged {"max_visits":3,"on":["rejected"]} limit keep a
must-fix finding looping and still terminate. The implementer gains
blocked_retryable -> implementer with {"max_visits":5,"on":["blocked_retryable"]}
for a transient environment/tooling/device problem a fresh attempt could
survive, while blocked -> #failure stays terminal. The cap is at least the
reviewer's rejection budget so the implementer's own pre-execution cap cannot
preempt the reviewer's rejected control.
No production Go code changed. New tests in internal/server/review_contract_test.go
cover advisory-only never revisiting the implementer, must-fix still looping to
the reviewer limit, the implementer cap not preempting the reviewer, retryable
blocks bounded then failing closed, a retry that recovers, and a terminal block
failing immediately; concurrency/control/human tests share the new submitRunner
and startRun seams.
Documentation checked: internal/author/skill/references/control.md and
docs/harnesses-and-control.md carry the new edges and the visit-cap rule;
no packaged template defines these pipelines (they are published immutable
versions), and docs/model-results.md needs no change because the {outcome,output}
result contract is unchanged. README and other shared docs deliberately untouched.
Verified: go build ./... and go test -count=1 ./... pass.
Residual limitation: the must-fix-vs-advisory split is carried by the prompt
contract, not a machine-readable marker, because the recorded findings have none;
a model that still returns rejected for advisory-only notes would still buy a
visit. All 18 recorded implementer blocked runs classify terminal, so the
blocked_retryable edge recovers 0 of them.
Move ui/chat/ChatScreen.kt (1864 lines) into ten files by concern with no
behaviour change: ChatScreen.kt keeps the destination and the shared chat
geometry tokens (84 lines); ChatListPane, ChatCreatePane, ChatOpenStrip,
ChatConversationPane, ChatTranscript, ChatComposer, ChatToolCalls,
ChatDiffCard and ChatApprovalCard take the session list, new-chat picker,
open-conversation strip, conversation header, transcript, composer, tool
chips and the cards.
Pure move: same package, same composable names and signatures, same call
graph. The only substantive edits are per-file imports and private->internal
widenings needed for the cross-file calls; review confirmed identical
declaration sets and an equal line multiset. :app:assembleDebug and the full
unit suite pass (545 tests, 0 failures, 0 skipped) and the built APK is
byte-identical (same sha256) to the published artifact.
Checked before committing:
- Packaged templates: this repository carries no packaged template tree, so
nothing to update.
- Packaged authoring skill references (internal/author/skill/references/):
none reference the chat UI internals; nothing to update.
- android/README.md still cites ChatScreen.kt inner declarations
(ChatScreen.MessagePart, rememberElapsedMillis, ChatConversationPane) that
this move relocated; left unedited for the single documentation writer.
Lands lane-app2's pill-standdown work: the floating destinations pill is hidden
while the Chat destination shows an open conversation and stays everywhere else,
with the bottom reserve tracking the drawn pill so content neither jumps nor
leaves a gap. Includes the lane's merge of main and its tests.
Brings main (c5b0de1) into the pill-standdown lane. Main added the whole-title
run view / two-line list rows (RunIdentity, RunTitlesTest) and the readable
conversation work (ChatFormat, ChatScreen, ChatStore, ChatTranscriptTest). Those
are disjoint from this lane's destination-pill change, so the Kotlin sources
auto-merged; only android/README.md conflicted, where both sides appended a new
dated section to the end of the item log.
Resolved android/README.md by keeping both intents: the lane's "Destination pill
stands down in an open conversation" section and main's "Run title readability"
section are both retained, in that order. No conflict marker remains and nothing
from either side was discarded.
Verified after resolving: gradle :app:testDebugUnitTest --offline --no-daemon ->
BUILD SUCCESSFUL, 60 suites / 545 tests / 0 failures / 0 errors / 0 skipped; and
gradle :app:assembleDebug --offline --no-daemon -> BUILD SUCCESSFUL.
The floating destinations pill was drawn over the bottom of every screen,
including an open chat, where it sat on the composer and the newest message
and competed with the send/stop controls. It now stands down while the Chat
destination shows an open conversation and stays everywhere else, unchanged.
- One rule: `destinationPillVisible(currentRoute, conversationOpen)` is false
only for `chat` with an open conversation. `conversationOpen` is the new
`AppViewModel.conversationOpen`, a distinctUntilChanged boolean derived from
the same ChatStore the chat surface renders, so a background chat never hides
the pill elsewhere and a streamed delta never recomposes the app shell.
- The space, not just the pill: `destinationPillReserve(pillVisible)` returns
the named DESTINATION_PILL_RESERVE while drawn and 0.dp while hidden, so the
content Column clears a drawn pill and leaves no empty band when it is gone,
and no frame reserves a gap behind a hidden pill or draws one over content it
does not clear. Keyboard-open and the IME padding are unchanged.
- Escapability untouched: the top-bar "Back to chats" arrow, ChatScreen's
PredictiveBackHandler and SlidingPaneStack.onPopTo remain the way out.
- No other pill behaviour changed: destinations, selection indicator,
morph-into-search and every other screen are as before.
Checked for staleness: none of the packaged templates or the packaged authoring
skill references (internal/author/skill/references) mention the destination pill,
so no template or reference needed updating for this Android-only change.
Tests: PipelinesNavTest gains thePillStandsDownOnlyWhileAConversationIsOpen and
theReserveTracksTheDrawnPillSoContentNeitherJumpsNorLeavesAGap.
Fix two honesty gaps in run-history retention that the implementer stage
left uncommitted on top of 14175eb:
- Populate RemovedRuns, RemovedRunCount, RemovedArtifactFiles/Bytes and
Applied right after the row transaction commits, before staging cleanup.
A cleanup failure must not report a successful row/artifact removal as
zero removed, and staging leftovers are excluded from SpaceReclaimedBytes.
A failed VACUUM after removal now reports the artifact bytes actually
removed while claiming no database pages.
- Stage artifacts through os.Stat instead of os.Lstat so a symlinked
artifacts root is followed: the report sized that directory, so apply
removes through it too instead of counting bytes it never deleted.
Tests cover post-commit staging-cleanup failure reporting, staging through a
symlinked artifacts root (including no staging directory left in the link
target), and an honest reclaim failure after removal.
Checked documentation surfaces:
- docs/cli.md: measured example refreshed with the current before/apply/after
output and the symlink/staging/VACUUM reporting described accurately.
- README.md: retention prose (explicit, never automatic, protected runs,
artifacts go with the run) is unchanged and still correct.
- internal/author/skill/references/operations.md: operator-only retention
summary describes the same behaviour; no user-facing surface changed, so
no reference update was needed.
- Packaged templates: retention is a CLI/store capability with no template
change, so nothing to update. internal/author/install.go inventory
unchanged (no reference added or renamed).
Verification: gofmt clean on the touched Go files, git diff --check clean,
go vet ./internal/pipeline clean, and go test ./internal/pipeline -run
'TestRetention' -count=1 passing.
Nothing told the operator that a run was waiting for a person or had failed; they
found out by going looking. A run that needs attention now reaches the ntfy they
already run, and the app answers "what needs me now" in one live, ordered surface.
Server (smallest change, reusing the existing publisher):
- internal/server/notify.go adds notifyRun, called from finishRunState (failed)
and when a run parks on a human (runner.go runLoop). It publishes to the same
already-configured `system` destination through the unchanged stage.PublishNtfy,
so there is no second publisher, topic or service and the token handling is the
stage's own. runAttentionEvent maps only waiting and failed; queued, running,
succeeded, canceled and interrupted publish nothing.
- No storms: runner.attentionSent records sequence:event per run before publishing,
so a run that stays waiting is never republished on a re-request or restart, and
a stage notify policy that already covers the same event marks it first so the
run-level default is suppressed. The set is dropped when the run is terminal. A
delivery failure is logged, never fails the run, and is not retried.
- The payload names the run and pipeline and carries a click action
pipelines://run/<id> (validated: absolute URL, no userinfo, no fragment, no
credentials). PublishNtfy gained the optional click parameter; existing callers
pass "".
App:
- AndroidManifest/MainActivity declare the pipelines://run/<id> deep link
(singleTop); runIdFromDeepLink parses it and PipelinesApp opens that run once,
clearing the link. It opens a run; it starts nothing.
- ui/Attention.kt is the pure model (status -> Decision/Failed/Finished or
nothing, ordered by kind then newest-first) and ui/components/AttentionSurface.kt
is the floating indicator plus bottom sheet. It is derived from the same run
events the server already pushes, so an entry appears with no refresh and clears
when resolved; a finished run clears once looked at, and any entry can be
dismissed, persisted in SettingsRepository. The existing destinations, pill and
bottom strip are untouched and no competing navigation surface is added.
Checked before committing:
- Packaged authoring skill references: internal/author/skill/references/
notifications.md documents the automatic run-attention notifications and the
app surface. The only packaged "template" carrying notify is that reference; no
pipeline definition template exists to update and install.go's managed file list
is unchanged (notifications.md already existed).
- Repository guidelines: docs/ntfy.md gains an "Automatic run-attention
notifications" section and no longer claims "No block means no notifications";
the top-level README phone-notifications note now says a waiting/failed run
notifies automatically; android/README.md gains the dated feature section and
supersedes the previous section's note that the attention surface was absent.
- docker.md, install docs and the CLI/TUI docs describe mechanisms this change
does not alter; left as they are.
Tests: go test ./internal/server/... ./internal/stage/... ./internal/author/...
all ok; notify_test.go covers the event mapping and the real HTTP delivery
(destination, topic, click, no duplicate). Android :app:testDebugUnitTest ->
BUILD SUCCESSFUL, 58 suites / 531 tests / 0 failures (new AttentionTest, 13 cases,
covering ordering, appearing from a push, clearing on resolution, dismissal, the
empty case, persistence and the deep link). Device screenshots and the phone's own
notification are visual review's per the brief's device policy.
Scope: android/ plus the smallest server change; no new dependency, no run started
from the app, no installer or Docker change.