perf(chat): reuse unchanged markdown render trees

This commit is contained in:
2026-10-24 11:12:47 +01:00
parent 2bcb4a4071
commit da44001ab2
2 changed files with 144 additions and 2 deletions
@@ -32,6 +32,24 @@ Widget chatMarkdownText(
class _ChatMarkdownViewState extends State<ChatMarkdownView> {
final Map<String, TapGestureRecognizer> _links = {};
Widget? _rendered;
@override
void didUpdateWidget(ChatMarkdownView oldWidget) {
super.didUpdateWidget(oldWidget);
if (widget.text != oldWidget.text ||
(widget.onOpenLink == null) != (oldWidget.onOpenLink == null)) {
_rendered = null;
}
}
@override
void didChangeDependencies() {
super.didChangeDependencies();
// Cached spans use host theme/localization roles. Never freeze those when
// brightness, typography, locale or surrounding text styles change.
_rendered = null;
}
@override
void dispose() {
@@ -43,9 +61,12 @@ class _ChatMarkdownViewState extends State<ChatMarkdownView> {
@override
Widget build(BuildContext context) {
// A new token or usage update elsewhere in the turn must not reparse and
// rebuild every earlier answer part, or disturb its text selection.
if (_rendered != null) return _rendered!;
final cupertino =
chatControlsStyleOf(context) == ChatControlsStyle.cupertino;
return _selectable(
return _rendered = _selectable(
context,
Column(
mainAxisSize: MainAxisSize.min,
@@ -279,7 +300,7 @@ class _ChatMarkdownViewState extends State<ChatMarkdownView> {
return TextSpan(children: children);
}
final recognizer = _links.putIfAbsent(url, TapGestureRecognizer.new);
recognizer.onTap = () => onOpenLink(url);
recognizer.onTap = () => widget.onOpenLink?.call(url);
return _withRecognizer(
TextSpan(
style: const TextStyle(decoration: TextDecoration.underline),
@@ -0,0 +1,121 @@
import 'package:flutter/material.dart';
import 'package:flutter/gestures.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/features/chat/ui/transcript/chat_markdown_view.dart';
void main() {
testWidgets(
'unchanged markdown retains its rendered subtree across parent updates',
(tester) async {
final updates = ValueNotifier<int>(0);
addTearDown(updates.dispose);
await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: ValueListenableBuilder<int>(
valueListenable: updates,
builder: (_, value, _) => ChatMarkdownView(
text:
'# Kept heading\n\nKept **answer**\n\n```dart\nfinal x = 1;\n```',
),
),
),
),
);
final view = find.byType(ChatMarkdownView);
final column = find
.descendant(of: view, matching: find.byType(Column))
.first;
final rendered = tester.widget(column);
final selection = tester.element(find.byType(SelectionArea));
updates.value++;
await tester.pump();
expect(tester.widget(column), same(rendered));
expect(tester.element(find.byType(SelectionArea)), same(selection));
},
);
testWidgets('text and inherited theme changes invalidate cached rendering', (
tester,
) async {
final text = ValueNotifier<String>('# First');
final dark = ValueNotifier<bool>(false);
addTearDown(text.dispose);
addTearDown(dark.dispose);
await tester.pumpWidget(
ValueListenableBuilder<bool>(
valueListenable: dark,
builder: (_, value, _) => MaterialApp(
theme: ThemeData(
brightness: value ? Brightness.dark : Brightness.light,
),
home: Scaffold(
body: ValueListenableBuilder<String>(
valueListenable: text,
builder: (_, value, _) => ChatMarkdownView(text: value),
),
),
),
),
);
final column = find
.descendant(
of: find.byType(ChatMarkdownView),
matching: find.byType(Column),
)
.first;
final before = tester.widget(column);
text.value = '# Second';
await tester.pump();
expect(find.text('Second'), findsOneWidget);
expect(find.text('First'), findsNothing);
expect(tester.widget(column), isNot(same(before)));
final changed = tester.widget(column);
dark.value = true;
await tester.pumpAndSettle();
expect(tester.widget(column), isNot(same(changed)));
});
testWidgets(
'an unchanged link invokes the latest callback and becomes inert when disabled',
(tester) async {
final version = ValueNotifier<int>(0);
addTearDown(version.dispose);
final opened = <int>[];
await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: ValueListenableBuilder<int>(
valueListenable: version,
builder: (_, value, _) => ChatMarkdownView(
text: '[Link](https://example.test)',
onOpenLink: value == 2 ? null : (_) => opened.add(value),
),
),
),
),
);
GestureRecognizer? recognizer(InlineSpan span) {
if (span is! TextSpan) return null;
if (span.recognizer != null) return span.recognizer;
for (final child in span.children ?? const <InlineSpan>[]) {
final found = recognizer(child);
if (found != null) return found;
}
return null;
}
TapGestureRecognizer? link() =>
recognizer(tester.widget<Text>(find.text('Link')).textSpan!)
as TapGestureRecognizer?;
link()!.onTap!();
version.value = 1;
await tester.pump();
link()!.onTap!();
expect(opened, [0, 1]);
version.value = 2;
await tester.pump();
expect(link(), isNull);
},
);
}