Add a "reflect the change where it belongs" rule for committers
The packaged authoring skill's orchestration reference now tells an author to carry the check from the brief into the pipeline: before committing, the committer verifies the change is reflected in the packaged templates, the repository's guidelines (README and topic docs) and the packaged skill references, updates anything stale, and states in the commit body what was checked or that nothing needed updating. - brief-writing section: add a "Where it belongs" item to the brief and renumber the hard-constraints and publishing items. - hard-constraints block: add a "Reflect the change where it belongs" bullet. - Pipeline choice: extend the committer bullet with the same pre-commit check, keeping the existing rule that the committer stages only the run's changed files. Checked before committing: the change is prose in the packaged skill reference, so no template, README or topic-doc edit was needed; the eight pipelines carrying a committer stage were republished with the same rule in their committer prompt (not tracked in this repository); no other reference is stale.
This commit is contained in:
@@ -55,8 +55,11 @@ Every brief has:
|
||||
output it must report, plus the screenshots the reviewer must read. Say plainly:
|
||||
"report the exact commands and their observed results. Do not claim a check you
|
||||
did not run."
|
||||
5. **The hard constraints block** (below).
|
||||
6. **Publishing rules** (`references/delivery.md`).
|
||||
5. **Where it belongs** — the packaged templates, the repository's guidelines (README
|
||||
and topic docs) and the packaged skill references the change is expected to touch,
|
||||
so the committer can check and update them before it commits.
|
||||
6. **The hard constraints block** (below).
|
||||
7. **Publishing rules** (`references/delivery.md`).
|
||||
|
||||
Template:
|
||||
|
||||
@@ -103,6 +106,10 @@ Adapt the scope and publishing lines per item; keep the rest.
|
||||
- **Keep values from single sources** — geometry, tokens, sizes and constants come
|
||||
from the source that already owns them, not from new literals.
|
||||
- **Commit locally only, never push** — the committer stage commits, no other stage.
|
||||
- **Reflect the change where it belongs** — before committing, the committer checks
|
||||
that the change is reflected in the packaged templates, the repository's guidelines
|
||||
(README and topic docs) and the packaged skill references, updates anything stale,
|
||||
and states in the commit body what it checked or that nothing needed updating.
|
||||
- **Publish rules** — WIP artefact naming and LAN URLs per `references/delivery.md`.
|
||||
|
||||
## Pipeline choice
|
||||
@@ -116,7 +123,10 @@ Adapt the scope and publishing lines per item; keep the rest.
|
||||
`skipped` with a reason when the change has no rendered surface. Never accept a UI
|
||||
change approved without the images.
|
||||
- The committer is the only stage that commits, and it stages only the run's changed
|
||||
files.
|
||||
files. Before committing it checks that the change is reflected in the packaged
|
||||
templates, the repository's guidelines (README and topic docs) and the packaged
|
||||
skill references, updates anything stale, and states in the commit body what it
|
||||
checked or that nothing needed updating.
|
||||
- Choose per item: a logic, server or format change usually wants the planner
|
||||
(a plan/implement/review pipeline); a small, fully understood tweak may use the
|
||||
leaner implementer-first variant. Both keep all review stages.
|
||||
|
||||
Reference in New Issue
Block a user