feat(app): finish measured native graph canvas and clear labels from wires
This commit is contained in:
@@ -0,0 +1,39 @@
|
||||
# Measured native definition graph canvas
|
||||
|
||||
Retained run71 hit its Code deadline while collecting browser evidence. Manager
|
||||
completed the existing work directly; no replacement workflow or lost edits.
|
||||
|
||||
DefinitionGraphView composes the landed native node, layout, route and passive
|
||||
edge components. Nodes/labels are measured from their rendered native widgets,
|
||||
then placed in a stock InteractiveViewer. Selection reports the exact stage or
|
||||
terminal key; no run status, visit or session is invented. Unknown targets produce
|
||||
bounded scrollable diagnostics. No node height/width is assumed.
|
||||
|
||||
## Corrections from actual checks
|
||||
|
||||
- Removed the fixed220px node bound: wrapping follows the caller's viewport.
|
||||
- Rank gaps follow measured outcome labels, not an assumed2x text width.
|
||||
- Split offstage native measurement into its own cohesive widget; source files
|
||||
remain below250lines rather than making an oversized renderer.
|
||||
- Two original selection tests tapped offscreen terminals. They now pan the real
|
||||
InteractiveViewer first; a new resize test checks viewport-dependent remeasure.
|
||||
- Browser inspection found the retry label crossed its own loop wire. Added
|
||||
three failing pure regressions, then fixed label candidate collision checks to
|
||||
include ALL route segments. No masking background or routing rewrite.
|
||||
- Browser fixture now pans to reveal offscreen nodes, instead of assuming the
|
||||
whole content-sized graph fits one screen. Selected terminal identity and real
|
||||
pan movement are asserted. Explicit owned Chrome pipe/server cleanup prevents
|
||||
successful probes leaving the Node process waiting on fixture resources.
|
||||
|
||||
## Verification
|
||||
|
||||
Graph tests (composition + existing geometry) pass; analyzer clean. Fresh real
|
||||
Chrome cases cover Material light1x/2x, Cupertino light1x/dark2x, five captures
|
||||
each (desktop/phone/selection/terminal/pan), under approved temp/
|
||||
graph-canvas-manager-browser. Each case's probe assertions passed; the cleanup
|
||||
fix was checked with clean process exit. Material2x label/wire view inspected.
|
||||
Fixtures bind loopback and touch no production server, session or device.
|
||||
|
||||
This is a definition-only component, NOT run-graph parity. Pipeline hook, authored
|
||||
stage pane, run evidence/recorded-visit integration and keyboard/fit toolbar are
|
||||
still separate acceptance work. Mobile remains unverified.
|
||||
Reference in New Issue
Block a user