Scroll details dialogs whose content is taller than the app

Chat details was cut off at 1280x800 (found by run 305's UI review).
This commit is contained in:
2026-11-10 22:21:14 +00:00
parent 75a61dbd8c
commit ba1cbccdf2
2 changed files with 49 additions and 2 deletions
+4 -2
View File
@@ -57,7 +57,8 @@ Future<T?> showAppChoiceMenu<T>(
/// Shows richer content (a chat's details, a file's details) built by
/// [builder]: a dialog on a wide app, a bottom sheet on a phone, on the root
/// navigator either way.
/// navigator either way. The content sizes itself (a `Column` with
/// `MainAxisSize.min`); the dialog scrolls it when it is taller than the app.
Future<T?> showAppDetails<T>(
BuildContext context, {
required WidgetBuilder builder,
@@ -83,7 +84,8 @@ Future<T?> showAppDetails<T>(
maxWidth: maxWidth,
maxHeight: MediaQuery.sizeOf(dialog).height * 0.85,
),
child: Padding(
// Content taller than the app scrolls inside the dialog.
child: SingleChildScrollView(
padding: const EdgeInsets.only(top: 16),
child: builder(dialog),
),
+45
View File
@@ -113,6 +113,51 @@ void main() {
expect(find.text('Details body'), findsOneWidget);
});
testWidgets('wide: details taller than the app scroll inside the dialog', (
tester,
) async {
_size(tester, const Size(1280, 600));
await tester.pumpWidget(
MaterialApp(
home: Builder(
builder: (context) => TextButton(
onPressed: () => showAppDetails<void>(
context,
builder: (_) => Column(
mainAxisSize: MainAxisSize.min,
children: [
for (var i = 0; i < 30; i++)
SizedBox(height: 48, child: Text('Row $i')),
],
),
),
child: const Text('Open'),
),
),
),
);
await tester.tap(find.text('Open'));
await tester.pumpAndSettle();
expect(tester.takeException(), isNull);
final dialog = tester.getRect(
find
.descendant(of: find.byType(Dialog), matching: find.byType(Material))
.first,
);
expect(dialog.height, lessThanOrEqualTo(600 * 0.85));
await tester.scrollUntilVisible(
find.text('Row 29'),
200,
scrollable: find
.descendant(
of: find.byType(Dialog),
matching: find.byType(Scrollable),
)
.first,
);
expect(find.text('Row 29').hitTestable(), findsOneWidget);
});
testWidgets('phone: both are bottom sheets', (tester) async {
_size(tester, const Size(430, 900));
final picked = <String>[];