fix(web): color custom terminal failure outcomes accurately
This commit is contained in:
@@ -32,7 +32,10 @@ export function miniatureModel(graph, run = null) {
|
||||
// A recorded current stage is evidence even in a compact list summary.
|
||||
const current = run?.executing && run.current_stage === node.key;
|
||||
const status = step?.status ?? (current ? run.status : null);
|
||||
const color = status === "completed" ? edgeStrokeColor(step.outcome) : status ? miniatureColor(status) : null;
|
||||
// Custom outcome names do not override a recorded terminal verdict.
|
||||
const color = step?.target === "#failure" ? "var(--bad)"
|
||||
: step?.target === "#success" ? "var(--ok)"
|
||||
: status === "completed" ? edgeStrokeColor(step.outcome) : status ? miniatureColor(status) : null;
|
||||
return { ...node, color,
|
||||
untaken: Boolean(run) && !step && !current };
|
||||
}),
|
||||
|
||||
@@ -3,6 +3,16 @@ import assert from "node:assert/strict";
|
||||
import { foldRunEvent } from "../src/runEvents.js";
|
||||
import { miniatureModel } from "../src/miniGraph.js";
|
||||
|
||||
test("custom outcome names use the recorded success/failure terminal", () => {
|
||||
const graph={stages:[{key:"research",edges:{success:"fix"}},{key:"fix",edges:{blocked:"#failure"}},{key:"never",edges:{}}]};
|
||||
const model=miniatureModel(graph,{graph_evidence:{complete:true,visits:[
|
||||
{sequence:1,stage:"research",status:"completed",outcome:"success",target:"fix"},
|
||||
{sequence:2,stage:"fix",status:"completed",outcome:"blocked",target:"#failure"},
|
||||
]}});
|
||||
assert.deepEqual(model.nodes.map(node=>node.color),["var(--ok)","var(--bad)",null]);
|
||||
assert.equal(model.nodes[2].untaken,true);
|
||||
});
|
||||
|
||||
test("coalesced live visits update list nodes and routes without a detail fetch", () => {
|
||||
const identity = { run_id: 1, pipeline_id: 7, name: "Run", version: 2 };
|
||||
let runs = foldRunEvent([], { ...identity, status: "running", graph_evidence: { complete: true, visits: [] } }).runs;
|
||||
|
||||
Reference in New Issue
Block a user