fix(app): collapse the summary sections and correct the visit index for search hits
This commit is contained in:
@@ -268,9 +268,12 @@ class _PipelinesAppState extends State<PipelinesApp>
|
||||
case SearchRunTarget(:final runId):
|
||||
route = AppRoute.run(runId);
|
||||
case SearchStepTarget(:final runId, :final stage, :final visit):
|
||||
// The server records a 1-based visit number; the route's `visit` is the
|
||||
// zero-based index into the recorded timeline.
|
||||
final index = visit == null || visit < 1 ? null : visit - 1;
|
||||
route = stage == null
|
||||
? AppRoute.run(runId)
|
||||
: AppRoute.run.stage(runId, stage, visit: visit);
|
||||
: AppRoute.run.stage(runId, stage, visit: index);
|
||||
case SearchFieldTarget(:final runId, :final sequence, :final field):
|
||||
selection = RunSearchSelection(
|
||||
runId: runId,
|
||||
|
||||
@@ -209,7 +209,10 @@ class _RunDetailTabsState extends State<RunDetailTabs> {
|
||||
case RunSummarySection.output:
|
||||
_outputSection.expand();
|
||||
case null:
|
||||
break;
|
||||
// A hit that names no section must not leave a previously expanded
|
||||
// one open; the Summary panel starts collapsed.
|
||||
_inputSection.collapse();
|
||||
_outputSection.collapse();
|
||||
}
|
||||
case RunVisitTarget(:final stageKey, :final timelineIndex):
|
||||
if (detailVisitStepAt(widget.run, timelineIndex) == null) return;
|
||||
|
||||
Reference in New Issue
Block a user