Order local storage operations across replacement owners
This commit is contained in:
@@ -0,0 +1,17 @@
|
||||
/// Reads and writes for one persisted key share an order across widget owners.
|
||||
/// This lets a replacement owner read after an old owner's in-flight write.
|
||||
/// Completed keys are removed, and one failed operation never blocks the next.
|
||||
final _pending = <Object, Future<void>>{};
|
||||
|
||||
Future<T> orderedLocalStorage<T>(Object key, Future<T> Function() operation) {
|
||||
final previous = _pending[key] ?? Future<void>.value();
|
||||
final result = previous.then((_) => operation());
|
||||
late final Future<void> completion;
|
||||
completion = result
|
||||
.then<void>((_) {}, onError: (Object _, StackTrace _) {})
|
||||
.whenComplete(() {
|
||||
if (identical(_pending[key], completion)) _pending.remove(key);
|
||||
});
|
||||
_pending[key] = completion;
|
||||
return result;
|
||||
}
|
||||
@@ -0,0 +1,46 @@
|
||||
import 'dart:async';
|
||||
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
import 'package:pipelines_app/core/storage/ordered_local_storage.dart';
|
||||
|
||||
void main() {
|
||||
test(
|
||||
'a later read waits for the in-flight write with the same key',
|
||||
() async {
|
||||
final gate = Completer<void>();
|
||||
final key = Object();
|
||||
var stored = 'old';
|
||||
final write = orderedLocalStorage(key, () async {
|
||||
await gate.future;
|
||||
stored = 'new';
|
||||
});
|
||||
var read = false;
|
||||
final reading = orderedLocalStorage(key, () async {
|
||||
read = true;
|
||||
return stored;
|
||||
});
|
||||
await Future<void>.delayed(Duration.zero);
|
||||
expect(read, isFalse);
|
||||
gate.complete();
|
||||
await write;
|
||||
expect(await reading, 'new');
|
||||
},
|
||||
);
|
||||
test(
|
||||
'different keys remain independent, and a failure does not poison a key',
|
||||
() async {
|
||||
final blockedKey = Object();
|
||||
final gate = Completer<void>();
|
||||
final blocked = orderedLocalStorage(blockedKey, () => gate.future);
|
||||
expect(await orderedLocalStorage(Object(), () async => 'free'), 'free');
|
||||
final key = Object();
|
||||
await expectLater(
|
||||
orderedLocalStorage(key, () async => throw StateError('failed')),
|
||||
throwsStateError,
|
||||
);
|
||||
expect(await orderedLocalStorage(key, () async => 7), 7);
|
||||
gate.complete();
|
||||
await blocked;
|
||||
},
|
||||
);
|
||||
}
|
||||
Reference in New Issue
Block a user