iPad layout review notes and native fixture host
Run the full-app fixture entry on an iOS simulator: options from a file in the app's tmp dir or the environment, route via a route provider, a narrow strip for Split View widths, and a small in-app tap/type driver.
@@ -0,0 +1,213 @@
|
||||
# iPad layout review (iOS simulator)
|
||||
|
||||
Review only. No app source under `lib/` (or `ios/`) is changed by this note's
|
||||
commit. Screenshots are in `notes/ipad-layout-review/` (downscaled JPEGs of the
|
||||
simulator captures; the crops are full resolution).
|
||||
|
||||
## Setup
|
||||
|
||||
- Simulators (iOS 26.4 runtime): iPad Air 13-inch (M4)
|
||||
`6D1598AE-46C0-4B2B-90FB-882BB48DE3FB` (1024x1366 pt) and iPad Pro 11-inch
|
||||
(M5) `A670C822-A32A-40DD-AF6C-EF1F162A81B4` (834x1194 pt). Debug build
|
||||
installed with `flutter run -t tool/search_selection_probe_entry.dart -d <sim>
|
||||
--debug --no-resident`. No live server, data dir or physical device was used.
|
||||
- Data: the full-app fixture entry. It previously compiled for the web only
|
||||
(`package:web`, `dart:js_interop` probes, URL query). This commit adds
|
||||
`tool/fixture_host/` (tool-only) so the same entry runs natively:
|
||||
- the options are read from `fixture_query.txt` in the app's tmp dir
|
||||
(`xcrun simctl get_app_container <sim> net.awan.pipelines.next data`/tmp),
|
||||
or the launch environment / `--dart-define=FIXTURE_QUERY` (the
|
||||
`SIMCTL_CHILD_` environment did not reach the app on this runtime);
|
||||
- `route=` goes through a `PlatformRouteInformationProvider`;
|
||||
- `server=ws://127.0.0.1:PORT/connect` points artifact fetches at a loopback
|
||||
file server (here `python3 -m http.server 0 --bind 127.0.0.1` serving
|
||||
`artifacts/7/2/release-report.txt`); the socket stays in-process;
|
||||
- `connect=1` runs the real launch flow with no saved server (Connect screen);
|
||||
- `width=N` lays the app out in an N-pt strip at the window's left edge
|
||||
(approximates Split View / narrow windows; system insets stay the
|
||||
full window's);
|
||||
- `do=` is a small in-app driver (`tap:<label>`, `tapxy:x,y`,
|
||||
`drag:x,y,dx,dy`, `type:<text>`, `labels`, `wait:ms`), because `simctl`
|
||||
cannot tap. Labels with `·` or other non-ASCII must use `tapxy`.
|
||||
The browser build and `tool/capture/` work as before (rebuilt and used for
|
||||
the web comparison shots).
|
||||
- Fixture options used for chat: `chats=8&colors=1&msgs=60,20&rich=1&links=1&tasks=4`.
|
||||
|
||||
### What could not be driven
|
||||
|
||||
- **Rotation.** `simctl` has no rotate command, Simulator.app GUI scripting
|
||||
timed out (no accessibility permission), and `SystemChrome
|
||||
.setPreferredOrientations` is ignored for an iPad app that supports
|
||||
multitasking. A temporary, uncommitted `UIRequiresFullScreen` build (reverted
|
||||
right after; `git diff ios/` is clean) did not rotate either: iPadOS 26 put
|
||||
the app into a 1024x~765 window instead (`air-l-test.jpg`). Landscape is
|
||||
therefore covered by the web build at 1366x1024 and 1210x834 (same Material
|
||||
code, no safe-area insets) and is **unverified on iOS**. Orientation-change
|
||||
glitches were not tested.
|
||||
- **Split View / Stage Manager sizes.** Not drivable; approximated with
|
||||
`width=375/507/600/683` on the Air (portrait height). Breakpoints from
|
||||
`lib/shell/list_detail_policy.dart`: list beside detail from 600 pt wide
|
||||
(`kListDetailMinWidth`), list pane 240–440 pt (`kListPaneMinWidth`,
|
||||
`kListPaneMaxWidth`), detail at least 320 pt. iPadOS 26 windowing did
|
||||
produce one real windowed launch on its own (`air-win-chat0.jpg`).
|
||||
- Keyboard: the simulator ran headless, so the software keyboard showed for
|
||||
every focused field.
|
||||
|
||||
## Findings (most severe first)
|
||||
|
||||
### 1. High: iPadOS 26 window controls cover the list pane's title pill
|
||||
- Screen: Chat list (any destination's top-left title pill), Air 13, windowed
|
||||
(iPadOS 26 windowed apps, ~1024x765 window).
|
||||
- Wrong: the system window controls (red/yellow/green) sit on top of the
|
||||
"Chat" title pill, hiding the title and the top of the pill, and they take
|
||||
the touches meant for it. The app pads the top bar only by the safe area,
|
||||
which does not include the window-controls region.
|
||||
- Expected: the leading top-bar content clears the window controls (UIKit's
|
||||
window-control layout margin), as native iPadOS 26 apps do, e.g. by
|
||||
shifting the title pill right or down when the controls are present.
|
||||
- Screenshots: `air-win-chat0.jpg`, `air-win-chat0-crop.jpg`; the same window
|
||||
on Runs with the pill just clearing the controls: `air-l-test-crop.jpg`.
|
||||
- Likely source: `lib/shell/adaptive_shell.dart` (`_ListPaneBar`, the top
|
||||
padding passed to the bar), `lib/ui/adaptive/segmented_bar.dart`. Flutter
|
||||
does not expose the window-controls margin, so this likely needs a small
|
||||
platform inset (iOS embedder/plugin) feeding the bar's leading padding.
|
||||
|
||||
### 2. High: narrow list pane collapses the top bar (blank title, cramped and clipped icons)
|
||||
- Screen: Runs and Pipelines list panes beside a detail. Air 13 portrait after
|
||||
dragging the divider to its minimum (full screen), and Air at `width=600`
|
||||
(both give the 240 pt list pane); `width=683` (≈ half of a 13" landscape
|
||||
screen); Pro 11 portrait at the default list width.
|
||||
- Wrong: the title pill keeps its glass but its text disappears entirely at
|
||||
240 pt ("Runs" becomes an empty pill), ellipsises to "R..." at ~270 pt and
|
||||
to "Pipe..." on the Pro 11 default. The five action icons squeeze to about
|
||||
30 pt pitch (below the 44 pt minimum target) and the last one ("Select") is
|
||||
clipped by the pill's rounded end.
|
||||
- Expected: the title stays readable (it is the destination name) and actions
|
||||
keep 44 pt targets; overflowing actions should move into an overflow menu
|
||||
rather than squeeze, or the pane's minimum should be wide enough for the
|
||||
bar's content.
|
||||
- Screenshots: `air-p-divider-narrow.jpg`, `air-w600-runs.jpg`,
|
||||
`air-w600-runs-bar.jpg`, `air-w683-runs-bar.jpg`, `pro-p-pipelines.jpg`.
|
||||
- Likely source: `lib/ui/adaptive/segmented_bar.dart` (`_actionIslands` lets
|
||||
icons "squeeze together", `minTitleShare`), `lib/shell/list_detail_policy.dart`
|
||||
(`kListPaneMinWidth` = 240).
|
||||
|
||||
### 3. Medium: list rows lose status, date and actions in narrow panes
|
||||
- Screen: Runs list and Chat list beside a detail at `width=600`/`683`
|
||||
(240–270 pt list pane).
|
||||
- Wrong: run rows drop the status icon, the date and the "More actions"
|
||||
button; chat rows drop the harness avatar and the time; subtitles truncate
|
||||
to "claude-opus · /workspa...". A failed run is no longer distinguishable
|
||||
from a succeeded one in the list.
|
||||
- Expected: status (at least the coloured icon) survives any list width;
|
||||
hidden row actions need another route (swipe/long-press) that is visible.
|
||||
- Screenshots: `air-w600-runs.jpg`, `air-w683-run7.jpg`, `air-w600-chat0.jpg`,
|
||||
`air-w683-chat0.jpg`.
|
||||
- Likely source: `lib/ui/layout/app_list_row.dart` (the shared row the run
|
||||
and chat lists use; see `notes/app-list-row.md`).
|
||||
|
||||
### 4. Medium: Settings shows the tab buttons where a list pane would be
|
||||
- Screen: Settings, Air 13 portrait, light and dark.
|
||||
- Wrong: Settings is a single full-width page, but the floating tab buttons
|
||||
stay centred under an absent 330 pt list column, i.e. over the left part of
|
||||
the settings cards, with "Pipelines" highlighted. At the default scroll
|
||||
position they cover the notification footnote text. The settings column is
|
||||
capped at ~590 pt and left-aligned, leaving the right ~40% of a 13" screen
|
||||
empty, which reads as unfinished next to the centred Connect screen.
|
||||
(The page's end padding is correct: the last card scrolls clear.)
|
||||
- Expected: on a page without a list pane, centre the tab buttons in the
|
||||
window (or under the content column) and centre or widen the content column
|
||||
on wide windows.
|
||||
- Screenshots: `air-p-settings.jpg`, `air-p-dark-settings.jpg`,
|
||||
`air-p-settings-end.jpg`; web at 1210x834 has the same placement:
|
||||
`web-1210x834-settings.jpg`.
|
||||
- Likely source: `lib/shell/adaptive_shell.dart` (the bar's
|
||||
`split = _bar.split(_selected) || showsListBesideDetail(context)` keeps it
|
||||
under the list column "so it never jumps sides"),
|
||||
`lib/features/settings/settings_layout.dart`.
|
||||
|
||||
### 5. Low: bottom controls in the detail pane are not consistent
|
||||
- Screen: run/stage detail vs artifact viewer vs diff viewer, Air 13 portrait.
|
||||
- Wrong: detail tab buttons are round floating buttons at the trailing edge;
|
||||
the artifact viewer's actions (download/share/open/link) are a glass pill at
|
||||
the leading edge; the diff viewer's "1 of 3" pager is a full-width glass bar.
|
||||
Three placements for the same bottom-chrome role in one pane.
|
||||
- Expected: one placement rule for detail bottom chrome (trailing, matching
|
||||
the tab buttons), or a deliberate, documented difference.
|
||||
- Screenshots: `air-p-stage-artifacts.jpg`, `air-p-artifact-viewer.jpg`,
|
||||
`air-p-diff.jpg`.
|
||||
- Likely source: `lib/features/artifacts/ui/` (viewer actions),
|
||||
`lib/features/changes/widgets/` (diff viewer pager),
|
||||
`lib/ui/adaptive/glass_bar.dart`.
|
||||
|
||||
### 6. Low: sheets end close to the bottom edge and rounded corner
|
||||
- Screen: chat background-task sheet, Air 13 portrait.
|
||||
- Wrong: the last row ("Agent "Review part 3" finished … Finished") sits about
|
||||
30 pt above the bottom edge, with the trailing status next to the display's
|
||||
rounded corner and the window resize grip.
|
||||
- Expected: sheet content padded by the bottom safe area plus the sheet's own
|
||||
padding. The chat information sheet is otherwise sized well: confined to
|
||||
the detail pane, not overly wide (`air-p-chat-info.jpg`).
|
||||
- Screenshots: `air-p-task-group.jpg`, `air-p-task-group-crop.jpg`.
|
||||
- Likely source: `lib/features/chat/ui/transcript/chat_task_notices_group.dart`.
|
||||
|
||||
### 7. Low: Material control heights below 44 pt
|
||||
- Screen: Connect, Settings (Air 13 portrait).
|
||||
- Wrong: filled and outlined buttons ("Continue", "Find servers on this
|
||||
network", "Disconnect", "Sign in") are about 40 pt tall, under the iOS 44 pt
|
||||
minimum. This follows from using Material defaults on iOS.
|
||||
- Expected: either accept it as the Material choice or raise the tap-target
|
||||
size for touch (`materialTapTargetSize`/minimum size in the iOS theme).
|
||||
- Screenshots: `air-p-connect.jpg`, `air-p-settings.jpg`.
|
||||
- Likely source: `lib/ui/theme/app_theme.dart`.
|
||||
|
||||
### 8. Low: transcript text shows beside the floating chat title
|
||||
- Screen: open chat, Pro 11 and Air 13 portrait.
|
||||
- Wrong: scrolled message text runs right up to and between the title pill
|
||||
and the model pill (on the Pro 11, a link fragment shows between them). It
|
||||
is legible but noisy. The colour wash only tints the top band.
|
||||
- Expected: a slightly stronger top fade behind the pills, as on the list
|
||||
pane's bar.
|
||||
- Screenshots: `pro-p-chat0.jpg`, `air-p-chat0.jpg`, `air-p-dark-chat0.jpg`.
|
||||
- Likely source: `lib/ui/adaptive/top_glass_strip.dart`,
|
||||
`lib/ui/adaptive/glass_pill.dart`.
|
||||
|
||||
### 9. Low: tab buttons and composer are not on one baseline
|
||||
- Screen: open chat, Air 13 portrait.
|
||||
- Wrong: the list pane's tab buttons and the detail pane's composer sit side
|
||||
by side but their bottoms differ by a few points (the tabs are taller and
|
||||
sit lower).
|
||||
- Expected: a shared bottom inset for both panes' floating chrome.
|
||||
- Screenshot: `air-p-chat0.jpg`.
|
||||
- Likely source: `lib/shell/list_detail.dart`,
|
||||
`lib/ui/adaptive/floating_bar_layout.dart`.
|
||||
|
||||
## Checked and fine
|
||||
|
||||
- Status bar, home indicator and rounded display corners: the top bars clear
|
||||
the status bar and the floating tab buttons and composer clear the bottom
|
||||
inset in full screen on both iPads (`air-p-run7.jpg`, `pro-p-stage-build.jpg`).
|
||||
- Tab-button placement: under the list pane when list and detail are shown;
|
||||
under the run detail's own tabs on the trailing side; at compact widths
|
||||
(375 pt) the detail's own tabs replace the shell tabs (`air-w375-run7.jpg`,
|
||||
`air-w375-chat0.jpg`).
|
||||
- Keyboard and composer: the composer moves above the software keyboard and
|
||||
grows to seven lines without covering the transcript or the send button
|
||||
(`air-p-composer-multiline.jpg`). Search keeps results above the keyboard
|
||||
(`air-p-search.jpg`).
|
||||
- Divider drag works and persists; the tab buttons recentre in the new list
|
||||
width (`air-p-divider-narrow.jpg`, but see finding 2).
|
||||
- Chat information sheet: sized to the detail pane (`air-p-chat-info.jpg`).
|
||||
- Dark mode: glass pills, colour-washed rows and status chips stay legible
|
||||
(`air-p-dark-run7.jpg`, `air-p-dark-chat0.jpg`).
|
||||
- Pipeline detail, run graph and diff content: no clipping
|
||||
(`air-p-pipeline24.jpg`, `air-p-diff.jpg`).
|
||||
- Compared with the web build at 1366x1024 / 1210x834 (`web-1366x1024-run7.jpg`,
|
||||
`web-1210x834-chat0.jpg`): the layout is the same. iOS uses SF at a smaller
|
||||
optical size, and on the web the tab buttons sit lower because there is no
|
||||
bottom inset. In web landscape the 440 pt list pane leaves the title and
|
||||
icons enough room, so finding 2 does not show there.
|
||||
|
||||
Fixture limits: the fixture does not implement `list_schedules` and
|
||||
`notification_settings`, so those sections show fixture errors; the run graph
|
||||
only shows with `graph=1`.
|
||||
|
After Width: | Height: | Size: 19 KiB |
|
After Width: | Height: | Size: 54 KiB |
|
After Width: | Height: | Size: 29 KiB |
|
After Width: | Height: | Size: 76 KiB |
|
After Width: | Height: | Size: 96 KiB |
|
After Width: | Height: | Size: 103 KiB |
|
After Width: | Height: | Size: 54 KiB |
|
After Width: | Height: | Size: 99 KiB |
|
After Width: | Height: | Size: 38 KiB |
|
After Width: | Height: | Size: 66 KiB |
|
After Width: | Height: | Size: 38 KiB |
|
After Width: | Height: | Size: 34 KiB |
|
After Width: | Height: | Size: 43 KiB |
|
After Width: | Height: | Size: 35 KiB |
|
After Width: | Height: | Size: 71 KiB |
|
After Width: | Height: | Size: 62 KiB |
|
After Width: | Height: | Size: 65 KiB |
|
After Width: | Height: | Size: 33 KiB |
|
After Width: | Height: | Size: 29 KiB |
|
After Width: | Height: | Size: 86 KiB |
|
After Width: | Height: | Size: 61 KiB |
|
After Width: | Height: | Size: 28 KiB |
|
After Width: | Height: | Size: 80 KiB |
|
After Width: | Height: | Size: 12 KiB |
|
After Width: | Height: | Size: 26 KiB |
|
After Width: | Height: | Size: 84 KiB |
|
After Width: | Height: | Size: 36 KiB |
|
After Width: | Height: | Size: 14 KiB |
|
After Width: | Height: | Size: 10 KiB |
|
After Width: | Height: | Size: 102 KiB |
|
After Width: | Height: | Size: 101 KiB |
|
After Width: | Height: | Size: 30 KiB |
|
After Width: | Height: | Size: 35 KiB |
|
After Width: | Height: | Size: 92 KiB |
|
After Width: | Height: | Size: 64 KiB |
|
After Width: | Height: | Size: 39 KiB |
@@ -0,0 +1,6 @@
|
||||
// The platform half of the full-app fixture entry
|
||||
// (tool/search_selection_probe_entry.dart): the browser build reads its
|
||||
// options from the page URL and installs the DevTools probes; a native build
|
||||
// (an iOS simulator) reads the same options from its launch environment.
|
||||
export 'fixture_host_native.dart'
|
||||
if (dart.library.js_interop) 'fixture_host_web.dart';
|
||||
@@ -0,0 +1,74 @@
|
||||
import 'dart:io';
|
||||
|
||||
import 'package:flutter/services.dart';
|
||||
import 'package:flutter/widgets.dart';
|
||||
import 'package:pipelines_app/application/server_endpoint.dart';
|
||||
|
||||
import 'fixture_steps.dart';
|
||||
import 'narrow_view.dart';
|
||||
|
||||
/// The fixture options on a native build. `simctl launch` passes the child
|
||||
/// environment through `SIMCTL_CHILD_FIXTURE_QUERY`, so one installed build
|
||||
/// opens any route/option set without rebuilding:
|
||||
///
|
||||
/// SIMCTL_CHILD_FIXTURE_QUERY='route=/chat/perf-chat-0&chats=3&rich=1' \
|
||||
/// xcrun simctl launch SIM net.awan.pipelines.next
|
||||
///
|
||||
/// Native-only keys: `server=ws://127.0.0.1:PORT/connect` (an artifact
|
||||
/// file server; the socket itself stays in-process), `orient=landscape|
|
||||
/// portrait`, `width=N` (logical px, draws the app in a left strip of that
|
||||
/// width to approximate an iPad Split View pane) and `do=` steps (see
|
||||
/// fixture_steps.dart). When the launch environment does not reach the app,
|
||||
/// the same query is read from `fixture_query.txt` in the app's temporary
|
||||
/// directory (`simctl get_app_container SIM BUNDLE data`/tmp), then from
|
||||
/// `--dart-define=FIXTURE_QUERY=...`.
|
||||
Map<String, String> fixtureParams() {
|
||||
var raw =
|
||||
Platform.environment['FIXTURE_QUERY'] ??
|
||||
const String.fromEnvironment('FIXTURE_QUERY');
|
||||
final file = File('${Directory.systemTemp.path}/fixture_query.txt');
|
||||
if (raw.isEmpty && file.existsSync()) raw = file.readAsStringSync().trim();
|
||||
return raw.isEmpty ? const {} : Uri.splitQueryString(raw);
|
||||
}
|
||||
|
||||
/// The DevTools probes are browser-only.
|
||||
void installHostProbes(Map<String, String> params) {}
|
||||
|
||||
/// The route goes through [fixtureRouteProvider] instead.
|
||||
void openFixtureRoute(String route, {required bool cupertino}) {}
|
||||
|
||||
/// An explicit loopback endpoint; nothing connects to it but artifact fetches.
|
||||
ServerEndpoint fixtureServer(Map<String, String> params) =>
|
||||
ServerEndpoint.resolve(
|
||||
base: Uri(),
|
||||
web: false,
|
||||
configured: params['server'] ?? 'ws://127.0.0.1:9/connect',
|
||||
);
|
||||
|
||||
/// Opens [route] as the launch location.
|
||||
RouteInformationProvider? fixtureRouteProvider(String? route) =>
|
||||
PlatformRouteInformationProvider(
|
||||
initialRouteInformation: RouteInformation(
|
||||
uri: Uri.parse(route ?? '/pipelines'),
|
||||
),
|
||||
);
|
||||
|
||||
/// Runs [app] with the native capture options applied.
|
||||
void runFixtureApp(Widget app, Map<String, String> params) {
|
||||
final binding = WidgetsFlutterBinding.ensureInitialized();
|
||||
switch (params['orient']) {
|
||||
case 'landscape':
|
||||
SystemChrome.setPreferredOrientations([
|
||||
DeviceOrientation.landscapeLeft,
|
||||
DeviceOrientation.landscapeRight,
|
||||
]);
|
||||
case 'portrait':
|
||||
SystemChrome.setPreferredOrientations([DeviceOrientation.portraitUp]);
|
||||
}
|
||||
final width = double.tryParse(params['width'] ?? '');
|
||||
final view = binding.platformDispatcher.implicitView!;
|
||||
runWidget(
|
||||
View(view: width == null ? view : NarrowView(view, width), child: app),
|
||||
);
|
||||
runFixtureSteps(params['do'] ?? '');
|
||||
}
|
||||
@@ -0,0 +1,38 @@
|
||||
import 'package:flutter/widgets.dart';
|
||||
import 'package:pipelines_app/application/server_endpoint.dart';
|
||||
import 'package:web/web.dart' as web;
|
||||
|
||||
import '../perf/backdrop_census.dart';
|
||||
import '../perf/chat_scroll_probe.dart';
|
||||
import '../perf/frame_log.dart';
|
||||
|
||||
/// The fixture options: the page URL's query.
|
||||
Map<String, String> fixtureParams() => Uri.base.queryParameters;
|
||||
|
||||
/// Installs the DevTools-facing probes the capture kit evaluates.
|
||||
void installHostProbes(Map<String, String> params) {
|
||||
installBackdropCensus();
|
||||
installFrameLog(params);
|
||||
installChatScrollProbe();
|
||||
}
|
||||
|
||||
/// Moves the browser to [route] before the app reads its location.
|
||||
void openFixtureRoute(String route, {required bool cupertino}) {
|
||||
final platform = cupertino ? 'platform=cupertino' : '';
|
||||
final joiner = route.contains('?') ? '&' : '?';
|
||||
web.window.history.replaceState(
|
||||
null,
|
||||
'',
|
||||
platform.isEmpty ? route : '$route$joiner$platform',
|
||||
);
|
||||
}
|
||||
|
||||
/// The browser build's endpoint is its own page origin.
|
||||
ServerEndpoint fixtureServer(Map<String, String> params) =>
|
||||
ServerEndpoint.resolve(base: Uri.base, web: true);
|
||||
|
||||
/// The browser's location is the route; no provider is needed.
|
||||
RouteInformationProvider? fixtureRouteProvider(String? route) => null;
|
||||
|
||||
/// Runs [app] unchanged.
|
||||
void runFixtureApp(Widget app, Map<String, String> params) => runApp(app);
|
||||
@@ -0,0 +1,165 @@
|
||||
import 'dart:async';
|
||||
|
||||
import 'package:flutter/gestures.dart';
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter/services.dart';
|
||||
|
||||
/// A tiny in-app driver for simulator captures, where `simctl` cannot tap.
|
||||
///
|
||||
/// [script] is `;`-separated steps run after the first frame, 700 ms apart:
|
||||
/// `wait:<ms>`, `tap:<label>` (a Text, Tooltip, Semantics label or field
|
||||
/// hint; `tap:<label>#<n>` picks the n-th match), `tapxy:<x>,<y>`,
|
||||
/// `drag:<x>,<y>,<dx>,<dy>`, `type:<text>` (into the focused field; `\n`
|
||||
/// is a newline), `orient:landscape|portrait` and `labels` (prints the
|
||||
/// visible labels with their centres to the device log).
|
||||
void runFixtureSteps(String script) {
|
||||
final steps = [
|
||||
for (final step in script.split(';'))
|
||||
if (step.trim().isNotEmpty) step.trim(),
|
||||
];
|
||||
if (steps.isEmpty) return;
|
||||
WidgetsBinding.instance.waitUntilFirstFrameRasterized.then((_) async {
|
||||
await Future<void>.delayed(const Duration(milliseconds: 1500));
|
||||
for (final step in steps) {
|
||||
final colon = step.indexOf(':');
|
||||
final verb = colon < 0 ? step : step.substring(0, colon);
|
||||
final value = colon < 0 ? '' : step.substring(colon + 1);
|
||||
try {
|
||||
await _run(verb, value);
|
||||
} catch (error) {
|
||||
// ignore: avoid_print
|
||||
print('FIXTURE_STEP_FAILED $step: $error');
|
||||
}
|
||||
await Future<void>.delayed(const Duration(milliseconds: 700));
|
||||
}
|
||||
// ignore: avoid_print
|
||||
print('FIXTURE_STEPS_DONE');
|
||||
});
|
||||
}
|
||||
|
||||
Future<void> _run(String verb, String value) async {
|
||||
switch (verb) {
|
||||
case 'wait':
|
||||
await Future<void>.delayed(Duration(milliseconds: int.parse(value)));
|
||||
case 'tap':
|
||||
final hash = value.lastIndexOf('#');
|
||||
final index = hash < 0 ? 0 : int.parse(value.substring(hash + 1));
|
||||
final label = hash < 0 ? value : value.substring(0, hash);
|
||||
final hits = _find(label);
|
||||
if (hits.length <= index) throw StateError('no "$label"');
|
||||
await _tap(hits[index].center);
|
||||
case 'tapxy':
|
||||
final parts = value.split(',').map(double.parse).toList();
|
||||
await _tap(Offset(parts[0], parts[1]));
|
||||
case 'drag':
|
||||
final p = value.split(',').map(double.parse).toList();
|
||||
await _drag(Offset(p[0], p[1]), Offset(p[2], p[3]));
|
||||
case 'type':
|
||||
_type(value.replaceAll(r'\n', '\n'));
|
||||
case 'orient':
|
||||
await SystemChrome.setPreferredOrientations(
|
||||
value == 'landscape'
|
||||
? [DeviceOrientation.landscapeLeft]
|
||||
: [DeviceOrientation.portraitUp],
|
||||
);
|
||||
case 'labels':
|
||||
for (final hit in _find(null)) {
|
||||
// ignore: avoid_print
|
||||
print('FIXTURE_LABEL ${hit.label} @ ${hit.center}');
|
||||
}
|
||||
default:
|
||||
throw StateError('unknown step');
|
||||
}
|
||||
}
|
||||
|
||||
class _Hit {
|
||||
_Hit(this.label, this.center);
|
||||
final String label;
|
||||
final Offset center;
|
||||
}
|
||||
|
||||
String? _labelOf(Widget widget) => switch (widget) {
|
||||
Text(:final data?) => data,
|
||||
Text(:final textSpan?) => textSpan.toPlainText(),
|
||||
Tooltip(:final message?) => message,
|
||||
Semantics(:final properties) => properties.label,
|
||||
Icon(:final semanticLabel?) => semanticLabel,
|
||||
InputDecorator(:final decoration) =>
|
||||
decoration.hintText ?? decoration.labelText,
|
||||
_ => null,
|
||||
};
|
||||
|
||||
/// Visible widgets labelled [label] (every labelled one when null).
|
||||
List<_Hit> _find(String? label) {
|
||||
final hits = <_Hit>[];
|
||||
final size = WidgetsBinding.instance.renderViews.first.size;
|
||||
void visit(Element element) {
|
||||
final text = _labelOf(element.widget);
|
||||
if (text != null && (label == null || text == label)) {
|
||||
final box = element.findRenderObject();
|
||||
if (box is RenderBox && box.attached && box.hasSize) {
|
||||
final center = box.localToGlobal(box.size.center(Offset.zero));
|
||||
if ((Offset.zero & size).contains(center)) hits.add(_Hit(text, center));
|
||||
}
|
||||
}
|
||||
element.visitChildren(visit);
|
||||
}
|
||||
|
||||
WidgetsBinding.instance.rootElement?.visitChildren(visit);
|
||||
return hits;
|
||||
}
|
||||
|
||||
var _pointer = 900;
|
||||
|
||||
Future<void> _tap(Offset at) async {
|
||||
final pointer = ++_pointer;
|
||||
final binding = GestureBinding.instance;
|
||||
binding.handlePointerEvent(PointerDownEvent(pointer: pointer, position: at));
|
||||
await Future<void>.delayed(const Duration(milliseconds: 60));
|
||||
binding.handlePointerEvent(PointerUpEvent(pointer: pointer, position: at));
|
||||
}
|
||||
|
||||
Future<void> _drag(Offset from, Offset by) async {
|
||||
final pointer = ++_pointer;
|
||||
final binding = GestureBinding.instance;
|
||||
binding.handlePointerEvent(
|
||||
PointerDownEvent(pointer: pointer, position: from),
|
||||
);
|
||||
const moves = 16;
|
||||
for (var i = 1; i <= moves; i++) {
|
||||
await Future<void>.delayed(const Duration(milliseconds: 16));
|
||||
binding.handlePointerEvent(
|
||||
PointerMoveEvent(
|
||||
pointer: pointer,
|
||||
position: from + by * (i / moves),
|
||||
delta: by / moves.toDouble(),
|
||||
),
|
||||
);
|
||||
}
|
||||
binding.handlePointerEvent(
|
||||
PointerUpEvent(pointer: pointer, position: from + by),
|
||||
);
|
||||
}
|
||||
|
||||
void _type(String text) {
|
||||
EditableTextState? focused;
|
||||
void visit(Element element) {
|
||||
if (element is StatefulElement &&
|
||||
element.state is EditableTextState &&
|
||||
(element.widget as EditableText).focusNode.hasFocus) {
|
||||
focused = element.state as EditableTextState;
|
||||
}
|
||||
element.visitChildren(visit);
|
||||
}
|
||||
|
||||
WidgetsBinding.instance.rootElement?.visitChildren(visit);
|
||||
final state = focused;
|
||||
if (state == null) throw StateError('no focused field');
|
||||
state.userUpdateTextEditingValue(
|
||||
TextEditingValue(
|
||||
text: text,
|
||||
selection: TextSelection.collapsed(offset: text.length),
|
||||
),
|
||||
SelectionChangedCause.keyboard,
|
||||
);
|
||||
}
|
||||
@@ -0,0 +1,64 @@
|
||||
import 'dart:ui' as ui;
|
||||
|
||||
/// The real view, reported [width] logical pixels wide (never wider than the
|
||||
/// view itself). The app lays out, paints and hit-tests in a strip at the
|
||||
/// window's left edge, which approximates an iPad Split View pane when the
|
||||
/// simulator cannot be driven into multitasking. Safe-area padding, insets
|
||||
/// and the display stay those of the full window.
|
||||
class NarrowView implements ui.FlutterView {
|
||||
NarrowView(this._view, this.width);
|
||||
|
||||
final ui.FlutterView _view;
|
||||
final double width;
|
||||
|
||||
@override
|
||||
ui.Size get physicalSize {
|
||||
final real = _view.physicalSize;
|
||||
final narrow = width * _view.devicePixelRatio;
|
||||
return ui.Size(narrow < real.width ? narrow : real.width, real.height);
|
||||
}
|
||||
|
||||
@override
|
||||
ui.ViewConstraints get physicalConstraints =>
|
||||
ui.ViewConstraints.tight(physicalSize);
|
||||
|
||||
@override
|
||||
int get viewId => _view.viewId;
|
||||
|
||||
@override
|
||||
ui.PlatformDispatcher get platformDispatcher => _view.platformDispatcher;
|
||||
|
||||
@override
|
||||
ui.Display get display => _view.display;
|
||||
|
||||
@override
|
||||
double get devicePixelRatio => _view.devicePixelRatio;
|
||||
|
||||
@override
|
||||
ui.ViewPadding get viewInsets => _view.viewInsets;
|
||||
|
||||
@override
|
||||
ui.ViewPadding get viewPadding => _view.viewPadding;
|
||||
|
||||
@override
|
||||
ui.ViewPadding get systemGestureInsets => _view.systemGestureInsets;
|
||||
|
||||
@override
|
||||
ui.ViewPadding get padding => _view.padding;
|
||||
|
||||
@override
|
||||
ui.GestureSettings get gestureSettings => _view.gestureSettings;
|
||||
|
||||
@override
|
||||
List<ui.DisplayFeature> get displayFeatures => _view.displayFeatures;
|
||||
|
||||
@override
|
||||
ui.DisplayCornerRadii? get displayCornerRadii => _view.displayCornerRadii;
|
||||
|
||||
@override
|
||||
void render(ui.Scene scene, {ui.Size? size}) => _view.render(scene);
|
||||
|
||||
@override
|
||||
void updateSemantics(ui.SemanticsUpdate update) =>
|
||||
_view.updateSemantics(update);
|
||||
}
|
||||
@@ -17,21 +17,18 @@ import 'dart:convert';
|
||||
|
||||
import 'package:pipelines_app/application/app_url_strategy.dart';
|
||||
import 'package:pipelines_app/application/pipelines_app.dart';
|
||||
import 'package:pipelines_app/application/server_endpoint.dart';
|
||||
import 'package:pipelines_app/application/bootstrap.dart';
|
||||
import 'package:pipelines_app/core/api_gateway.dart';
|
||||
import 'package:pipelines_app/core/transport/pipelines_client.dart';
|
||||
import 'package:pipelines_app/features/search/ui/search_bar_controls.dart'
|
||||
show searchFieldKey;
|
||||
import 'package:pipelines_app/ui/input/app_search_field.dart';
|
||||
import 'package:flutter/widgets.dart';
|
||||
import 'package:web/web.dart' as web;
|
||||
import 'package:web_socket_channel/web_socket_channel.dart';
|
||||
|
||||
import 'perf/backdrop_census.dart';
|
||||
import 'fixture_host/fixture_host.dart';
|
||||
import 'perf/chat_search_fixture.dart';
|
||||
import 'perf/chat_scroll_fixture.dart';
|
||||
import 'perf/chat_scroll_probe.dart';
|
||||
import 'perf/frame_log.dart';
|
||||
import 'perf/perf_fixture.dart';
|
||||
import 'probe_folder_fixture.dart';
|
||||
|
||||
@@ -597,41 +594,41 @@ class _FixtureSink implements WebSocketSink {
|
||||
///
|
||||
/// app/tool/capture/ drives this entry generically; see its README.
|
||||
void main() {
|
||||
final params = Uri.base.queryParameters;
|
||||
installBackdropCensus();
|
||||
installFrameLog(params);
|
||||
installChatScrollProbe();
|
||||
WidgetsFlutterBinding.ensureInitialized();
|
||||
final params = fixtureParams();
|
||||
installHostProbes(params);
|
||||
// `?connect=1` (native only) opens the real launch flow with no saved
|
||||
// server, so the Connect screen can be reviewed without any server.
|
||||
if (params['connect'] == '1') {
|
||||
runPipelinesApp(configured: '');
|
||||
return;
|
||||
}
|
||||
configurePerfFixture(params);
|
||||
_fillerRunCount = int.tryParse(params['runs'] ?? '') ?? 0;
|
||||
_fillerStepCount = int.tryParse(params['steps'] ?? '') ?? 0;
|
||||
final cupertino = params['platform'] == 'cupertino';
|
||||
final route = params['route'];
|
||||
if (route != null && route.startsWith('/')) {
|
||||
final platform = cupertino ? 'platform=cupertino' : '';
|
||||
final joiner = route.contains('?') ? '&' : '?';
|
||||
web.window.history.replaceState(
|
||||
null,
|
||||
'',
|
||||
platform.isEmpty ? route : '$route$joiner$platform',
|
||||
);
|
||||
}
|
||||
final opensRoute = route != null && route.startsWith('/');
|
||||
if (opensRoute) openFixtureRoute(route, cupertino: cupertino);
|
||||
final query = params['q'];
|
||||
if (query != null && query.isNotEmpty) _typeSearchWhenShown(query);
|
||||
useAppUrlStrategy();
|
||||
final app = PipelinesApp(
|
||||
server: ServerEndpoint.resolve(base: Uri.base, web: true),
|
||||
server: fixtureServer(params),
|
||||
client: PipelinesClient(channelFactory: (_) => _FixtureChannel()),
|
||||
cupertino: cupertino,
|
||||
routeInformationProvider: fixtureRouteProvider(opensRoute ? route : null),
|
||||
);
|
||||
final brightness = switch (params['theme']) {
|
||||
'dark' => Brightness.dark,
|
||||
'light' => Brightness.light,
|
||||
_ => null,
|
||||
};
|
||||
runApp(
|
||||
runFixtureApp(
|
||||
brightness == null
|
||||
? app
|
||||
: _PinnedBrightness(brightness: brightness, child: app),
|
||||
params,
|
||||
);
|
||||
}
|
||||
|
||||
|
||||