Hug the turn activity row's hover on desktop
On macOS, Linux, Windows and desktop browsers the "Thought · tool calls · background tasks" row is as wide as its label, so its hover and click area no longer span the transcript. Phones keep the full-width touch row. The check uses the device platform because web themes are pinned to Android. The scroll fixture gains ?turnactivity=1 for captures.
This commit is contained in:
@@ -5,6 +5,7 @@ import 'package:flutter/material.dart';
|
||||
|
||||
import '../../../../core/api_gateway.dart';
|
||||
import '../../domain/chat_turn_activity.dart';
|
||||
import '../../../../ui/adaptive/platform.dart';
|
||||
import '../sessions/chat_adaptive.dart';
|
||||
import 'chat_response_pending.dart';
|
||||
import 'chat_turn_activity_details.dart';
|
||||
@@ -149,9 +150,12 @@ class _ChatTurnActivityViewState extends State<ChatTurnActivityView> {
|
||||
: DateTime.now().difference(started);
|
||||
final seconds = duration.inSeconds.clamp(0, 2147483647);
|
||||
final label = '${data.label}${widget.streaming ? ' ${seconds}s' : ''}';
|
||||
// Desktop hover hugs the label; phones keep the full-width touch row.
|
||||
final compact = prefersCompactHitTargets(context);
|
||||
final content = ConstrainedBox(
|
||||
constraints: BoxConstraints(minHeight: cupertino ? 28 : 32),
|
||||
child: Row(
|
||||
mainAxisSize: compact ? MainAxisSize.min : MainAxisSize.max,
|
||||
children: [
|
||||
if (widget.streaming) ...[
|
||||
ExcludeSemantics(
|
||||
|
||||
@@ -1,3 +1,6 @@
|
||||
import 'package:flutter/foundation.dart';
|
||||
import 'package:flutter/material.dart';
|
||||
|
||||
/// The app renders the same Material layout and design on every platform:
|
||||
/// web, Android, iOS and macOS. The Cupertino host and controls remain
|
||||
/// available only when a caller asks for them explicitly (`cupertino: true`);
|
||||
@@ -6,3 +9,17 @@
|
||||
/// Flutter's automatic platform behaviours (scroll physics, text selection,
|
||||
/// page transitions and back-swipe) still follow the target platform.
|
||||
bool prefersCupertino() => false;
|
||||
|
||||
/// Whether this runs on a desktop platform (macOS, Linux, Windows),
|
||||
/// including a desktop browser. Hover and click targets there hug their
|
||||
/// content; phones and tablets keep full-width touch rows. Uses the device's
|
||||
/// platform, not the theme's: web themes are pinned to Android.
|
||||
bool prefersCompactHitTargets(BuildContext context) =>
|
||||
switch (defaultTargetPlatform) {
|
||||
TargetPlatform.macOS ||
|
||||
TargetPlatform.linux ||
|
||||
TargetPlatform.windows => true,
|
||||
TargetPlatform.android ||
|
||||
TargetPlatform.iOS ||
|
||||
TargetPlatform.fuchsia => false,
|
||||
};
|
||||
|
||||
@@ -0,0 +1,52 @@
|
||||
import 'package:flutter/foundation.dart';
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
import 'package:pipelines_app/features/chat/ui/transcript/chat_turn_activity_view.dart';
|
||||
|
||||
Future<double> _activityWidth(
|
||||
WidgetTester tester,
|
||||
TargetPlatform platform,
|
||||
) async {
|
||||
debugDefaultTargetPlatformOverride = platform;
|
||||
tester.view.physicalSize = const Size(1200, 800);
|
||||
tester.view.devicePixelRatio = 1;
|
||||
addTearDown(tester.view.reset);
|
||||
await tester.pumpWidget(
|
||||
MaterialApp(
|
||||
// Web pins the theme to Android; the device platform decides.
|
||||
theme: ThemeData(platform: TargetPlatform.android),
|
||||
home: const Scaffold(
|
||||
body: Column(
|
||||
crossAxisAlignment: CrossAxisAlignment.stretch,
|
||||
children: [
|
||||
ChatTurnActivityView(
|
||||
parts: [
|
||||
{'type': 'reasoning', 'text': 'Considering the files.'},
|
||||
],
|
||||
streaming: false,
|
||||
),
|
||||
],
|
||||
),
|
||||
),
|
||||
),
|
||||
);
|
||||
final width = tester
|
||||
.getSize(find.byKey(const Key('chat-turn-activity')))
|
||||
.width;
|
||||
debugDefaultTargetPlatformOverride = null;
|
||||
return width;
|
||||
}
|
||||
|
||||
void main() {
|
||||
testWidgets('desktop hover hugs the activity label', (tester) async {
|
||||
for (final platform in [TargetPlatform.macOS, TargetPlatform.linux]) {
|
||||
expect(await _activityWidth(tester, platform), lessThan(400));
|
||||
}
|
||||
});
|
||||
|
||||
testWidgets('phones keep the full-width touch row', (tester) async {
|
||||
for (final platform in [TargetPlatform.android, TargetPlatform.iOS]) {
|
||||
expect(await _activityWidth(tester, platform), 1200);
|
||||
}
|
||||
});
|
||||
}
|
||||
@@ -23,6 +23,10 @@ Map<String, String> _params = const {};
|
||||
void configureChatScrollFixture(Map<String, String> params) => _params = params;
|
||||
|
||||
bool get _rich => _params['rich'] == '1';
|
||||
|
||||
/// `?turnactivity=1`: replies carry thinking and a tool call, so the turn
|
||||
/// activity row ("Thought … · 1 tool call") is shown.
|
||||
bool get _activity => _params['turnactivity'] == '1';
|
||||
bool get _links => _params['links'] == '1';
|
||||
bool get _older => _params['older'] == '1';
|
||||
int get _live => int.tryParse(_params['live'] ?? '') ?? 0;
|
||||
@@ -135,6 +139,16 @@ JsonMap _message(String chat, int i) {
|
||||
'id': id,
|
||||
'role': 'assistant',
|
||||
'parts': [
|
||||
if (_activity) ...[
|
||||
{'type': 'reasoning', 'text': 'Checking the files for step $i.'},
|
||||
{
|
||||
'type': 'tool',
|
||||
'id': 'tool-$i',
|
||||
'name': 'read',
|
||||
'state': 'completed',
|
||||
'input': {'path': 'lib/main.dart'},
|
||||
},
|
||||
],
|
||||
{'type': 'text', 'text': _answer(i)},
|
||||
],
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user