Merge lane-go: keep the lane's reviewed work
Combines lane-go's typed omni search, launch-time model overrides, TUI artifacts view, run-state websocket push, and the "reflect the change where it belongs" committer rule with the Templates gallery, chat/omni-search and other reviewed work already on main. The 12 files both sides touched keep both intents composed rather than dropping either side: the omni search keeps the typed search contract (CLI `pipelines search` and the TUI popup with type badges and marked snippets) alongside the run-list quick filter; cli.md and ui-ux-review.md document both the search rework and the artifacts view; orchestration.md, harnesses.md and operations.md keep the model-override and reflect-where-it-belongs guidance; and the protocol/CLI/server/TUI code keeps the new search, run-event, override and artifacts paths alongside the existing run, title and help surfaces. Checks before committing: - go build ./... -- pass - go vet ./... -- pass - go test -count=1 ./internal/... ./cmd/... -- all pass Doc check before committing: nothing needs updating. The lane's own docs and references (docs/cli.md, docs/ui-ux-review.md, and the orchestration, harnesses and operations skill references) already carry the new features. format.md and the packaged templates already describe the line-oriented result format and the human decision stage from the earlier lane-go merge. The root README already describes the omni search popup. Model overrides, the search command, run events and the artifacts view are runtime/CLI/TUI surfaces that cli.md documents; no template, README or topic-doc edit is required by this merge.
This commit is contained in:
@@ -118,6 +118,16 @@ preserved and partial stdout after the grace is never accepted as success.
|
||||
|
||||
Stages set `harness=pi` or `harness=opencode` in configs; omission preserves
|
||||
historical OpenCode behavior. Pi must be configured on the execution server.
|
||||
A run may override the pinned model at launch: `pipelines run --model
|
||||
PROVIDER/MODEL` covers every model stage and repeatable `--stage-model
|
||||
STAGE=PROVIDER/MODEL` overrides one stage, with precedence **per-stage >
|
||||
whole-run > the model pinned in the pipeline version**. Overrides are validated
|
||||
against the pinned version before the run starts (an unknown stage key fails
|
||||
naming the valid keys; a non-model stage cannot be overridden), apply to that run
|
||||
only, and are recorded on the run so `retry` reproduces them. The effective
|
||||
provider/model is stamped on the step and exposed by the run's graph, and the
|
||||
stage's repair/formatter path uses the same resolved model because both read the
|
||||
stage's effective configs.
|
||||
The RPC adapter starts new retained sessions per visit with explicit tools and
|
||||
a Pipelines permission extension. Ambient extensions, skills, context files,
|
||||
prompt templates, automatic retries/compaction are disabled. Tool gates are not
|
||||
|
||||
@@ -151,9 +151,17 @@ runs natively through `./install` by default (`scripts/setup-native.py`, with
|
||||
`--native` equivalent); the Docker server + ntfy installation is explicit with
|
||||
`./install --docker`.
|
||||
|
||||
In the TUI, Home advertises `/` search and `:` commands. Run Tab switches only
|
||||
In the TUI, Home advertises `/` omni search and `:` commands. Home `/` opens one
|
||||
popup over pipelines, versions, runs, steps/visits, artifact names and stage
|
||||
input/output/evidence text; each row shows a short type badge and a text match
|
||||
shows a bracketed snippet, and a bare status word or date selects runs. The same
|
||||
query is available as `pipelines search QUERY [--type KIND]`, where `--type`
|
||||
narrows the kind. Run Tab switches only
|
||||
Details ↔ Graph. `n/p` select recorded visits, including repeated stages; `d`
|
||||
focuses/toggles file changes, `a` selects the active/latest retained
|
||||
focuses/toggles file changes, `A` opens the run's grouped artifacts view (name,
|
||||
content type, size and URL per entry, `PgUp`/`PgDn` scroll so a trailing visit
|
||||
that recorded none stays reachable, `Enter`/`o` to open the selected URL and
|
||||
`y` to copy it), `a` selects the active/latest retained
|
||||
configured-harness agent session's bounded, redacted tool evidence, `D`/`:debug`
|
||||
opens fresh investigation, and `P` opens the pinned pipeline version. `:quit`
|
||||
exits; `q` does not. Results are retained reports, not independently confirmed
|
||||
@@ -200,7 +208,10 @@ The instruction is general: save images, screenshots, reports and logs there.
|
||||
|
||||
After the visit the server makes one bounded inventory and records each file's
|
||||
name, size, content type (extension, sniff fallback) and a relative url; these
|
||||
appear under each step's `artifacts` in `inspect RUN_ID --json` and the TUI.
|
||||
appear under each step's `artifacts` in `inspect RUN_ID --json` and the TUI's
|
||||
`A` artifacts view, which groups them by stage and visit, marks images and shows
|
||||
the recorded count, capture-pending/not-recorded wording and partial-capture
|
||||
notes.
|
||||
`GET /artifacts/<run>/<step>/<name>` serves the bytes (correct Content-Type and
|
||||
Content-Length, HEAD, and Range/206/416 via `http.ServeContent`), refusing
|
||||
traversal, absolute paths, symlink escapes and unknown runs/steps.
|
||||
|
||||
@@ -55,8 +55,11 @@ Every brief has:
|
||||
output it must report, plus the screenshots the reviewer must read. Say plainly:
|
||||
"report the exact commands and their observed results. Do not claim a check you
|
||||
did not run."
|
||||
5. **The hard constraints block** (below).
|
||||
6. **Publishing rules** (`references/delivery.md`).
|
||||
5. **Where it belongs** — the packaged templates, the repository's guidelines (README
|
||||
and topic docs) and the packaged skill references the change is expected to touch,
|
||||
so the committer can check and update them before it commits.
|
||||
6. **The hard constraints block** (below).
|
||||
7. **Publishing rules** (`references/delivery.md`).
|
||||
|
||||
Template:
|
||||
|
||||
@@ -103,6 +106,10 @@ Adapt the scope and publishing lines per item; keep the rest.
|
||||
- **Keep values from single sources** — geometry, tokens, sizes and constants come
|
||||
from the source that already owns them, not from new literals.
|
||||
- **Commit locally only, never push** — the committer stage commits, no other stage.
|
||||
- **Reflect the change where it belongs** — before committing, the committer checks
|
||||
that the change is reflected in the packaged templates, the repository's guidelines
|
||||
(README and topic docs) and the packaged skill references, updates anything stale,
|
||||
and states in the commit body what it checked or that nothing needed updating.
|
||||
- **Publish rules** — WIP artefact naming and LAN URLs per `references/delivery.md`.
|
||||
|
||||
## Pipeline choice
|
||||
@@ -116,11 +123,14 @@ Adapt the scope and publishing lines per item; keep the rest.
|
||||
`skipped` with a reason when the change has no rendered surface. Never accept a UI
|
||||
change approved without the images.
|
||||
- The committer is the only stage that commits, and it stages only the run's changed
|
||||
files. It must select `input.server_changed_files` (the runner's captured evidence,
|
||||
`references/control.md`) alongside the implementer's declared `changed_files` and
|
||||
stage their union: an implementer's declared list can be incomplete, and a captured
|
||||
path it omitted is still this run's change. Its prompt carries the pre-commit
|
||||
checklist in `references/format.md`; it commits locally and stops, never pushing.
|
||||
files. Before committing it checks that the change is reflected in the packaged
|
||||
templates, the repository's guidelines (README and topic docs) and the packaged
|
||||
skill references, updates anything stale, and states in the commit body what it
|
||||
checked or that nothing needed updating. It must also select `input.server_changed_files`
|
||||
(the runner's captured evidence, `references/control.md`) alongside the implementer's
|
||||
declared `changed_files` and stage their union: an implementer's declared list can be
|
||||
incomplete, and a captured path it omitted is still this run's change. Its prompt carries
|
||||
the pre-commit checklist in `references/format.md`; it commits locally and stops, never pushing.
|
||||
- A run cannot approve its own work. When an item genuinely needs an operator gate
|
||||
before it continues or commits, insert a `type=human` decision stage
|
||||
(`references/format.md`); never invent a model stage that pretends to approve.
|
||||
@@ -133,6 +143,13 @@ Adapt the scope and publishing lines per item; keep the rest.
|
||||
- Launch with the authoritative `CLI_PREFIX` (`pipelines run`). The brief text is the
|
||||
run's task; pass it whole. Read `references/operations.md` for the exact flags —
|
||||
`--json`, confirmation (`--yes`) and `--wait`/`--wait-timeout`.
|
||||
- **Model overrides at launch.** Use `--model PROVIDER/MODEL` to override the model
|
||||
for every model stage of that run, and repeatable `--stage-model
|
||||
STAGE=PROVIDER/MODEL` to override individual stages. Precedence is per-stage >
|
||||
whole-run > the model pinned in the pipeline version. Overrides apply to that run
|
||||
only (the pinned pipeline is never edited), are validated before the run starts,
|
||||
and are recorded on the run; `retry` reuses them. See `references/harnesses.md`
|
||||
for how a stage's model and its repair path both use the effective model.
|
||||
- Watch to a **terminal state** (`succeeded`, `failed`, `canceled`, `interrupted`).
|
||||
Poll `CLI_PREFIX inspect RUN_ID --json` (or use `--wait`) until terminal. A reached
|
||||
client wait limit is not a run failure: the run stays active; keep waiting or
|
||||
|
||||
Reference in New Issue
Block a user