android: document the omni-search results panel

Add a "Omni-search results panel (16 Oct 2026)" section to android/README.md
describing the panel that sits above the omni-search field: its placement above
the input and IME, the badge/title/secondary row layout with a bold+underlined
snippet span, the debounced query with stale-response gating and no flicker to
empty, the loading/empty/error states, and result-to-target navigation for every
kind. Records the verification evidence (unit tests and assembleDebug, APK hash
and size, published APK and LAN URL) and notes what was left to the visual review.

No source behaviour changes: the panel logic already existed; this pass verified
it and filled the documentation gap.
This commit is contained in:
2026-10-16 21:42:33 +01:00
parent 9b9f12f48e
commit 1fe7edb30f
+59
View File
@@ -4245,3 +4245,62 @@ cache, `ANDROID_HOME=/Users/alan/Library/Android/sdk`, `--no-daemon --offline`):
Not verified in this pass: device captures (the visual review owns the device, per
the brief's device policy), so the filter-menu name field's on-screen layout is
exercised by the compile and the pure filter tests only.
## Omni-search results panel (16 Oct 2026)
The results panel above the omni-search field was already on the tree (it landed
with the entry point and pill morph, commits `80f7b0a` and `e2147b0`); this pass
verified it against the brief and documents it, because the entry point/pill
section left the panel itself undocumented.
- **Above the input, above the keyboard.** `PipelinesApp` puts the panel and the
destination bar in one bottom-anchored `Column` that clears `paneSafeArea()`
(`WindowInsets.safeDrawing`, which carries the IME and the navigation bar); the
panel takes the remaining height with `weight(1f, fill = false)` and scrolls
its `LazyColumn` inside it, so it is never under the field or the keyboard. The
activity declares `adjustNothing`, so the IME inset is counted once, not twice.
- **Badge, title, secondary line.** `OmniSearchResults.searchRow` gives every hit
a `pipeline`/`run`/`step`/`artifact`/`match` badge (`searchBadge`, a version hit
reads as `pipeline`), a title and a secondary line; a text ("field") hit's
secondary line is its snippet, split by `snippetSpans` and rendered
bold+underlined for the matched span, so the match is legible without colour.
- **Debounced, no flicker, no stale overwrite.** `AppViewModel` debounces
keystrokes through the pure `SearchSequencer`: a burst collapses to one request
for the last edit, `SearchUiState.editing` keeps the previous results (a thin
progress bar marks the refresh), and `accepts` gates every reply on the newest
sent token, so an older query can never land on top of a newer one.
- **Loading, empty, error.** The first load shows a "Searching…" row; the empty
state names the query (`No matches for "<query>".`); a failure is shown in place
of the results without discarding what was already loaded.
- **Navigation.** Selecting a result resolves through `searchTarget` and closes
the search: a pipeline/version opens the pipeline detail, a run opens the run
detail, a step or artifact opens the recorded visit's stage pane (whose leading
section is the visit's Artifacts gallery), and a text match opens the run-detail
section holding it (`searchFieldSection`). A kind with no known payload resolves
to no target and is shown read-only rather than dropped.
- **Tests.** `OmniSearchResultsTest` covers the badge/row mapping, the snippet
split, the result-to-target mapping for every kind, the run-target resolution
(visit index and section) and the debounce/stale/panel-state transitions;
`OmniSearchTest` covers the field state and its Saver.
Evidence (macOS, JDK 17 from Homebrew `openjdk@17`, Gradle 8.11.1 from the
wrapper cache, `ANDROID_HOME=/Users/alan/Library/Android/sdk`, `--no-daemon
--offline`):
- `gradle :app:testDebugUnitTest :app:assembleDebug --no-daemon --offline
--console=plain --rerun-tasks` → `BUILD SUCCESSFUL in 14s` (41 actionable tasks:
41 executed). The 39 result XMLs aggregate to **349 tests, 0 failures, 0 errors,
0 skipped**.
- `app/build/outputs/apk/debug/app-debug.apk` is **18,126,113 bytes**, sha256
`69e61b9564b5958e21e9b56465a7f1c9c60e29d5767b53fe7549ecfd67db6f8b`.
- **APK publish.** `app-debug.apk` copied to
`~/.local/share/pipelines/data/artifacts/186/1/pipelines-debug-wip-9b9f12f.apk`
(`9b9f12f` = `git rev-parse --short HEAD`); `shasum -a 256` matched. The LAN URL
`http://10.0.0.249:8080/artifacts/186/1/pipelines-debug-wip-9b9f12f.apk`
returned `HTTP/1.1 200 OK`, `Content-Type:
application/vnd.android.package-archive`, `Content-Length: 18126113`.
Not verified in this pass: device frames of the populated panel, the empty result
and a selection navigating (the visual review owns the device, per the brief's
device policy); the panel's pure logic is exercised by the unit tests and the
compile only.