feat(app): add native retry and restart action

This commit is contained in:
2026-10-21 15:13:00 +01:00
parent 0a00526692
commit 178f22aec2
10 changed files with 1235 additions and 0 deletions
@@ -0,0 +1,123 @@
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import '../../../core/api_gateway.dart';
import '../data/runs_repository.dart';
import 'action_refusal.dart';
import 'retry_dialog.dart';
import 'retry_eligibility.dart';
import 'retry_intent.dart';
import 'retry_wording.dart';
/// The run detail's deliberate retry entry point.
///
/// Renders one native button only while [run] is a stopped `failed` run. Opening
/// the resume or restart confirmation sends nothing; only the confirm action
/// asks the server to retry. A refusal is returned to the kept-open prompt
/// immediately and the run is re-read separately, so [onRunChanged] still
/// receives server truth without locking the prompt while that read is pending.
class RetryRunAction extends StatefulWidget {
const RetryRunAction({
super.key,
required this.run,
required this.gateway,
required this.onRunChanged,
});
final JsonMap run;
final ApiGateway gateway;
final ValueChanged<JsonMap> onRunChanged;
@override
State<RetryRunAction> createState() => _RetryRunActionState();
}
class _RetryRunActionState extends State<RetryRunAction> {
bool _dialogOpen = false;
Future<bool?>? _resync;
bool _usesCupertino(BuildContext context) {
final material = Localizations.of<MaterialLocalizations>(
context,
MaterialLocalizations,
);
return material == null;
}
Future<void> _open() async {
final id = retryRunId(widget.run);
if (id == null || !canRetryRun(widget.run) || _dialogOpen) return;
_dialogOpen = true;
try {
await showRetryRunPrompt(
context: context,
runId: id,
cupertino: _usesCupertino(context),
onSubmit: (intent) => _submit(id, intent),
);
} finally {
_dialogOpen = false;
if (mounted) setState(() {});
}
}
Future<ActionRefusal?> _submit(num id, RetryIntent intent) async {
final repository = RunsRepository(widget.gateway);
try {
final run = await repository.retryRun(
id,
requestKey: intent.requestKey,
mode: intent.mode.wireMode,
);
if (!mounted) return null;
if (_owns(id)) widget.onRunChanged(run);
return null;
} catch (error) {
return ActionRefusal(
describeRetryError(error),
stillPossible: _resyncRun(id),
);
}
}
bool _owns(num id) => mounted && retryRunId(widget.run) == id;
/// One bounded re-read per refusal. A refusal that arrives while a read is
/// already in flight observes that same read instead of starting another.
Future<bool?> _resyncRun(num id) {
return _resync ??= _readRun(id);
}
Future<bool?> _readRun(num id) async {
try {
final run = await RunsRepository(widget.gateway).getRun(id);
if (!_owns(id)) return null;
widget.onRunChanged(run);
return canRetryRun(run);
} catch (_) {
// Unknown server truth: keep the refusal and leave a deliberate retry.
return null;
} finally {
_resync = null;
}
}
@override
Widget build(BuildContext context) {
if (retryRunId(widget.run) == null || !canRetryRun(widget.run)) {
return const SizedBox.shrink();
}
if (_usesCupertino(context)) {
return CupertinoButton.filled(
key: retryActionKey,
onPressed: _open,
child: const Text(retryActionLabel),
);
}
return FilledButton(
key: retryActionKey,
onPressed: _open,
child: const Text(retryActionLabel),
);
}
}
@@ -0,0 +1,207 @@
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'action_refusal.dart';
import 'retry_intent.dart';
import 'retry_wording.dart';
/// Sends the confirmed retry intent. Returns null once the server has accepted
/// it, or an [ActionRefusal] carrying the server's words verbatim; the prompt
/// then stays open with dismissal available immediately.
typedef RetrySubmit = Future<ActionRefusal?> Function(RetryIntent intent);
/// Opens the native retry confirmation for [runId].
///
/// The first confirmation offers resume (the default) and a secondary
/// `Restart from start` confirmation, exactly like the browser's retry dialog.
/// Nothing is sent until the operator presses a confirm action; `Keep` only
/// closes the prompt.
Future<void> showRetryRunPrompt({
required BuildContext context,
required num runId,
required bool cupertino,
required RetrySubmit onSubmit,
}) {
final prompt = _RetryPrompt(
runId: runId,
cupertino: cupertino,
onSubmit: onSubmit,
);
if (cupertino) {
return showCupertinoDialog<void>(
context: context,
barrierDismissible: false,
builder: (_) => prompt,
);
}
return showDialog<void>(
context: context,
barrierDismissible: false,
builder: (_) => prompt,
);
}
class _RetryPrompt extends StatefulWidget {
const _RetryPrompt({
required this.runId,
required this.cupertino,
required this.onSubmit,
});
final num runId;
final bool cupertino;
final RetrySubmit onSubmit;
@override
State<_RetryPrompt> createState() => _RetryPromptState();
}
class _RetryPromptState extends State<_RetryPrompt> {
RetryMode _mode = RetryMode.resume;
String? _requestKey;
bool _sending = false;
bool _checking = false;
bool _blocked = false;
bool _attempted = false;
String? _error;
void _keep() {
if (!_sending) Navigator.of(context).pop();
}
void _restart() {
if (_sending || _checking || _attempted) return;
setState(() {
_mode = RetryMode.restart;
_error = null;
});
}
Future<void> _confirm() async {
if (_sending || _checking || _blocked) return;
setState(() {
_sending = true;
_attempted = true;
_error = null;
});
final intent = RetryIntent(
mode: _mode,
requestKey: _requestKey ??= newRetryRequestKey(widget.runId),
);
final refusal = await widget.onSubmit(intent);
if (!mounted) return;
if (refusal == null) {
Navigator.of(context).pop();
return;
}
final check = refusal.stillPossible;
setState(() {
_sending = false;
_error = refusal.message;
_checking = check != null;
});
if (check == null) return;
bool? stillPossible;
try {
stillPossible = await check;
} catch (_) {
// The action reports re-read failures as null; never fabricate one here.
}
if (!mounted) return;
setState(() {
_checking = false;
_blocked = stillPossible == false;
});
}
@override
Widget build(BuildContext context) {
final dialog = widget.cupertino ? _cupertino(context) : _material(context);
return PopScope(canPop: !_sending, child: dialog);
}
bool get _confirmDisabled => _sending || _checking || _blocked;
bool get _showRestart => _mode == RetryMode.resume && !_attempted;
Widget _material(BuildContext context) {
final theme = Theme.of(context);
return AlertDialog(
scrollable: true,
title: Text(_dialogTitle),
content: _body(errorStyle: TextStyle(color: theme.colorScheme.error)),
actions: [
if (_showRestart)
TextButton(
key: retryRestartKey,
onPressed: _sending || _checking ? null : _restart,
child: const Text(restartConfirmLabel),
),
TextButton(
key: retryKeepKey,
onPressed: _sending ? null : _keep,
child: const Text(retryKeepLabel),
),
FilledButton(
key: retryConfirmKey,
onPressed: _confirmDisabled ? null : _confirm,
child: Text(_confirmLabel),
),
],
);
}
Widget _cupertino(BuildContext context) {
return CupertinoAlertDialog(
title: Text(_dialogTitle),
content: _body(
errorStyle: TextStyle(
color: CupertinoColors.systemRed.resolveFrom(context),
),
),
actions: [
if (_showRestart)
CupertinoDialogAction(
key: retryRestartKey,
onPressed: _sending || _checking ? null : _restart,
child: const Text(restartConfirmLabel),
),
CupertinoDialogAction(
key: retryKeepKey,
onPressed: _sending ? null : _keep,
child: const Text(retryKeepLabel),
),
CupertinoDialogAction(
key: retryConfirmKey,
isDestructiveAction: _mode == RetryMode.restart,
onPressed: _confirmDisabled ? null : _confirm,
child: Text(_confirmLabel),
),
],
);
}
Widget _body({required TextStyle errorStyle}) {
return Column(
mainAxisSize: MainAxisSize.min,
crossAxisAlignment: CrossAxisAlignment.stretch,
children: [
Text(_dialogMessage),
if (_error case final error?)
Padding(
padding: const EdgeInsets.only(top: 8),
child: Text(error, key: retryErrorKey, style: errorStyle),
),
],
);
}
String get _dialogTitle => _mode == RetryMode.restart
? restartDialogTitle(widget.runId)
: retryDialogTitle(widget.runId);
String get _dialogMessage =>
_mode == RetryMode.restart ? restartDialogMessage : retryDialogMessage;
String get _confirmLabel =>
_mode == RetryMode.restart ? restartConfirmLabel : retryConfirmLabel;
}
@@ -0,0 +1,16 @@
import '../../../core/api_gateway.dart';
/// Whether the operator may retry [run], matching `canRetry` in
/// `web/src/actions.js` exactly: a loaded run that is not executing and whose
/// status is `failed`. A stale `failed` status while the run still executes is
/// not retryable.
bool canRetryRun(JsonMap? run) {
if (run == null) return false;
return run['executing'] != true && run['status'] == 'failed';
}
/// The run id used by the retry request, or null for a malformed run.
num? retryRunId(JsonMap run) {
final id = run['id'];
return id is num ? id : null;
}
@@ -0,0 +1,29 @@
import 'dart:math';
/// The two deliberate retry choices. `resume` is the server's default, so its
/// wire field is omitted; `restart` replays the whole pipeline.
enum RetryMode {
resume,
restart;
/// The `retry_mode` value to send, or null to let the server resume.
String? get wireMode => this == RetryMode.restart ? 'restart' : null;
}
/// One confirmed retry intent: the chosen mode plus the idempotency key that
/// belongs to it. Retrying the same uncertain intent reuses [requestKey] so the
/// server can dedupe it; a fresh deliberate intent uses a new key.
class RetryIntent {
const RetryIntent({required this.mode, required this.requestKey});
final RetryMode mode;
final String requestKey;
}
/// A fresh `request_key` for one retry intent. The server requires one and caps
/// it at 128 characters; this stays well inside that bound and unique per call.
String newRetryRequestKey(num runId, {DateTime? now, int? random}) {
final stamp = (now ?? DateTime.now()).microsecondsSinceEpoch;
final entropy = random ?? Random().nextInt(1 << 32);
return 'app-retry-$runId-$stamp-${entropy.toRadixString(36)}';
}
@@ -0,0 +1,33 @@
import 'package:flutter/widgets.dart';
/// The browser client's retry wording, kept verbatim.
const retryActionLabel = 'Retry';
const retryDialogMessage =
'Only failed runs can be retried. The server starts a new run from the '
'same input.';
const retryConfirmLabel = 'Retry';
const restartDialogMessage =
'This replays the whole pipeline from the start instead of resuming the '
'failed stage.';
const restartConfirmLabel = 'Restart from start';
const retryKeepLabel = 'Keep';
/// Stable test/semantics keys shared by the action and its prompt.
const retryActionKey = ValueKey<String>('retry-run-action');
const retryKeepKey = ValueKey<String>('retry-run-keep');
const retryConfirmKey = ValueKey<String>('retry-run-confirm');
const retryRestartKey = ValueKey<String>('retry-run-restart');
const retryErrorKey = ValueKey<String>('retry-run-error');
/// The retry dialog's title: `Retry run {id}?`.
String retryDialogTitle(num runId) => 'Retry run $runId?';
/// The restart dialog's title: `Restart run {id}?`.
String restartDialogTitle(num runId) => 'Restart run $runId?';
/// The server's refusal, verbatim. Only a blank error gets a generic sentence
/// so the prompt never claims a retry that did not happen.
String describeRetryError(Object error) {
final message = '$error'.trim();
return message.isEmpty ? 'The server did not retry the run.' : message;
}
+114
View File
@@ -0,0 +1,114 @@
# R2c — native retry / restart action
Small app-only addition, new files only. `RetryRunAction(run, gateway,
onRunChanged)` is the deliberate retry entry point for a stopped failed run; it
does not add a screen or controller and is not wired into the shell.
## What changed
| File | Lines | Responsibility |
| --- | --- | --- |
| `lib/features/runs/actions/retry_action.dart` | 123 | `RetryRunAction`, gating, send/refusal/resync orchestration |
| `lib/features/runs/actions/retry_dialog.dart` | 207 | Native resume/restart confirmation, refusal display, key lifetime |
| `lib/features/runs/actions/retry_eligibility.dart` | 16 | `canRetryRun` mirroring the web `canRetry` |
| `lib/features/runs/actions/retry_intent.dart` | 29 | Mode, confirmed intent and idempotency-key generation |
| `lib/features/runs/actions/retry_wording.dart` | 33 | Web-verbatim words, titles, error wording and test keys |
| `test/.../retry_test_support.dart` | 112 | Fake gateway and Material/Cupertino hosts |
| `test/.../retry_action_test.dart` | 245 | Eligibility, both platforms, modes and key fields |
| `test/.../retry_resilience_test.dart` | 223 | Immediate refusals, recheck outcomes, key retention |
| `test/.../retry_safety_test.dart` | 133 | Double submit, late replies, narrow 2x layout |
No repository, gateway, socket, controller, shell, main, pubspec, web, server or
device file was edited.
## Behavior
Eligibility is exactly the browser's rule: a loaded run that is not executing and
whose status is `failed` (`run != null && !run.executing && status == "failed"`).
A stale `failed` status while execution is still in flight, a running/waiting/
succeeded/canceled run, and a malformed run render nothing.
The button is a Material `FilledButton` or a Cupertino `CupertinoButton.filled`,
labelled `Retry`. Opening the prompt sends nothing, and `Keep` only closes it.
The first confirmation is the browser's retry copy: title `Retry run {id}?`,
message `Only failed runs can be retried. The server starts a new run from the
same input.`, confirm `Retry`, dismiss `Keep`, plus the browser-only secondary
`Restart from start` that leads to a distinct confirmation. That second prompt
uses title `Restart run {id}?`, message `This replays the whole pipeline from the
start instead of resuming the failed stage.` and confirm `Restart from start`;
the resume actions are gone, so the more destructive choice cannot be mistaken
for resume.
Resume calls `RunsRepository.retryRun` with only `run_id` and `request_key`, so
`retry_mode` is omitted and the server's `resume` default applies. Restart sends
`retry_mode: "restart"` with the same two required fields.
A `request_key` is created on the first confirm of an open prompt, not on opening
or `Keep`. It survives a refusal, so pressing confirm again for the same
uncertain request reuses the key and the server can dedupe it. Closing the prompt
and opening it again is a fresh deliberate intent and gets a new key, so a resume
attempt followed by a restart attempt never shares a key. Switching to the
restart confirmation before any send simply confirms restart with that prompt's
first key. Keys are bounded and run-scoped (`app-retry-{runId}-…`, well under the
server's 128-character cap).
A server refusal returns to the prompt immediately: the exact server words are
visible and `Keep`/back are available while the detached `get_run` recheck is
still pending. One bounded re-read is issued per refusal, single-flight through a
retained future, with no retry loop or polling. If server truth says the run is no
longer retryable, confirm is disabled and an attempted tap sends nothing; the
refusal stays visible until dismissal. If the recheck itself fails, truth is
unknown, so confirm is re-enabled and a deliberate retry uses the retained key.
Late retry replies and late rechecks after disposal or navigation are ignored.
Construction, controls and error colour are standard Material/Cupertino defaults;
there is no custom palette, fixed control size or dependency. The narrow layout
relies on the native dialog's own scrolling/wrapping.
## Acceptance checks
Fake-gateway widget tests, both platforms, no socket or real server:
- eligibility table for stopped failed vs executing failed, running, waiting,
succeeded and canceled runs, plus the same visibility table under both apps;
- `Retry` opens the native `AlertDialog`/`CupertinoAlertDialog`, `Keep` closes it
and the recorded gateway calls are still empty;
- resume sends exactly `{run_id, request_key}` and no `retry_mode`; restart sends
exactly `{run_id, request_key, retry_mode: "restart"}`;
- key format is deterministic under an injected clock/entropy, bounded, fresh per
call, retained across an uncertain retry (resume and restart), and different
after a deliberate reopen or mode change;
- refusal message appears while `get_run` is deliberately unresolved, with Keep
enabled, confirm disabled and no callback yet; Keep then closes and the late
recheck still delivers server truth safely;
- ineligible recheck (`succeeded`) blocks a repeat action; failed recheck leaves
the same key and a working deliberate retry;
- two confirm taps while in flight produce one `retry_run`; both the retry reply
and the recheck are safe after disposal;
- 320×480 at 2× text: both resume and restart confirmations render on both apps
with no exception, and Keep sends nothing.
## Checks actually run
```
dart format lib/features/runs/actions test/features/runs/actions # clean
flutter analyze # No issues found!
flutter test test/features/runs/actions # 40 passed
flutter test # 69 passed
flutter build web # Built build/web (14.5s)
```
## Honest limits
- **Not wired into a run-detail screen.** This branch has no runs screen or
controller; the manager owns that integration. There is no browser interaction
or rendered capture for this widget, and `flutter build web` proves compilation
only, not rendered behavior.
- Browser parity is by source/word/request-shape comparison with
`web/src/actions.js` and `web/src/repository.js`; the web client itself was not
changed and no live web retry was performed.
- **Mobile unverified.** No Android/iOS build, emulator, ADB or device was used.
- No real server or run was retried, canceled or otherwise mutated; all evidence
uses local fakes.
- The candidate is committed, not pushed or deployed.
@@ -0,0 +1,245 @@
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/core/api_gateway.dart';
import 'package:pipelines_app/features/runs/actions/retry_eligibility.dart';
import 'package:pipelines_app/features/runs/actions/retry_intent.dart';
import 'package:pipelines_app/features/runs/actions/retry_wording.dart';
import 'retry_test_support.dart';
void main() {
test('retry eligibility matches the web canRetry exactly', () {
final cases = <(String, JsonMap, bool)>[
('failed and stopped', failedRun(), true),
('failed but still executing', failedRun(executing: true), false),
('running', failedRun(status: 'running'), false),
('waiting', failedRun(status: 'waiting'), false),
('succeeded', failedRun(status: 'succeeded'), false),
('canceled', failedRun(status: 'canceled'), false),
];
for (final (label, run, expected) in cases) {
expect(canRetryRun(run), expected, reason: label);
}
expect(canRetryRun(null), isFalse);
expect(retryRunId(failedRun()), 7);
expect(retryRunId({'id': '7'}), isNull);
});
test('a generated retry key is bounded, run-scoped and fresh', () {
final first = newRetryRequestKey(7);
final second = newRetryRequestKey(7);
expect(first, startsWith('app-retry-7-'));
expect(first.length, lessThanOrEqualTo(128));
expect(second.length, lessThanOrEqualTo(128));
expect(first, isNot(second));
expect(
newRetryRequestKey(7, now: DateTime.utc(2026, 1, 1), random: 36),
'app-retry-7-${DateTime.utc(2026, 1, 1).microsecondsSinceEpoch}-10',
);
});
testWidgets(
'material retry asks first, Keep sends nothing, then omits retry_mode',
(tester) async {
final accepted = retriedRun();
final gateway = FakeRetryGateway(
(type, fields) async => {'run_detail': accepted},
);
final changed = <JsonMap>[];
await pumpRetry(tester, gateway: gateway, changed: changed);
expect(find.byKey(retryActionKey), findsOneWidget);
expect(find.byType(FilledButton), findsOneWidget);
expect(gateway.calls, isEmpty);
await tester.tap(find.byKey(retryActionKey));
await tester.pumpAndSettle();
expect(find.byType(AlertDialog), findsOneWidget);
expect(find.text(retryDialogTitle(7)), findsOneWidget);
expect(find.text(retryDialogMessage), findsOneWidget);
expect(
find.descendant(
of: find.byType(AlertDialog),
matching: find.text(retryConfirmLabel),
),
findsOneWidget,
);
expect(find.text(restartConfirmLabel), findsOneWidget);
expect(gateway.calls, isEmpty);
await tester.tap(find.byKey(retryKeepKey));
await tester.pumpAndSettle();
expect(find.byType(AlertDialog), findsNothing);
expect(find.byKey(retryActionKey), findsOneWidget);
expect(gateway.calls, isEmpty);
await tester.tap(find.byKey(retryActionKey));
await tester.pumpAndSettle();
await tester.tap(find.byKey(retryConfirmKey));
await tester.pumpAndSettle();
expect(gateway.retries, hasLength(1));
final fields = gateway.retries.single.fields;
expect(fields.keys, containsAll(<String>['run_id', 'request_key']));
expect(fields.containsKey('retry_mode'), isFalse);
expect(fields['run_id'], 7);
expect(fields['request_key'], startsWith('app-retry-7-'));
expect(fields['request_key'].length, lessThanOrEqualTo(128));
expect(changed.single, equals(accepted));
expect(find.byType(AlertDialog), findsNothing);
expect(find.byKey(retryActionKey), findsNothing);
},
);
testWidgets(
'material restart has its own confirmation and sends retry_mode',
(tester) async {
final accepted = retriedRun();
final gateway = FakeRetryGateway(
(type, fields) async => {'run_detail': accepted},
);
final changed = <JsonMap>[];
await pumpRetry(tester, gateway: gateway, changed: changed);
await tester.tap(find.byKey(retryActionKey));
await tester.pumpAndSettle();
await tester.tap(find.byKey(retryRestartKey));
await tester.pumpAndSettle();
expect(find.text(restartDialogTitle(7)), findsOneWidget);
expect(find.text(restartDialogMessage), findsOneWidget);
expect(find.text(retryDialogTitle(7)), findsNothing);
expect(find.text(retryDialogMessage), findsNothing);
expect(find.text(restartConfirmLabel), findsOneWidget);
expect(find.byKey(retryRestartKey), findsNothing);
expect(gateway.calls, isEmpty);
await tester.tap(find.byKey(retryConfirmKey));
await tester.pumpAndSettle();
expect(gateway.retries, hasLength(1));
final fields = gateway.retries.single.fields;
expect(fields['run_id'], 7);
expect(fields['retry_mode'], 'restart');
expect(fields['request_key'], startsWith('app-retry-7-'));
expect(changed.single, equals(accepted));
expect(find.byType(AlertDialog), findsNothing);
},
);
testWidgets(
'cupertino retry uses a native prompt and sends only on confirm',
(tester) async {
final accepted = retriedRun();
final gateway = FakeRetryGateway(
(type, fields) async => {'run_detail': accepted},
);
final changed = <JsonMap>[];
await pumpRetry(
tester,
gateway: gateway,
changed: changed,
cupertino: true,
);
expect(find.byKey(retryActionKey), findsOneWidget);
expect(find.byType(CupertinoButton), findsOneWidget);
expect(find.byType(FilledButton), findsNothing);
await tester.tap(find.byKey(retryActionKey));
await tester.pumpAndSettle();
expect(find.byType(CupertinoAlertDialog), findsOneWidget);
expect(find.byType(AlertDialog), findsNothing);
expect(find.text(retryDialogTitle(7)), findsOneWidget);
expect(find.text(retryDialogMessage), findsOneWidget);
expect(gateway.calls, isEmpty);
await tester.tap(find.byKey(retryKeepKey));
await tester.pumpAndSettle();
expect(gateway.calls, isEmpty);
expect(find.byType(CupertinoAlertDialog), findsNothing);
await tester.tap(find.byKey(retryActionKey));
await tester.pumpAndSettle();
await tester.tap(find.byKey(retryConfirmKey));
await tester.pumpAndSettle();
expect(gateway.retries, hasLength(1));
final fields = gateway.retries.single.fields;
expect(fields['run_id'], 7);
expect(fields.containsKey('retry_mode'), isFalse);
expect(fields['request_key'], startsWith('app-retry-7-'));
expect(changed.single, equals(accepted));
expect(find.byType(CupertinoAlertDialog), findsNothing);
},
);
testWidgets('cupertino restart switches to the restart confirmation', (
tester,
) async {
final gateway = FakeRetryGateway(
(type, fields) async => {'run_detail': retriedRun()},
);
await pumpRetry(
tester,
gateway: gateway,
changed: <JsonMap>[],
cupertino: true,
);
await tester.tap(find.byKey(retryActionKey));
await tester.pumpAndSettle();
await tester.tap(find.byKey(retryRestartKey));
await tester.pumpAndSettle();
expect(find.byType(CupertinoAlertDialog), findsOneWidget);
expect(find.text(restartDialogTitle(7)), findsOneWidget);
expect(find.text(restartDialogMessage), findsOneWidget);
expect(gateway.calls, isEmpty);
await tester.tap(find.byKey(retryConfirmKey));
await tester.pumpAndSettle();
expect(gateway.retries.single.fields['retry_mode'], 'restart');
});
testWidgets('the action is absent for runs the web does not retry', (
tester,
) async {
final gateway = FakeRetryGateway(
(type, fields) async => {'run_detail': retriedRun()},
);
final changed = <JsonMap>[];
final cases = <(String, JsonMap, bool)>[
('failed', failedRun(), true),
('executing', failedRun(executing: true), false),
('running', failedRun(status: 'running'), false),
('waiting', failedRun(status: 'waiting'), false),
('succeeded', failedRun(status: 'succeeded'), false),
('canceled', failedRun(status: 'canceled'), false),
];
for (final cupertino in [false, true]) {
for (final (label, run, visible) in cases) {
await tester.pumpWidget(
retryApp(
RetryHost(
key: ValueKey('$label-$cupertino'),
gateway: gateway,
initial: run,
changed: changed,
),
cupertino: cupertino,
),
);
expect(
find.byKey(retryActionKey),
visible ? findsOneWidget : findsNothing,
reason: '$label cupertino=$cupertino',
);
}
}
expect(gateway.calls, isEmpty);
expect(changed, isEmpty);
});
}
@@ -0,0 +1,223 @@
import 'dart:async';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/core/api_gateway.dart';
import 'package:pipelines_app/core/transport/connection_state.dart';
import 'package:pipelines_app/features/runs/actions/retry_eligibility.dart';
import 'package:pipelines_app/features/runs/actions/retry_wording.dart';
import 'retry_test_support.dart';
Future<void> _openAndConfirm(WidgetTester tester) async {
await tester.tap(find.byKey(retryActionKey));
await tester.pumpAndSettle();
await tester.tap(find.byKey(retryConfirmKey));
}
void main() {
testWidgets('a refusal is shown at once and Keep does not wait for resync', (
tester,
) async {
const refusal = 'run 7 is still executing; wait for it to stop completely';
final resync = Completer<JsonMap>();
final gateway = FakeRetryGateway((type, fields) {
if (type == 'retry_run') throw const ProtocolError(refusal);
return resync.future;
});
final changed = <JsonMap>[];
await pumpRetry(tester, gateway: gateway, changed: changed);
await _openAndConfirm(tester);
await tester.pump();
expect(gateway.calls.map((call) => call.type), ['retry_run', 'get_run']);
expect(find.text(refusal), findsOneWidget);
expect(find.byKey(retryErrorKey), findsOneWidget);
expect(
tester.widget<TextButton>(find.byKey(retryKeepKey)).onPressed,
isNotNull,
);
expect(
tester.widget<FilledButton>(find.byKey(retryConfirmKey)).onPressed,
isNull,
);
expect(changed, isEmpty);
await tester.tap(find.byKey(retryKeepKey));
await tester.pumpAndSettle();
expect(find.byType(AlertDialog), findsNothing);
resync.complete({'run_detail': failedRun(status: 'succeeded')});
await tester.pump();
await tester.pump();
expect(tester.takeException(), isNull);
expect(changed.single['status'], 'succeeded');
expect(find.byKey(retryActionKey), findsNothing);
});
testWidgets('server truth that is ineligible blocks a repeat action', (
tester,
) async {
const refusal = 'only failed runs can be retried';
final finished = failedRun(status: 'succeeded');
final gateway = FakeRetryGateway((type, fields) async {
if (type == 'retry_run') throw const ProtocolError(refusal);
return {'run_detail': finished};
});
final changed = <JsonMap>[];
await pumpRetry(tester, gateway: gateway, changed: changed);
await _openAndConfirm(tester);
await tester.pumpAndSettle();
expect(gateway.calls.map((call) => call.type), ['retry_run', 'get_run']);
expect(find.text(refusal), findsOneWidget);
expect(
tester.widget<FilledButton>(find.byKey(retryConfirmKey)).onPressed,
isNull,
);
expect(
tester.widget<TextButton>(find.byKey(retryKeepKey)).onPressed,
isNotNull,
);
await tester.tap(find.byKey(retryConfirmKey));
await tester.pump();
expect(gateway.calls.map((call) => call.type), ['retry_run', 'get_run']);
await tester.tap(find.byKey(retryKeepKey));
await tester.pumpAndSettle();
expect(find.byType(AlertDialog), findsNothing);
expect(find.byKey(retryActionKey), findsNothing);
expect(changed.single, equals(finished));
expect(canRetryRun(changed.single), isFalse);
});
testWidgets('a failed recheck keeps the same key for the uncertain request', (
tester,
) async {
const refusal = 'connection dropped while retrying';
var attempts = 0;
final gateway = FakeRetryGateway((type, fields) async {
if (type == 'get_run') throw const NotConnectedError();
attempts += 1;
if (attempts == 1) throw const ProtocolError(refusal);
return {'run_detail': retriedRun()};
});
final changed = <JsonMap>[];
await pumpRetry(tester, gateway: gateway, changed: changed);
await _openAndConfirm(tester);
await tester.pumpAndSettle();
expect(find.text(refusal), findsOneWidget);
expect(
tester.widget<FilledButton>(find.byKey(retryConfirmKey)).onPressed,
isNotNull,
);
expect(gateway.retries, hasLength(1));
await tester.tap(find.byKey(retryConfirmKey));
await tester.pumpAndSettle();
expect(gateway.retries, hasLength(2));
expect(
gateway.retries.last.fields['request_key'],
gateway.retries.first.fields['request_key'],
);
expect(
gateway.retries.every((call) => !call.fields.containsKey('retry_mode')),
isTrue,
);
expect(changed.single, equals(retriedRun()));
expect(find.byType(AlertDialog), findsNothing);
});
testWidgets('a restart retry keeps the mode and key across uncertainty', (
tester,
) async {
var attempts = 0;
final gateway = FakeRetryGateway((type, fields) async {
if (type == 'get_run') throw const NotConnectedError();
attempts += 1;
if (attempts == 1) throw const ProtocolError('network lost');
return {'run_detail': retriedRun()};
});
await pumpRetry(tester, gateway: gateway, changed: <JsonMap>[]);
await tester.tap(find.byKey(retryActionKey));
await tester.pumpAndSettle();
await tester.tap(find.byKey(retryRestartKey));
await tester.pumpAndSettle();
await tester.tap(find.byKey(retryConfirmKey));
await tester.pumpAndSettle();
await tester.tap(find.byKey(retryConfirmKey));
await tester.pumpAndSettle();
expect(gateway.retries, hasLength(2));
expect(gateway.retries.first.fields['retry_mode'], 'restart');
expect(gateway.retries.last.fields['retry_mode'], 'restart');
expect(
gateway.retries.last.fields['request_key'],
gateway.retries.first.fields['request_key'],
);
});
testWidgets('a deliberate reopen sends a fresh request key', (tester) async {
final gateway = FakeRetryGateway((type, fields) async {
if (type == 'get_run') throw const NotConnectedError();
throw const ProtocolError('server did not answer');
});
await pumpRetry(tester, gateway: gateway, changed: <JsonMap>[]);
await _openAndConfirm(tester);
await tester.pumpAndSettle();
await tester.tap(find.byKey(retryKeepKey));
await tester.pumpAndSettle();
await _openAndConfirm(tester);
await tester.pumpAndSettle();
expect(gateway.retries, hasLength(2));
expect(
gateway.retries.first.fields['request_key'],
isNot(gateway.retries.last.fields['request_key']),
);
});
testWidgets('a restart after a dismissed resume uses a fresh key', (
tester,
) async {
var attempts = 0;
final gateway = FakeRetryGateway((type, fields) async {
if (type == 'get_run') throw const NotConnectedError();
attempts += 1;
if (attempts == 1) throw const ProtocolError('resume refused');
return {'run_detail': retriedRun()};
});
await pumpRetry(tester, gateway: gateway, changed: <JsonMap>[]);
await _openAndConfirm(tester);
await tester.pumpAndSettle();
// A refusal leaves the prompt open; keep the mode frozen and dismiss.
await tester.tap(find.byKey(retryKeepKey));
await tester.pumpAndSettle();
await tester.tap(find.byKey(retryActionKey));
await tester.pumpAndSettle();
await tester.tap(find.byKey(retryRestartKey));
await tester.pumpAndSettle();
await tester.tap(find.byKey(retryConfirmKey));
await tester.pumpAndSettle();
expect(gateway.retries, hasLength(2));
expect(gateway.retries.first.fields.containsKey('retry_mode'), isFalse);
expect(gateway.retries.last.fields['retry_mode'], 'restart');
expect(
gateway.retries.first.fields['request_key'],
isNot(gateway.retries.last.fields['request_key']),
);
});
}
@@ -0,0 +1,133 @@
import 'dart:async';
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/core/api_gateway.dart';
import 'package:pipelines_app/core/transport/connection_state.dart';
import 'package:pipelines_app/features/runs/actions/retry_wording.dart';
import 'retry_test_support.dart';
void main() {
testWidgets('confirm cannot submit twice while the retry is in flight', (
tester,
) async {
final reply = Completer<JsonMap>();
final gateway = FakeRetryGateway((type, fields) => reply.future);
final changed = <JsonMap>[];
await pumpRetry(tester, gateway: gateway, changed: changed);
await tester.tap(find.byKey(retryActionKey));
await tester.pumpAndSettle();
final confirm = find.byKey(retryConfirmKey);
await tester.tap(confirm);
await tester.tap(confirm);
await tester.pump();
expect(gateway.retries, hasLength(1));
expect(
tester.widget<FilledButton>(find.byKey(retryConfirmKey)).onPressed,
isNull,
);
expect(
tester.widget<TextButton>(find.byKey(retryKeepKey)).onPressed,
isNull,
);
expect(find.byType(AlertDialog), findsOneWidget);
reply.complete({'run_detail': retriedRun()});
await tester.pumpAndSettle();
expect(find.byType(AlertDialog), findsNothing);
expect(changed, hasLength(1));
});
testWidgets('a late retry reply after disposal is ignored safely', (
tester,
) async {
final reply = Completer<JsonMap>();
final gateway = FakeRetryGateway((type, fields) => reply.future);
final changed = <JsonMap>[];
await pumpRetry(tester, gateway: gateway, changed: changed);
await tester.tap(find.byKey(retryActionKey));
await tester.pumpAndSettle();
await tester.tap(find.byKey(retryConfirmKey));
await tester.pump();
expect(gateway.retries, hasLength(1));
await tester.pumpWidget(const SizedBox());
reply.complete({'run_detail': retriedRun()});
await tester.pump();
expect(tester.takeException(), isNull);
expect(changed, isEmpty);
});
testWidgets('a late resync after disposal is ignored safely', (tester) async {
final resync = Completer<JsonMap>();
final gateway = FakeRetryGateway((type, fields) {
if (type == 'retry_run') throw const ProtocolError('refused');
return resync.future;
});
final changed = <JsonMap>[];
await pumpRetry(tester, gateway: gateway, changed: changed);
await tester.tap(find.byKey(retryActionKey));
await tester.pumpAndSettle();
await tester.tap(find.byKey(retryConfirmKey));
await tester.pump();
expect(gateway.calls.map((call) => call.type), ['retry_run', 'get_run']);
await tester.pumpWidget(const SizedBox());
resync.complete({'run_detail': retriedRun()});
await tester.pump();
expect(tester.takeException(), isNull);
expect(changed, isEmpty);
});
testWidgets('both confirmations fit 2x text at a narrow width', (
tester,
) async {
tester.view.physicalSize = const Size(320, 480);
tester.view.devicePixelRatio = 1;
addTearDown(tester.view.resetPhysicalSize);
addTearDown(tester.view.resetDevicePixelRatio);
for (final cupertino in [false, true]) {
final gateway = FakeRetryGateway(
(type, fields) async => {'run_detail': retriedRun()},
);
await pumpRetry(
tester,
gateway: gateway,
changed: <JsonMap>[],
cupertino: cupertino,
textScale: 2,
);
await tester.tap(find.byKey(retryActionKey));
await tester.pumpAndSettle();
expect(tester.takeException(), isNull, reason: 'cupertino=$cupertino');
expect(find.text(retryDialogTitle(7)), findsOneWidget);
expect(find.text(retryDialogMessage), findsOneWidget);
expect(
cupertino
? find.byType(CupertinoAlertDialog)
: find.byType(AlertDialog),
findsOneWidget,
);
await tester.tap(find.byKey(retryRestartKey));
await tester.pumpAndSettle();
expect(tester.takeException(), isNull, reason: 'restart=$cupertino');
expect(find.text(restartDialogTitle(7)), findsOneWidget);
expect(find.text(restartDialogMessage), findsOneWidget);
await tester.tap(find.byKey(retryKeepKey));
await tester.pumpAndSettle();
expect(gateway.calls, isEmpty);
}
});
}
@@ -0,0 +1,112 @@
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/core/api_gateway.dart';
import 'package:pipelines_app/features/runs/actions/retry_action.dart';
typedef RetryHandler = Future<JsonMap> Function(String type, JsonMap fields);
/// A fake gateway that records every request and never owns a socket.
class FakeRetryGateway implements ApiGateway {
FakeRetryGateway(this.handler);
final RetryHandler handler;
final List<({String type, JsonMap fields})> calls = [];
@override
Future<JsonMap> call(String type, [JsonMap fields = const {}]) {
final copy = Map<String, dynamic>.from(fields);
calls.add((type: type, fields: copy));
return handler(type, copy);
}
@override
Stream<JsonMap> get frames => const Stream.empty();
Iterable<({String type, JsonMap fields})> get retries =>
calls.where((call) => call.type == 'retry_run');
}
JsonMap failedRun({
num id = 7,
bool executing = false,
String status = 'failed',
String title = 'Nightly build',
}) => {'id': id, 'title': title, 'status': status, 'executing': executing};
JsonMap retriedRun({num id = 8}) =>
failedRun(id: id, status: 'running', executing: true, title: 'Retry of 7');
/// Owns the run like a run-detail screen would, so the callback's returned
/// server detail is what the action renders next.
class RetryHost extends StatefulWidget {
const RetryHost({
super.key,
required this.gateway,
required this.initial,
required this.changed,
});
final FakeRetryGateway gateway;
final JsonMap initial;
final List<JsonMap> changed;
@override
State<RetryHost> createState() => _RetryHostState();
}
class _RetryHostState extends State<RetryHost> {
late JsonMap _run = widget.initial;
@override
Widget build(BuildContext context) {
return RetryRunAction(
run: _run,
gateway: widget.gateway,
onRunChanged: (run) {
widget.changed.add(run);
setState(() => _run = run);
},
);
}
}
Widget retryApp(Widget child, {required bool cupertino, double textScale = 1}) {
Widget media(BuildContext context, Widget? app) => MediaQuery(
data: MediaQuery.of(
context,
).copyWith(textScaler: TextScaler.linear(textScale)),
child: app!,
);
if (cupertino) {
return CupertinoApp(
builder: media,
home: CupertinoPageScaffold(child: Center(child: child)),
);
}
return MaterialApp(
builder: media,
home: Scaffold(body: Center(child: child)),
);
}
Future<void> pumpRetry(
WidgetTester tester, {
required FakeRetryGateway gateway,
required List<JsonMap> changed,
bool cupertino = false,
double textScale = 1,
JsonMap? run,
}) async {
await tester.pumpWidget(
retryApp(
RetryHost(
gateway: gateway,
initial: run ?? failedRun(),
changed: changed,
),
cupertino: cupertino,
textScale: textScale,
),
);
}