feat(app): Rename and Schedule this run move into the run detail's more menu

This commit is contained in:
2026-10-23 16:10:20 +01:00
parent 9e2d3c558d
commit 13d293eb47
12 changed files with 264 additions and 170 deletions
+46 -33
View File
@@ -32,27 +32,19 @@ class RunTitleAction extends StatefulWidget {
class _RunTitleActionState extends State<RunTitleAction> {
bool _dialogOpen = false;
bool _saving = false;
bool _usesCupertino(BuildContext context) {
final material = Localizations.of<MaterialLocalizations>(
context,
MaterialLocalizations,
);
return material == null;
}
bool _usesCupertino(BuildContext context) => _cupertinoLocale(context);
Future<void> _open() async {
final id = runTitleId(widget.run);
if (id == null || _dialogOpen) return;
if (_dialogOpen) return;
_dialogOpen = true;
try {
await showRunTitlePrompt(
context: context,
runId: id,
initialTitle: storedRunTitle(widget.run),
cupertino: _usesCupertino(context),
onSubmit: (title) => _submit(id, title),
await openRunTitleEditor(
context,
run: widget.run,
gateway: widget.gateway,
onRunChanged: widget.onRunChanged,
owns: (id) => mounted && runTitleId(widget.run) == id,
);
} finally {
_dialogOpen = false;
@@ -60,23 +52,6 @@ class _RunTitleActionState extends State<RunTitleAction> {
}
}
Future<ActionRefusal?> _submit(num id, String title) async {
if (_saving) return const ActionRefusal(actionAlreadySending);
_saving = true;
try {
final run = await RunsRepository(widget.gateway).setRunTitle(id, title);
if (!mounted) return null;
if (_owns(id)) widget.onRunChanged(run);
return null;
} catch (error) {
return ActionRefusal(describeTitleError(error));
} finally {
_saving = false;
}
}
bool _owns(num id) => mounted && runTitleId(widget.run) == id;
@override
Widget build(BuildContext context) {
if (runTitleId(widget.run) == null) return const SizedBox.shrink();
@@ -96,6 +71,44 @@ class _RunTitleActionState extends State<RunTitleAction> {
}
}
bool _cupertinoLocale(BuildContext context) =>
Localizations.of<MaterialLocalizations>(context, MaterialLocalizations) ==
null;
/// Opens the rename prompt for [run]; only Save sends `set_run_title`, and the
/// server's returned detail reaches [onRunChanged] while [owns] still holds
/// for that run id. Shared by the button and the run detail's more menu.
Future<void> openRunTitleEditor(
BuildContext context, {
required JsonMap run,
required ApiGateway gateway,
required ValueChanged<JsonMap> onRunChanged,
required bool Function(num id) owns,
}) async {
final id = runTitleId(run);
if (id == null) return;
var saving = false;
await showRunTitlePrompt(
context: context,
runId: id,
initialTitle: storedRunTitle(run),
cupertino: _cupertinoLocale(context),
onSubmit: (title) async {
if (saving) return const ActionRefusal(actionAlreadySending);
saving = true;
try {
final updated = await RunsRepository(gateway).setRunTitle(id, title);
if (owns(id)) onRunChanged(updated);
return null;
} catch (error) {
return ActionRefusal(describeTitleError(error));
} finally {
saving = false;
}
},
);
}
/// The run id used by the rename request, or null for a malformed run.
num? runTitleId(JsonMap run) {
final id = run['id'];
@@ -2,12 +2,10 @@ import 'package:flutter/widgets.dart';
import '../../../core/api_gateway.dart';
import '../../artifacts/ui/artifact_gallery_action.dart';
import '../../schedules/ui/run/schedule_run_action.dart';
import '../actions/cancel_eligibility.dart';
import '../actions/cancel_run_action.dart';
import '../actions/retry_action.dart';
import '../actions/retry_eligibility.dart';
import '../actions/title_action.dart';
import 'run_decision_notice.dart';
/// Native actions on the loaded run, all using the app's one gateway and
@@ -47,14 +45,6 @@ class RunDetailActions extends StatelessWidget {
runSpacing: 4,
crossAxisAlignment: WrapCrossAlignment.center,
children: [
if (runTitleId(run) != null)
RunTitleAction(
run: run,
gateway: gateway,
onRunChanged: onRunChanged,
),
if (canScheduleRun(run))
ScheduleRunAction(run: run, gateway: gateway),
if (retry && retryRunId(run) != null && canRetryRun(run))
RetryRunAction(
run: run,
@@ -6,6 +6,7 @@ import '../domain/run_models.dart';
import 'run_changes_action.dart';
import 'run_detail_content.dart';
import 'run_detail_tabs.dart';
import 'run_more_menu.dart';
/// The runs detail with standard Cupertino controls. It has no Material
/// ancestor: the host header keeps native navigation, actions and notices, and
@@ -65,6 +66,12 @@ Widget buildCupertinoRunDetail({
),
if (showRunChangesAction(run)) RunChangesButton(run: run),
if (copying) const CupertinoActivityIndicator(),
RunMoreMenu(
run: run,
gateway: gateway,
onRunChanged: onRunChanged,
cupertino: true,
),
],
),
),
@@ -6,6 +6,7 @@ import '../domain/run_models.dart';
import 'run_changes_action.dart';
import 'run_detail_content.dart';
import 'run_detail_tabs.dart';
import 'run_more_menu.dart';
/// The runs detail with standard Material controls.
///
@@ -45,17 +46,30 @@ Widget buildMaterialRunDetail({
children: [
Padding(
padding: const EdgeInsets.fromLTRB(16, 8, 16, 0),
child: Wrap(
spacing: 8,
runSpacing: 4,
crossAxisAlignment: WrapCrossAlignment.center,
child: Row(
crossAxisAlignment: CrossAxisAlignment.start,
children: [
TextButton.icon(
onPressed: onBack,
icon: const Icon(Icons.arrow_back),
label: const Text('Back to list'),
Expanded(
child: Wrap(
spacing: 8,
runSpacing: 4,
crossAxisAlignment: WrapCrossAlignment.center,
children: [
TextButton.icon(
onPressed: onBack,
icon: const Icon(Icons.arrow_back),
label: const Text('Back to list'),
),
if (showRunChangesAction(run)) RunChangesButton(run: run),
],
),
),
RunMoreMenu(
run: run,
gateway: gateway,
onRunChanged: onRunChanged,
cupertino: false,
),
if (showRunChangesAction(run)) RunChangesButton(run: run),
],
),
),
+111
View File
@@ -0,0 +1,111 @@
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import '../../../core/api_gateway.dart';
import '../../schedules/ui/run/schedule_run_action.dart';
import '../actions/title_action.dart';
import '../actions/title_wording.dart';
const runMoreMenuKey = ValueKey<String>('run-more-menu');
/// Whether the run has anything for its more menu.
bool showRunMoreMenu(JsonMap run) =>
runTitleId(run) != null || canScheduleRun(run);
enum _RunMoreItem { rename, schedule }
/// The run detail's more menu: Rename and Schedule this run, which act on the
/// run's pipeline record rather than its progress, kept out of the header.
/// This widget stays mounted while a picked flow runs, so the flow's result
/// still reaches the current run.
class RunMoreMenu extends StatefulWidget {
const RunMoreMenu({
super.key,
required this.run,
required this.gateway,
required this.onRunChanged,
required this.cupertino,
});
final JsonMap run;
final ApiGateway gateway;
final ValueChanged<JsonMap> onRunChanged;
final bool cupertino;
@override
State<RunMoreMenu> createState() => _RunMoreMenuState();
}
class _RunMoreMenuState extends State<RunMoreMenu> {
JsonMap get run => widget.run;
List<(_RunMoreItem, String)> get _items => [
if (runTitleId(run) != null) (_RunMoreItem.rename, runTitleActionLabel),
if (canScheduleRun(run)) (_RunMoreItem.schedule, scheduleRunActionLabel),
];
void _pick(BuildContext context, _RunMoreItem item) {
switch (item) {
case _RunMoreItem.rename:
openRunTitleEditor(
context,
run: run,
gateway: widget.gateway,
onRunChanged: widget.onRunChanged,
// The latest run, so a result for a run no longer shown is dropped.
owns: (owned) => mounted && runTitleId(widget.run) == owned,
);
case _RunMoreItem.schedule:
openScheduleRunEditor(context, run: run, gateway: widget.gateway);
}
}
@override
Widget build(BuildContext context) {
final items = _items;
if (items.isEmpty) return const SizedBox.shrink();
if (!widget.cupertino) {
return PopupMenuButton<_RunMoreItem>(
key: runMoreMenuKey,
icon: const Icon(Icons.more_vert),
tooltip: 'More actions',
onSelected: (item) => _pick(context, item),
itemBuilder: (_) => [
for (final (item, label) in items)
PopupMenuItem(value: item, child: Text(label)),
],
);
}
return Semantics(
button: true,
label: 'More actions',
excludeSemantics: true,
child: CupertinoButton(
key: runMoreMenuKey,
padding: EdgeInsets.zero,
minimumSize: const Size.square(kMinInteractiveDimensionCupertino),
onPressed: () async {
final picked = await showCupertinoModalPopup<_RunMoreItem>(
context: context,
builder: (sheet) => CupertinoActionSheet(
actions: [
for (final (item, label) in items)
CupertinoActionSheetAction(
onPressed: () => Navigator.of(sheet).pop(item),
child: Text(label),
),
],
cancelButton: CupertinoActionSheetAction(
isDefaultAction: true,
onPressed: () => Navigator.of(sheet).pop(),
child: const Text('Cancel'),
),
),
);
if (picked != null && context.mounted) _pick(context, picked);
},
child: const Icon(CupertinoIcons.ellipsis_circle),
),
);
}
}
@@ -23,6 +23,25 @@ bool canScheduleRun(JsonMap run) =>
bool _positive(int? value) => value != null && value > 0;
/// Opens the create editor over [ScheduleDraft.fromRun]; nothing is sent until
/// Save. One request key is minted per opening, so retrying a refused save
/// cannot create a duplicate. Shared by the button and the run's more menu.
Future<void> openScheduleRunEditor(
BuildContext context, {
required JsonMap run,
required ApiGateway gateway,
}) async {
if (!canScheduleRun(run)) return;
final requestKey = newScheduleCreateRequestKey();
final repository = SchedulesRepository(gateway);
await openSchedulePipelineEditor(
context,
draft: ScheduleDraft.fromRun(run),
onSubmit: (record) =>
repository.saveSchedule(record, requestKey: requestKey),
);
}
/// The run detail's "Schedule this run" action.
///
/// Pressing it only opens the landed create editor over [ScheduleDraft.fromRun]:
@@ -49,17 +68,13 @@ class _ScheduleRunActionState extends State<ScheduleRunAction> {
bool _opening = false;
Future<void> _open() async {
if (_opening || !canScheduleRun(widget.run)) return;
if (_opening) return;
_opening = true;
// Minted once for this editor; every retry inside it reuses the key.
final requestKey = newScheduleCreateRequestKey();
final repository = SchedulesRepository(widget.gateway);
try {
await openSchedulePipelineEditor(
await openScheduleRunEditor(
context,
draft: ScheduleDraft.fromRun(widget.run),
onSubmit: (record) =>
repository.saveSchedule(record, requestKey: requestKey),
run: widget.run,
gateway: widget.gateway,
);
} finally {
_opening = false;
@@ -1,7 +1,7 @@
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/features/runs/ui/run_more_menu.dart';
import 'package:pipelines_app/features/graph/widgets/run_graph_view.dart';
import 'package:pipelines_app/features/runs/actions/title_wording.dart';
import 'package:pipelines_app/features/runs/ui/run_detail_tab.dart';
import 'package:pipelines_app/features/runs/ui/run_detail_tab_strip.dart';
@@ -36,7 +36,7 @@ void main() {
expect(center.dx, greaterThan(previous));
previous = center.dx;
}
expect(find.byKey(runTitleActionKey), findsOneWidget);
expect(find.byKey(runMoreMenuKey), findsOneWidget);
// The strip lines up with the header's 16px inset on both hosts: the
// first label sits within its segment's own padding of that inset, not
// behind a second 16px control inset (which put it at 48 on Cupertino).
@@ -48,7 +48,7 @@ void main() {
RunDetailTab.summary,
]) {
await openRunDetailTab(tester, tab);
expect(find.byKey(runTitleActionKey), findsOneWidget);
expect(find.byKey(runMoreMenuKey), findsOneWidget);
expect(find.text('Graph run'), findsOneWidget);
}
});
@@ -1,8 +1,8 @@
import 'package:flutter/widgets.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/features/runs/ui/run_more_menu.dart';
import 'package:pipelines_app/core/transport/connection_state.dart';
import 'package:pipelines_app/features/runs/actions/retry_wording.dart';
import 'package:pipelines_app/features/runs/actions/title_wording.dart';
import 'run_retry_wiring_support.dart';
@@ -108,7 +108,7 @@ void main() {
addTearDown(gateway.framesController.close);
await mountRetryScreen(tester, gateway, cupertino: false);
expect(find.byKey(runTitleActionKey), findsOneWidget);
expect(find.byKey(runMoreMenuKey), findsOneWidget);
expect(find.byKey(retryActionKey), findsNothing);
});
}
@@ -3,13 +3,12 @@ import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/features/runs/actions/cancel_wording.dart';
import 'package:pipelines_app/features/runs/actions/retry_wording.dart';
import 'package:pipelines_app/features/runs/actions/title_wording.dart';
import 'package:pipelines_app/features/runs/ui/run_detail_actions.dart';
import 'run_retry_wiring_support.dart';
void main() {
testWidgets('a hidden retry adds no extra gap for Rename and Cancel', (
testWidgets('a hidden retry adds no leading gap before Cancel', (
tester,
) async {
final gateway = RetryWiringGateway();
@@ -32,45 +31,13 @@ void main() {
// Retry is not eligible on the running run and must not consume spacing.
expect(find.byKey(retryActionKey), findsNothing);
final rename = tester.getRect(find.byKey(runTitleActionKey));
// Rename lives in the more menu; Cancel now leads the row.
final cancel = tester.getRect(find.byKey(cancelActionKey));
expect(cancel.left - rename.right, closeTo(8, 0.5));
expect(cancel.left, closeTo(16, 0.5));
});
for (final cupertino in [false, true]) {
testWidgets('adjacent actions keep native spacing at 320 px ($cupertino)', (
tester,
) async {
tester.view.physicalSize = const Size(320, 480);
tester.view.devicePixelRatio = 1;
addTearDown(tester.view.resetPhysicalSize);
addTearDown(tester.view.resetDevicePixelRatio);
final gateway = RetryWiringGateway();
addTearDown(gateway.framesController.close);
final row = Padding(
padding: const EdgeInsets.all(16),
child: RunDetailActions(
run: retryFailedDetail(),
gateway: gateway,
onRunChanged: (_) {},
),
);
await tester.pumpWidget(
cupertino
? CupertinoApp(
home: CupertinoPageScaffold(child: SafeArea(child: row)),
)
: MaterialApp(home: Scaffold(body: row)),
);
await tester.pumpAndSettle();
expectNativeActionSpacing(tester);
});
}
for (final cupertino in [false, true]) {
testWidgets('320 px at 2x keeps Rename and Retry reachable ($cupertino)', (
testWidgets('320 px at 2x keeps Retry reachable ($cupertino)', (
tester,
) async {
tester.view.physicalSize = const Size(320, 480);
@@ -109,12 +76,10 @@ void main() {
);
await tester.pumpAndSettle();
expect(find.byKey(runTitleActionKey).hitTestable(), findsOneWidget);
expect(find.byKey(retryActionKey).hitTestable(), findsOneWidget);
final rect = tester.getRect(find.byKey(retryActionKey));
expect(rect.left, greaterThanOrEqualTo(0));
expect(rect.right, lessThanOrEqualTo(320));
expectNativeActionSpacing(tester);
await tester.tap(find.byKey(retryActionKey));
await tester.pumpAndSettle();
@@ -125,27 +90,3 @@ void main() {
});
}
}
/// Asserts the action row uses the detail's native 8 dp / 4 dp spacing.
///
/// The row previously had no `spacing`, leaving the outlined Rename border
/// touching the filled Retry button; browser measurement at 320 px reported a
/// 0.008 px gap. A hidden action must not consume spacing either.
void expectNativeActionSpacing(WidgetTester tester) {
final rename = tester.getRect(find.byKey(runTitleActionKey));
final retry = tester.getRect(find.byKey(retryActionKey));
final sameRow = retry.top < rename.bottom && rename.top < retry.bottom;
if (sameRow) {
expect(
retry.left - rename.right,
greaterThanOrEqualTo(8 - 0.01),
reason: 'side-by-side actions need the 8 dp Wrap spacing',
);
} else {
expect(
retry.top - rename.bottom,
greaterThanOrEqualTo(4 - 0.01),
reason: 'wrapped actions need the 4 dp Wrap run spacing',
);
}
}
@@ -1,7 +1,7 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/features/runs/ui/run_more_menu.dart';
import 'package:pipelines_app/features/runs/actions/cancel_wording.dart';
import 'package:pipelines_app/features/runs/actions/retry_wording.dart';
import 'package:pipelines_app/features/runs/actions/title_wording.dart';
import 'run_retry_wiring_support.dart';
@@ -21,7 +21,7 @@ void main() {
);
expect(find.text(retryFailedTitle), findsOneWidget);
expect(find.byKey(runTitleActionKey), findsOneWidget);
expect(find.byKey(runMoreMenuKey), findsOneWidget);
expect(find.byKey(retryActionKey), findsOneWidget);
expect(find.byKey(cancelActionKey), findsNothing);
expect(gateway.retryCalls, isEmpty);
@@ -3,6 +3,7 @@ import 'dart:async';
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/features/runs/ui/run_more_menu.dart';
import 'package:pipelines_app/core/api_gateway.dart';
import 'package:pipelines_app/core/transport/connection_state.dart';
import 'package:pipelines_app/features/runs/actions/title_wording.dart';
@@ -86,18 +87,24 @@ String _fieldText(WidgetTester tester, {required bool cupertino}) => cupertino
.text
: tester.widget<TextField>(find.byKey(runTitleFieldKey)).controller!.text;
/// Rename lives in the run detail's more menu.
Future<void> _openRename(WidgetTester tester) async {
await tester.tap(find.byKey(runMoreMenuKey));
await tester.pumpAndSettle();
await tester.tap(find.text(runTitleActionLabel).last);
await tester.pumpAndSettle();
}
void main() {
testWidgets('material detail renames through the shared gateway and folds '
'only the server reply into the detail and list', (tester) async {
final gateway = await _mount(tester, cupertino: false);
expect(find.text('Nightly build'), findsOneWidget);
expect(find.byKey(runTitleActionKey), findsOneWidget);
expect(find.byType(OutlinedButton), findsOneWidget);
expect(find.byKey(runMoreMenuKey), findsOneWidget);
expect(gateway.saves, isEmpty);
await tester.tap(find.byKey(runTitleActionKey));
await tester.pumpAndSettle();
await _openRename(tester);
expect(find.byType(AlertDialog), findsOneWidget);
expect(_fieldText(tester, cupertino: false), 'Nightly build');
@@ -109,8 +116,7 @@ void main() {
expect(gateway.saves, isEmpty);
expect(find.text('Nightly build'), findsOneWidget);
await tester.tap(find.byKey(runTitleActionKey));
await tester.pumpAndSettle();
await _openRename(tester);
await tester.enterText(find.byKey(runTitleFieldKey), ' Release build ');
await tester.tap(find.byKey(runTitleSaveKey));
await tester.pump();
@@ -139,11 +145,9 @@ void main() {
) async {
final gateway = await _mount(tester, cupertino: true);
expect(find.byKey(runTitleActionKey), findsOneWidget);
expect(find.byType(OutlinedButton), findsNothing);
expect(find.byKey(runMoreMenuKey), findsOneWidget);
await tester.tap(find.byKey(runTitleActionKey));
await tester.pumpAndSettle();
await _openRename(tester);
expect(find.byType(CupertinoAlertDialog), findsOneWidget);
expect(find.byType(AlertDialog), findsNothing);
@@ -166,8 +170,7 @@ void main() {
) async {
final gateway = await _mount(tester, cupertino: false);
await tester.tap(find.byKey(runTitleActionKey));
await tester.pumpAndSettle();
await _openRename(tester);
await tester.enterText(find.byKey(runTitleFieldKey), ' locked ');
await tester.tap(find.byKey(runTitleSaveKey));
await tester.pump();
@@ -3,7 +3,7 @@ import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/core/api_gateway.dart';
import 'package:pipelines_app/core/transport/connection_state.dart';
import 'package:pipelines_app/features/runs/ui/run_detail_actions.dart';
import 'package:pipelines_app/features/runs/ui/run_more_menu.dart';
import 'package:pipelines_app/features/schedules/ui/editor/schedule_editor_wording.dart';
import 'package:pipelines_app/features/schedules/ui/run/schedule_run_action.dart';
@@ -194,36 +194,36 @@ void main() {
tester,
) async {
final gateway = SaveGateway();
await pumpAction(
tester,
RunDetailActions(
run: runFixture(),
gateway: gateway,
onRunChanged: (_) {},
),
);
expect(find.byKey(scheduleRunActionKey), findsOneWidget);
// The run detail offers it from its more menu, beside Rename.
Future<void> openMenu(JsonMap run) async {
await pumpAction(
tester,
RunMoreMenu(
run: run,
gateway: gateway,
onRunChanged: (_) {},
cupertino: false,
),
);
// A run with nothing to offer shows no menu at all.
if (find.byKey(runMoreMenuKey).evaluate().isEmpty) return;
await tester.tap(find.byKey(runMoreMenuKey));
await tester.pumpAndSettle();
}
await openMenu(runFixture());
expect(find.text(scheduleRunActionLabel), findsOneWidget);
await tester.tap(find.text(scheduleRunActionLabel));
await tester.pumpAndSettle();
expect(find.byKey(scheduleEditorSubmitKey), findsOneWidget);
expect(gateway.calls, isEmpty);
await tester.pumpWidget(const SizedBox.shrink());
await pumpAction(
tester,
RunDetailActions(
run: runFixture(version: 0),
gateway: gateway,
onRunChanged: (_) {},
),
);
expect(find.byKey(scheduleRunActionKey), findsNothing);
await openMenu(runFixture(version: 0));
expect(find.text(scheduleRunActionLabel), findsNothing);
await pumpAction(
tester,
RunDetailActions(
run: runFixture(pipelineId: null),
gateway: gateway,
onRunChanged: (_) {},
),
);
expect(find.byKey(scheduleRunActionKey), findsNothing);
await openMenu(runFixture(pipelineId: null));
expect(find.text(scheduleRunActionLabel), findsNothing);
});
testWidgets('Cupertino uses the native action and fields', (tester) async {