android: correct omni-search IME docs to the declared adjustResize mode
The soft-input comments in the manifest, PipelinesApp.kt and android/README.md still described `adjustNothing`, a mode the activity no longer declares. MainActivity uses `android:windowSoftInputMode="adjustResize"` and the app draws edge-to-edge, so the Compose window inset (WindowInsets.safeDrawing) is the single source of the IME geometry and is applied once by the surface that owns it. - AndroidManifest.xml: rewrite the soft-input comment to describe adjustResize, why the app is edge-to-edge and reads the IME from Compose window insets, and warn against changing it without re-checking the chat composer. - PipelinesApp.kt: correct the bottom search column comment that claimed the activity declares adjustNothing and the window is never resized for the IME. - android/README.md: correct the omni-search results-panel section that claimed the IME inset was counted once because of adjustNothing; now records the declared adjustResize mode, the edge-to-edge single source of IME geometry, and the chat composer's imePadding. Documentation only; no rendered surface or behaviour changes. The omni-search entry point and pill morph already exist at this HEAD; this reconciles the stale wording with the committed mode.
This commit is contained in:
+3
-1
@@ -4258,7 +4258,9 @@ section left the panel itself undocumented.
|
||||
(`WindowInsets.safeDrawing`, which carries the IME and the navigation bar); the
|
||||
panel takes the remaining height with `weight(1f, fill = false)` and scrolls
|
||||
its `LazyColumn` inside it, so it is never under the field or the keyboard. The
|
||||
activity declares `adjustNothing`, so the IME inset is counted once, not twice.
|
||||
activity declares `adjustResize` and the app is edge-to-edge, so the Compose
|
||||
window inset is the only source of the IME geometry and it is applied once,
|
||||
here (the chat composer likewise reads it once, through `imePadding`).
|
||||
- **Badge, title, secondary line.** `OmniSearchResults.searchRow` gives every hit
|
||||
a `pipeline`/`run`/`step`/`artifact`/`match` badge (`searchBadge`, a version hit
|
||||
reads as `pipeline`), a title and a secondary line; a text ("field") hit's
|
||||
|
||||
@@ -19,13 +19,12 @@
|
||||
the user types an arbitrary host. Do not expose the server to the internet.
|
||||
-->
|
||||
<!--
|
||||
adjustNothing: the app reads the IME from the Compose window insets
|
||||
(paneSafeArea / WindowInsets.safeDrawing) everywhere, so the window
|
||||
must not also be resized or panned for the soft input. The default
|
||||
(adjustUnspecified) resized the window on the Pixel 10 Pro Fold for
|
||||
the omni-search field, which is not inside a scrollable parent, and
|
||||
the field then cleared the IME twice (once by the window resize, once
|
||||
by the Compose inset) and floated above the keyboard.
|
||||
adjustResize: the app is drawn edge-to-edge (enableEdgeToEdge), so it
|
||||
reads the IME from the Compose window insets (paneSafeArea /
|
||||
WindowInsets.safeDrawing) and applies it once in the surface that owns
|
||||
it. Both the omni-search field and the chat composer (imePadding) sit
|
||||
directly above the keyboard. This is the mode the chat UI was reviewed
|
||||
with; re-check that composer before changing it to adjustNothing.
|
||||
-->
|
||||
<activity
|
||||
android:name=".MainActivity"
|
||||
|
||||
@@ -298,9 +298,9 @@ fun PipelinesApp(vm: AppViewModel) {
|
||||
// applied once here: the panel then takes exactly the height the IME and
|
||||
// navigation bar leave (weight, `fill = false` so a short panel wraps)
|
||||
// and scrolls inside it, and the input always sits directly below the
|
||||
// panel and above the keyboard. This is the only place the IME is
|
||||
// cleared because the activity declares `adjustNothing`: the window is
|
||||
// never resized for the IME, so the inset below is not counted twice.
|
||||
// panel and above the keyboard. The activity declares `adjustResize`
|
||||
// and the app is edge-to-edge, so the Compose window inset is the only
|
||||
// source of the IME geometry and it is applied once, here.
|
||||
Column(
|
||||
modifier = Modifier
|
||||
.fillMaxSize()
|
||||
|
||||
Reference in New Issue
Block a user