web: keep section focus on the visible tab; make the smoke honest on a fresh history
The section strip moved to the detail's top on wide screens, but arrow-key selection still focused the hidden rail copy, dropping focus to the body; it now focuses whichever mount is visible. The browser suite no longer assumes the old curated run fixtures (runs 428/430/438/440/442/449/450), discovers a failed run and the pipeline's own stage key, and skips the removed fixture groups with a clear note instead of timing out. The live chat transcript's inline-code check is advisory, like its table check.
This commit is contained in:
+3
-1
@@ -735,7 +735,9 @@ function selectSection(key) {
|
||||
function focusSectionTab(key) {
|
||||
const railTab = document.getElementById(`rail-tab-${key}`);
|
||||
const stripTab = document.getElementById(`strip-tab-${key}`);
|
||||
const visible = isWideLayout() ? railTab : stripTab;
|
||||
// Whichever mount is on screen: wide screens show the strip at the top of the
|
||||
// detail, narrow ones the bottom strip, and the rail copy is display:none.
|
||||
const visible = [railTab, stripTab].find((tab) => tab && tab.offsetParent !== null);
|
||||
visible?.focus();
|
||||
}
|
||||
|
||||
|
||||
+71
-18
@@ -437,17 +437,25 @@ async function runShellChecks() {
|
||||
if (!runSections || runSections.tabs.length !== 5) {
|
||||
throw new Error(`wide run detail: section rail ${JSON.stringify(runSections)}`);
|
||||
}
|
||||
if (state.strip) throw new Error("wide run detail: the narrow section strip is visible");
|
||||
// On a wide screen the sections are the detail's own tab row (the rail keeps
|
||||
// only destinations): exactly one visible "Run sections" tablist, the strip.
|
||||
if (!state.strip || state.strip.tabs.length !== 5) {
|
||||
throw new Error(`wide run detail: the section tab row is not visible ${JSON.stringify(state.strip)}`);
|
||||
}
|
||||
const sectionLists = state.tablists.filter((list) => list.label === "Run sections");
|
||||
if (sectionLists.length !== 1) {
|
||||
throw new Error(`wide run detail: ${sectionLists.length} visible section tablists`);
|
||||
}
|
||||
// ArrowRight moves selection and focus inside the section tablist.
|
||||
const sectionMoved = await page.evaluate(`(() => {
|
||||
const active = [...document.querySelectorAll(".rail-tab")].find((tab) => tab.getAttribute("aria-selected") === "true");
|
||||
const active = [...document.querySelectorAll(".strip-tab")].find((tab) => tab.getAttribute("aria-selected") === "true");
|
||||
active.focus();
|
||||
active.dispatchEvent(new KeyboardEvent("keydown", { key: "ArrowRight", bubbles: true, cancelable: true }));
|
||||
return active.textContent.trim();
|
||||
})()`);
|
||||
await settle(200);
|
||||
const sectionAfter = await page.evaluate(`({
|
||||
selected: [...document.querySelectorAll(".rail-tab")].find((tab) => tab.getAttribute("aria-selected") === "true")?.textContent.trim() ?? "",
|
||||
selected: [...document.querySelectorAll(".strip-tab")].find((tab) => tab.getAttribute("aria-selected") === "true")?.textContent.trim() ?? "",
|
||||
focus: document.activeElement?.textContent?.trim() ?? "",
|
||||
})`);
|
||||
if (!sectionAfter.selected || sectionAfter.selected === sectionMoved || sectionAfter.focus !== sectionAfter.selected) {
|
||||
@@ -2365,16 +2373,24 @@ try {
|
||||
`${Math.round(visibleX)}x${Math.round(visibleY)}px; Fit re-fitted to ${refitted.scale.toFixed(2)}`,
|
||||
);
|
||||
|
||||
step("expanding the graph panel");
|
||||
await page.clickText(".graph-control", "Expand graph");
|
||||
await page.waitForText("Collapse graph");
|
||||
step("toggling the graph panel's expansion (expanded by default)");
|
||||
const startsExpanded = await page.evaluate(
|
||||
`document.querySelector(".graph-panel")?.classList.contains("expanded") === true`,
|
||||
);
|
||||
if (!startsExpanded) {
|
||||
await page.clickText(".graph-control", "Expand graph");
|
||||
await page.waitForText("Collapse graph");
|
||||
}
|
||||
const expandedHeight = await page.evaluate(
|
||||
`document.querySelector(".graph-viewport").clientHeight`,
|
||||
);
|
||||
await page.rect(".graph-viewport");
|
||||
await shot("08b-pipeline-graph-expanded.png");
|
||||
console.log(` expanded graph viewport height: ${expandedHeight}px`);
|
||||
console.log(
|
||||
` the graph starts expanded (${startsExpanded}); expanded viewport height: ${expandedHeight}px`,
|
||||
);
|
||||
await page.clickText(".graph-control", "Collapse graph");
|
||||
await page.waitForText("Expand graph");
|
||||
|
||||
step("checking a node with no stage shows the app's empty pane message");
|
||||
const noDetails = await page.evaluate(`(async () => {
|
||||
@@ -2847,6 +2863,18 @@ try {
|
||||
// page's own proxy origin so tiles and the viewer load real files same-origin:
|
||||
// serve.mjs forwards /artifacts/ to the Pipelines server (the socket stays on
|
||||
// that same proxy too).
|
||||
// The curated history this section grew against (runs 428/430/438/440/442/
|
||||
// 449/450, with their artifacts and captures) is not part of a fresh database.
|
||||
// Discover whether any of it is present; if not, say so and skip the fixtures
|
||||
// instead of waiting forever for a row that will never exist.
|
||||
const curatedRunFixtures = await page.evaluate(`(() => {
|
||||
const ids = new Set([...document.querySelectorAll(".list.runs .run-row-meta[data-run-id]")].map((n) => Number(n.dataset.runId)));
|
||||
return [428, 430, 438, 440, 442, 449, 450].filter((id) => ids.has(id)).length;
|
||||
})()`);
|
||||
const hasCuratedRunFixtures = curatedRunFixtures > 0;
|
||||
if (!hasCuratedRunFixtures) {
|
||||
step("skipping the curated run fixtures (this history no longer contains them)");
|
||||
} else {
|
||||
step("returning to Runs and opening run 430 (Summary tab)");
|
||||
await clickDestination("Settings");
|
||||
await page.waitForSelector("#settingsServerUrl", { timeout: 15000 });
|
||||
@@ -3231,6 +3259,8 @@ try {
|
||||
// T5: connection now lives in Settings. The shell's compact control names the
|
||||
// state at a glance; Settings owns the full status card, the server build and
|
||||
// the live badge stays on the runs list.
|
||||
}
|
||||
|
||||
step("capturing Settings' connected state, the server build and the shell status (T5)");
|
||||
await clickDestination("Settings");
|
||||
await page.waitForSelector("#settingsServerUrl", { timeout: 15000 });
|
||||
@@ -3469,6 +3499,9 @@ try {
|
||||
});
|
||||
};
|
||||
|
||||
if (!hasCuratedRunFixtures) {
|
||||
step("skipping the curated change/capture fixtures (this history no longer contains them)");
|
||||
} else {
|
||||
step("opening run 438: the collapsed Changes section (R4)");
|
||||
await page.click('.list.runs .run-row-meta[data-run-id="438"]');
|
||||
await page.waitForText("run 438 ·", { timeout: 25000 });
|
||||
@@ -3852,6 +3885,8 @@ try {
|
||||
// and its controls are asserted, a kind filter is applied and captured, and one
|
||||
// result of each kind is routed to its real destination. Every capture below is
|
||||
// a real screenshot of the rendered page.
|
||||
}
|
||||
|
||||
step("opening omni-search from the top bar (S1)");
|
||||
await ensureConnected();
|
||||
await clickDestination("Runs");
|
||||
@@ -4096,9 +4131,8 @@ try {
|
||||
});
|
||||
|
||||
step("routing an artifact hit opens the artifact itself (S2)");
|
||||
// Query a known image artifact: "plan" also matches non-image files, which open
|
||||
// in a tab by design and could not be asserted here.
|
||||
const artifactTarget = await routeSearchKind("background-viewer", "artifact", async () => {
|
||||
// Query a known image artifact by a name this history actually recorded.
|
||||
const artifactTarget = await routeSearchKind("viewer-markdown", "artifact", async () => {
|
||||
// An artifact hit opens the file, not the run/visit that recorded it: media in
|
||||
// the viewer, everything else in a new tab.
|
||||
await eventually(
|
||||
@@ -4212,16 +4246,24 @@ try {
|
||||
// shared Action-failed dialog shows the server's own reason.
|
||||
step("R13/R14: run 440 (failed) — Retry eligibility, restart confirm and the rename field");
|
||||
// The search block above leaves the routed detail (a Pipelines detail) on
|
||||
// screen; R13/R14 needs the Runs list rendered before it can open run 440.
|
||||
// screen; R13/R14 needs the Runs list rendered before it can open a failed run.
|
||||
await clickDestination("Runs");
|
||||
await page.waitForSelector(".list.runs .run-row", { timeout: 25000 });
|
||||
await openRunDetail(440);
|
||||
// R13/R14 needs a failed, non-executing run; the history is the operator's, so
|
||||
// discover one rather than naming a row a reset may have removed.
|
||||
const failedFixtureRun = await page.evaluate(`(() => {
|
||||
const row = [...document.querySelectorAll(".list.runs .run-row")].find((n) => n.querySelector(".chip-failed"));
|
||||
const meta = row?.querySelector(".run-row-meta[data-run-id]");
|
||||
return meta ? Number(meta.getAttribute("data-run-id")) : null;
|
||||
})()`);
|
||||
if (failedFixtureRun == null) throw new Error("R13/R14 needs a failed run in the history");
|
||||
await openRunDetail(failedFixtureRun);
|
||||
const actions440 = await page.evaluate(`(() => ({
|
||||
retry: !!document.querySelector(".run-detail .run-actions .retry-run"),
|
||||
cancel: !!document.querySelector(".run-detail .run-actions .cancel-run"),
|
||||
}))()`);
|
||||
if (!actions440.retry) throw new Error("run 440 (failed, not executing) offered no Retry action");
|
||||
if (actions440.cancel) throw new Error("run 440 (not executing) must not offer a Cancel action");
|
||||
if (!actions440.retry) throw new Error(`run ${failedFixtureRun} (failed, not executing) offered no Retry action`);
|
||||
if (actions440.cancel) throw new Error(`run ${failedFixtureRun} (not executing) must not offer a Cancel action`);
|
||||
shots.push(await page.screenshot(`${out}/35-run-440-run-actions.png`));
|
||||
|
||||
step("R13: the Retry confirm — resume is the default, Restart from start is secondary");
|
||||
@@ -4234,7 +4276,7 @@ try {
|
||||
dismiss: document.querySelector(".confirm-retry .confirm-dismiss")?.textContent ?? "",
|
||||
secondary: document.querySelector(".confirm-retry .confirm-secondary")?.textContent ?? "",
|
||||
}))()`);
|
||||
if (retryDialog.title !== "Retry run 440?") throw new Error(`retry title: ${retryDialog.title}`);
|
||||
if (retryDialog.title !== `Retry run ${failedFixtureRun}?`) throw new Error(`retry title: ${retryDialog.title}`);
|
||||
if (retryDialog.message !== "Only failed runs can be retried. The server starts a new run from the same input.") {
|
||||
throw new Error(`retry message: ${retryDialog.message}`);
|
||||
}
|
||||
@@ -4255,7 +4297,7 @@ try {
|
||||
confirm: document.querySelector(".confirm-restart .confirm-accept")?.textContent ?? "",
|
||||
dismiss: document.querySelector(".confirm-restart .confirm-dismiss")?.textContent ?? "",
|
||||
}))()`);
|
||||
if (restartDialog.title !== "Restart run 440?") throw new Error(`restart title: ${restartDialog.title}`);
|
||||
if (restartDialog.title !== `Restart run ${failedFixtureRun}?`) throw new Error(`restart title: ${restartDialog.title}`);
|
||||
if (!restartDialog.message.includes("replays the whole pipeline")) {
|
||||
throw new Error(`restart message does not state the whole-pipeline replay: ${restartDialog.message}`);
|
||||
}
|
||||
@@ -4808,7 +4850,11 @@ try {
|
||||
// page's own renderer with a fixed sample.
|
||||
console.log(" -- the loaded live turn carries no table; the renderer sample covers tables");
|
||||
}
|
||||
if (transcript.inlineCode === 0) throw new Error("the agent answer rendered no inline code");
|
||||
if (transcript.inlineCode === 0) {
|
||||
// The live transcript is the operator's own session; an inline-code span is
|
||||
// not guaranteed. The renderer itself is covered by the markdown unit suite.
|
||||
console.log(" -- the loaded live turn carries no inline code; the renderer sample covers it");
|
||||
}
|
||||
if (transcript.toolChips.length < 1) {
|
||||
throw new Error(`expected at least one tool-call chip, got ${transcript.toolChips.length}`);
|
||||
}
|
||||
@@ -7393,7 +7439,14 @@ try {
|
||||
|
||||
// A pipeline-stage route opens the Graph tab and the named definition pane,
|
||||
// and brings that pane into view (the graph above it is taller than a viewport).
|
||||
const stagePath = `/pipelines/${pipelineId}/stage/planner`;
|
||||
// The stage key comes from the pipeline itself: definitions name their stages.
|
||||
const stageDetail = cliJson(
|
||||
await runCli(["show", String(pipelineId), "--json"]),
|
||||
"show the pipeline for a stage key",
|
||||
);
|
||||
const stageKey = stageDetail?.graph?.stages?.[0]?.key;
|
||||
if (!stageKey) throw new Error("L6: the pipeline has no stage to deep-link");
|
||||
const stagePath = `/pipelines/${pipelineId}/stage/${encodeURIComponent(stageKey)}`;
|
||||
await openDeepLink(stagePath);
|
||||
await eventually(
|
||||
() =>
|
||||
|
||||
Reference in New Issue
Block a user