5e2aece1be
The pipelines list (and every other run-state view) kept the row it had when the screen was last fetched. Two class-level root causes, fixed here: - The app subscribed to run events scoped to the one workspace the operator configured, so a run executing in another workspace (a lane worktree is its own workspace) never delivered a frame: the rows only changed on a manual refresh. The app now asks for the blank "any workspace" scope the server already treats as any (ALL_WORKSPACES in AppViewModel.subscribeRuns, blank default on PipelinesRepository.subscribeRuns). Workspace isolation on the server is unchanged: an explicit workspace scope still matches only that workspace (TestRunEventWorkspaceIsolation); the new TestRunEventAllWorkspacesSubscription pins the blank "any" scope. - foldRunEvent refused to insert a run the list had never held, returning needsResync and leaving the list untouched, so a run started after the screen loaded appeared only after a fetch. The pushed frame now carries the pipeline identity a row needs (RunEventFrame.PipelineID/Name/Title/Version), so the fold inserts the new run at the head from the frame's own identity without a fetch and without reordering existing rows; a server that predates those fields still falls back to the one resync. Added fields and why each is needed: pipeline_id (row's pipeline join), name (row title), title (the stored operator-facing title a row shows), version (the row's pinned version) - everything a RunSummary row renders, so no per-event fetch and no guess from stale cache. The server stamps them on every emitted frame from a per-run identity remembered at create/decide/cancel/resume (runner.go runIdentity/rememberRunIdentity/stampRunIdentity), first-write-wins through the coalescer (mergeRunEventFrame) and on the subscribe snapshot, so every transition - created/queued, running, each stage start/finish, terminal - carries them. Reconnect still resyncs once then follows pushes; the pull-to-refresh path is untouched. Checks run: go build ./..., go vet ./..., go test ./... (all packages ok), go test -race -run 'RunEvent|RunEvents|Subscribe' ./internal/protocol/ ./internal/server/, and gradle --no-daemon testDebugUnitTest assembleDebug (558 tests, 0 failures, 0 skipped; BUILD SUCCESSFUL). Packaged templates and the packaged authoring skill references were checked: nothing there describes the run_event field list or the client's subscription scope, so neither needs updating (references/notifications.md only says the attention surface is derived from the pushed run events, which is unchanged). Docs are a shared file owned by a single writer and were not edited: docs/cli.md's description of the pushed `run_event` frame still enumerates only the older fields (status, outcome, current stage, completed-step count, timestamps, optional step) and is now incomplete - it should mention the pipeline identity fields; docs/ntfy.md remains accurate.
60 lines
2.8 KiB
Go
60 lines
2.8 KiB
Go
package protocol
|
|
|
|
// Server-pushed run state. A client sends subscribe (scoped to the workspace and
|
|
// optionally to explicit run ids) to ask for the runs it displays: the server
|
|
// first returns the current state of those runs so a reconnecting client
|
|
// re-syncs, then pushes a compact run_event delta on every meaningful
|
|
// transition. It sends unsubscribe to stop. Like chat_event, run_event is a
|
|
// server-pushed frame with no matching request, so both fields are optional and
|
|
// older peers ignore them.
|
|
const (
|
|
Subscribe = "subscribe"
|
|
Unsubscribe = "unsubscribe"
|
|
RunEvent = "run_event"
|
|
)
|
|
|
|
// RunEventFrame is the server-pushed run_event delta. It carries only the values
|
|
// that changed, never the whole run: the run's identity, status, outcome, current
|
|
// stage, completed-step count and timestamps, plus at most one changed step.
|
|
// Every field is optional so an older peer ignores what it does not know and a
|
|
// client can fold the frame into its cached run.
|
|
//
|
|
// PipelineID, Name, Title and Version are the pipeline identity and stored title
|
|
// a list row shows, so a client that has never held the run can insert its row
|
|
// from the frame instead of re-reading the whole list. They repeat on every
|
|
// frame (pipeline identity never changes mid-run).
|
|
type RunEventFrame struct {
|
|
RunID int64 `json:"run_id"`
|
|
Workspace string `json:"workspace,omitempty"`
|
|
// PipelineID, Name, Title and Version identify the run's pipeline and its
|
|
// operator-facing title, so a new run's row can be built without a fetch.
|
|
PipelineID int64 `json:"pipeline_id,omitempty"`
|
|
Name string `json:"name,omitempty"`
|
|
Title string `json:"title,omitempty"`
|
|
Version int `json:"version,omitempty"`
|
|
Status string `json:"status,omitempty"`
|
|
Outcome string `json:"outcome,omitempty"`
|
|
CurrentStage string `json:"current_stage,omitempty"`
|
|
CompletedSteps int `json:"completed_steps,omitempty"`
|
|
CreatedAt string `json:"created_at,omitempty"`
|
|
FinishedAt string `json:"finished_at,omitempty"`
|
|
// Artifacts is the number of files recorded for the referenced step, so a
|
|
// client can surface artifact capture without reading the step.
|
|
Artifacts int `json:"artifacts,omitempty"`
|
|
// Step is present when a single step changed (started, finished or waiting).
|
|
Step *RunStepDelta `json:"step,omitempty"`
|
|
}
|
|
|
|
// RunStepDelta is the compact change of one step within a RunEventFrame. It is a
|
|
// delta, not a RunStep: it omits the input/output, transcript, file changes and
|
|
// artifact bytes a full step carries.
|
|
type RunStepDelta struct {
|
|
Sequence int `json:"sequence"`
|
|
Stage string `json:"stage,omitempty"`
|
|
Status string `json:"status,omitempty"`
|
|
Outcome string `json:"outcome,omitempty"`
|
|
Target string `json:"target,omitempty"`
|
|
Diagnostic string `json:"diagnostic,omitempty"`
|
|
Artifacts int `json:"artifacts,omitempty"`
|
|
}
|