5834b9c504
Add subtle outlineVariant hairlines around the centered chat column so its boundary remains clear without changing the reading width or split layout. Cover light and dark center-stage visibility with focused widget and geometry tests.
2.0 KiB
2.0 KiB
Center stage column edges
Change
- In center stage (Alt+E / Option+E), the centred chat column had no visible boundary: its neighbours are strips or the workspace background, so the column's end read as unfinished.
- Added two 1px
outlineVarianthairlines (ChatCenterStageEdgesinapp/lib/features/chat/workspace/chat_center_stage_edges.dart). Each sits centred in the 12px gap beside the stage, or on the workspace edge when the stage reaches it. - Painted from
chat_workspace_surface.dart, only while a stage layout exists. The split layout, phone/collapsed layouts and single-chat workspaces draw nothing new. - Reading width is unchanged (stage stays
chatCenterStageWidth, 950 at the test size). The lines travel with the stage's animated rectangle.
Focused results
tool/memwatch/full.sh 'test/features/chat/workspace/chat_center_stage_test.dart'→ PASS: 21 passed, 0 failed, 0 skipped; peak 893 MB; 8s; exit 0. New tests among them:the stage edges sit in the gaps beside the stage, or on the workspace edgecenter stage draws the column edges in the light theme, only on stagecenter stage draws the column edges in the dark theme, only on stage
tool/analyze.sh→ clean, exit 0.- Not run: other
test/features/chat/workspace/*files useChatWorkspacewithoutcenterStageon stage, so the new branch is not reached there. The land gate runs the suites.
Affected states (code-level only)
- Center stage on, 3 panes, light and dark: both hairlines present, colour is
the theme's
outlineVariant. - Center stage off: no hairlines (asserted in both themes).
- Stage with a neighbour on each side (gaps) and stage at a workspace edge (line on the edge) are both covered by the geometry test.
Limitations
- No browser or device capture was made;
ui-reviewowns visual evidence. Visual weight of a 1pxoutlineVariantline in light and dark is unverified. - Hairlines hide at once when leaving center stage (same as the split dividers); they do not fade.