3e0b1e55c7
Expose the existing shortcut help as a global Ctrl+?/Cmd+? cheatsheet while preserving Ctrl+/ search behavior. Register the current shortcuts and cover composer, terminal, layout, and close interactions with focused tests.
2.9 KiB
2.9 KiB
Ctrl+? keyboard shortcuts cheatsheet
Ctrl+? (Cmd+? on macOS) opens the keyboard shortcuts help as a cheatsheet from any destination, from a focused chat composer and from floating windows. Ctrl+? or Escape closes it. Ctrl+/ still opens Search.
Chord rules
shell/shell_cheatsheet_shortcut.dart: primary modifier (Ctrl, or Cmd on macOS, as Search uses), no Alt, KeyDown only. Matches the logical?key or?character, or the slash key with Shift (US layout).- Ctrl+/ without Shift is unchanged: Search. Search's matcher already rejects Shift, so Ctrl+Shift+/ never opens Search.
- The terminal keeps the chord while it has the keyboard
(
primaryFocusIsTypingSurface(), the chat shell terminal'sTypingSurface). - Labels:
Cmd+?, Ctrl+?on macOS (the matcher accepts both, as Search's labels do),Ctrl+?elsewhere.
Shell wiring
shell/shell_cheatsheet.dartowns open/close. A token guards against a second pop; dismissal by barrier or close button clears it.shell/adaptive_shell.dartchecks the chord and Escape before the chat, Search and list handlers. The rest of the handler is unchanged.
Help page
- Entries carry a group: Navigation, Chat, Windows, Terminal, Lists.
- Wide dialogs (content at least 520 px) split the groups into two balanced columns; phone sheets stack them.
- Registry audit, added since the last help version: Ctrl+?, Esc to leave
Search, Esc Esc to stop a chat, pane focus and move chords, the Ctrl+Tab
pane cycle (not on web), divider and transcript arrows, slash-command arrows,
terminal copy/paste/select-all, terminal panel arrows, list pane arrows and
viewer Left/Right. The window-cycle entry now reads
Alt+\``,Alt+Shift+`(it wasAlt+`` with Shift).
Focused tests (memwatch, 4 files, 27 passed, 0 failed)
test/shell/shell_cheatsheet_shortcut_test.dart: matcher cases (US and other layouts, Ctrl+/ vs Ctrl+?, Ctrl+Shift+/ not Search, Alt and key-up rejected, macOS Cmd/Ctrl).test/shell/shell_cheatsheet_test.dart: opens from another destination and from a focused composer on macOS and Windows; Ctrl+/ still opens Search; Ctrl+Shift+/ opens the cheatsheet and not Search; ignored while a terminal (TypingSurface) has focus, with the key reaching it; Escape and a second Ctrl+? close it.test/features/settings/keyboard_shortcuts_cheatsheet_test.dart: every implemented action appears once per platform, group coverage, Ctrl+? label, pane/terminal chord labels, web tab-entry exclusion, two columns wide, one column narrow.test/features/settings/keyboard_shortcuts_help_test.dart(existing, expectations unchanged): passes.
tool/analyze.sh: clean.
Not verified here
- No UI capture or device run (ui-review owns it). Widget tests use synthetic key events; real Mac, Windows and non-US keyboard delivery is unverified.
- Phone bottom sheet and two-column wide layout are only checked by widget layout tests, not by captures.