04ba81e0ea
Keep chat and folder-picker UI on the Material path by removing obsolete Cupertino imports, icon metadata, flags, and alternate control handling while preserving existing behavior and focused test coverage.
358 lines
12 KiB
Dart
358 lines
12 KiB
Dart
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:pipelines_app/features/chat/conversation/chat_bar_control_style.dart';
|
|
import 'package:pipelines_app/features/chat/conversation/chat_thread_view.dart';
|
|
import 'package:pipelines_app/features/chat/conversation/chat_thread_header.dart';
|
|
import 'package:pipelines_app/features/chat/conversation/chat_sidebar_controls.dart';
|
|
import 'package:pipelines_app/features/chat/ui/sessions/chat_adaptive.dart';
|
|
import 'package:pipelines_app/ui/adaptive/segmented_bar.dart';
|
|
|
|
import '../../../native_back.dart';
|
|
import 'chat_thread_fixtures.dart';
|
|
|
|
const _title = 'A conversation title long enough to need an ellipsis at 320px';
|
|
const _session = <String, dynamic>{
|
|
'id': 's',
|
|
'backend': 'opencode',
|
|
'model': 'provider/an-extremely-long-recorded-model-id',
|
|
'model_provider': 'p1',
|
|
};
|
|
|
|
Widget _host(Widget child) => MaterialApp(
|
|
theme: ThemeData(platform: TargetPlatform.android),
|
|
home: Scaffold(body: child),
|
|
);
|
|
|
|
void _useNarrowText(WidgetTester tester) {
|
|
tester.view.physicalSize = const Size(320, 640);
|
|
tester.view.devicePixelRatio = 1;
|
|
tester.platformDispatcher.textScaleFactorTestValue = 2;
|
|
addTearDown(tester.view.resetPhysicalSize);
|
|
addTearDown(tester.view.resetDevicePixelRatio);
|
|
addTearDown(tester.platformDispatcher.clearTextScaleFactorTestValue);
|
|
}
|
|
|
|
void main() {
|
|
testWidgets('wide header uses one explicit control gap', (tester) async {
|
|
tester.view.physicalSize = const Size(1440, 900);
|
|
tester.view.devicePixelRatio = 1;
|
|
addTearDown(tester.view.resetPhysicalSize);
|
|
addTearDown(tester.view.resetDevicePixelRatio);
|
|
|
|
Widget control(String key) =>
|
|
SizedBox(key: Key(key), width: 48, height: 48);
|
|
|
|
await tester.pumpWidget(
|
|
_host(
|
|
ChatThreadHeader(
|
|
title: 'Chat',
|
|
folder: 'demo',
|
|
onInfo: () {},
|
|
controls: [control('header-control-1'), control('header-control-2')],
|
|
actions: [control('header-action-1'), control('header-action-2')],
|
|
moreActions: [
|
|
ChatBarAction(
|
|
label: 'More action',
|
|
onPressed: () {},
|
|
materialIcon: Icons.more_horiz,
|
|
),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
double gap(String left, String right) =>
|
|
tester.getTopLeft(find.byKey(Key(right))).dx -
|
|
tester.getTopRight(find.byKey(Key(left))).dx;
|
|
|
|
expect(gap('header-control-1', 'header-control-2'), 8);
|
|
expect(gap('header-control-2', 'header-action-1'), 8);
|
|
expect(gap('header-action-1', 'header-action-2'), 8);
|
|
expect(
|
|
tester.getTopLeft(find.byKey(segmentedMoreKey).first).dx -
|
|
tester.getTopRight(find.byKey(const Key('header-action-2'))).dx,
|
|
8,
|
|
);
|
|
});
|
|
|
|
testWidgets('short large-text header keeps controls in its single row', (
|
|
tester,
|
|
) async {
|
|
_useNarrowText(tester);
|
|
await tester.pumpWidget(
|
|
_host(
|
|
Align(
|
|
alignment: Alignment.topLeft,
|
|
child: SizedBox(
|
|
width: 320,
|
|
height: 100,
|
|
child: ChatThreadHeader(
|
|
title: _title,
|
|
folder: 'demo',
|
|
onInfo: () {},
|
|
showBack: true,
|
|
onBack: () {},
|
|
controls: const [
|
|
IconButton(onPressed: null, icon: Icon(Icons.memory_outlined)),
|
|
IconButton(onPressed: null, icon: Icon(Icons.shield_outlined)),
|
|
],
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
expect(tester.takeException(), isNull);
|
|
expect(
|
|
find.byKey(const Key('chat-model-permission-island')),
|
|
findsOneWidget,
|
|
);
|
|
expect(tester.takeException(), isNull);
|
|
});
|
|
|
|
testWidgets(
|
|
'Material narrow header keeps native back/title and compact model icon',
|
|
(tester) async {
|
|
_useNarrowText(tester);
|
|
final semantics = tester.ensureSemantics();
|
|
final gateway = FakeChatGateway();
|
|
addTearDown(gateway.close);
|
|
gateway.history = (_) async => chatPage(const []);
|
|
gateway.subscribe = () async => const {};
|
|
var backed = 0;
|
|
|
|
await tester.pumpWidget(
|
|
_host(
|
|
ChatThreadView(
|
|
gateway: gateway,
|
|
sessionId: 's',
|
|
title: _title,
|
|
session: _session,
|
|
onBack: () => backed++,
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
final title = find.text(_title);
|
|
final model = find.byKey(const Key('chat-model'));
|
|
final info = find.byKey(const Key('chat-info'));
|
|
final back = find.byKey(const Key('chat-back'));
|
|
expect(title, findsOneWidget);
|
|
expect(model, findsOneWidget);
|
|
expect(info, findsOneWidget);
|
|
expect(back, findsOneWidget);
|
|
expect(tester.takeException(), isNull);
|
|
// Back is the platform's own control, as on every other page.
|
|
expect(
|
|
find.descendant(of: back, matching: findNativeBack()),
|
|
findsOneWidget,
|
|
);
|
|
|
|
// One floating row of separate pieces: the round Back, the title pill
|
|
// (which is the information control and holds the title), then the
|
|
// selector island in the trailing row.
|
|
double centerY(Finder finder) => tester.getCenter(finder).dy;
|
|
expect((centerY(back) - centerY(info)).abs(), lessThan(16));
|
|
expect((centerY(model) - centerY(info)).abs(), lessThan(16));
|
|
expect(find.descendant(of: info, matching: title), findsOneWidget);
|
|
double right(Finder finder) => tester.getTopRight(finder).dx;
|
|
expect(right(back), lessThanOrEqualTo(tester.getTopLeft(info).dx));
|
|
expect(find.byIcon(Icons.memory_outlined), findsOneWidget);
|
|
final modelSemantics = tester.getSemantics(model);
|
|
expect(modelSemantics.label, contains('Change model'));
|
|
expect(modelSemantics.label, contains('currently'));
|
|
expect(
|
|
find.textContaining('an-extremely-long-recorded-model-id'),
|
|
findsNothing,
|
|
);
|
|
|
|
await tester.tap(back);
|
|
await tester.pump();
|
|
expect(backed, 1);
|
|
semantics.dispose();
|
|
},
|
|
);
|
|
|
|
// The mode control is Material only.
|
|
for (final width in [320.0, 390.0, 1280.0]) {
|
|
testWidgets('grouped actions at $width and text scale 2', (tester) async {
|
|
_useNarrowText(tester);
|
|
tester.view.physicalSize = Size(width, 800);
|
|
final gateway = FakeChatGateway();
|
|
addTearDown(gateway.close);
|
|
gateway.history = (_) async => chatPage(const []);
|
|
gateway.subscribe = () async => const {};
|
|
var sidebar = 0;
|
|
var pane = 0;
|
|
var next = 0;
|
|
await tester.pumpWidget(
|
|
_host(
|
|
ChatThreadView(
|
|
gateway: gateway,
|
|
sessionId: 's',
|
|
title: _title,
|
|
session: {
|
|
..._session,
|
|
'mode': 'safe',
|
|
'mode_name': 'Ask before making changes',
|
|
},
|
|
onBack: () {},
|
|
onNextChat: () => next++,
|
|
sidebarControl: ChatBarAction(
|
|
label: 'Sidebar action',
|
|
onPressed: () => sidebar++,
|
|
materialIcon: Icons.menu,
|
|
),
|
|
paneControls: [
|
|
ChatBarAction(
|
|
label: 'Pane action',
|
|
onPressed: () => pane++,
|
|
materialIcon: Icons.add_box,
|
|
),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
final selectors = find.byKey(const Key('chat-model-permission-island'));
|
|
final actions = find.byKey(const Key('chat-actions-island'));
|
|
expect(selectors, findsOneWidget);
|
|
expect(actions, findsOneWidget);
|
|
expect(
|
|
(tester.getCenter(selectors).dy - tester.getCenter(actions).dy).abs(),
|
|
lessThan(16),
|
|
);
|
|
expect(find.byKey(const Key('chat-next')), findsNothing);
|
|
expect(find.text('Next chat'), findsNothing);
|
|
expect(find.byKey(const Key('chat-model')), findsOneWidget);
|
|
expect(find.byKey(const Key('chat-mode')), findsOneWidget);
|
|
if (width < 600) {
|
|
expect(find.text('model-a'), findsNothing);
|
|
expect(find.text('Ask before making changes'), findsNothing);
|
|
expect(find.byIcon(Icons.memory_outlined), findsOneWidget);
|
|
expect(find.byIcon(Icons.shield_outlined), findsOneWidget);
|
|
expect(
|
|
tester.getSemantics(find.byKey(const Key('chat-model'))).label,
|
|
contains('Change model, currently'),
|
|
);
|
|
expect(
|
|
tester.getSemantics(find.byKey(const Key('chat-mode'))).label,
|
|
contains('Change mode, currently'),
|
|
);
|
|
expect(
|
|
(tester.getCenter(selectors).dy - tester.getCenter(actions).dy).abs(),
|
|
lessThan(16),
|
|
);
|
|
}
|
|
for (final key in ['chat-model', 'chat-mode']) {
|
|
expect(
|
|
tester.getSize(find.byKey(Key(key))).width,
|
|
greaterThanOrEqualTo(48),
|
|
);
|
|
}
|
|
expect(find.text('Sidebar action'), findsNothing);
|
|
expect(find.text('Pane action'), findsNothing);
|
|
expect(tester.takeException(), isNull);
|
|
// Both More entries retain their original callbacks in native menus.
|
|
await tester.tap(find.byKey(segmentedMoreKey).hitTestable());
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(find.text('Sidebar action'));
|
|
await tester.pumpAndSettle();
|
|
expect(sidebar, 1);
|
|
await tester.tap(find.byKey(segmentedMoreKey).hitTestable());
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(find.text('Pane action'));
|
|
await tester.pumpAndSettle();
|
|
expect(pane, 1);
|
|
expect(next, 0);
|
|
expect(tester.takeException(), isNull);
|
|
});
|
|
}
|
|
|
|
testWidgets('sidebar layout submenu retains callback on Material', (
|
|
tester,
|
|
) async {
|
|
ChatSidebarMode? picked;
|
|
await tester.pumpWidget(
|
|
_host(
|
|
ChatThreadHeader(
|
|
title: 'Chat',
|
|
folder: 'demo',
|
|
onInfo: () {},
|
|
actions: const [Icon(Icons.folder_outlined)],
|
|
moreActions: [
|
|
ChatSidebarButton(
|
|
mode: ChatSidebarMode.expanded,
|
|
onChanged: (value) => picked = value,
|
|
),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
expect(find.byType(ChatSidebarButton), findsNothing);
|
|
await tester.tap(find.byKey(segmentedMoreKey).hitTestable());
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(find.text('Chat list layout'));
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(find.text('Hide chat list'));
|
|
await tester.pumpAndSettle();
|
|
expect(picked, ChatSidebarMode.hidden);
|
|
expect(tester.takeException(), isNull);
|
|
});
|
|
|
|
testWidgets('a conversation without a model keeps the same compact row', (
|
|
tester,
|
|
) async {
|
|
_useNarrowText(tester);
|
|
final gateway = FakeChatGateway();
|
|
addTearDown(gateway.close);
|
|
gateway.history = (_) async => chatPage(const []);
|
|
gateway.subscribe = () async => const {};
|
|
|
|
await tester.pumpWidget(
|
|
_host(
|
|
ChatThreadView(
|
|
gateway: gateway,
|
|
sessionId: 's',
|
|
title: _title,
|
|
session: {..._session, 'backend': 'other'},
|
|
onBack: () {},
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text(_title), findsOneWidget);
|
|
expect(find.byKey(const Key('chat-model')), findsNothing);
|
|
expect(
|
|
(tester.getCenter(find.byKey(const Key('chat-info'))).dy -
|
|
tester.getCenter(find.text(_title)).dy)
|
|
.abs(),
|
|
lessThan(16),
|
|
);
|
|
expect(tester.takeException(), isNull);
|
|
});
|
|
|
|
testWidgets('wide bar text buttons keep their text off the shape ends', (
|
|
tester,
|
|
) async {
|
|
late ButtonStyle wide;
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: Builder(
|
|
builder: (context) {
|
|
wide = chatBarTextButtonStyle(context);
|
|
return const SizedBox();
|
|
},
|
|
),
|
|
),
|
|
);
|
|
expect(wide.padding?.resolve({}), chatBarButtonPadding);
|
|
expect(chatBarButtonPadding.left, 12);
|
|
expect(chatBarButtonPadding.right, 12);
|
|
});
|
|
}
|