3136e5bb7e
Replace the tabbed Settings flow with a single grouped page that searches and lazily loads server-backed sections. Preserve existing settings behavior while adding inline loading and retry states and updating coverage for the new navigation model.
178 lines
6.6 KiB
Dart
178 lines
6.6 KiB
Dart
import '../features/settings/settings_section_test_helper.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:pipelines_app/application/pipelines_app.dart';
|
|
import 'package:pipelines_app/core/transport/pipelines_client.dart';
|
|
import 'package:pipelines_app/features/settings/settings_screen.dart';
|
|
import 'package:pipelines_app/ui/adaptive/floating_destination_bar.dart';
|
|
import 'package:shared_preferences/shared_preferences.dart';
|
|
|
|
import '../bar_action.dart';
|
|
import '../core/transport/pipelines_client_test.dart' show FakeChannel;
|
|
import '../features/pipelines/fixtures.dart';
|
|
import 'pipelines_app_test.dart' show webServer;
|
|
import 'pipelines_replies.dart';
|
|
|
|
/// Settings is not a tab: it opens as a page (from the gear in the Pipelines
|
|
/// bar on a phone, from the rail's foot on a wide window), keeps its
|
|
/// `/settings` route (and deep link), and closes back to Pipelines. The tab bar keeps Pipelines selected meanwhile.
|
|
void main() {
|
|
Future<PlatformRouteInformationProvider> pumpApp(
|
|
WidgetTester tester, {
|
|
required String location,
|
|
required Size size,
|
|
}) async {
|
|
SharedPreferences.setMockInitialValues({});
|
|
tester.view.physicalSize = size;
|
|
tester.view.devicePixelRatio = 1;
|
|
addTearDown(tester.view.reset);
|
|
final channel = FakeChannel()..readyCompleter.complete();
|
|
final provider = PlatformRouteInformationProvider(
|
|
initialRouteInformation: RouteInformation(uri: Uri.parse(location)),
|
|
);
|
|
addTearDown(provider.dispose);
|
|
await tester.pumpWidget(
|
|
PipelinesApp(
|
|
androidSupported: false,
|
|
server: webServer(),
|
|
client: PipelinesClient(channelFactory: (_) => channel),
|
|
routeInformationProvider: provider,
|
|
),
|
|
);
|
|
await tester.pump();
|
|
if (location == '/pipelines') {
|
|
await replyPipelines(tester, channel, PipelineFixture());
|
|
}
|
|
return provider;
|
|
}
|
|
|
|
int selectedTab(WidgetTester tester) => tester
|
|
.widget<FloatingDestinationBar>(find.byType(FloatingDestinationBar))
|
|
.currentIndex;
|
|
|
|
// A phone's Pipelines bar keeps the gear; a wide window's rail offers
|
|
// Settings instead (see the wide test below).
|
|
for (final size in [const Size(390, 844)]) {
|
|
testWidgets('${size.width}: the Pipelines bar gear opens Settings '
|
|
'as a page and Back returns', (tester) async {
|
|
final provider = await pumpApp(
|
|
tester,
|
|
location: '/pipelines',
|
|
size: size,
|
|
);
|
|
// Four tabs; Settings is none of them.
|
|
expect(
|
|
tester
|
|
.widget<FloatingDestinationBar>(find.byType(FloatingDestinationBar))
|
|
.items
|
|
.map((item) => item.label),
|
|
['Pipelines', 'Runs', 'Chat', 'Search'],
|
|
);
|
|
expect(
|
|
find.byKey(const ValueKey('shell.destination.settings')),
|
|
findsNothing,
|
|
);
|
|
expect(find.byKey(const ValueKey('shell.back')), findsNothing);
|
|
|
|
await tapBarAction(
|
|
tester,
|
|
find.byKey(const Key('pipelines-open-settings')),
|
|
'Settings',
|
|
);
|
|
await tester.pump();
|
|
await tester.pump();
|
|
expect(provider.value.uri.path, '/settings');
|
|
expect(find.byType(SettingsScreen), findsOneWidget);
|
|
expect(find.text('Quick switch animation'), findsOneWidget);
|
|
await openSettingsSection(tester, 'Connection');
|
|
expect(find.text('Server URL'), findsOneWidget);
|
|
// A page of Pipelines: Back in its bar, Pipelines still selected.
|
|
expect(find.byKey(const ValueKey('shell.back')), findsOneWidget);
|
|
expect(find.byKey(const ValueKey('shell.search')), findsNothing);
|
|
expect(selectedTab(tester), 0);
|
|
expect(tester.takeException(), isNull);
|
|
|
|
await tester.tap(find.byKey(const ValueKey('shell.back')));
|
|
await tester.pump();
|
|
await tester.pump();
|
|
expect(provider.value.uri.path, '/pipelines');
|
|
expect(find.byKey(const Key('pipelines-open-settings')), findsWidgets);
|
|
expect(find.byKey(const ValueKey('shell.back')), findsNothing);
|
|
await tester.pumpWidget(const SizedBox.shrink());
|
|
await tester.pump();
|
|
});
|
|
}
|
|
|
|
testWidgets('1200: the rail offers Settings at its foot and no gear is '
|
|
'left in the Pipelines toolbar; Settings is a page and Back returns', (
|
|
tester,
|
|
) async {
|
|
final provider = await pumpApp(
|
|
tester,
|
|
location: '/pipelines',
|
|
size: const Size(1200, 800),
|
|
);
|
|
expect(find.byType(NavigationRail), findsOneWidget);
|
|
expect(find.byKey(const Key('pipelines-open-settings')), findsNothing);
|
|
expect(find.byType(FloatingDestinationBar), findsNothing);
|
|
final rail = tester.widget<NavigationRail>(find.byType(NavigationRail));
|
|
expect(rail.selectedIndex, 0);
|
|
for (final label in ['Pipelines', 'Runs', 'Chat', 'Search', 'Settings']) {
|
|
expect(
|
|
find.descendant(
|
|
of: find.byType(NavigationRail),
|
|
matching: find.text(label),
|
|
),
|
|
findsOneWidget,
|
|
reason: label,
|
|
);
|
|
}
|
|
|
|
await tester.tap(find.byKey(const ValueKey('shell.destination.settings')));
|
|
await tester.pump();
|
|
await tester.pump();
|
|
expect(provider.value.uri.path, '/settings');
|
|
expect(find.byType(SettingsScreen), findsOneWidget);
|
|
// Settings is a page of Pipelines: the rail marks Settings, not a tab.
|
|
expect(
|
|
tester.widget<NavigationRail>(find.byType(NavigationRail)).selectedIndex,
|
|
isNull,
|
|
);
|
|
expect(find.byKey(const ValueKey('shell.back')), findsOneWidget);
|
|
expect(tester.takeException(), isNull);
|
|
|
|
await tester.tap(find.byKey(const ValueKey('shell.back')));
|
|
await tester.pump();
|
|
await tester.pump();
|
|
expect(provider.value.uri.path, '/pipelines');
|
|
expect(find.byKey(const Key('pipelines-open-settings')), findsNothing);
|
|
expect(
|
|
tester.widget<NavigationRail>(find.byType(NavigationRail)).selectedIndex,
|
|
0,
|
|
);
|
|
await tester.pumpWidget(const SizedBox.shrink());
|
|
await tester.pump();
|
|
});
|
|
|
|
testWidgets('the /settings deep link opens the Settings page and '
|
|
'the system Back closes it to Pipelines', (tester) async {
|
|
final provider = await pumpApp(
|
|
tester,
|
|
location: '/settings',
|
|
size: const Size(390, 844),
|
|
);
|
|
await tester.pump();
|
|
expect(find.byType(SettingsScreen), findsOneWidget);
|
|
expect(find.byKey(const ValueKey('shell.back')), findsOneWidget);
|
|
expect(selectedTab(tester), 0);
|
|
|
|
final handled = await tester.binding.handlePopRoute();
|
|
expect(handled, isTrue, reason: 'Back closes the page, not the app');
|
|
await tester.pump();
|
|
await tester.pump();
|
|
expect(provider.value.uri.path, '/pipelines');
|
|
await tester.pumpWidget(const SizedBox.shrink());
|
|
await tester.pump();
|
|
});
|
|
}
|