bd09c55c47
Integrates nine commits of reviewed work from the lane-go branch after the automated resolver failed on this merge five times (each attempt dying on the malformed-result defect whose fix is contained in this same merge). Integration decisions: - Search: kept main's shipped design (Store.Search + SearchResponse.Results) and dropped lane-go's parallel, older attempt (an unused Message.Matches field, an absent runs.search, and two partial TUI plumbing blocks). lane-go itself did not compile: protocol.SearchMatch was undefined and model.go referenced searchNav, requestSearch and applyRunNav, which exist nowhere. Those partial TUI blocks are removed; the queued TUI omni-search item will implement the surface properly on main's design. - Both sides' additions are kept where they are independent: run titles and provenance, the human decision stage and its CLI/TUI surface, the derived stage verdict, the stale-client guard, the line-oriented result format, and main's search command. - The search key's help label is now "/ omni search"; the two tests asserting the old label are updated rather than the label reverted. - docs/cli.md and the packaged operations reference carry both sides' text. Verified: go build ./... , go vet ./... and the full go test ./... suite pass.
164 lines
5.3 KiB
JavaScript
164 lines
5.3 KiB
JavaScript
// Client transport tests against a fake WebSocket: id matching, serialization,
|
|
// error replies, timeouts and the not-connected guard. No server required.
|
|
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
|
|
import { PipelinesClient, ProtocolError, NotConnectedError } from "../src/client.js";
|
|
import { validateServerUrl } from "../src/serverUrl.js";
|
|
|
|
const VALID = validateServerUrl("ws://host:8080/connect");
|
|
|
|
class FakeWebSocket {
|
|
static instances = [];
|
|
|
|
constructor(url) {
|
|
this.url = url;
|
|
this.sent = [];
|
|
this.closed = null;
|
|
this.onopen = null;
|
|
this.onmessage = null;
|
|
this.onclose = null;
|
|
this.onerror = null;
|
|
/** @type {((frame: any) => any | undefined) | null} */
|
|
this.reply = null;
|
|
FakeWebSocket.instances.push(this);
|
|
}
|
|
|
|
send(data) {
|
|
const frame = JSON.parse(data);
|
|
this.sent.push(frame);
|
|
const response = this.reply?.(frame);
|
|
if (response !== undefined) {
|
|
this.onmessage?.({ data: JSON.stringify(response) });
|
|
}
|
|
}
|
|
|
|
close(code, reason) {
|
|
this.closed = { code, reason };
|
|
this.onclose?.({ code, reason });
|
|
}
|
|
|
|
// test hooks
|
|
open() {
|
|
this.onopen?.({});
|
|
}
|
|
|
|
push(obj) {
|
|
this.onmessage?.({ data: JSON.stringify(obj) });
|
|
}
|
|
|
|
drop(code = 1006) {
|
|
this.onclose?.({ code, reason: "test" });
|
|
}
|
|
}
|
|
|
|
/** Let the client's serialized call chain run to the point where it has sent. */
|
|
const flush = () => new Promise((resolve) => setImmediate(resolve));
|
|
|
|
function freshClient(options = {}) {
|
|
FakeWebSocket.instances = [];
|
|
return new PipelinesClient({ WebSocketImpl: FakeWebSocket, ...options });
|
|
}
|
|
|
|
function connectedClient(options = {}) {
|
|
const client = freshClient(options);
|
|
client.connect(VALID);
|
|
const ws = FakeWebSocket.instances.at(-1);
|
|
ws.open();
|
|
return { client, ws };
|
|
}
|
|
|
|
test("a call before connect is rejected as not connected", async () => {
|
|
const client = freshClient();
|
|
await assert.rejects(() => client.call({ type: "ping" }), NotConnectedError);
|
|
});
|
|
|
|
test("a call sends a JSON frame with a generated id and resolves the matching reply", async () => {
|
|
const { client, ws } = connectedClient();
|
|
ws.reply = (frame) => ({ id: frame.id, type: "pong" });
|
|
|
|
const reply = await client.call({ type: "ping" });
|
|
assert.equal(reply.type, "pong");
|
|
assert.equal(ws.sent.length, 1);
|
|
assert.equal(ws.sent[0].type, "ping");
|
|
assert.match(ws.sent[0].id, /^web-\d+$/);
|
|
});
|
|
|
|
test("an error reply surfaces the server text as a ProtocolError", async () => {
|
|
const { client, ws } = connectedClient();
|
|
ws.reply = (frame) => ({ id: frame.id, type: "error", error: "nope" });
|
|
await assert.rejects(() => client.call({ type: "get_run" }), ProtocolError);
|
|
});
|
|
|
|
test("an unsolicited envelope with no matching id is dropped, not misattributed", async () => {
|
|
const { client, ws } = connectedClient();
|
|
ws.reply = undefined;
|
|
|
|
const pending = client.call({ type: "ping" });
|
|
let settled = false;
|
|
pending.then(() => (settled = true), () => (settled = true));
|
|
await flush();
|
|
|
|
ws.push({ type: "pipelines", pipelines: [] }); // no id
|
|
await flush();
|
|
assert.equal(settled, false);
|
|
|
|
const frame = ws.sent.at(-1);
|
|
ws.push({ id: frame.id, type: "pong" });
|
|
assert.equal((await pending).type, "pong");
|
|
});
|
|
|
|
test("a malformed frame is ignored and does not reject a pending call", async () => {
|
|
const { client, ws } = connectedClient();
|
|
const pending = client.call({ type: "ping" });
|
|
await flush();
|
|
ws.onmessage?.({ data: "{not json" });
|
|
const frame = ws.sent.at(-1);
|
|
ws.push({ id: frame.id, type: "pong" });
|
|
assert.equal((await pending).type, "pong");
|
|
});
|
|
|
|
test("a missing reply times out with a clear error", async () => {
|
|
const { client } = connectedClient({ requestTimeoutMs: 20 });
|
|
await assert.rejects(() => client.call({ type: "ping" }), /timed out after 20ms/);
|
|
});
|
|
|
|
test("concurrent calls are serialized in submission order", async () => {
|
|
const { client, ws } = connectedClient();
|
|
const order = [];
|
|
ws.reply = (frame) => {
|
|
order.push(frame.type);
|
|
return { id: frame.id, type: "ok" };
|
|
};
|
|
await Promise.all([client.call({ type: "a" }), client.call({ type: "b" })]);
|
|
assert.deepEqual(order, ["a", "b"]);
|
|
});
|
|
|
|
test("the state flow reports connecting then connected", async () => {
|
|
const seen = [];
|
|
const client = freshClient();
|
|
client.addEventListener("state", (e) => seen.push(e.detail.kind));
|
|
client.connect(VALID);
|
|
FakeWebSocket.instances.at(-1).open();
|
|
assert.deepEqual(seen, ["connecting", "connected"]);
|
|
});
|
|
|
|
test("an unexpected close fails pending calls and schedules a reconnect", async () => {
|
|
const { client, ws } = connectedClient({ backoffBaseMs: 1, backoffMaxMs: 5 });
|
|
const pending = client.call({ type: "ping" }); // never answered
|
|
await flush(); // let the call reach the socket before it is dropped
|
|
ws.drop(1006);
|
|
await assert.rejects(() => pending, /Connection closed/);
|
|
assert.equal(client.state.kind, "disconnected");
|
|
assert.equal(client.state.retrying, true);
|
|
client.disconnect(); // stop the reconnect timer before the test ends
|
|
});
|
|
|
|
test("disconnect goes idle and does not schedule a reconnect", () => {
|
|
const { client, ws } = connectedClient();
|
|
client.disconnect();
|
|
assert.equal(client.state.kind, "idle");
|
|
assert.equal(client.state.retrying, false);
|
|
assert.deepEqual(ws.closed, { code: 1000, reason: "client closing" });
|
|
});
|