5e2aece1be
The pipelines list (and every other run-state view) kept the row it had when the screen was last fetched. Two class-level root causes, fixed here: - The app subscribed to run events scoped to the one workspace the operator configured, so a run executing in another workspace (a lane worktree is its own workspace) never delivered a frame: the rows only changed on a manual refresh. The app now asks for the blank "any workspace" scope the server already treats as any (ALL_WORKSPACES in AppViewModel.subscribeRuns, blank default on PipelinesRepository.subscribeRuns). Workspace isolation on the server is unchanged: an explicit workspace scope still matches only that workspace (TestRunEventWorkspaceIsolation); the new TestRunEventAllWorkspacesSubscription pins the blank "any" scope. - foldRunEvent refused to insert a run the list had never held, returning needsResync and leaving the list untouched, so a run started after the screen loaded appeared only after a fetch. The pushed frame now carries the pipeline identity a row needs (RunEventFrame.PipelineID/Name/Title/Version), so the fold inserts the new run at the head from the frame's own identity without a fetch and without reordering existing rows; a server that predates those fields still falls back to the one resync. Added fields and why each is needed: pipeline_id (row's pipeline join), name (row title), title (the stored operator-facing title a row shows), version (the row's pinned version) - everything a RunSummary row renders, so no per-event fetch and no guess from stale cache. The server stamps them on every emitted frame from a per-run identity remembered at create/decide/cancel/resume (runner.go runIdentity/rememberRunIdentity/stampRunIdentity), first-write-wins through the coalescer (mergeRunEventFrame) and on the subscribe snapshot, so every transition - created/queued, running, each stage start/finish, terminal - carries them. Reconnect still resyncs once then follows pushes; the pull-to-refresh path is untouched. Checks run: go build ./..., go vet ./..., go test ./... (all packages ok), go test -race -run 'RunEvent|RunEvents|Subscribe' ./internal/protocol/ ./internal/server/, and gradle --no-daemon testDebugUnitTest assembleDebug (558 tests, 0 failures, 0 skipped; BUILD SUCCESSFUL). Packaged templates and the packaged authoring skill references were checked: nothing there describes the run_event field list or the client's subscription scope, so neither needs updating (references/notifications.md only says the attention surface is derived from the pushed run events, which is unchanged). Docs are a shared file owned by a single writer and were not edited: docs/cli.md's description of the pushed `run_event` frame still enumerates only the older fields (status, outcome, current stage, completed-step count, timestamps, optional step) and is now incomplete - it should mention the pipeline identity fields; docs/ntfy.md remains accurate.
83 lines
3.0 KiB
Go
83 lines
3.0 KiB
Go
package protocol
|
|
|
|
import (
|
|
"encoding/json"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// TestRunEventGoldenJSON pins the exact wire shape of the pushed run_event frame
|
|
// so a JSON tag change cannot silently alter what a client parses. The pipeline
|
|
// identity fields let a client build a brand-new run's row from the frame.
|
|
func TestRunEventGoldenJSON(t *testing.T) {
|
|
frame := RunEventFrame{
|
|
RunID: 7, Workspace: "/work", PipelineID: 4, Name: "release", Title: "Ship it", Version: 3,
|
|
Status: RunStatusRunning, CurrentStage: "build",
|
|
CompletedSteps: 1, CreatedAt: "2026-01-02T03:04:05Z", Artifacts: 2,
|
|
Step: &RunStepDelta{Sequence: 2, Stage: "build", Status: "completed", Outcome: "success", Target: SuccessEnd, Artifacts: 2},
|
|
}
|
|
encoded, err := json.Marshal(frame)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
want := `{"run_id":7,"workspace":"/work","pipeline_id":4,"name":"release","title":"Ship it","version":3,"status":"running","current_stage":"build","completed_steps":1,"created_at":"2026-01-02T03:04:05Z","artifacts":2,"step":{"sequence":2,"stage":"build","status":"completed","outcome":"success","target":"#success","artifacts":2}}`
|
|
if string(encoded) != want {
|
|
t.Fatalf("golden mismatch\n got %s\nwant %s", encoded, want)
|
|
}
|
|
var decoded RunEventFrame
|
|
if err := json.Unmarshal([]byte(want), &decoded); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !reflect.DeepEqual(decoded, frame) {
|
|
t.Fatalf("golden did not decode back: %+v", decoded)
|
|
}
|
|
}
|
|
|
|
// TestRunEventOmitsBlankIdentity proves a frame without identity (a run with no
|
|
// remembered identity) omits the fields entirely, so an older peer sees exactly
|
|
// the previous shape and a client falls back to its resync.
|
|
func TestRunEventOmitsBlankIdentity(t *testing.T) {
|
|
encoded, err := json.Marshal(RunEventFrame{RunID: 3, Workspace: "/w", Status: RunStatusQueued})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
for _, absent := range []string{"pipeline_id", "name", "title", "version"} {
|
|
if strings.Contains(string(encoded), absent) {
|
|
t.Fatalf("blank %q must be omitted: %s", absent, encoded)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestRunEventEnvelopeRoundTrip proves the new optional fields survive the shared
|
|
// Message envelope and that an unused payload is omitted from the wire.
|
|
func TestRunEventEnvelopeRoundTrip(t *testing.T) {
|
|
message := Message{
|
|
Type: RunEvent,
|
|
ID: "r1",
|
|
RunEvent: &RunEventFrame{RunID: 3, Workspace: "/w", Status: RunStatusQueued, CreatedAt: "2026-01-02T03:04:05Z"},
|
|
RunIDs: []int64{3, 4},
|
|
}
|
|
encoded, err := json.Marshal(message)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var decoded Message
|
|
if err := json.Unmarshal(encoded, &decoded); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !reflect.DeepEqual(decoded.RunEvent, message.RunEvent) || !reflect.DeepEqual(decoded.RunIDs, message.RunIDs) {
|
|
t.Fatalf("run event fields lost: %+v", decoded)
|
|
}
|
|
|
|
minimal, err := json.Marshal(Message{Type: Subscribe, ID: "s1", Workspace: "/w"})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
for _, absent := range []string{"run_event", "run_ids"} {
|
|
if strings.Contains(string(minimal), absent) {
|
|
t.Fatalf("absent %q must be omitted: %s", absent, minimal)
|
|
}
|
|
}
|
|
}
|