aabd22b5ad
Replace the narrow-layout floating destination pill with a full-width Material 3 NavigationBar. Reuse the shell destination model and badge wiring while preserving re-selection callbacks and hiding the bar for keyboard/detail states.
182 lines
6.2 KiB
Dart
182 lines
6.2 KiB
Dart
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:pipelines_app/shell/adaptive_shell.dart';
|
|
import 'package:pipelines_app/shell/destination.dart';
|
|
import 'package:pipelines_app/shell/shell_bar.dart';
|
|
import 'package:pipelines_app/shell/shell_navigation_bar.dart';
|
|
import 'package:pipelines_app/ui/adaptive/floating_destination_bar.dart';
|
|
|
|
Widget _app({required bool open, VoidCallback? back}) {
|
|
final shell = AdaptiveShell(
|
|
destination: AppDestination.runs,
|
|
destinationBodies: {
|
|
AppDestination.runs: (_) => open
|
|
? ShellBar(
|
|
title: 'Run 7',
|
|
onBack: back,
|
|
actions: const [Icon(Icons.more_vert, key: Key('run-more'))],
|
|
child: const Text('detail'),
|
|
)
|
|
: const Text('list'),
|
|
},
|
|
);
|
|
return MaterialApp(home: shell);
|
|
}
|
|
|
|
void main() {
|
|
testWidgets('an open screen takes over the bar and gives it back', (
|
|
tester,
|
|
) async {
|
|
tester.view.physicalSize = const Size(390, 844);
|
|
tester.view.devicePixelRatio = 1;
|
|
addTearDown(tester.view.reset);
|
|
var backs = 0;
|
|
await tester.pumpWidget(_app(open: true, back: () => backs++));
|
|
await tester.pump();
|
|
|
|
expect(find.text('Run 7'), findsOneWidget);
|
|
expect(find.byKey(const Key('run-more')), findsOneWidget);
|
|
await tester.tap(find.byKey(const ValueKey('shell.back')));
|
|
expect(backs, 1);
|
|
|
|
await tester.pumpWidget(_app(open: false));
|
|
await tester.pump();
|
|
expect(find.text('Run 7'), findsNothing);
|
|
expect(find.byKey(const ValueKey('shell.back')), findsNothing);
|
|
expect(find.byKey(const Key('run-more')), findsNothing);
|
|
});
|
|
|
|
testWidgets('Search is the fourth tab; Settings is the bar\'s last item', (
|
|
tester,
|
|
) async {
|
|
tester.view.physicalSize = const Size(390, 844);
|
|
tester.view.devicePixelRatio = 1;
|
|
addTearDown(tester.view.reset);
|
|
await tester.pumpWidget(_app(open: false));
|
|
expect(AppDestination.values, hasLength(5));
|
|
expect(shellTabDestinations, [
|
|
AppDestination.pipelines,
|
|
AppDestination.runs,
|
|
AppDestination.chat,
|
|
AppDestination.search,
|
|
]);
|
|
expect(
|
|
find.byKey(const ValueKey('shell.destination.search')),
|
|
findsOneWidget,
|
|
);
|
|
expect(
|
|
find.byKey(const ValueKey('shell.destination.settings')),
|
|
findsOneWidget,
|
|
);
|
|
expect(find.byKey(const ValueKey('shell.search')), findsNothing);
|
|
expect(find.byType(NavigationBar), findsOneWidget);
|
|
expect(find.byType(FloatingDestinationBar), findsNothing);
|
|
});
|
|
|
|
testWidgets('the phone bar is a full-width navigation bar that selects '
|
|
'destinations', (tester) async {
|
|
tester.view.physicalSize = const Size(390, 844);
|
|
tester.view.devicePixelRatio = 1;
|
|
addTearDown(tester.view.reset);
|
|
await tester.pumpWidget(_app(open: false));
|
|
|
|
final bar = find.byType(NavigationBar);
|
|
final rect = tester.getRect(bar);
|
|
expect(rect.left, 0);
|
|
expect(rect.right, 390);
|
|
expect(rect.bottom, 844);
|
|
expect(
|
|
tester.widget<NavigationBar>(bar).destinations,
|
|
hasLength(shellBarDestinations.length),
|
|
);
|
|
expect(tester.widget<NavigationBar>(bar).selectedIndex, 1);
|
|
for (var index = 0; index < shellBarDestinations.length; index++) {
|
|
final label = destinationDetails(shellBarDestinations[index]).label;
|
|
expect(
|
|
find.descendant(of: bar, matching: find.text(label)),
|
|
findsOneWidget,
|
|
);
|
|
// Each destination's whole slot is its target, not just the icon.
|
|
final target = tester.getSize(
|
|
find.byType(NavigationDestination).at(index),
|
|
);
|
|
expect(target.width, greaterThanOrEqualTo(44), reason: label);
|
|
expect(target.height, greaterThanOrEqualTo(44), reason: label);
|
|
}
|
|
await tester.tap(find.byKey(const ValueKey('shell.destination.chat')));
|
|
await tester.pump();
|
|
expect(find.text('Chat — Not implemented'), findsOneWidget);
|
|
expect(tester.widget<NavigationBar>(bar).selectedIndex, 2);
|
|
});
|
|
|
|
testWidgets('tabs show the running and unread counts their screens publish', (
|
|
tester,
|
|
) async {
|
|
tester.view.physicalSize = const Size(390, 844);
|
|
tester.view.devicePixelRatio = 1;
|
|
addTearDown(tester.view.reset);
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: AdaptiveShell(
|
|
destination: AppDestination.runs,
|
|
destinationBodies: {
|
|
AppDestination.runs: (_) => const ShellBadge(
|
|
kind: ShellBadgeKind.running,
|
|
count: 2,
|
|
child: Text('runs'),
|
|
),
|
|
},
|
|
),
|
|
),
|
|
);
|
|
await tester.pump();
|
|
final running = find.byKey(const ValueKey('shell.badge.runs.running'));
|
|
expect(
|
|
find.descendant(of: running, matching: find.text('2')),
|
|
findsOneWidget,
|
|
);
|
|
expect(
|
|
find.byKey(const ValueKey('shell.badge.chat.unread')),
|
|
findsOneWidget,
|
|
);
|
|
expect(
|
|
find.descendant(
|
|
of: find.byKey(const ValueKey('shell.badge.chat.unread')),
|
|
matching: find.textContaining(RegExp(r'\d')),
|
|
),
|
|
findsNothing,
|
|
);
|
|
});
|
|
|
|
testWidgets(
|
|
'a pushed detail covers tabs without unmounting the Back destination',
|
|
(tester) async {
|
|
tester.view.physicalSize = const Size(390, 844);
|
|
tester.view.devicePixelRatio = 1;
|
|
addTearDown(tester.view.reset);
|
|
Widget shell() => MaterialApp(
|
|
home: AdaptiveShell(
|
|
destination: AppDestination.runs,
|
|
destinationBodies: {AppDestination.runs: (_) => const Text('runs')},
|
|
),
|
|
);
|
|
await tester.pumpWidget(shell());
|
|
expect(find.byType(NavigationBar), findsOneWidget);
|
|
final navigator = tester.state<NavigatorState>(find.byType(Navigator));
|
|
navigator.push(
|
|
MaterialPageRoute<void>(
|
|
builder: (_) => const Scaffold(body: Text('detail')),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
expect(find.byType(NavigationBar), findsNothing);
|
|
expect(find.byType(NavigationBar, skipOffstage: false), findsOneWidget);
|
|
await navigator.maybePop();
|
|
await tester.pump(const Duration(milliseconds: 16));
|
|
expect(find.byType(NavigationBar), findsOneWidget);
|
|
await tester.pumpAndSettle();
|
|
expect(find.byType(NavigationBar), findsOneWidget);
|
|
},
|
|
);
|
|
}
|