283 lines
18 KiB
JavaScript
283 lines
18 KiB
JavaScript
// Focused UI-smoke extension: real createChatView + mock repository only.
|
|
// No native chats, provider calls, live server or framework.
|
|
import assert from "node:assert/strict";
|
|
import { createServer } from "node:http";
|
|
import { readFile, mkdir, writeFile } from "node:fs/promises";
|
|
import { resolve, extname, dirname } from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
import { launchChrome } from "./browser.mjs";
|
|
|
|
const root = resolve(dirname(fileURLToPath(import.meta.url)), "..");
|
|
const out = resolve(process.argv[2] ?? "captures-chat-row-actions");
|
|
await mkdir(out, { recursive: true });
|
|
const html = `<!doctype html><meta charset="utf-8"><meta name="viewport" content="width=device-width,initial-scale=1">
|
|
${["design/tokens/tokens", "base", "shell", "lists", "run-detail", "chat", "dialogs"].map(n => `<link rel="stylesheet" href="/${n}.css">`).join("")}
|
|
<style>body { margin: 0; } #fixture { display: flex; height: calc(100dvh - 80px); max-width: 540px; margin: 40px auto; } #fixture > .chat-list { flex: 1; }</style>
|
|
<div id="fixture"></div>
|
|
<div style="position:fixed;top:-1000px;left:0"><button id="ghostBaseline" class="ghost">Ordinary ghost</button><button id="rowBaseline" class="row">Ordinary row</button></div>
|
|
<script type="module">
|
|
import { createChatView } from '/src/views/chat.js';
|
|
import { newChatThread } from '/src/chat.js';
|
|
const long = 'Review a very long chat title that must never overlap any of its controls or backend mark';
|
|
const directory = '/Users/fixture/projects/a-very-long-project-directory/with/deeply/nested/worktrees';
|
|
const sessions = [
|
|
{ id:'selected', title:long, backend:'opencode', model:'openai/gpt-6.1-sol-with-a-very-long-model-name', starred:true },
|
|
{ id:'streaming', title:long, backend:'claude', model:'claude-sonnet' },
|
|
{ id:'new', title:long, backend:'codex', model:'gpt-5' },
|
|
{ id:'closed', title:long, backend:'opencode', model:'gpt-6.1', closed:true },
|
|
].map(s => ({ ...s, directory, updated_at:Date.now() }));
|
|
window.calls = { routes:[], stars:[] };
|
|
window.state = {
|
|
view:'chat', chatActiveId:'selected', chatSessions:sessions, chatQuery:'',
|
|
chatOverrides:{}, chatStars:new Set(['selected']), chatClosedOpen:true,
|
|
chatSeen:{}, chatThreads:new Map([
|
|
['selected',{...newChatThread('selected'),loaded:true}],
|
|
['streaming',{...newChatThread('streaming'),loaded:true,running:true}],
|
|
]), connection:{kind:'disconnected'}, chatSubscriptions:new Set(), chatDrafts:{}, chatScroll:{},
|
|
};
|
|
const repo = {
|
|
starChat:async(id,starred) => { calls.stars.push({id,starred}); return {starred}; },
|
|
chatHistory:async() => ({messages:[]}), chatShells:async() => [],
|
|
};
|
|
const rt = {state,repo,renderContent:() => paint(),focusDetailHeading:() => {},pushRoute:route => calls.routes.push(route)};
|
|
const view = createChatView(rt);
|
|
window.paint = () => document.querySelector('#fixture').replaceChildren(view.renderChatList());
|
|
window.reset = () => { state.chatMenu=null; state.chatActiveId='selected'; paint(); };
|
|
paint();
|
|
</script>`;
|
|
const server = createServer(async (req, res) => {
|
|
try {
|
|
const path = new URL(req.url, "http://fixture").pathname;
|
|
if (path === "/") { res.setHeader("Content-Type", "text/html"); res.end(html); return; }
|
|
const file = resolve(root, `.${path}`);
|
|
if (!file.startsWith(root + "/")) throw Error("outside fixture");
|
|
res.setHeader("Content-Type", extname(file) === ".css" ? "text/css" : "text/javascript");
|
|
res.end(await readFile(file));
|
|
} catch { res.writeHead(404); res.end(); }
|
|
});
|
|
await new Promise(r => server.listen(0, "127.0.0.1", r));
|
|
let browser, mouse;
|
|
const captures = [];
|
|
const measurements = [];
|
|
const styleComparisons = [];
|
|
try {
|
|
browser = await launchChrome();
|
|
const page = await browser.openPage(`http://127.0.0.1:${server.address().port}/`);
|
|
await page.waitForSelector('.chat-row-actions');
|
|
// A direct page CDP connection supplies actual pointer movement without clicks.
|
|
const target = (await (await fetch(`http://127.0.0.1:${browser.port}/json/list`)).json()).find(t => t.id === page.targetId);
|
|
mouse = new WebSocket(target.webSocketDebuggerUrl);
|
|
await new Promise(r => mouse.addEventListener('open', r, {once:true}));
|
|
let sequence = 0;
|
|
const command = (method, params = {}) => new Promise((resolve, reject) => {
|
|
const id = ++sequence;
|
|
const listener = event => {
|
|
const response = JSON.parse(event.data);
|
|
if (response.id !== id) return;
|
|
mouse.removeEventListener('message', listener);
|
|
response.error ? reject(Error(response.error.message)) : resolve(response.result);
|
|
};
|
|
mouse.addEventListener('message', listener);
|
|
mouse.send(JSON.stringify({id,method,params}));
|
|
});
|
|
const move = (x, y) => command('Input.dispatchMouseEvent', {type:'mouseMoved',x,y});
|
|
await command('DOM.enable');
|
|
await command('CSS.enable');
|
|
const {root:documentRoot} = await command('DOM.getDocument');
|
|
const force = async (selector, forcedPseudoClasses) => {
|
|
const {nodeId} = await command('DOM.querySelector', {nodeId:documentRoot.nodeId,selector});
|
|
await command('CSS.forcePseudoState', {nodeId,forcedPseudoClasses});
|
|
};
|
|
const styles = selector => page.evaluate(`(() => {
|
|
const s=getComputedStyle(document.querySelector(${JSON.stringify(selector)}));
|
|
return Object.fromEntries(['backgroundColor','borderTopColor','borderTopWidth','borderRadius','boxShadow','color',
|
|
'outlineColor','outlineWidth','outlineStyle','outlineOffset'].map(key=>[key,s[key]]));
|
|
})()`);
|
|
const compareStyles = async (width, coarse = false) => {
|
|
await move(1,1);
|
|
await page.evaluate('document.activeElement.blur()');
|
|
for (const state of [[],['hover'],['active'],['hover','active'],['focus-visible']]) {
|
|
const selectors=['#ghostBaseline','[data-session=streaming] .chat-star','[data-session=streaming] .chat-menu-button'];
|
|
for (const selector of selectors) await force(selector,state);
|
|
// Allow the shared background/border transitions to settle before comparing.
|
|
await page.evaluate('new Promise(r=>setTimeout(r,250))');
|
|
const baseline=await styles('#ghostBaseline');
|
|
for (const selector of selectors.slice(1)) assert.deepEqual(await styles(selector),baseline,`${selector}: ghost ${state}`);
|
|
await force('[data-session=selected] .chat-star',state);
|
|
await page.evaluate('new Promise(r=>setTimeout(r,250))');
|
|
const starred=await styles('[data-session=selected] .chat-star');
|
|
for (const key of ['backgroundColor','borderTopColor','borderTopWidth','borderRadius','boxShadow','outlineWidth','outlineStyle','outlineOffset']) assert.equal(starred[key],baseline[key],`starred ghost ${state}: ${key}`);
|
|
assert.equal(starred.color,await page.evaluate("(() => {const el=document.createElement('span');el.style.color='var(--color-accent)';document.body.append(el);const color=getComputedStyle(el).color;el.remove();return color;})()"),'starred state alone keeps its accent');
|
|
await force('[data-session=selected] .chat-star',[]);
|
|
for (const selector of selectors) await force(selector,[]);
|
|
for (const selected of [false,true]) {
|
|
const row=selected?'[data-session=selected]':'[data-session=streaming]';
|
|
await page.evaluate(`document.querySelector('#rowBaseline').classList.toggle('selected',${selected})`);
|
|
await force('#rowBaseline',state);
|
|
await force(row,state.includes('hover')?['hover']:[]);
|
|
await force(row+' .chat-session-button',state);
|
|
await page.evaluate('new Promise(r=>setTimeout(r,250))');
|
|
const expected=await styles('#rowBaseline'), actual=await styles(row);
|
|
// Container and native row inherit the same row surface/focus tokens.
|
|
for (const key of ['backgroundColor','borderTopColor','borderTopWidth','borderRadius','boxShadow','outlineColor','outlineWidth','outlineStyle','outlineOffset']) {
|
|
assert.equal(actual[key],expected[key],`row selected=${selected} ${state}: ${key}`);
|
|
}
|
|
const inner=await styles(row+' .chat-session-button');
|
|
assert.equal(inner.backgroundColor,'rgba(0, 0, 0, 0)','no inner hover/press fill');
|
|
assert.equal(inner.boxShadow,'none','no inner inset');
|
|
assert.equal(inner.outlineStyle,'none','focus ring belongs to outer row');
|
|
styleComparisons.push({width,coarse,state,selected,ghost:baseline,starred,row:actual,inner});
|
|
if (!selected && state.includes('active') && !state.includes('hover') && !coarse) await capture(`active-surface-${width}`);
|
|
await force(row+' .chat-session-button',[]);
|
|
await force(row,[]);
|
|
await force('#rowBaseline',[]);
|
|
}
|
|
}
|
|
};
|
|
const capture = async name => {
|
|
const file = `topright-leftlogo-bottomright-${name}.png`;
|
|
await page.screenshot(resolve(out, file));
|
|
captures.push(file);
|
|
};
|
|
const geometry = () => page.evaluate(`(() => {
|
|
const overlaps = (a,b) => a.left < b.right && b.left < a.right && a.top < b.bottom && b.top < a.bottom;
|
|
return [...document.querySelectorAll('.chat-row')].map(row => {
|
|
const controls = [...row.querySelectorAll('.chat-star,.chat-menu-button')];
|
|
const content = [...row.querySelectorAll('.chat-session-button,.chat-backend-logo')];
|
|
const r=row.getBoundingClientRect(), s=getComputedStyle(row), logo=row.querySelector('.chat-backend-logo'), title=row.querySelector('.chat-row-title');
|
|
const star=controls[0].getBoundingClientRect(), more=controls[1].getBoundingClientRect();
|
|
return {id:row.dataset.session,
|
|
topRight:Math.abs(star.top-r.top-parseFloat(s.paddingTop))<1,
|
|
bottomRight:Math.abs(more.bottom-r.bottom+parseFloat(s.paddingBottom)+parseFloat(s.borderBottomWidth))<1,
|
|
sameRight:star.right===more.right && Math.abs(star.right-r.right+parseFloat(s.paddingRight))<1,
|
|
logoBeforeTitle:logo.parentElement===title.parentElement && logo.nextElementSibling===title && logo.getBoundingClientRect().right<=title.getBoundingClientRect().left,
|
|
logoNonshrink:getComputedStyle(logo).flexShrink==='0',
|
|
controls:controls.map(button => {
|
|
const r=button.getBoundingClientRect(), style=getComputedStyle(button);
|
|
return {width:r.width,height:r.height,x:r.x,y:r.y,opacity:getComputedStyle(button.parentElement).opacity,
|
|
transition:getComputedStyle(button.parentElement).transitionDuration,
|
|
visible:style.visibility==='visible' && style.display!=='none',
|
|
hit:document.elementFromPoint(r.x+r.width/2,r.y+r.height/2)===button,
|
|
overlap:content.some(node => overlaps(r,node.getBoundingClientRect())),
|
|
nested:!!button.parentElement.closest('button')};
|
|
})};
|
|
});
|
|
})()`);
|
|
for (const width of [390, 420, 1100]) {
|
|
await page.resize(width, 844);
|
|
await page.evaluate('reset()');
|
|
await move(1, 1);
|
|
const before = await geometry();
|
|
measurements.push({width, rows:before});
|
|
assert.equal(before.length, 4);
|
|
for (const row of before) for (const key of ['topRight','bottomRight','sameRight','logoBeforeTitle','logoNonshrink']) assert.equal(row[key],true,`${row.id}: ${key}`);
|
|
for (const row of before) for (const button of row.controls) {
|
|
assert.ok(button.width >= 44 && button.height >= 44, `${row.id}: touch target`);
|
|
assert.equal(button.opacity, '1');
|
|
assert.equal(button.transition, '0s');
|
|
assert.equal(button.visible, true);
|
|
assert.equal(button.hit, true, `${row.id}: control centre hit-test`);
|
|
assert.equal(button.overlap, false, `${row.id}: no text/logo overlay`);
|
|
assert.equal(button.nested, false);
|
|
}
|
|
assert.equal(await page.evaluate('document.documentElement.scrollWidth > innerWidth'), false);
|
|
assert.equal(await page.evaluate("document.querySelector('[data-session=streaming] .chat-backend-logo').dataset.activity"), 'streaming');
|
|
assert.equal(await page.evaluate("document.querySelector('[data-session=new] .chat-backend-logo').dataset.activity"), 'new');
|
|
await capture(`rows-visible-${width}`);
|
|
await compareStyles(width);
|
|
await page.evaluate("document.querySelector('[data-session=selected] .chat-session-button').style.minHeight='160px'");
|
|
assert.ok((await geometry()).every(row=>row.topRight && row.bottomRight && row.sameRight),'controls anchor to full row height, not two adjacent fixed rows');
|
|
await page.evaluate("document.querySelector('[data-session=selected] .chat-session-button').style.minHeight=''");
|
|
const first = before[0].controls[0];
|
|
await move(first.x + 22, first.y + 22);
|
|
assert.deepEqual(await geometry(), before, 'hover changes neither controls nor layout');
|
|
const more = before[0].controls[1];
|
|
await move(more.x + 22, more.y + 22);
|
|
assert.deepEqual(await geometry(), before, 'hovering Chat actions reveals no new controls');
|
|
assert.equal(await page.evaluate("document.querySelectorAll('.chat-menu-panel').length"), 0, 'hover never opens a menu');
|
|
await capture(`rows-hover-${width}`);
|
|
|
|
// Natural keyboard order: thread, star, menu. Focus must not open the menu.
|
|
await page.evaluate("document.querySelector('[data-session=selected] .chat-session-button').focus()");
|
|
await page.pressKey('Tab');
|
|
assert.equal(await page.evaluate("document.activeElement.classList.contains('chat-star')"), true);
|
|
await page.pressKey('Tab');
|
|
assert.equal(await page.evaluate("document.activeElement.classList.contains('chat-menu-button')"), true);
|
|
assert.equal(await page.evaluate("document.querySelectorAll('.chat-menu-panel').length"), 0);
|
|
await capture(`rows-keyboard-${width}`);
|
|
await page.pressKey('Enter');
|
|
assert.equal(await page.evaluate("document.activeElement.classList.contains('chat-menu-item')"), true);
|
|
assert.deepEqual(await page.evaluate("Array.from(document.querySelectorAll('.chat-menu-item'),n=>n.textContent)"), ['Rename…', 'Close chat…', 'Hide on this device']);
|
|
assert.equal(await page.evaluate('state.chatActiveId'), 'selected');
|
|
assert.deepEqual(await page.evaluate('calls.routes'), []);
|
|
await capture(`rows-menu-${width}`);
|
|
|
|
await page.evaluate('reset()');
|
|
await page.click('[data-session=streaming] .chat-menu-button');
|
|
assert.equal(await page.evaluate('state.chatMenu'), 'streaming');
|
|
assert.equal(await page.evaluate('state.chatActiveId'), 'selected');
|
|
assert.deepEqual(await page.evaluate('calls.routes'), []);
|
|
await capture(`rows-pointer-menu-${width}`);
|
|
await page.click('[data-session=streaming] .chat-menu-button');
|
|
assert.equal(await page.evaluate("document.querySelectorAll('.chat-menu-panel').length"), 0);
|
|
const stars = await page.evaluate('calls.stars.length');
|
|
await page.click('[data-session=streaming] .chat-star');
|
|
assert.deepEqual(await page.evaluate('calls.stars.at(-1)'), {id:'streaming',starred:true});
|
|
assert.equal(await page.evaluate('calls.stars.length'), stars + 1);
|
|
assert.equal(await page.evaluate('state.chatActiveId'), 'selected');
|
|
assert.deepEqual(await page.evaluate('calls.routes'), []);
|
|
await page.click('[data-session=streaming] .chat-star');
|
|
|
|
// Force the closed trigger against the actual list scroller bottom. Unlike
|
|
// click(selector), Enter does not silently scroll it to the viewport centre.
|
|
await page.resize(width, 500);
|
|
await page.evaluate(`(() => {
|
|
const rows=document.querySelector('#chatRows'), row=document.querySelector('[data-session=closed]');
|
|
rows.scrollTop += row.getBoundingClientRect().bottom - rows.getBoundingClientRect().bottom;
|
|
row.querySelector('.chat-menu-button').focus({preventScroll:true});
|
|
})()`);
|
|
assert.equal(await page.evaluate(`(() => {
|
|
const rows=document.querySelector('#chatRows'), row=document.querySelector('[data-session=closed]');
|
|
return Math.abs(row.getBoundingClientRect().bottom-rows.getBoundingClientRect().bottom)<2 && rows.scrollTop>0;
|
|
})()`), true, 'fixture must exercise a real scroller bottom edge');
|
|
await page.pressKey('Enter');
|
|
const items = await page.evaluate(`Array.from(document.querySelectorAll('.chat-menu-item'), node => {
|
|
const r=node.getBoundingClientRect();
|
|
return {text:node.textContent,inside:r.top>=0 && r.bottom<=innerHeight,
|
|
hit:node===document.elementFromPoint(r.x+r.width/2,r.y+r.height/2)};
|
|
})`);
|
|
assert.ok(items.some(item => item.text === 'Reopen'));
|
|
assert.ok(items.every(item => item.inside && item.hit), JSON.stringify(items));
|
|
await capture(`rows-bottom-menu-${width}`);
|
|
await page.evaluate('paint()');
|
|
assert.equal(await page.evaluate(`Array.from(document.querySelectorAll('.chat-menu-item')).every(node => {
|
|
const r=node.getBoundingClientRect();
|
|
return r.top>=0 && r.bottom<=innerHeight && document.elementFromPoint(r.x+r.width/2,r.y+r.height/2)===node;
|
|
})`), true, 'open menu re-anchors on a later render');
|
|
await page.click('.chat-menu-rename');
|
|
assert.equal(await page.evaluate('state.chatRename.id'), 'closed');
|
|
assert.equal(await page.evaluate('state.chatActiveId'), 'selected');
|
|
assert.deepEqual(await page.evaluate('calls.routes'), []);
|
|
await page.resize(width, 844);
|
|
await page.evaluate('reset()');
|
|
}
|
|
await page.emulateTouch();
|
|
await page.resize(390, 844);
|
|
measurements.push({width:390,coarse:true,rows:await geometry()});
|
|
assert.ok((await geometry()).every(row => row.controls.every(button => button.width >= 48 && button.height >= 48)));
|
|
assert.ok((await geometry()).every(row => row.topRight && row.bottomRight && row.sameRight && row.logoBeforeTitle && row.logoNonshrink));
|
|
await compareStyles(390,true);
|
|
await capture('rows-coarse-pointer-390');
|
|
// Exactly one route dispatch for a thread click (all action tests dispatched 0).
|
|
await page.click('[data-session=selected] .chat-session-button');
|
|
assert.deepEqual(await page.evaluate('calls.routes'), [{kind:'chatSession',id:'selected'}]);
|
|
await page.click('[data-session=selected] .chat-backend-logo');
|
|
assert.deepEqual(await page.evaluate('calls.routes'), [{kind:'chatSession',id:'selected'},{kind:'chatSession',id:'selected'}], 'logo inside native session button dispatches once too');
|
|
await writeFile(resolve(out, 'manifest.json'), JSON.stringify({captures, measurements, styleComparisons, widths:[390,420,1100],fixture:'actual createChatView, mock repo/rt, no native chat'}, null, 2));
|
|
console.log(`PASS: top-right star, left-before-title logo, bottom-right more, common ghost/row computed styles (${styleComparisons.length} states), no hover reveal, 44/48px targets, keyboard order, shared star API, selected thread retained, single thread/logo click dispatch, bottom menu hit-tests. Captures: ${out}`);
|
|
} finally {
|
|
mouse?.close();
|
|
await browser?.close();
|
|
await new Promise(r => server.close(r));
|
|
}
|