Files
pipelines/docs/notes/pill-overlay-and-position.md
T
alan 5a44ff1568 android: make the destinations pill a true overlay, centred narrow and right when wide
The floating destination pill no longer takes layout space: it is drawn in the
bottom overlay layer above the content, horizontally centred on a narrow window
and anchored to the bottom-right corner on a wide one. Templates leaves the pill
for a Templates row on the Settings page.

- PipelinesApp: the content Column's pill reservation is gone; contentPillPadding
  (pillVisible) is the named zero and a unit test pins both states. The pill and
  the attention chip stay in their own bottom-anchored overlay Column, a sibling
  of the content in the Box, so nothing positions the content. The one placement
  rule is destinationPillAlignment(wide) (CenterHorizontally narrow, End wide);
  the corner margin is the named SPACING_L, so no new number. The attention chip
  keeps its own bottom-right place at every width via Modifier.align(End).
- Trailing clearance moves into each scrollable's own content: pillScrollInset
  (DESTINATION_PILL_RESERVE + ATTENTION_CHIP_RESERVE while drawn, zero while
  hidden) is published through the new LocalPillBottomInset
  (components/PillInset.kt) and applied with pillContentPadding /
  Modifier.pillBottomPadding in every list, grid and scrolling detail, stage and
  settings body. The container keeps its full height, a hidden pill leaves no
  empty band, and the last row still scrolls clear of the pill.
- Templates is no longer a pill destination: TemplatesDestination.kt is deleted
  and destinations is pipelines/runs/chat/settings. The new SettingsDestination
  sliding stack (pane 0 SettingsScreen, 1 TemplateGalleryScreen, 2
  TemplateDetailScreen) with the pure, Bundle-able SettingsSelection model gives
  the gallery the shared covered-pane strip and one-level Back; SettingsScreen
  gains the Templates row that opens it. This re-lands the intent of a2043f9,
  which never reached main.
- Dimens: the two reserve tokens' docs now describe the scroll-content clearance
  and the chip's share of it; no new token and no hardcoded geometry.

Checked where the change belongs: no packaged template (examples/*.md) and no
packaged authoring skill reference (internal/author/skill/references/*) describes
the Android pill, its destinations or the Templates gallery, so none needs
updating and internal/author/install.go's inventory is unchanged. android/README.md
does document the surfaces this item changed, so it is now stale: this item does
not edit that shared document - docs/notes/pill-overlay-and-position.md records
the two places that need it (the Templates bullet and the dated section to append)
for the single docs-fold writer.

Tests: at a297fb6 with these working changes the build and unit suite were green
(593 tests, 0 failures); no device command was run and the geometry stays
token-derived. Visual rendering of the centred/right pill needs the device and
was not verified here.
2026-10-18 00:20:37 +01:00

9.7 KiB

The destinations pill: a true overlay, centred narrow and right when wide

What this item changed

android/ only, the app shell's floating destination pill and where Templates lives.

  • ui/PipelinesApp.kt — the pill is a true overlay. The content Column no longer reserves the pill's height (destinationPillReserve and the ATTENTION_CHIP_RESERVE padding on it are gone); contentPillPadding(pillVisible) is the named zero it applies, zero whether the pill is drawn or hidden. The pill and the attention chip stay in their own bottom-anchored overlay Column, already a sibling of the content in the Box, so nothing positions the content. The one placement rule is destinationPillAlignment(wide) — Alignment.CenterHorizontally on a narrow window, Alignment.End on a wide one — with the corner margin from the named SPACING_L; the attention chip keeps its own bottom-right place at every width via Modifier.align(Alignment.End). destinations is now pipelines/runs/chat/settings (Templates removed), and the settings route is SettingsDestination.
  • ui/components/PillInset.kt (new) — LocalPillBottomInset plus pillContentPadding (for a scroll container's contentPadding) and Modifier.pillBottomPadding (for a scrollable Column's own content). They add pillScrollInset(pillVisible) — the named DESTINATION_PILL_RESERVE + ATTENTION_CHIP_RESERVE while the pill is drawn, zero while it is hidden — inside the scroll content, never as layout padding on the container, so the content keeps its full height, a hidden pill leaves no empty band, and the last row still scrolls clear of the pill. Applied in the lists, the graph/source/stage panes, the chat list and create panes, the run tabs and history, the pipeline list/detail and the template gallery/detail.
  • ui/SettingsDestination.kt (new) — the Settings destination as the shared SlidingPaneStack: pane 0 SettingsScreen, pane 1 the existing TemplateGalleryScreen, pane 2 the existing TemplateDetailScreen, with PredictiveBackHandler.
  • ui/SettingsSelection.kt (new) — the pure, Bundle-able pane model (SettingsPane/SettingsSelection, openTemplatesGallery, openTemplateDetail, settingsBack, settingsPopTo, encodeSettingsSelection/decodeSettingsSelection and the saver): one-level Back (detail → gallery → settings) and a covered-pane pop.
  • ui/screens/SettingsScreen.kt — gains the Templates row (section label, card with the TemplatesIcon glyph, title, description and a forward chevron) that opens the gallery; the screen's own body takes pillBottomPadding().
  • ui/TemplatesDestination.kt — deleted (its gallery is now the settings stack's pane 1).
  • ui/theme/Dimens.kt — the docs of DESTINATION_PILL_RESERVE and ATTENTION_CHIP_RESERVE now describe scroll-content clearance rather than a reserved layout band. No new token, no new hardcoded dimension.
  • Tests — PipelinesNavTest (the pill holds no templates route, the remaining destinations and their order, the narrow/wide alignment, the content's padding is zero and the scroll inset tracks the drawn pill) and SettingsSelectionTest (the Templates row opens the gallery, a card opens the detail, Back steps one pane, a covered strip pops, the saver round-trips). This re-lands the intent of a2043f9 ("move Templates from the floating pill to Settings"), whose commit never reached main.

Shared documents this change makes stale

android/README.md documents the app's surfaces this item changed. The note is written here rather than edited in place; the docs-fold writer should update it.

  • android/README.md:107 — the bullet "A Templates destination (its own top-level pill between Pipelines and Runs, with its own gallery glyph rather than the Pipelines workflow tree): a measured gallery of cards…" should read "The Templates gallery, reached from a Templates row on the Settings page (not a floating-pill destination — it is configuration, so it lives with the other settings; its own gallery glyph rather than the Pipelines workflow tree): a measured gallery of cards…". The rest of the bullet (the cards, the stage count, the column count, the detail pane) is still true.
  • android/README.md — append the dated section below at the end of the file, after the last record (## Run title readability: whole in the run view, two lines in the list (17 Oct 2026)). Insert it verbatim; its build counts and the APK name are that run's dated evidence, not current values.
## The destinations pill: a true overlay, centred narrow and right when wide (18 Oct 2026)

The floating destination pill no longer takes layout space. It is drawn in the
bottom overlay above the content and its resting place follows the window width:
horizontally centred at the bottom on a **narrow** window, anchored to the
**bottom-right corner** on a **wide** one. Templates leaves the pill for the
Settings page. `android/` only; no new dependency (still only the declared
`material-icons-extended`), no Pipelines server/Go/installer/Docker file touched
and no run started from the app; the build and unit tests only, no device command
run.

- **An overlay, not a layout band.** `PipelinesApp`'s content `Column` no longer
  reserves the pill's height (`destinationPillReserve` and its
  `ATTENTION_CHIP_RESERVE` padding are gone). The pill and the attention chip stay
  in their own bottom-anchored overlay `Column` — already a sibling of the content
  in the `Box`, so nothing about them positions the content. `contentPillPadding(pillVisible)`
  is the named zero it applies (zero whether the pill is drawn or hidden); a unit
  test pins both states.
- **Trailing space moves into each scrollable.** A hidden pill must leave no empty
  band, but scrolling to the end must still reveal the last row clear of the pill.
  `pillScrollInset(pillVisible)` (the named `DESTINATION_PILL_RESERVE` +
  `ATTENTION_CHIP_RESERVE` while drawn, zero while hidden) is published around the
  content through the new `LocalPillBottomInset`, and `pillContentPadding` /
  `Modifier.pillBottomPadding` add it to a screen's **own scroll content** (every
  list, grid and scrolling detail/stage/settings body), never as layout padding on
  the container — so the content keeps its full height and only its end clears the
  pill.
- **Centred narrow, right corner when wide.** `destinationPillAlignment(wide)` is
  the one pure rule (`Alignment.CenterHorizontally` narrow, `Alignment.End` wide);
  the corner margin is the named `SPACING_L`, so no new number is introduced. The
  pill still clears the safe area (system bars, cutout, gesture area and IME) via
  `windowInsetsPadding(paneSafeArea())`, so it never covers the keyboard or an open
  composer, and it still stands down while a conversation is open.
- **Templates leaves the pill for Settings.** `destinations` is now
  pipelines/runs/chat/settings, so the pill's width (its icon row) simply narrows.
  The `settings` route is the shared `SlidingPaneStack` (`SettingsDestination`):
  pane 0 the Settings page, pane 1 the existing `TemplateGalleryScreen`, pane 2 the
  existing `TemplateDetailScreen`. `SettingsSelection` is the pure, Bundle-able
  pane model with one-level Back (detail → gallery → settings) and a
  covered-pane pop. `SettingsScreen` gains a Templates row (section label + card
  with the `TemplatesIcon` glyph, title, description and forward chevron). This
  re-lands the intent of `a2043f9` ("move Templates from the floating pill to
  Settings"), whose commit never reached main.

Tests: the 64 result XMLs (plus Gradle's `binary` results directory) aggregate to
**593 tests, 0 failures, 0 errors, 0 skipped**. New/updated pure tests —
`PipelinesNavTest` (11, incl. the pill holds no `templates` route, the remaining
destinations and their order, the narrow/wide alignment, the content's padding is
zero, and the scroll inset tracks the drawn pill) and `SettingsSelectionTest` (6,
the Templates row opens the gallery, a card opens the detail, Back steps one pane,
a covered strip pops and the saver round-trips).

Evidence (macOS, `JAVA_HOME=/Applications/Android Studio.app/Contents/jbr/Contents/Home`,
`ANDROID_HOME=/Users/alan/Library/Android/sdk`, Gradle 8.11.1, `--offline`,
`--no-daemon`, built at `a297fb6` = `main`'s tip with this item's working changes):

- `<gradle> --offline --no-daemon :app:assembleDebug :app:testDebugUnitTest` →
  `BUILD SUCCESSFUL`; the 64 result XMLs aggregate to 593 tests, 0 failures, 0
  errors, 0 skipped; `app-debug.apk` 18,657,246 bytes, sha256
  `c60f9b269368b51d4bc1f43b95b0970210d803e4fe0dc4add8db39e3b3821f51`.
- **APK publish.** Copied to this run's artifacts directory as
  `pipelines-debug-wip-a297fb6.apk`, served at
  `http://10.0.0.75:8080/artifacts/327/3/pipelines-debug-wip-a297fb6.apk`
  (`HTTP/1.1 200 OK`, `Content-Type: application/vnd.android.package-archive`, the
  downloaded bytes sha256-matching the local file).

Not verified in this pass: how the centred/right pill actually renders and that a
scrolled list's last row clears it — that needs the device, which this
build-and-unit-test pass did not use; visual review owns the operator's Pixel 9
Pro XL.

Not stale

  • No packaged OpenCode skill reference documents this app surface. The references in internal/author/skill/references/ describe the server, the CLI and the pipeline authoring model; none names the app's destination pill, its destinations or the templates gallery.
  • No packaged template (examples/*.md) and no internal/author/ managed file names them either, so internal/author/install.go's inventory needs no change.
  • android/AGENTS.md already describes ui/PipelinesApp.kt as "the app shell: destinations, the floating pill, the omni-search morph" and lists ui/screens/, so it needs no change.