Files
pipelines/app/lib/features/pipelines/pipeline_format.dart
T
alan fe24f228fe fix(app): one relative-time style, day-aware durations, consistent visit wording
Review r2 findings P2-4, P2-5, P3-13: a shared relative-time helper for
every list row's time, formatDuration switches to days past 24h ('9d
16h'), the stage page uses one visit numbering, drops a repeated stage
heading and fixes '1 files', and search run hits read 'Run 1'.
Implemented by pipeline run #205/#207 (Terra); its UIReview blocked on a
fixture without timestamps, verified by the manager.
2026-10-31 12:29:16 +00:00

95 lines
2.9 KiB
Dart

/// Formatting shared by the pipeline list and detail.
///
/// The wording mirrors the web client (`src/pipelines.js`), which in turn
/// mirrors the Android app: one date shape, one duration shape, one status
/// vocabulary and one singular/plural rule.
library;
const _monthNames = <String>[
'Jan',
'Feb',
'Mar',
'Apr',
'May',
'Jun',
'Jul',
'Aug',
'Sep',
'Oct',
'Nov',
'Dec',
];
/// Parses an RFC3339 timestamp, or null when blank or unparseable.
DateTime? parseInstant(String? text) {
final trimmed = text?.trim() ?? '';
if (trimmed.isEmpty) return null;
return DateTime.tryParse(trimmed);
}
/// `d MMM HH:mm` in local time, e.g. `17 Oct 21:26`, or null when the
/// timestamp is unusable so callers omit the value instead of printing blank.
String? formatLocalTimestamp(String? text) {
final instant = parseInstant(text);
if (instant == null) return null;
final local = instant.toLocal();
final hour = local.hour.toString().padLeft(2, '0');
final minute = local.minute.toString().padLeft(2, '0');
return '${local.day} ${_monthNames[local.month - 1]} $hour:$minute';
}
/// `45s`, `2m 5s`, `1h 2m`, `9d 16h`. Negative values clamp to `0s`.
String formatDuration(int totalSeconds) {
final seconds = totalSeconds < 0 ? 0 : totalSeconds;
if (seconds < 60) return '${seconds}s';
if (seconds < 3600) return '${seconds ~/ 60}m ${seconds % 60}s';
if (seconds < 86400) return '${seconds ~/ 3600}h ${(seconds % 3600) ~/ 60}m';
return '${seconds ~/ 86400}d ${(seconds % 86400) ~/ 3600}h';
}
/// Whole non-negative seconds between two timestamps, or null when either is
/// unusable or the end precedes the start.
int? durationSeconds(String? start, String? end) {
final from = parseInstant(start);
final to = parseInstant(end);
if (from == null || to == null) return null;
final seconds = to.difference(from).inSeconds;
return seconds >= 0 ? seconds : null;
}
/// `1 stage` / `n stages`.
String stageCountText(int count) => '$count ${count == 1 ? 'stage' : 'stages'}';
const _runStateAliases = <String, String>{
'running': 'running',
'queued': 'queued',
'waiting': 'waiting',
'active': 'active',
'succeeded': 'succeeded',
'success': 'succeeded',
'completed': 'succeeded',
'done': 'succeeded',
'failed': 'failed',
'error': 'failed',
'canceled': 'canceled',
'cancelled': 'canceled',
'interrupted': 'interrupted',
'blocked': 'blocked',
'skipped': 'skipped',
};
/// Maps a server status word to the shared run-state vocabulary. Unknown or
/// blank values become `unknown` rather than crashing a row.
String runStateOf(String? status) {
final key = (status ?? '').trim().toLowerCase();
return _runStateAliases[key] ?? 'unknown';
}
/// `Running`-style title for a run state.
String runStateLabel(String? status) {
final state = runStateOf(status);
return state.isEmpty
? state
: '${state[0].toUpperCase()}${state.substring(1)}';
}