Files
pipelines/docs/notes/pill-run-decision.md
T

5.3 KiB

The destinations pill stands down over a run's pending decision

What this item changed

android/ only, the app shell's floating destination pill and the run view's decision surface.

  • ui/PipelinesApp.kt — the pill's one rule gains a second hiding state. destinationPillVisible(currentRoute, conversationOpen, decisionOpen) is now !(currentRoute == CHAT_ROUTE && conversationOpen) && !decisionOpen: the chat conversation hides it exactly as before (the chat clause is unchanged), and a run's open pending-decision surface hides it too. Everything downstream is unchanged and still keys off that one predicate — contentPillPadding(pillVisible) (the named zero) and pillScrollInset(pillVisible) (the named DESTINATION_PILL_RESERVE + ATTENTION_CHIP_RESERVE, or 0.dp while hidden) — so hiding the pill over a decision leaves no empty band, exactly as hiding it in a conversation already does. The shell holds the new input as decisionSurfaceOpen (remember { mutableStateOf(false) }: a transient state of the run view, not a destination and not saved — the sheet is not saveable either, so a configuration change closes both together) and passes its setter down the same path decisionRequest already travels.
  • ui/components/DecisionPrompt.kt — gains onSurfaceOpenChange: (Boolean) -> Unit = {}, reporting open on every change (LaunchedEffect(open)) and clearing it when the prompt leaves the composition (DisposableEffect) so a surface closed with its pane can never leave the pill hidden behind it. The component still owns no networking and no pill knowledge: it only says when its own surface is up.
  • ui/screens/RunDetailScreen.kt, ui/RunsDestination.kt, ui/graph/StageDetailPane.kt — the run detail, the runs destination and the run's stage pane (its section level included) pass that callback through, so the decision sheet hides the pill wherever it is opened from. The pipeline-side stage pane gets the default no-op.
  • Tests — PipelinesNavTest: the existing destinationPillVisible test is extended in place (renamed thePillStandsDownWhileAConversationOrARunDecisionSurfaceIsOpen) to pin that the decision surface hides the pill on the runs route, that a run being read keeps it, and that the chat clause is untouched; and the scroll-inset test's loop gains the decision dimension, so pillScrollInset is proved zero while the decision surface hides the pill (no empty band) and the drawn reserve while it is drawn.

No new dimension, so no ui/theme/Dimens.kt token was needed (a raw literal would fail DimensTest). No dependency added, no server/Go/installer/Docker file touched, and no run started from the app.

Shared documents this change makes stale

android/README.md documents the pill's hiding rule and is written here rather than edited in place; the docs-fold writer should update it.

  • android/README.md:6219 — the section headline "## Destination pill stands down in an open conversation (17 Oct 2026)" and its opening paragraph ("It now stands down while the Chat destination is showing an open conversation and stays everywhere else, unchanged") now describe only half the rule. The section should also record the new item, e.g. append a dated section:
## The destinations pill stands down over a run's pending decision (18 Oct 2026)

The floating destinations pill also stood over a run's pending-decision surface — the
decision sheet ("Choose things that need to happen") the operator opens from the run
summary's Decide action — where it covered the options. It now stands down there too,
exactly as it already does inside an open chat conversation, and returns the moment the
decision is answered or dismissed. `android/` only; no new dependency, no run started from
the app, no server/installer/Docker file touched.

- **The one rule gains a second hiding state.** `destinationPillVisible(currentRoute,
  conversationOpen, decisionOpen)` is `!(currentRoute == CHAT_ROUTE && conversationOpen) &&
  !decisionOpen`. The chat clause is unchanged; the new `decisionOpen` is reported up by the
  run view (`DecisionPrompt.onSurfaceOpenChange`), so the surface is a state of the run view,
  not a destination: answering or dismissing it returns the pill with no navigation.
- **Still one predicate, still no band.** `contentPillPadding` and `pillScrollInset` are
  unchanged and still derive from `pillVisible` alone, so a hidden pill over the decision
  leaves no empty band; the scroll-inset test now loops the decision dimension and pins that.
- **Scoped to the decision surface.** A run being read, its stage pane, an artifact and the
  graph all keep the pill; only the open decision sheet hides it. The chat behaviour and the
  narrow/wide placement rules are untouched.

Not stale

  • No packaged OpenCode skill reference (internal/author/skill/references/) documents the app's destination pill or its hiding states; they describe the server, the CLI and the pipeline authoring model. No packaged template (examples/*.md) and no internal/author/ managed file names them either, so internal/author/install.go's inventory needs no change.
  • android/AGENTS.md describes ui/PipelinesApp.kt generically ("the app shell: destinations, the floating pill, the omni-search morph") and needs no change.