Files
pipelines/examples/catalog_test.go
T
alan 526c19fc21 web: shared chat stars, pipeline mini graphs and agent questions
- Persist chat stars in the operator-session registry (chat_star) so every
  browser/device shows the same Starred group; migrate old local stars once.
- Add a compact pipeline graph shape to list responses and draw a lightweight
  list miniature; replace the cryptic id/version line with the stage count.
- Surface OpenCode form questions as a chat card (chat_answer), replay a
  pending form to late subscribers, and notify for background questions.
- Make the mobile dock's Search cell equal to every destination, keep the
  tab row visible with 100svh, and let Source use the full pane height.
- Let a fresh sign-in auto-connect to its own origin; use a Lax session cookie
  with Expires so Remember me survives app/link launches.
- Keep shipped starters and the skill agnostic: no repository paths, project
  areas or personal device commands; add Diagnose/Fix and Research starters.
- Refresh the installed skill and document the new browser conventions.
2026-10-20 03:11:37 +01:00

202 lines
6.2 KiB
Go

package examples_test
import (
"os"
"slices"
"strings"
"testing"
"git.a-wan.net/alan/pipelines/examples"
"git.a-wan.net/alan/pipelines/internal/pipeline"
"git.a-wan.net/alan/pipelines/internal/protocol"
"git.a-wan.net/alan/pipelines/internal/stage"
)
func TestReadmeThreeStageExampleIsValid(t *testing.T) {
source, err := os.ReadFile("three-stage.md")
if err != nil {
t.Fatal(err)
}
graph, err := pipeline.Parse(string(source))
if err != nil {
t.Fatal(err)
}
if len(graph.Stages) != 4 || graph.Settings != nil {
t.Fatal("example must be manual-only and four stages")
}
}
func TestCatalogContainsValidUnpublishedTemplates(t *testing.T) {
items := examples.Catalog()
if len(items) != 5 {
t.Fatal("unexpected catalog size", len(items))
}
seen := map[string]bool{}
wantStages := map[string]int{"task": 2, "review": 1, "research": 2, "three-stage": 4, "debug": 4}
for _, item := range items {
if seen[item.Key] || item.Description == "" || item.Name == "" {
t.Fatal("invalid template metadata", item.Key)
}
seen[item.Key] = true
graph, err := pipeline.Parse(item.Source)
if err != nil {
t.Fatal(item.Key, err)
}
if (graph.Settings != nil) != item.Scheduled {
t.Fatal("missing schedule warning", item.Key)
}
if graph.Settings != nil || len(graph.Stages) > 4 {
t.Fatal("starters must be small and manual-only", item.Key)
}
if len(graph.Stages) != wantStages[item.Key] {
t.Fatal("unexpected/non-generic catalog entry", item.Key)
}
}
}
// parsedCatalog parses every bundled starter once for the role/route assertions.
func parsedCatalog(t *testing.T) map[string]pipeline.Graph {
t.Helper()
parsed := map[string]pipeline.Graph{}
for _, item := range examples.Catalog() {
graph, err := pipeline.Parse(item.Source)
if err != nil {
t.Fatal(item.Key, err)
}
parsed[item.Key] = graph
}
return parsed
}
func stageTools(t *testing.T, graph pipeline.Graph, key string) ([]string, bool) {
t.Helper()
for _, s := range graph.Stages {
if s.Key != key {
continue
}
tools, explicit, err := stage.ToolNames(pipeline.StageDefinition(s))
if err != nil {
t.Fatalf("stage %s: %v", key, err)
}
sorted := slices.Clone(tools)
slices.Sort(sorted)
return sorted, explicit
}
t.Fatalf("stage %s not found", key)
return nil, false
}
// starterTools is the expected explicit role allowlist per template and stage.
// Every bundled starter declares a tools block; an empty list is the intentional
// deny-all tool-free role.
var starterTools = map[string]map[string][]string{
"task": {
"worker": {"read", "glob", "grep", "edit", "shell", "websearch", "webfetch"},
"committer": {"read", "glob", "grep", "shell"},
},
"review": {"review": {"read", "glob", "grep", "websearch", "webfetch"}},
"research": {
"research": {"websearch", "webfetch"},
"report": {},
},
"three-stage": {
"planner": {"read", "glob", "grep", "websearch", "webfetch"},
"implementer": {"read", "glob", "grep", "edit", "shell"},
"reviewer": {"read", "glob", "grep", "shell", "websearch", "webfetch"},
"committer": {"read", "glob", "grep", "shell"},
},
"debug": {
"diagnose": {"read", "glob", "grep", "shell"},
"fix": {"read", "glob", "grep", "edit", "shell"},
"verify": {"read", "glob", "grep", "shell"},
"committer": {"read", "glob", "grep", "shell"},
},
}
func TestStarterRoleToolRestrictions(t *testing.T) {
parsed := parsedCatalog(t)
for key, stages := range starterTools {
graph, ok := parsed[key]
if !ok {
t.Fatalf("catalog entry %s missing", key)
}
for stageKey, want := range stages {
tools, explicit := stageTools(t, graph, stageKey)
if !explicit {
t.Fatalf("%s/%s must declare an explicit tools block", key, stageKey)
}
sortedWant := slices.Clone(want)
slices.Sort(sortedWant)
if !slices.Equal(tools, sortedWant) {
t.Fatalf("%s/%s tools = %v, want %v", key, stageKey, tools, sortedWant)
}
}
}
}
func TestThreeStagePlannerBlockedRoute(t *testing.T) {
graph := parsedCatalog(t)["three-stage"]
for _, s := range graph.Stages {
if s.Key == "planner" {
if got := s.Edges["blocked"]; got != protocol.FailureEnd {
t.Fatalf("planner blocked route = %q, want %q", got, protocol.FailureEnd)
}
}
}
}
func TestThreeStageUsesTurnFilesWithoutRetiredBlocks(t *testing.T) {
graph := parsedCatalog(t)["three-stage"]
for _, s := range graph.Stages {
if len(s.Memory) != 0 {
t.Fatalf("%s stage %s must not use the retired memory block: %v", "three-stage", s.Key, s.Memory)
}
if s.Output != "" {
t.Fatalf("%s stage %s must not declare the retired output block", "three-stage", s.Key)
}
}
var reviewer protocol.Stage
for _, s := range graph.Stages {
if s.Key == "reviewer" {
reviewer = s
}
}
if reviewer.Key == "" || !strings.Contains(strings.ToLower(reviewer.Prompt), "independently review") {
t.Fatalf("three-stage reviewer must independently review the full diff: %+v", reviewer)
}
}
// TestWorkProducingStartersEndInACommitter pins the guideline that a workflow
// which changes the repository commits locally through its final committer stage,
// staging the server-captured change set rather than only a model's declaration.
func TestWorkProducingStartersEndInACommitter(t *testing.T) {
for _, tc := range []struct{ key, producer string }{
{"task", "worker"},
{"three-stage", "implementer"},
{"debug", "fix"},
} {
graph := parsedCatalog(t)[tc.key]
last := graph.Stages[len(graph.Stages)-1]
if last.Key != "committer" {
t.Fatalf("%s must end in a committer stage, got %q", tc.key, last.Key)
}
if got := last.Edges["success"]; got != protocol.SuccessEnd {
t.Fatalf("%s committer success route = %q, want %q", tc.key, got, protocol.SuccessEnd)
}
if len(last.Memory) != 0 || last.Output != "" {
t.Fatalf("%s committer must use the turn files, not retired blocks: %+v", tc.key, last)
}
if !strings.Contains(last.Prompt, "diff") {
t.Fatalf("%s committer prompt must inspect the actual diff", tc.key)
}
// The producer hands its work on rather than ending the run itself.
for _, s := range graph.Stages {
if s.Key == tc.producer {
if protocol.IsTerminal(s.Edges["success"]) {
t.Fatalf("%s/%s must hand success to a later stage, not %q", tc.key, tc.producer, s.Edges["success"])
}
}
}
}
}