bd4f1437bc
Adds a SKILL.md bundle validator, immutable per-skill versions with content digests and deduplication, protocol requests to import, list and show skills, and the pipelines skills import/list/show commands. Imports are serialised so concurrent imports never share a version number.
94 lines
3.2 KiB
Go
94 lines
3.2 KiB
Go
package server
|
|
|
|
import (
|
|
"context"
|
|
"net/http/httptest"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/coder/websocket"
|
|
"github.com/coder/websocket/wsjson"
|
|
|
|
"git.a-wan.net/alan/pipelines/internal/pipeline"
|
|
"git.a-wan.net/alan/pipelines/internal/protocol"
|
|
"git.a-wan.net/alan/pipelines/internal/skills"
|
|
)
|
|
|
|
func TestSkillWebSocketHandlers(t *testing.T) {
|
|
ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
|
|
defer cancel()
|
|
store, err := pipeline.Open(filepath.Join(t.TempDir(), "skills.db"))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer store.Close()
|
|
handler := Handler(ctx, store)
|
|
srv := httptest.NewServer(handler)
|
|
defer srv.Close()
|
|
defer func() { cancel(); WaitRuns(handler) }()
|
|
|
|
conn, _, err := websocket.Dial(ctx, "ws"+strings.TrimPrefix(srv.URL, "http")+"/connect", nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
defer conn.CloseNow()
|
|
var welcome protocol.Message
|
|
if err := wsjson.Read(ctx, conn, &welcome); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
dir := t.TempDir()
|
|
if err := writeSkillFixture(dir); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
bundle, err := skills.Validate(dir)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
files := make([]protocol.SkillFile, len(bundle.Files))
|
|
for i, file := range bundle.Files {
|
|
files[i] = protocol.SkillFile{Path: file.Path, Bytes: file.Bytes}
|
|
}
|
|
request := protocol.Message{Type: protocol.ImportSkill, ID: "import", Name: bundle.Name, Description: bundle.Description, Digest: bundle.Digest, SourcePath: dir, SkillFiles: files}
|
|
response := skillRequest(t, ctx, conn, request)
|
|
if response.Type != protocol.SkillImported || response.SkillVersion == nil || response.SkillVersion.Version != 1 {
|
|
t.Fatalf("import response = %+v", response)
|
|
}
|
|
|
|
response = skillRequest(t, ctx, conn, protocol.Message{Type: protocol.ListSkills, ID: "list"})
|
|
if response.Type != protocol.Skills || len(response.SkillSummaries) != 1 || response.SkillSummaries[0].Name != bundle.Name {
|
|
t.Fatalf("list response = %+v", response)
|
|
}
|
|
response = skillRequest(t, ctx, conn, protocol.Message{Type: protocol.ShowSkill, ID: "show", Name: bundle.Name})
|
|
if response.Type != protocol.Skill || response.SkillVersion == nil || response.SkillVersion.SkillMD == "" {
|
|
t.Fatalf("show response = %+v", response)
|
|
}
|
|
|
|
response = skillRequest(t, ctx, conn, protocol.Message{Type: protocol.ImportSkill, ID: "bad", Name: bundle.Name, SourcePath: dir, Digest: bundle.Digest, SkillFiles: []protocol.SkillFile{{Path: "../escape", Bytes: []byte("x")}}})
|
|
if response.Type != protocol.Error || response.Error == "" {
|
|
t.Fatalf("invalid import response = %+v", response)
|
|
}
|
|
}
|
|
|
|
func skillRequest(t *testing.T, ctx context.Context, conn *websocket.Conn, request protocol.Message) protocol.Message {
|
|
t.Helper()
|
|
if err := wsjson.Write(ctx, conn, request); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
var response protocol.Message
|
|
if err := wsjson.Read(ctx, conn, &response); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if response.ID != request.ID {
|
|
t.Fatalf("response ID = %q, want %q", response.ID, request.ID)
|
|
}
|
|
return response
|
|
}
|
|
|
|
func writeSkillFixture(dir string) error {
|
|
return os.WriteFile(filepath.Join(dir, "SKILL.md"), []byte("---\nname: websocket-skill\ndescription: Handler test\n---\n\nDo not execute this.\n"), 0600)
|
|
}
|