7d9b6c1d1b
Prioritize the conversation title on narrow chat bars, move compact controls and overflow actions into More, and omit the duplicate title in floating windows. Add focused widget coverage for title sizing, icon dimensions, menus, and floating chrome.
479 lines
15 KiB
Dart
479 lines
15 KiB
Dart
import 'dart:async';
|
|
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:pipelines_app/core/api_gateway.dart';
|
|
import 'package:pipelines_app/core/transport/connection_state.dart';
|
|
import 'package:pipelines_app/features/chat/conversation/chat_models.dart';
|
|
import 'package:pipelines_app/features/chat/conversation/chat_thread_view.dart';
|
|
import 'package:pipelines_app/ui/adaptive/segmented_bar.dart'
|
|
show segmentedMoreKey;
|
|
|
|
/// A chat thread gateway with scripted model catalog and switch replies.
|
|
class _ModelGateway implements ApiGateway {
|
|
final calls = <({String type, JsonMap fields})>[];
|
|
|
|
JsonMap modelsReply = const {'chat_models': []};
|
|
JsonMap switchReply = const {};
|
|
String? switchRefusal;
|
|
String? modelsRefusal;
|
|
|
|
/// Holds a `chat_model` reply until the test completes it.
|
|
Completer<void>? switchGate;
|
|
|
|
@override
|
|
Future<JsonMap> call(String type, [JsonMap fields = const {}]) async {
|
|
calls.add((type: type, fields: fields));
|
|
switch (type) {
|
|
case 'chat_subscribe':
|
|
return <String, dynamic>{};
|
|
case 'chat_messages':
|
|
return {
|
|
'chat_history': {
|
|
'messages': const [],
|
|
'next_cursor': '',
|
|
'has_more': false,
|
|
},
|
|
};
|
|
case 'chat_models':
|
|
final refusal = modelsRefusal;
|
|
if (refusal != null) throw ProtocolError(refusal);
|
|
return modelsReply;
|
|
case 'chat_model':
|
|
final refusal = switchRefusal;
|
|
if (refusal != null) throw ProtocolError(refusal);
|
|
final gate = switchGate;
|
|
if (gate != null) await gate.future;
|
|
return switchReply;
|
|
}
|
|
return <String, dynamic>{};
|
|
}
|
|
|
|
@override
|
|
Stream<JsonMap> get frames => const Stream.empty();
|
|
|
|
JsonMap? lastFields(String type) {
|
|
for (final call in calls.reversed) {
|
|
if (call.type == type) return call.fields;
|
|
}
|
|
return null;
|
|
}
|
|
}
|
|
|
|
Widget _host(Widget child) => MaterialApp(
|
|
theme: ThemeData(platform: TargetPlatform.android),
|
|
home: Scaffold(body: child),
|
|
);
|
|
|
|
const _session = <String, dynamic>{
|
|
'id': 's',
|
|
'backend': 'opencode',
|
|
'model': 'model-a',
|
|
'model_provider': 'p1',
|
|
};
|
|
|
|
/// The same opened row with some recorded facts replaced.
|
|
JsonMap _withSession(Map<String, dynamic> changes) => {..._session, ...changes};
|
|
|
|
Future<void> _openThread(
|
|
WidgetTester tester,
|
|
_ModelGateway gateway, {
|
|
JsonMap session = _session,
|
|
ValueChanged<ChatModelSelection>? onChanged,
|
|
}) async {
|
|
final thread = ChatThreadView(
|
|
gateway: gateway,
|
|
sessionId: 's',
|
|
session: session,
|
|
onBack: () {},
|
|
onModelChanged: onChanged,
|
|
);
|
|
await tester.pumpWidget(_host(thread));
|
|
await tester.pumpAndSettle();
|
|
}
|
|
|
|
Future<void> _openChooser(WidgetTester tester) async {
|
|
// A narrow bar keeps the model in the More menu's settings sheet.
|
|
if (find.byKey(const Key('chat-model')).evaluate().isEmpty) {
|
|
await tester.tap(find.byKey(segmentedMoreKey).hitTestable());
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(find.text('Chat settings'));
|
|
await tester.pumpAndSettle();
|
|
}
|
|
await tester.tap(find.byKey(const Key('chat-model')));
|
|
await tester.pumpAndSettle();
|
|
}
|
|
|
|
const _catalog = <String, dynamic>{
|
|
'chat_models': [
|
|
{'id': 'model-a', 'provider': 'p1', 'name': 'Model Alpha'},
|
|
{'id': 'model-b', 'provider': 'p2', 'name': 'Model Beta'},
|
|
],
|
|
};
|
|
|
|
void main() {
|
|
testWidgets('shows the recorded model and sends the web model requests', (
|
|
tester,
|
|
) async {
|
|
final gateway = _ModelGateway()
|
|
..modelsReply = _catalog
|
|
..switchReply = const {
|
|
'chat_model': {'session_id': 's', 'provider': 'p2', 'model': 'model-b'},
|
|
};
|
|
await _openThread(tester, gateway);
|
|
|
|
expect(find.text('model-a'), findsOneWidget);
|
|
|
|
await _openChooser(tester);
|
|
|
|
expect(find.text('Change model'), findsOneWidget);
|
|
expect(find.text('Applies to the next turn in this chat.'), findsOneWidget);
|
|
expect(find.text('Model Alpha'), findsOneWidget);
|
|
expect(find.text('Model Beta'), findsOneWidget);
|
|
expect(gateway.lastFields('chat_models'), {
|
|
'chat_query': {'session_id': 's'},
|
|
});
|
|
|
|
await tester.tap(find.text('Model Beta'));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(gateway.lastFields('chat_model'), {
|
|
'chat_model': {'session_id': 's', 'provider': 'p2', 'model': 'model-b'},
|
|
});
|
|
expect(find.byKey(const Key('chat-model-chooser')), findsNothing);
|
|
expect(find.text('model-b'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('choosing the current model only dismisses the chooser', (
|
|
tester,
|
|
) async {
|
|
final gateway = _ModelGateway()..modelsReply = _catalog;
|
|
await _openThread(tester, gateway);
|
|
await _openChooser(tester);
|
|
|
|
await tester.tap(find.text('Model Alpha'));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.byKey(const Key('chat-model-chooser')), findsNothing);
|
|
expect(gateway.lastFields('chat_model'), isNull);
|
|
});
|
|
|
|
testWidgets('a refusal keeps the previous model and shows the reason', (
|
|
tester,
|
|
) async {
|
|
final gateway = _ModelGateway()
|
|
..modelsReply = _catalog
|
|
..switchRefusal = 'This harness does not support changing models.';
|
|
await _openThread(tester, gateway);
|
|
|
|
await _openChooser(tester);
|
|
await tester.tap(find.text('Model Beta'));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(
|
|
find.text('This harness does not support changing models.'),
|
|
findsOneWidget,
|
|
);
|
|
expect(find.byKey(const Key('chat-model-chooser')), findsOneWidget);
|
|
expect(find.text('model-a'), findsOneWidget);
|
|
|
|
await tester.tap(find.byKey(const Key('chat-model-cancel')));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.byKey(const Key('chat-model-chooser')), findsNothing);
|
|
expect(find.text('model-a'), findsOneWidget);
|
|
expect(find.text('model-b'), findsNothing);
|
|
});
|
|
|
|
testWidgets('an accepted switch shows the server-reported model ', (
|
|
tester,
|
|
) async {
|
|
final gateway = _ModelGateway()
|
|
..modelsReply = _catalog
|
|
..switchReply = const {
|
|
'chat_model': {
|
|
'session_id': 's',
|
|
'provider': 'p2',
|
|
'model': 'server-reported-model',
|
|
'selection': 'next_turn',
|
|
},
|
|
};
|
|
await _openThread(tester, gateway);
|
|
|
|
await _openChooser(tester);
|
|
await tester.tap(find.text('Model Beta'));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('server-reported-model · next turn'), findsOneWidget);
|
|
expect(tester.takeException(), isNull);
|
|
});
|
|
|
|
testWidgets('lists only the server catalog and reports an empty one', (
|
|
tester,
|
|
) async {
|
|
final gateway = _ModelGateway()
|
|
..modelsReply = const {
|
|
'chat_models': [
|
|
{'id': 'only-recorded', 'provider': 'p1'},
|
|
],
|
|
};
|
|
await _openThread(tester, gateway);
|
|
|
|
await _openChooser(tester);
|
|
|
|
expect(find.text('only-recorded'), findsOneWidget);
|
|
expect(find.text('Model Alpha'), findsNothing);
|
|
expect(find.text('Model Beta'), findsNothing);
|
|
|
|
await tester.tap(find.byKey(const Key('chat-model-cancel')));
|
|
await tester.pumpAndSettle();
|
|
|
|
gateway.modelsReply = const {'chat_models': []};
|
|
await _openChooser(tester);
|
|
|
|
expect(find.text('No models are available for this chat.'), findsOneWidget);
|
|
expect(find.text('only-recorded'), findsNothing);
|
|
});
|
|
|
|
testWidgets('reports the accepted server echo to the conversation', (
|
|
tester,
|
|
) async {
|
|
final reported = <ChatModelSelection>[];
|
|
final gateway = _ModelGateway()
|
|
..modelsReply = _catalog
|
|
..switchReply = const {
|
|
'chat_model': {
|
|
'session_id': 's',
|
|
'provider': 'p2',
|
|
'model': 'server-reported-model',
|
|
'selection': 'next_turn',
|
|
},
|
|
};
|
|
await _openThread(tester, gateway, onChanged: reported.add);
|
|
|
|
await _openChooser(tester);
|
|
await tester.tap(find.text('Model Beta'));
|
|
await tester.pumpAndSettle();
|
|
|
|
// The server's echo, not the tapped row (`model-b`).
|
|
expect(reported, [
|
|
(provider: 'p2', model: 'server-reported-model', selection: 'next_turn'),
|
|
]);
|
|
});
|
|
|
|
testWidgets('shows the recorded next-turn selection before any switch', (
|
|
tester,
|
|
) async {
|
|
final gateway = _ModelGateway()..modelsReply = _catalog;
|
|
await _openThread(
|
|
tester,
|
|
gateway,
|
|
session: _withSession({'model_selection': 'next_turn'}),
|
|
);
|
|
|
|
expect(find.text('model-a · next turn'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('adopts a row the destination replaced after an accepted switch', (
|
|
tester,
|
|
) async {
|
|
final gateway = _ModelGateway()..modelsReply = _catalog;
|
|
final thread = ChatThreadView(
|
|
gateway: gateway,
|
|
sessionId: 's',
|
|
session: _session,
|
|
onBack: () {},
|
|
);
|
|
await tester.pumpWidget(_host(thread));
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('model-a'), findsOneWidget);
|
|
|
|
await tester.pumpWidget(
|
|
_host(
|
|
ChatThreadView(
|
|
gateway: gateway,
|
|
sessionId: 's',
|
|
session: _withSession({
|
|
'model': 'model-b',
|
|
'model_provider': 'p2',
|
|
'model_selection': 'next_turn',
|
|
}),
|
|
onBack: () {},
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(find.text('model-b · next turn'), findsOneWidget);
|
|
expect(find.text('model-a'), findsNothing);
|
|
|
|
// The chooser marks the replaced row, not the one this control first read.
|
|
await _openChooser(tester);
|
|
expect(
|
|
find.descendant(
|
|
of: find.byKey(const Key('chat-model-option-p2/model-b')),
|
|
matching: find.byIcon(Icons.check),
|
|
),
|
|
findsOneWidget,
|
|
);
|
|
});
|
|
|
|
testWidgets('searches the catalog by name, id and provider ', (tester) async {
|
|
final gateway = _ModelGateway()..modelsReply = _catalog;
|
|
await _openThread(tester, gateway);
|
|
await _openChooser(tester);
|
|
|
|
final search = find.byKey(const Key('chat-model-search'));
|
|
expect(search, findsOneWidget);
|
|
|
|
await tester.enterText(search, 'beta');
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('Model Beta'), findsOneWidget);
|
|
expect(find.text('Model Alpha'), findsNothing);
|
|
|
|
await tester.enterText(search, 'P1');
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('Model Alpha'), findsOneWidget);
|
|
expect(find.text('Model Beta'), findsNothing);
|
|
|
|
await tester.enterText(search, 'zzz');
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('No models match "zzz".'), findsOneWidget);
|
|
expect(find.text('Model Alpha'), findsNothing);
|
|
expect(find.text('Model Beta'), findsNothing);
|
|
|
|
await tester.enterText(search, '');
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('Model Alpha'), findsOneWidget);
|
|
expect(find.text('Model Beta'), findsOneWidget);
|
|
expect(find.text('No models match "zzz".'), findsNothing);
|
|
});
|
|
|
|
testWidgets('marks the current row by id and provider when ids repeat', (
|
|
tester,
|
|
) async {
|
|
final gateway = _ModelGateway()
|
|
..modelsReply = const {
|
|
'chat_models': [
|
|
{'id': 'shared', 'provider': 'p1', 'name': 'One'},
|
|
{'id': 'shared', 'provider': 'p2', 'name': 'Two'},
|
|
],
|
|
};
|
|
await _openThread(
|
|
tester,
|
|
gateway,
|
|
session: _withSession({'model': 'shared', 'model_provider': 'p2'}),
|
|
);
|
|
await _openChooser(tester);
|
|
|
|
expect(
|
|
find.descendant(
|
|
of: find.byKey(const Key('chat-model-option-p2/shared')),
|
|
matching: find.byIcon(Icons.check),
|
|
),
|
|
findsOneWidget,
|
|
);
|
|
expect(
|
|
find.descendant(
|
|
of: find.byKey(const Key('chat-model-option-p1/shared')),
|
|
matching: find.byIcon(Icons.check),
|
|
),
|
|
findsNothing,
|
|
);
|
|
});
|
|
|
|
testWidgets('shows no control for a harness without model switching', (
|
|
tester,
|
|
) async {
|
|
final gateway = _ModelGateway()..modelsReply = _catalog;
|
|
await _openThread(
|
|
tester,
|
|
gateway,
|
|
session: _withSession({'backend': 'other'}),
|
|
);
|
|
|
|
expect(find.byKey(const Key('chat-model')), findsNothing);
|
|
expect(gateway.lastFields('chat_models'), isNull);
|
|
});
|
|
|
|
testWidgets('reports a catalog failure and keeps the recorded model', (
|
|
tester,
|
|
) async {
|
|
final gateway = _ModelGateway()
|
|
..modelsRefusal = 'The harness is not running.';
|
|
await _openThread(tester, gateway);
|
|
|
|
await _openChooser(tester);
|
|
|
|
expect(find.text('The harness is not running.'), findsOneWidget);
|
|
expect(find.byKey(const Key('chat-model-error')), findsOneWidget);
|
|
expect(find.text('No models are available for this chat.'), findsNothing);
|
|
|
|
await tester.tap(find.byKey(const Key('chat-model-cancel')));
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('model-a'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('the chooser fits the smallest surface at 2x text ', (
|
|
tester,
|
|
) async {
|
|
tester.view.physicalSize = const Size(320, 640);
|
|
tester.view.devicePixelRatio = 1;
|
|
tester.platformDispatcher.textScaleFactorTestValue = 2;
|
|
addTearDown(tester.view.resetPhysicalSize);
|
|
addTearDown(tester.view.resetDevicePixelRatio);
|
|
addTearDown(tester.platformDispatcher.clearTextScaleFactorTestValue);
|
|
|
|
final gateway = _ModelGateway()
|
|
..modelsReply = {
|
|
'chat_models': [
|
|
for (var index = 1; index <= 6; index++)
|
|
{
|
|
'id': 'model-$index',
|
|
'provider': 'provider-$index',
|
|
'name': 'Model number $index with a longer name',
|
|
},
|
|
],
|
|
};
|
|
await _openThread(tester, gateway);
|
|
await _openChooser(tester);
|
|
|
|
expect(find.byKey(const Key('chat-model-chooser')), findsOneWidget);
|
|
expect(find.byKey(const Key('chat-model-search')), findsOneWidget);
|
|
expect(tester.takeException(), isNull);
|
|
// Every row is built inside the dialog's own scroll view.
|
|
expect(find.textContaining('Model number 6'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('an accepted switch applies after the chooser was dismissed', (
|
|
tester,
|
|
) async {
|
|
final reported = <ChatModelSelection>[];
|
|
final gateway = _ModelGateway()
|
|
..modelsReply = _catalog
|
|
..switchReply = const {
|
|
'chat_model': {'session_id': 's', 'provider': 'p2', 'model': 'model-b'},
|
|
}
|
|
..switchGate = Completer<void>();
|
|
await _openThread(tester, gateway, onChanged: reported.add);
|
|
|
|
await _openChooser(tester);
|
|
await tester.tap(find.text('Model Beta'));
|
|
await tester.pump();
|
|
|
|
// The switch is in flight, so the operator can still dismiss the chooser.
|
|
await tester.tap(find.byKey(const Key('chat-model-cancel')));
|
|
await tester.pumpAndSettle();
|
|
expect(find.byKey(const Key('chat-model-chooser')), findsNothing);
|
|
expect(find.text('model-a'), findsOneWidget);
|
|
|
|
gateway.switchGate!.complete();
|
|
await tester.pumpAndSettle();
|
|
|
|
// The server applied the switch; the conversation reports it rather than
|
|
// silently dropping it with the dismissed dialog.
|
|
expect(find.text('model-b'), findsOneWidget);
|
|
expect(reported.single.model, 'model-b');
|
|
});
|
|
}
|