227c036aa5
A new terminal runs su -l for the server's own account in its PTY, so the operator types the account password before getting a shell. Opening is refused when su is missing, the server runs as root, or su opens a shell without asking. The Pipelines-owned tmux backing, its reattach and its persisted session names are removed: terminals end with the server and are listed as ended. A starting server ends leftover pipelines-term_* sessions on tmux -L pipelines only.
70 lines
2.1 KiB
Go
70 lines
2.1 KiB
Go
package server
|
|
|
|
import (
|
|
"log"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strings"
|
|
)
|
|
|
|
// Earlier servers kept each terminal's shell in a session `pipelines-<id>`
|
|
// of a Pipelines-owned tmux server (`tmux -L pipelines -f /dev/null`).
|
|
// Terminals now end with the server, so a starting server ends the sessions
|
|
// such a server left behind. Only that socket and only sessions with that
|
|
// name prefix are touched, never the operator's own tmux.
|
|
const (
|
|
legacyTerminalTmuxSocket = "pipelines"
|
|
legacyTerminalTmuxPrefix = "pipelines-term_"
|
|
)
|
|
|
|
// EndLegacyTerminalTmux ends the terminal sessions an earlier Pipelines
|
|
// server left in its own tmux server (that tmux server exits with its last
|
|
// session). It does nothing where tmux is not installed or not running.
|
|
func EndLegacyTerminalTmux() { endLegacyTerminalTmux(legacyTerminalTmuxSocket) }
|
|
|
|
func endLegacyTerminalTmux(socket string) int {
|
|
program := findLegacyTmux()
|
|
if program == "" {
|
|
return 0
|
|
}
|
|
tmux := func(args ...string) *exec.Cmd {
|
|
cmd := exec.Command(program, append([]string{"-L", socket, "-f", os.DevNull}, args...)...)
|
|
cmd.Env = terminalEnv(os.Environ(), "")
|
|
return cmd
|
|
}
|
|
out, err := tmux("list-sessions", "-F", "#{session_name}").Output()
|
|
if err != nil {
|
|
return 0 // no tmux server on that socket
|
|
}
|
|
ended := 0
|
|
for _, name := range strings.Fields(string(out)) {
|
|
if !strings.HasPrefix(name, legacyTerminalTmuxPrefix) {
|
|
continue
|
|
}
|
|
if err := tmux("kill-session", "-t", "="+name).Run(); err != nil {
|
|
log.Printf("terminal: ending leftover tmux session %s: %v", name, err)
|
|
continue
|
|
}
|
|
ended++
|
|
}
|
|
if ended > 0 {
|
|
log.Printf("terminal: ended %d tmux session(s) an earlier Pipelines server left on tmux -L %s", ended, socket)
|
|
}
|
|
return ended
|
|
}
|
|
|
|
// findLegacyTmux is tmux on PATH or in the usual package-manager locations.
|
|
func findLegacyTmux() string {
|
|
if program, err := exec.LookPath("tmux"); err == nil {
|
|
return program
|
|
}
|
|
for _, dir := range []string{"/opt/homebrew/bin", "/usr/local/bin", "/usr/bin"} {
|
|
candidate := filepath.Join(dir, "tmux")
|
|
if info, err := os.Stat(candidate); err == nil && !info.IsDir() && info.Mode()&0o111 != 0 {
|
|
return candidate
|
|
}
|
|
}
|
|
return ""
|
|
}
|