Detail bodies are flat on the page on both hosts (no Cupertino inset groups, pinned headings on the page colour). Run and pipeline Summary share a FactsGrid that fills its width (no centred single-fact card). Missing run graph is one muted line. Beside a list the run tabs and header share one row; the duplicate Pipeline fact and the decision card-in-card are gone. Pipeline Summary: facts grid, Schedules heading with Add (no inline Refresh or paragraph), versions as AppListRow. Timeline rows are AppListRow.
8.2 KiB
Run, stage and pipeline detail bodies (style review round 2: B, C, E)
These are fixes from the second style review
(/tmp/app-style-review-r2/report-summary.md):
- P1-2: Cupertino summary pages were a patchwork of grouped bands.
- P2-2: run detail chrome.
- P2-3: the pipeline Summary read as a document.
The shell, the floating destination bar, templates, settings, chat,
segmented_bar*.dart and sticky_section.dart were out of scope and are
untouched.
One approach: flat on the page, both hosts
The run detail, the stage (visit) page and the pipeline detail now use the
flat list style on both hosts, as Material already did. The Cupertino page
stays the theme's page colour (AppColors.background: white, or #141416 in
dark mode). Content sits directly on it:
- facts as a grid;
- sections under quiet headings;
- rows as
AppListRowwith inset dividers.
There is no CupertinoListSection.insetGrouped left in these bodies, so no
group can be nested inside another. Settings and Templates keep their grouped
background. They are lists of settings and choices, not detail documents.
SectionHeadingStyle(lib/ui/layout/section_heading.dart):- On Cupertino, the background and body are now the theme's
scaffoldBackgroundColor, notsystemGroupedBackground. Pinned sticky headings (Input/Output, the artifact groups) used to be grey bands, or black bands in dark mode. They now blend into the page, as on Material.sticky_section.dartitself is unchanged. - New
headerflag: it marks the title (only) as a heading for semantics.
- On Cupertino, the background and body are now the theme's
FactsGrid(lib/ui/layout/facts_grid.dart, new) is shared by the run and pipeline Summaries:- two facts per line below 600 wide, three from 600;
- a long (over 28 characters),
wideor monospace value takes a whole line; - the
Wrapis wrapped in a full-widthSizedBox, so a single fact sits at x=16 instead of a half-width card centred on the page; - no card of its own;
- optional
cupertinooverride.
- Run Summary (
run_detail_tab_bodies.dart):- the facts are a
FactsGrid, keepingrun-detail-summary-factsand therun-detail-summary-<slug>cell keys; - the Cupertino Input/Output field tabs no longer wrap the body in an inset group;
- the old
_summaryFactswas removed.
- the facts are a
- Timeline (
run_detail_timeline.dart):- rows are
AppListRowwith the status avatar (as in the runs list); - the title is the visit, the time is the duration, and the line is the
outcome chip then
→ target; - inset dividers between rows, on a flat list on both hosts;
- the "Timeline" group header and the
CupertinoListTile/ListTileare gone; - the keys
run-timeline-visit-<seq>andrun-detail-tab-body-timelineare kept.
- rows are
- Stage Session (
run_detail_visit_session.dart): the Cupertino inset group is gone, and the body is the same padded flat list as on Material. ArtifactDocumentSection: the Cupertino "Turn documents" inset group (the group nested in the Session group) is now the same flat titled rows as on Material, with the heading in the quiet section style.ArtifactVisitList: the grid/list switch's pinned bar wasStickyBar, a grouped-background band. It is now a localPinnedHeaderSliveron the heading/page colour.- The standalone
ArtifactGalleryPageno longer forces the grouped background on Cupertino.
Run detail chrome (P2-2)
- No graph:
RunGraphPreviewnow showsrunGraphMissingas one muted line (keyrun-graph-preview-missing). There is no 200px outlined box, and nothing to tap or open. - Wide (pane tabs at the top, pane at least 600 wide):
RunDetailWideChrome(new,run_detail_wide_chrome.dart) puts the tabs and the header (status kicker, Cancel/Retry, notices, decision banner) in one floating row under the bar;- the tabs lead, in line with the title pill, and take at most 60% of the
row; the header follows as a glass piece (key
run-detail-header); - before, this was title pill, then the status strip, then the tabs strip: about 200px before content;
- narrower panes and phone pages keep the header strip under the bar, with the tabs at the bottom.
- The Pipeline fact is dropped from the Summary when the run has a pipeline
name. That name is already in the bar's subtitle, and the title opens the
pipeline.
detailSummaryRowsitself is unchanged. - Decision banner: the tinted, bordered card inside the grey header strip is
now a flat line of the strip. It keeps the teal glyph, the title over the
meta line, and Decide. The key
run-decision-banneris kept.
Pipeline Summary (P2-3)
- Facts: the five label/value rows are now a
FactsGrid(keypipeline-summary-facts, cellspipeline-summary-<slug>).- The content hash takes a whole line (
wide). It keeps the host font, because the pipeline detail's no-monospace choice is untouched (P2-6 is still a pending decision). - Blank values are omitted instead of drawn empty.
- The content hash takes a whole line (
- Schedules (
schedule_pipeline_list_body.dart):- The heading is a quiet
SectionHeading("Schedules (n)"), with Add as its only trailing action: an icon button whose tooltip/semantics is "Add schedule" (keyschedule-pipeline-addkept). - The inline Refresh is removed, with
scheduleRefreshKey/Label. The section reloads after every accepted mutation and has Retry on failure. Note that the pipeline bar has no Refresh. The review assumed it did. - The standing paragraph is gone. Its sentence is appended to the empty state.
- The heading is a quiet
- Versions:
AppListRowrows under a quiet "Versions" heading. The title isvN, the time is the created date, and the line isN stages, pluslatestwhen it is the latest version.- The shown version is the selected row (fill and selected semantics). This replaces the check icon.
- "View latest vN" is a row too.
- Keys
pipeline-version-<n>andpipeline-latest-versionare kept.
Tests
- New:
test/features/runs/ui/run_detail_flat_bodies_test.dart, both hosts:- no
CupertinoListSectionon Summary or Timeline; - the stage Session has Turn documents but no group (no nested groups);
- beside a list (
PageTabsEdge.top, 720 wide) the header sits to the right of the tabs and overlaps them vertically (one row); - Cupertino heading scrim equals the page colour in light and dark.
- no
test/features/pipelines/pipeline_summary_flat_test.dart, both hosts:- facts grid with short facts side by side;
- no Refresh, Add is an icon in the heading;
- no grouped section or
ListTile; - the version row is a selected
AppListRow.
run_detail_summary_fields_test:- new single-fact case: the grid spans 900, the fact is at x=16 and left of centre, and there is no group (the centred-card regression);
- the recorded-rows case now expects no Pipeline fact (it is in the bar).
run_detail_tabs_test"missing graph": now expects one line on Summary, with no preview,RunGraphViewor frame, and under 60px tall.- Updated for intentional changes:
run_timeline_row_test: target and duration split;AppListRow, no section;pipelines_adaptive_test: Cupertino version rows instead ofCupertinoListTile;schedule_pipeline_section_test: the empty text gained the note.
Evidence
Captures are in /tmp/r3-b-evidence/. They were taken with the reviewer's
driver (/tmp/r3-b-scripts/shoot.mjs, a copy of
/tmp/app-style-review-r2/shoot.mjs pointing at this worktree's
pipelines_wiring_probe_server.mjs). The spec is
/tmp/r3-b-scripts/mkspec.py.
- Runs: a web build of
tool/app_host_probe_entry.dartover the wave2-e runs fixture. - Pipelines: the same build over
pipelines_wiring_probe_server. - Names:
{m,c}-{run1,run5,stage,pdetail}-{560,1200}-{light,dark};{m,c}-{run1-timeline,stage-session,stage-artifacts}-560-{light,dark}.
There was no device run: Android and iOS are unverified.
Not done / notes
- In the stage Session, the turn documents start at x=32 to 36: the list's 16 padding plus the section's own 16. Material already rendered it this way before this change, and it was left alone.
- Summary bodies are still uncapped on wide windows. That is batch K, which is not in this scope.
- The 1200 Timeline/Session interactions were not captured. Only the 560 tab clicks were scripted.