Files

95 lines
3.1 KiB
Go

package pipeline
import (
"context"
"os"
"path/filepath"
"slices"
"testing"
"time"
)
func TestValidateRunWritePaths(t *testing.T) {
workspace, err := ResolveRunWorkspace(t.TempDir(), true)
if err != nil {
t.Fatal(err)
}
if err = os.Mkdir(filepath.Join(workspace, "internal"), 0700); err != nil {
t.Fatal(err)
}
if err = os.Symlink(t.TempDir(), filepath.Join(workspace, "escape")); err != nil {
t.Fatal(err)
}
if err = os.Symlink(filepath.Join(workspace, "internal"), filepath.Join(workspace, "inside")); err != nil {
t.Fatal(err)
}
for _, paths := range [][]string{nil, {}, {"."}, {"new.go", "internal/another/new.go"}, {"inside/new.go"}} {
if err = ValidateRunWritePaths(workspace, paths); err != nil {
t.Fatal("valid scope rejected", paths, err)
}
}
for _, paths := range invalidRunWritePaths(workspace) {
if err = ValidateRunWritePaths(workspace, paths); err == nil {
t.Fatal("invalid scope accepted", paths)
}
}
}
func invalidRunWritePaths(workspace string) [][]string {
return [][]string{{""}, {".."}, {"../outside.go"}, {"internal/../outside.go"}, {"./one.go"}, {"one//two.go"}, {"*.go"}, {"file?.go"}, {`one\two.go`}, {filepath.Join(workspace, "absolute.go")}, {"escape/new.go"}, slices.Repeat([]string{"new.go"}, 21)}
}
func TestSavedScheduleWriteScopeValidationAndIdempotency(t *testing.T) {
s, pid, spec, now := savedStoreFixture(t)
ctx := context.Background()
if err := os.Symlink(t.TempDir(), filepath.Join(spec.Workspace, "escape")); err != nil {
t.Fatal(err)
}
spec.WritePaths = []string{"internal/one.go", "README.md"}
spec.AllowTools = true
a, err := s.SaveSchedule(ctx, spec, now, "restricted-create")
if err != nil {
t.Fatal(err)
}
if !a.AllowTools || !slices.Equal(a.WritePaths, spec.WritePaths) {
t.Fatal("scope omitted on save", a)
}
for _, paths := range invalidRunWritePaths(spec.Workspace) {
bad := spec
bad.WritePaths = paths
if _, err = s.SaveSchedule(ctx, bad, now, "invalid-create"); err == nil {
t.Fatal("invalid scope created a schedule", paths)
}
bad.ID = a.ID
bad.Revision = a.Revision
if _, err = s.SaveSchedule(ctx, bad, now.Add(time.Minute)); err == nil {
t.Fatal("invalid scope edited a schedule", paths)
}
}
for _, change := range []string{"paths", "allow_tools"} {
bad := spec
if change == "paths" {
bad.WritePaths = []string{"different.go"}
} else {
bad.AllowTools = false
}
if _, err = s.SaveSchedule(ctx, bad, now, "restricted-create"); err == nil {
t.Fatal("scope missing from create payload hash", change)
}
}
other, err := Open(s.path)
if err != nil {
t.Fatal(err)
}
defer other.Close()
entries, err := other.ListSchedules(ctx, pid)
if err != nil || len(entries) != 1 || entries[0].Revision != a.Revision || entries[0].NextDue != a.NextDue || !entries[0].AllowTools || !slices.Equal(entries[0].WritePaths, spec.WritePaths) {
t.Fatal("scope changed or invalid save mutated state", entries, err)
}
// Rejected saves did not reserve their request key or consume an ID.
b, err := s.SaveSchedule(ctx, spec, now, "invalid-create")
if err != nil || b.ID != a.ID+1 {
t.Fatal(b, err)
}
}