Files
pipelines/app/test/features/settings/settings_topic_restore_test.dart
alan 3933ff980c Remove Cupertino settings branches
Keep the Material settings implementation while preserving public Cupertino parameters for later cleanup. Narrow settings tests to the Material-only behavior.
2026-11-11 05:21:30 +00:00

204 lines
6.8 KiB
Dart

import 'dart:async';
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:pipelines_app/core/servers/server_scope.dart';
import 'package:pipelines_app/core/storage/ordered_local_storage.dart';
import 'package:pipelines_app/features/settings/settings_tabs.dart';
import 'package:pipelines_app/features/settings/settings_topic_store.dart';
import 'package:shared_preferences/shared_preferences.dart';
import 'settings_topic_test_helper.dart';
Widget host({String? scope, SettingsTopicStore? store}) {
final tabs = SettingsTopicTabs(
navigationScope: scope,
selectionStore: store,
pages: {
for (final topic in SettingsTopic.values)
topic: (_) => Text('${topic.name} page'),
},
);
return MaterialApp(home: Scaffold(body: tabs));
}
class DelayedStore implements SettingsTopicStore {
final read = Completer<String?>();
final saves = <String>[];
final pending = <Completer<void>>[];
bool blockWrites = false;
@override
Future<String?> load() => read.future;
@override
Future<void> save(String topic) async {
saves.add(topic);
if (blockWrites) {
final gate = Completer<void>();
pending.add(gate);
await gate.future;
}
}
}
class SharedTopicBackend {
final firstWrite = Completer<void>();
final writes = <String>[];
String? value;
}
class SharedQueuedTopicStore implements SettingsTopicStore {
SharedQueuedTopicStore(this.backend);
final SharedTopicBackend backend;
@override
Future<String?> load() async => backend.value;
@override
Future<void> save(String topic) async {
backend.writes.add(topic);
if (backend.writes.length == 1) await backend.firstWrite.future;
backend.value = topic;
}
}
void main() {
testWidgets('restores selected category after recreation', (tester) async {
SharedPreferences.setMockInitialValues({});
await tester.pumpWidget(host(scope: 'server-a'));
await tester.pumpAndSettle();
await selectSettingsTopic(tester, 'Connection');
expect(find.text('connection page'), findsOneWidget);
await tester.pumpWidget(const SizedBox.shrink());
await tester.pumpWidget(host(scope: 'server-a'));
await tester.pumpAndSettle();
expect(find.text('connection page'), findsOneWidget);
final preferences = await SharedPreferences.getInstance();
expect(
preferences.getString(scopedServerKey(settingsTopicKey, 'server-a')),
'connection',
);
});
testWidgets('server scopes and malformed selections are independent', (
tester,
) async {
SharedPreferences.setMockInitialValues({
scopedServerKey(settingsTopicKey, 'server-a'): 'connection',
scopedServerKey(settingsTopicKey, 'server-b'): 'not-a-topic',
});
await tester.pumpWidget(host(scope: 'server-a'));
await tester.pumpAndSettle();
expect(find.text('connection page'), findsOneWidget);
await tester.pumpWidget(host(scope: 'server-b'));
await tester.pumpAndSettle();
expect(find.text('appearance page'), findsOneWidget);
await tester.pumpWidget(host(scope: 'server-a'));
await tester.pumpAndSettle();
expect(find.text('connection page'), findsOneWidget);
});
testWidgets('standalone category tabs do not read or write preferences', (
tester,
) async {
SharedPreferences.setMockInitialValues({settingsTopicKey: 'updates'});
await tester.pumpWidget(host());
await tester.pumpAndSettle();
expect(find.text('appearance page'), findsOneWidget);
await selectSettingsTopic(tester, 'Connection');
expect(
(await SharedPreferences.getInstance()).getString(settingsTopicKey),
'updates',
);
});
testWidgets('late restore cannot overwrite a newer user selection', (
tester,
) async {
final store = DelayedStore();
await tester.pumpWidget(host(store: store));
await selectSettingsTopic(tester, 'Connection');
store.read.complete('updates');
await tester.pumpAndSettle();
expect(find.text('connection page'), findsOneWidget);
expect(store.saves, ['connection']);
});
testWidgets('writes are serialized so the latest selection wins last', (
tester,
) async {
final store = DelayedStore()..blockWrites = true;
store.read.complete(null);
await tester.pumpWidget(host(store: store));
await tester.pumpAndSettle();
await selectSettingsTopic(tester, 'Connection');
await selectSettingsTopic(tester, 'Notifications');
expect(store.saves, ['connection']);
store.pending.first.complete();
await tester.pumpAndSettle();
expect(store.saves, ['connection', 'notifications']);
store.pending.last.complete();
await tester.pumpAndSettle();
expect(find.text('notifications page'), findsOneWidget);
});
for (final newerChoice in [false, true]) {
testWidgets('recreation preserves accepted B; newer choice: $newerChoice', (
tester,
) async {
final backend = SharedTopicBackend();
final store = SharedQueuedTopicStore(backend);
await tester.pumpWidget(host(store: store));
await tester.pumpAndSettle();
await selectSettingsTopic(tester, 'Connection');
expect(backend.writes, ['connection']);
await selectSettingsTopic(tester, 'Notifications');
expect(backend.writes, ['connection']);
await tester.pumpWidget(const SizedBox.shrink());
await tester.pumpWidget(host(store: store));
if (newerChoice) await selectSettingsTopic(tester, 'Tools');
backend.firstWrite.complete();
await tester.pumpAndSettle();
expect(
find.text(newerChoice ? 'tools page' : 'notifications page'),
findsOneWidget,
);
expect(backend.value, newerChoice ? 'tools' : 'notifications');
expect(backend.writes, [
'connection',
'notifications',
if (newerChoice) 'tools',
]);
});
}
testWidgets('production replacement reads after all accepted old writes', (
tester,
) async {
SharedPreferences.setMockInitialValues({});
const oldStore = SharedPreferencesSettingsTopicStore('ownership-check');
final gate = Completer<void>();
final oldA = orderedLocalStorage(oldStore.key, () async {
await gate.future;
await (await SharedPreferences.getInstance()).setString(
oldStore.key,
'connection',
);
});
final oldB = oldStore.save('notifications');
final replacement = SharedPreferencesSettingsTopicStore('ownership-check');
var readFinished = false;
final read = replacement.load().then((value) {
readFinished = true;
return value;
});
await tester.pump();
expect(readFinished, isFalse);
gate.complete();
await oldA;
await oldB;
expect(await read, 'notifications');
await replacement.save('tools');
expect(
(await SharedPreferences.getInstance()).getString(oldStore.key),
'tools',
);
});
}