a7c41063fa
Keep the Material-only settings implementation and its focused tests while preserving public cupertino parameters for later cleanup. This removes unreachable platform-specific widgets and test variants without changing the Material path.
212 lines
7.4 KiB
Dart
212 lines
7.4 KiB
Dart
import 'dart:async';
|
|
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:pipelines_app/core/api_gateway.dart';
|
|
import 'package:pipelines_app/core/transport/connection_state.dart';
|
|
import 'package:pipelines_app/features/settings/settings_ntfy_section.dart';
|
|
|
|
/// A scripted gateway: records every request and answers from [respond].
|
|
class _Gateway implements ApiGateway {
|
|
_Gateway(this.respond);
|
|
|
|
final FutureOr<JsonMap> Function(String type, JsonMap fields) respond;
|
|
final calls = <(String, JsonMap)>[];
|
|
|
|
@override
|
|
Future<JsonMap> call(String type, [JsonMap fields = const {}]) async {
|
|
calls.add((type, fields));
|
|
return respond(type, fields);
|
|
}
|
|
|
|
@override
|
|
Stream<JsonMap> get frames => const Stream.empty();
|
|
}
|
|
|
|
JsonMap _reply(bool run, bool needs, bool reply) => {
|
|
'type': 'notification_settings',
|
|
'notification_settings': {
|
|
'run_finished': run,
|
|
'chat_needs_you': needs,
|
|
'chat_reply_finished': reply,
|
|
},
|
|
};
|
|
|
|
Widget _host(ApiGateway gateway) {
|
|
final body = SingleChildScrollView(
|
|
child: SettingsNtfySection(gateway: gateway, connected: true),
|
|
);
|
|
return MaterialApp(home: Scaffold(body: body));
|
|
}
|
|
|
|
bool _checked(WidgetTester tester, String key) {
|
|
final tile = find.byKey(ntfySettingKey(key));
|
|
return tester.widget<CheckboxListTile>(tile).value!;
|
|
}
|
|
|
|
void main() {
|
|
testWidgets('loads the stored values', (tester) async {
|
|
final gateway = _Gateway((_, _) => _reply(true, false, true));
|
|
await tester.pumpWidget(_host(gateway));
|
|
await tester.pumpAndSettle();
|
|
expect(gateway.calls.single.$1, 'notification_settings');
|
|
expect(find.text('Notify when any run ends'), findsOneWidget);
|
|
expect(
|
|
find.text('Otherwise only runs started with Notify me'),
|
|
findsOneWidget,
|
|
);
|
|
expect(find.text('Chat needs your answer or approval'), findsOneWidget);
|
|
expect(find.text('Chat reply finished'), findsOneWidget);
|
|
expect(find.text(ntfySectionSubtitle), findsOneWidget);
|
|
expect(_checked(tester, 'run_finished'), isTrue);
|
|
expect(_checked(tester, 'chat_needs_you'), isFalse);
|
|
expect(_checked(tester, 'chat_reply_finished'), isTrue);
|
|
});
|
|
|
|
testWidgets('shows the server default: only marked runs', (tester) async {
|
|
// The server's defaults: run ends notify only for "Notify me" runs.
|
|
final gateway = _Gateway((_, _) => _reply(false, true, false));
|
|
await tester.pumpWidget(_host(gateway));
|
|
await tester.pumpAndSettle();
|
|
expect(_checked(tester, 'run_finished'), isFalse);
|
|
expect(_checked(tester, 'chat_needs_you'), isTrue);
|
|
expect(_checked(tester, 'chat_reply_finished'), isFalse);
|
|
});
|
|
|
|
testWidgets('toggling writes only that setting', (tester) async {
|
|
final gateway = _Gateway((type, fields) {
|
|
if (type == 'set_notification_settings') {
|
|
return _reply(true, true, true);
|
|
}
|
|
return _reply(true, true, false);
|
|
});
|
|
await tester.pumpWidget(_host(gateway));
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(find.byKey(ntfySettingKey('chat_reply_finished')));
|
|
await tester.pumpAndSettle();
|
|
expect(gateway.calls, hasLength(2));
|
|
expect(gateway.calls.last.$1, 'set_notification_settings');
|
|
expect(gateway.calls.last.$2, {
|
|
'notification_settings': {'chat_reply_finished': true},
|
|
});
|
|
expect(_checked(tester, 'chat_reply_finished'), isTrue);
|
|
expect(find.byKey(ntfyErrorKey), findsNothing);
|
|
});
|
|
|
|
testWidgets('failure reverts and shows the refusal', (tester) async {
|
|
final pending = Completer<JsonMap>();
|
|
final gateway = _Gateway((type, _) {
|
|
if (type == 'set_notification_settings') return pending.future;
|
|
return _reply(true, true, false);
|
|
});
|
|
await tester.pumpWidget(_host(gateway));
|
|
await tester.pumpAndSettle();
|
|
await tester.tap(find.byKey(ntfySettingKey('run_finished')));
|
|
await tester.pump();
|
|
// The change shows at once and the group is disabled while it saves.
|
|
expect(_checked(tester, 'run_finished'), isFalse);
|
|
await tester.tap(find.byKey(ntfySettingKey('chat_needs_you')));
|
|
await tester.pump();
|
|
expect(gateway.calls, hasLength(2));
|
|
pending.completeError(const ProtocolError('settings are read-only'));
|
|
await tester.pumpAndSettle();
|
|
expect(_checked(tester, 'run_finished'), isTrue);
|
|
expect(_checked(tester, 'chat_needs_you'), isTrue);
|
|
expect(
|
|
find.text('Could not save: settings are read-only'),
|
|
findsOneWidget,
|
|
);
|
|
});
|
|
|
|
testWidgets('disabled while loading and offline', (tester) async {
|
|
final pending = Completer<JsonMap>();
|
|
final gateway = _Gateway((_, _) => pending.future);
|
|
await tester.pumpWidget(_host(gateway));
|
|
await tester.pump();
|
|
expect(find.text('Loading…'), findsOneWidget);
|
|
await tester.tap(find.byKey(ntfySettingKey('run_finished')));
|
|
await tester.pump();
|
|
expect(gateway.calls, hasLength(1));
|
|
expect(
|
|
tester
|
|
.widget<CheckboxListTile>(find.byKey(ntfySettingKey('run_finished')))
|
|
.onChanged,
|
|
isNull,
|
|
);
|
|
pending.complete(_reply(true, true, false));
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('Loading…'), findsNothing);
|
|
|
|
final offline = _Gateway((_, _) => _reply(true, true, false));
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
home: Scaffold(
|
|
body: SettingsNtfySection(gateway: offline, connected: false),
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
expect(offline.calls, isEmpty);
|
|
expect(find.text(ntfyOfflineText), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('a load failure is shown with a retry', (tester) async {
|
|
var fail = true;
|
|
final gateway = _Gateway((_, _) {
|
|
if (fail) throw const ProtocolError('no store');
|
|
return _reply(false, true, false);
|
|
});
|
|
await tester.pumpWidget(_host(gateway));
|
|
await tester.pumpAndSettle();
|
|
expect(
|
|
find.text('Could not load notification settings: no store'),
|
|
findsOneWidget,
|
|
);
|
|
fail = false;
|
|
await tester.tap(find.text('Retry'));
|
|
await tester.pumpAndSettle();
|
|
expect(find.byKey(ntfyErrorKey), findsNothing);
|
|
expect(
|
|
tester
|
|
.widget<CheckboxListTile>(find.byKey(ntfySettingKey('run_finished')))
|
|
.value,
|
|
isFalse,
|
|
);
|
|
});
|
|
|
|
group('ntfy_enabled', () {
|
|
JsonMap withNtfy(bool ntfy) => {
|
|
'type': 'notification_settings',
|
|
'notification_settings': {
|
|
...(_reply(true, true, false)['notification_settings'] as Map),
|
|
'ntfy_enabled': ntfy,
|
|
},
|
|
};
|
|
|
|
testWidgets('hidden when the server does not send it', (tester) async {
|
|
final gateway = _Gateway((_, _) => _reply(true, true, false));
|
|
await tester.pumpWidget(_host(gateway));
|
|
await tester.pumpAndSettle();
|
|
expect(find.byKey(ntfySettingKey('ntfy_enabled')), findsNothing);
|
|
expect(find.text(ntfySectionSubtitle), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('shows and writes it', (tester) async {
|
|
final gateway = _Gateway(
|
|
(type, _) => withNtfy(type == 'set_notification_settings'),
|
|
);
|
|
await tester.pumpWidget(_host(gateway));
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('Also send to ntfy'), findsOneWidget);
|
|
expect(find.text(ntfySectionAppSubtitle), findsOneWidget);
|
|
expect(_checked(tester, 'ntfy_enabled'), isFalse);
|
|
await tester.tap(find.byKey(ntfySettingKey('ntfy_enabled')));
|
|
await tester.pumpAndSettle();
|
|
expect(gateway.calls.last.$2, {
|
|
'notification_settings': {'ntfy_enabled': true},
|
|
});
|
|
expect(_checked(tester, 'ntfy_enabled'), isTrue);
|
|
});
|
|
});
|
|
}
|