9adee6cc60
Keep the public Cupertino-compatible parameters while retaining only the Material implementations and tests. The app is Material-only, so deleting unreachable Cupertino branches reduces dead code without changing the active path.
218 lines
7.4 KiB
Dart
218 lines
7.4 KiB
Dart
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:pipelines_app/core/api_gateway.dart';
|
|
import 'package:pipelines_app/features/changes/changes.dart';
|
|
import 'package:pipelines_app/features/changes/widgets/visit_pager.dart';
|
|
|
|
import 'fixtures.dart';
|
|
import 'widget_hosts.dart';
|
|
|
|
List<JsonMap> twoVisitRun() => [
|
|
stepFixture(
|
|
stage: 'implementer',
|
|
sequence: 1,
|
|
fileChanges: captureFixture(
|
|
files: [
|
|
fileChangeFixture(path: 'lib/a.dart'),
|
|
fileChangeFixture(path: 'lib/b.dart'),
|
|
],
|
|
),
|
|
),
|
|
stepFixture(
|
|
stage: 'reviewer',
|
|
sequence: 2,
|
|
fileChanges: captureFixture(
|
|
files: [
|
|
fileChangeFixture(path: 'lib/b.dart'),
|
|
fileChangeFixture(path: 'lib/c.dart'),
|
|
],
|
|
),
|
|
),
|
|
];
|
|
|
|
void main() {
|
|
testWidgets(
|
|
'Previous/Next page recorded visits while the aggregate stays run-wide',
|
|
(tester) async {
|
|
await tester.pumpWidget(
|
|
materialHost(ChangesViewer(steps: twoVisitRun())),
|
|
);
|
|
|
|
// The aggregate counts each path once across both visits, and does not
|
|
// change as the operator pages.
|
|
expect(find.text('3 files changed'), findsOneWidget);
|
|
expect(find.text('1 of 2'), findsOneWidget);
|
|
expect(find.text('implementer'), findsNothing);
|
|
expect(find.text('Visit 1 · completed'), findsOneWidget);
|
|
expect(find.text('lib/a.dart'), findsOneWidget);
|
|
expect(find.text('lib/c.dart'), findsNothing);
|
|
|
|
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
|
|
await tester.pump();
|
|
|
|
// The shown page keeps its own visit identity in the heading.
|
|
expect(find.text('reviewer'), findsNothing);
|
|
expect(find.text('Visit 1 · completed'), findsOneWidget);
|
|
expect(find.text('lib/c.dart'), findsOneWidget);
|
|
expect(find.text('lib/a.dart'), findsNothing);
|
|
expect(find.text('3 files changed'), findsOneWidget);
|
|
expect(find.text('2 of 2'), findsOneWidget);
|
|
|
|
await tester.tap(find.byKey(ChangesVisitPager.previousKey));
|
|
await tester.pump();
|
|
|
|
expect(find.text('implementer'), findsNothing);
|
|
expect(find.text('lib/a.dart'), findsOneWidget);
|
|
expect(find.text('lib/c.dart'), findsNothing);
|
|
expect(find.text('1 of 2'), findsOneWidget);
|
|
},
|
|
);
|
|
|
|
testWidgets('visit chevrons share one row at the bottom right', (
|
|
tester,
|
|
) async {
|
|
tester.view.physicalSize = const Size(390, 844);
|
|
tester.view.devicePixelRatio = 1;
|
|
addTearDown(tester.view.reset);
|
|
await tester.pumpWidget(materialHost(ChangesViewer(steps: twoVisitRun())));
|
|
|
|
final previous = tester.getRect(find.byKey(ChangesVisitPager.previousKey));
|
|
final next = tester.getRect(find.byKey(ChangesVisitPager.nextKey));
|
|
expect(previous.center.dy, moreOrLessEquals(next.center.dy));
|
|
expect(previous.right, lessThanOrEqualTo(next.left));
|
|
expect(next.right, greaterThan(390 - 32));
|
|
expect(next.bottom, greaterThan(844 - 80));
|
|
});
|
|
|
|
for (final size in [
|
|
const Size(390, 844),
|
|
const Size(880, 1000),
|
|
const Size(1100, 800),
|
|
]) {
|
|
testWidgets('Material pager clears an inherited stacked bar at $size', (
|
|
tester,
|
|
) async {
|
|
tester.view.physicalSize = size;
|
|
tester.view.devicePixelRatio = 1;
|
|
addTearDown(tester.view.reset);
|
|
final child = ChangesViewer(steps: twoVisitRun());
|
|
await tester.pumpWidget(
|
|
MediaQuery(
|
|
data: const MediaQueryData(padding: EdgeInsets.only(bottom: 120)),
|
|
child: materialHost(child),
|
|
),
|
|
);
|
|
await tester.pump();
|
|
final pager = tester.getRect(find.byKey(ChangesVisitPager.nextKey));
|
|
expect(pager.bottom, lessThanOrEqualTo(size.height - 120));
|
|
});
|
|
}
|
|
|
|
testWidgets('paging stops at both ends instead of wrapping', (tester) async {
|
|
await tester.pumpWidget(materialHost(ChangesViewer(steps: twoVisitRun())));
|
|
|
|
IconButton previous() =>
|
|
tester.widget<IconButton>(find.byKey(ChangesVisitPager.previousKey));
|
|
IconButton next() =>
|
|
tester.widget<IconButton>(find.byKey(ChangesVisitPager.nextKey));
|
|
|
|
expect(previous().onPressed, isNull);
|
|
expect(next().onPressed, isNotNull);
|
|
|
|
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
|
|
await tester.pump();
|
|
expect(previous().onPressed, isNotNull);
|
|
expect(next().onPressed, isNull);
|
|
|
|
// The disabled Next is inert; the page stays on the last visit.
|
|
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
|
|
await tester.pump();
|
|
expect(find.text('reviewer'), findsNothing);
|
|
|
|
await tester.tap(find.byKey(ChangesVisitPager.previousKey));
|
|
await tester.pump();
|
|
expect(find.text('implementer'), findsNothing);
|
|
expect(previous().onPressed, isNull);
|
|
});
|
|
|
|
testWidgets('a run with one recorded visit offers no pager', (tester) async {
|
|
await tester.pumpWidget(
|
|
materialHost(
|
|
ChangesViewer(
|
|
steps: [
|
|
stepFixture(
|
|
fileChanges: captureFixture(
|
|
files: [fileChangeFixture(path: 'lib/only.dart')],
|
|
),
|
|
),
|
|
],
|
|
),
|
|
),
|
|
);
|
|
expect(find.byKey(ChangesVisitPager.previousKey), findsNothing);
|
|
expect(find.byKey(ChangesVisitPager.nextKey), findsNothing);
|
|
expect(
|
|
find.byKey(const ValueKey<String>('changes-visit-position')),
|
|
findsNothing,
|
|
);
|
|
// The single visit still keeps its identity heading.
|
|
expect(find.text('implementer'), findsNothing);
|
|
expect(find.text('Visit 1 · completed'), findsOneWidget);
|
|
expect(find.text('lib/only.dart'), findsOneWidget);
|
|
});
|
|
|
|
testWidgets('a shorter reply clamps the shown visit instead of overflowing', (
|
|
tester,
|
|
) async {
|
|
final first = twoVisitRun();
|
|
final second = [
|
|
stepFixture(
|
|
stage: 'implementer',
|
|
sequence: 1,
|
|
fileChanges: captureFixture(
|
|
files: [fileChangeFixture(path: 'lib/a.dart')],
|
|
),
|
|
),
|
|
];
|
|
await tester.pumpWidget(materialHost(ChangesViewer(steps: first)));
|
|
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
|
|
await tester.pump();
|
|
expect(find.text('reviewer'), findsNothing);
|
|
|
|
await tester.pumpWidget(materialHost(ChangesViewer(steps: second)));
|
|
await tester.pump();
|
|
expect(tester.takeException(), isNull);
|
|
expect(find.text('implementer'), findsNothing);
|
|
expect(find.text('Visit 1 · completed'), findsOneWidget);
|
|
expect(find.byKey(ChangesVisitPager.previousKey), findsNothing);
|
|
});
|
|
|
|
testWidgets('the pager stays reachable at 320x720 with 2x text', (
|
|
tester,
|
|
) async {
|
|
tester.view.physicalSize = const Size(320, 720);
|
|
tester.view.devicePixelRatio = 1;
|
|
addTearDown(tester.view.reset);
|
|
await tester.pumpWidget(
|
|
materialHost(
|
|
ChangesViewer(steps: twoVisitRun()),
|
|
scaler: const TextScaler.linear(2),
|
|
),
|
|
);
|
|
expect(tester.takeException(), isNull);
|
|
expect(find.byKey(ChangesVisitPager.previousKey), findsOneWidget);
|
|
expect(find.byKey(ChangesVisitPager.nextKey), findsOneWidget);
|
|
|
|
// At 2x text the fixed summary and filter leave a short scroll viewport;
|
|
// the pager is still reachable by scrolling the visit body.
|
|
await tester.ensureVisible(find.byKey(ChangesVisitPager.nextKey));
|
|
await tester.pump();
|
|
await tester.tap(find.byKey(ChangesVisitPager.nextKey));
|
|
await tester.pump();
|
|
expect(tester.takeException(), isNull);
|
|
expect(find.text('reviewer'), findsNothing);
|
|
expect(find.text('Visit 1 · completed'), findsOneWidget);
|
|
expect(find.text('lib/c.dart'), findsOneWidget);
|
|
});
|
|
}
|