0ceafcb6d7
Remove the 840 px Search reading cap (results column and bar pill) so both fill the pane at Fold and wide widths. Add a width test for the stage page at 880 and 1400 and deep-link/query flags to the search probe entry.
1.3 KiB
1.3 KiB
Stage page and Search width on a Fold / wide web
Captures: /tmp/width-evidence/{before,after}-{stage,search,run}-{material,cupertino}-{880x1000,1100x800,1400x900}.png,
from the real PipelinesApp probe (tool/search_selection_probe_entry.dart) served by
python3 -m http.server. The entry now takes ?route=/runs/7/stage/build%3Fvisit%3D1
(opens a deep app location from a plain file server) and ?q=release (types into Search).
- Search: the result column was capped at
kSearchContentMaxWidth(840) by aSliverConstrainedCrossAxis, and the bar pill at the same cap, leaving the right of the window empty at 1100/1400. Both caps are removed: results and pill span the pane between the bar's 12 px insets. - Stage page: already fills the detail pane edge to edge in every capture (no
ContentWidth/Center/ConstrainedBox in the visit page; the run_detail_tabs header
ConstrainedBox limits height only).
test/shell/split_stage_page_width_test.dartlocks this at 880 and 1400. The pane itself is the shell's 60% list/detail split; making the stage page cover the list is a shell policy decision, not changed here. - Headless Chrome's virtual time stops the Cupertino page push mid-transition, so the Cupertino stage captures show the slide in progress; the widget test covers the settled layout.